Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-server/pull/873
LGTM
---
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-server/pull/877
It should be safe to add these headers here since it will not be inherited
by `brooklyn-downstream-parent`
---
GitHub user robertgmoss opened a pull request:
https://github.com/apache/brooklyn-server/pull/877
update maven-bundle-plugin to include headers for catalog bundles rebind
after upgrade
depends on #873
You can merge this pull request into a Git repository by running:
$ git
Github user robertgmoss closed the pull request at:
https://github.com/apache/brooklyn-library/pull/138
---
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-library/pull/138
closing in favour of adding higher up the pom hierarchy
---
GitHub user robertgmoss opened a pull request:
https://github.com/apache/brooklyn-library/pull/138
add maven-bundle-plugin configuration to allow rebind
(depends on brooklyn-server#873)
You can merge this pull request into a Git repository by running:
$ git pull https
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-server/pull/873
I have tested rebinding using the
[brooklyn-etcd](https://github.com/brooklyncentral/brooklyn-etcd) entity, where
the following was added to its `pom.xml
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
Thanks @geomacy LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@Graeme-Miller I take your point about security, but I am not convinced
that caching 1 context is _really_ that much more secure than caching `n`! The
surprising thing to me is that we
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@geomacy I'd rather this was not merged as is. It would deprecate a
current format, then introduce a further deprecation further down the line.
I will make a PR into your branch
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/723#discussion_r120929497
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/AbstractComputeServiceRegistry.java
---
@@ -0,0 +1,283
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-server/pull/723
@andreaturli can you take another look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/723#discussion_r120842986
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/AbstractComputeServiceRegistry.java
---
@@ -0,0 +1,312
GitHub user robertgmoss opened a pull request:
https://github.com/apache/brooklyn-server/pull/723
adds a new ComputeServiceRegistry to handle when Brooklyn runs on an ec2
instance and want to pick up credentials from an IAM role
Allows the following catalog item to be added to add
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@m4rkmckenna sorry, I thought I'd implemented that feature, but clearly I
didn't. Yes, @geomacy the format was like that so that you could simply change
the `target` in the `login
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@geomacy I think it is a shame to lose the caching of credentials for
multiple Brooklyn servers and the ability to switch between them without
re-entering credentials.
---
If your
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/605#discussion_r108628950
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/composite/AbstractCompositeEffector.java
---
@@ -0,0 +1,184
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/605#discussion_r108162883
--- Diff:
policy/src/main/java/org/apache/brooklyn/policy/action/PeriodicEffectorPolicy.java
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/605#discussion_r107871568
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/composite/TransformEffector.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/605#discussion_r107871522
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/composite/ComposeEffector.java
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/605#discussion_r107871553
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/composite/SequenceEffector.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/605#discussion_r107871537
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/composite/LoopEffector.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/605#discussion_r107643925
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/composite/AbstractCompositeEffector.java
---
@@ -0,0 +1,184
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-client/pull/39
@geomacy I'm not sure why, but the global variable doesn't seem to be
getting set - this PR makes it use a local flag instead, which seems more
appropriate anyway, and crucially works
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-client/pull/18
cool
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertgmoss closed the pull request at:
https://github.com/apache/brooklyn-client/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-client/pull/24
thanks @jittakal; LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/218#discussion_r69442254
--- Diff:
launcher/src/test/java/org/apache/brooklyn/launcher/blueprints/Windows7zipBlueprintLiveTest.java
---
@@ -81,7 +81,7 @@ public void
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/218#discussion_r69441816
--- Diff:
core/src/test/java/org/apache/brooklyn/core/mgmt/rebind/RebindEntityTest.java
---
@@ -310,7 +310,7 @@ public void testEntityTags
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/218#discussion_r69441669
--- Diff:
launcher/src/test/java/org/apache/brooklyn/launcher/blueprints/Windows7zipBlueprintLiveTest.java
---
@@ -81,7 +81,7 @@ public void
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/218#discussion_r69440147
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -100,30 +103,36
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/218#discussion_r69440473
--- Diff: core/src/main/java/org/apache/brooklyn/core/entity/Entities.java
---
@@ -655,34 +677,112 @@ public static boolean isDescendant(Entity
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/218#discussion_r69440113
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -100,30 +103,36
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-server/pull/218
Makes sense not to have self included in `$brooklyn:descendants`, but I
find it contrary to expectations that `Entities.descendants(entity)` does not
mirror this. I presume
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-server/pull/218
@aledsage test failure in `EntitiesYamlTest.testMultipleReferences()`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-server/pull/217
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertgmoss commented on the pull request:
https://github.com/apache/brooklyn-client/pull/19#issuecomment-221061284
I wonder if we would be better to start introducing tests that are
[idomatic to golang](https://golang.org/pkg/testing/)?
---
If your project is set up
GitHub user robertgmoss opened a pull request:
https://github.com/apache/brooklyn-dist/pull/25
use JAVA_HOME if available when starting up
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertgmoss/brooklyn-dist java-home
Github user robertgmoss commented on the pull request:
https://github.com/apache/brooklyn-client/pull/11#issuecomment-199833278
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertgmoss commented on the pull request:
https://github.com/apache/brooklyn-client/pull/11#issuecomment-199801547
I have a feeling the Godeps.json file has not been created properly - I
think it is only supposed to have external dependencies in there...
---
If your
Github user robertgmoss commented on the pull request:
https://github.com/apache/brooklyn-client/pull/11#issuecomment-199799131
Ah didn't see that! I thought you were removing everything. Should be fine
the way you have it.
---
If your project is set up for it, you can reply
Github user robertgmoss commented on the pull request:
https://github.com/apache/brooklyn-client/pull/11#issuecomment-199795833
I believe it is customary in Golang circles to commit the Godep to repos.
If the Godep is out of date perhaps it should be updated?
---
If your project
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/25#discussion_r55651252
--- Diff: guide/ops/cli/index.md ---
@@ -6,7 +6,25 @@ children:
- cli-usage-guide.md
---
-{% include list-children.html
43 matches
Mail list logo
