ahgittin commented on issue #129: UI for defining parameters
URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-485403658
@tbouron the constraints hover text currently says:
> Constraints such as "required" or "forbiddenUnless(otherKey)", expressed
as a JSON list (wrapp
ahgittin commented on issue #129: UI for defining parameters
URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-478654065
(all comments addressed and pushed @tbouron )
This is an automated message from the Apache
ahgittin commented on issue #129: UI for defining parameters
URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-478653794
great points @tbouron
> `==` vs `===` and `!=` vs `!==` ...
you are 100% correct we should use the latter. i revert to bad other
language h
ahgittin commented on issue #129: UI for defining parameters
URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477630964
took me far too long to find, but i've got it now @jcabrerizo . can you
look at last commit and then we can merge!
--
ahgittin commented on issue #129: UI for defining parameters
URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477614540
that's weird, `name` seems to make it blow up. i'll look at that.
This is an automated me
ahgittin commented on issue #129: UI for defining parameters
URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477586017
@jcabrerizo both updated; went with a subset of common parameter types, with
note in code and ability to write others
good to merge in your opinion?
ahgittin commented on issue #129: UI for defining parameters
URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477576730
all good suggestions @jcabrerizo , TY. your 2 and 4 are easy, i'll do that
in this PR.
not sure about 1, it might make the display noisy. but we s
ahgittin commented on issue #129: UI for defining parameters
URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477229926
did some testing and it all works (6 is happy), except a default value of
`''` is being set for things so `required` has no effect.
i've fixed that
ahgittin commented on issue #129: UI for defining parameters
URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477125795
i've addressed 1,2,4, and applied a similar toolbar cleanup to configuration
(also use labels a la palette instead of checkboxes for the filters). 3 is
m
