Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/151#issuecomment-220959515
I like the idea of the PR, but feel that it should be more constrained in
scope. Either having this behaviour only for `prosivioning.properties` or even
more to
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64207370
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java ---
@@ -126,7 +127,11 @@ public void markUsed(String key) {
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64207286
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/collections/CollectionHelpers.java
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64207206
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java ---
@@ -126,7 +127,11 @@ public void markUsed(String key) {
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64206860
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/collections/CollectionHelpers.java
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64206445
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/collections/CollectionHelpers.java
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64206361
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/collections/CollectionHelpers.java
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64203567
--- Diff:
core/src/main/java/org/apache/brooklyn/location/byon/FixedListMachineProvisioningLocation.java
---
@@ -345,7 +346,7 @@ protected void
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64203063
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/EmptySoftwareProcessYamlTest.java
---
@@ -60,6 +62,31 @@ public void
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64197998
--- Diff:
core/src/main/java/org/apache/brooklyn/location/byon/FixedListMachineProvisioningLocation.java
---
@@ -345,7 +346,7 @@ protected void
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64197677
--- Diff:
core/src/main/java/org/apache/brooklyn/location/byon/FixedListMachineProvisioningLocation.java
---
@@ -345,7 +346,7 @@ protected void
Github user bostko commented on the pull request:
https://github.com/apache/brooklyn-server/pull/151#issuecomment-220939386
Is the naming OK. Do you think I named properly the util class?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/151#discussion_r64197284
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/EmptySoftwareProcessYamlTest.java
---
@@ -60,6 +62,31 @@ public void
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/151
Merge Map values in config
Merge location configuration and application's provisioning.properties
You can merge this pull request into a Git repository by running:
$ git pull
14 matches
Mail list logo
