Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66146520
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/EffectorTransformer.java
---
@@ -83,7 +84,8 @@ public static
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66146158
--- Diff:
api/src/main/java/org/apache/brooklyn/api/effector/ParameterType.java ---
@@ -45,4 +47,6 @@
* @return The default value for
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66145873
--- Diff:
api/src/main/java/org/apache/brooklyn/api/effector/ParameterType.java ---
@@ -45,4 +47,6 @@
* @return The default value for
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66145442
--- Diff:
launcher/src/test/java/org/apache/brooklyn/giulauncher/effectors/TestEntityWithEffectors.java
---
@@ -0,0 +1,33 @@
+/*
+ *
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66116549
--- Diff:
launcher/src/test/java/org/apache/brooklyn/giulauncher/effectors/TestEntityWithEffectorsImpl.java
---
@@ -0,0 +1,43 @@
+/*
+ *
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66116521
--- Diff:
launcher/src/test/java/org/apache/brooklyn/giulauncher/effectors/TestEntityWithEffectors.java
---
@@ -0,0 +1,33 @@
+/*
+ *
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66116469
--- Diff:
core/src/test/java/org/apache/brooklyn/core/mgmt/internal/TestEntityWithEffectorsImpl.java
---
@@ -0,0 +1,42 @@
+/*
+ *
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66116298
--- Diff:
core/src/test/java/org/apache/brooklyn/core/mgmt/internal/TestEntityWithEffectors.java
---
@@ -0,0 +1,34 @@
+/*
+ * Licensed to
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66116186
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/BasicParameterType.java ---
@@ -44,6 +45,7 @@ public BasicParameterType(Map
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66115978
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/BasicParameterType.java ---
@@ -44,6 +45,7 @@ public BasicParameterType(Map
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66115696
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/EffectorSummary.java
---
@@ -61,6 +64,10 @@ public String getType() {
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/185
Fix/effectors
For review.
@ygy can you check it?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-server
12 matches
Mail list logo
