Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/715
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120356395
--- Diff:
core/src/test/java/org/apache/brooklyn/core/effector/http/HttpCommandEffectorTest.java
---
@@ -248,6 +248,27 @@ public void
Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120353271
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -72,7 +74,8 @@
* It deals with some
Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120353161
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -88,7 +91,9 @@
public static
Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120352362
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -88,7 +91,9 @@
public static
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120344061
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -88,7 +91,9 @@
public static final
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120345288
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -72,7 +74,8 @@
* It deals with some
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120347806
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -211,7 +226,7 @@ private HttpRequest
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r12033
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -88,7 +91,9 @@
public static final
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120349310
--- Diff:
core/src/test/java/org/apache/brooklyn/core/effector/http/HttpCommandEffectorTest.java
---
@@ -248,6 +248,27 @@ public void
Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120064369
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -181,7 +204,19 @@ private HttpRequest
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120019201
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -181,7 +204,19 @@ private HttpRequest
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120019119
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -181,7 +204,19 @@ private HttpRequest
Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120018659
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -181,7 +204,19 @@ private HttpRequest
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120018466
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -181,7 +204,19 @@ private HttpRequest
Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120005612
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -181,7 +204,19 @@ private HttpRequest
Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120003820
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -71,9 +88,10 @@
public static
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r119672629
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -181,7 +204,19 @@ private HttpRequest
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r119665858
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -71,9 +88,10 @@
public static final
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r119630764
--- Diff:
core/src/test/java/org/apache/brooklyn/core/effector/http/HttpCommandEffectorHttpBinTest.java
---
@@ -147,8 +147,10 @@ public void
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r119630195
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -71,9 +88,10 @@
public static final
21 matches
Mail list logo
