[GitHub] brooklyn-server pull request #926: [WIP] remove PortableTemplateBuilder

2018-01-08 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/926#discussion_r160125927 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/pool/MachinePoolPredicates.java --- @@ -82,40 +83,31 @@ public

[GitHub] brooklyn-server pull request #926: [WIP] remove PortableTemplateBuilder

2018-01-08 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/926#discussion_r160127430 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/JcloudsSshMachineLocationStubbedTest.java --- @@ -76,29 +76,12 @@

[GitHub] brooklyn-server pull request #926: [WIP] remove PortableTemplateBuilder

2018-01-08 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/926#discussion_r160126361 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -2609,7 +2609,7 @@ protected

[GitHub] brooklyn-server pull request #926: [WIP] remove PortableTemplateBuilder

2017-12-29 Thread andreaturli
GitHub user andreaturli opened a pull request: https://github.com/apache/brooklyn-server/pull/926 [WIP] remove PortableTemplateBuilder based on https://github.com/apache/brooklyn-server/pull/807 You can merge this pull request into a Git repository by running: $ git pull