[GitHub] brooklyn-server issue #762: Remove a bit of code duplication.

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/762 @geomacy nice! Merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server pull request #762: Remove a bit of code duplication.

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/762 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #761: Async entities

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/761#discussion_r127450153 --- Diff: core/src/main/java/org/apache/brooklyn/entity/stock/AsyncApplicationImpl.java --- @@ -0,0 +1,473 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #761: Async entities

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/761#discussion_r127451101 --- Diff: core/src/main/java/org/apache/brooklyn/entity/stock/AsyncApplicationImpl.java --- @@ -0,0 +1,473 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #761: Async entities

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/761 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #761: Async entities

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/761 Thanks @drigodwin - comments addressed (adding more explanation to `AsyncApplicationImpl.start`, and fixing the config key descriptions). Squashed and pushed here as a single commit. ---

[GitHub] brooklyn-ui pull request #47: Fix app wizard configuration load

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-ui/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127496656 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java --- @@ -336,14 +358,14 @@ private synchronized void

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127499434 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java --- @@ -308,11 +326,16 @@ private synchronized void

[GitHub] brooklyn-server pull request #763: Add 'first' to aggregator

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/763 Add 'first' to aggregator Use case is that we have a cluster - we want to propagate the sensor form any of the cluster's members, where that value is not null (in the same format as the

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127488615 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBomScanner.java --- @@ -1,130 +0,0 @@ -/* --- End diff --

[GitHub] brooklyn-ui pull request #47: Fix app wizard configuration load

GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-ui/pull/47 Fix app wizard configuration load The endpoint used was changed to require a version. Assume latest. You can merge this pull request into a Git repository by running: $ git pull

Build failed in Jenkins: brooklyn-master-build #1152

See -- [...truncated 7.52 MB...] [INFO] Brooklyn Container Location Targets SUCCESS [ 18.322 s] [INFO] Brooklyn Command Line Interface SUCCESS

[GitHub] brooklyn-server pull request #756: Support recursive option and limits when ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/756#discussion_r127454471 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/Tasks.java --- @@ -492,4 +494,29 @@ private static String

[GitHub] brooklyn-client issue #54: Fixed setting config. Added setting sensors

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-client/pull/54 @Graeme-Miller should this PR be closed now in light of the above conversation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127427771 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java --- @@ -64,14 +62,26 @@ public

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127412080 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiManager.java --- @@ -372,33 +376,46 @@ public synchronized Bundle

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127409790 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java --- @@ -371,23 +394,36 @@ public void run() {

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127431960 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java --- @@ -81,22 +91,54 @@ public

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127245988 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java --- @@ -81,22 +91,54 @@ public

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127262964 --- Diff: core/src/main/java/org/apache/brooklyn/core/location/BasicLocationRegistry.java --- @@ -194,29 +168,71 @@ public boolean

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127248654 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogItemDtoAbstract.java --- @@ -386,7 +387,7 @@ protected void

Fwd: REMINDER: [JENKINS] [IMPORTANT] - Jenkins Migration and Upgrade (And JDK7 deprecation)

Just for general awareness, I'm forwarding an Infra reminder relating to downtime on the Apache Jenkins instances this weekend. G -- Forwarded message - From: Gavin McDonald Date: Fri, 14 Jul 2017 at 11:56 Subject: REMINDER: [JENKINS] [IMPORTANT] -