[GitHub] brooklyn-server pull request: fix location leak - use LocationSpec...

GitHub user ahgittin reopened a pull request: https://github.com/apache/brooklyn-server/pull/70 fix location leak - use LocationSpec wherever possible This improves how locations are handled internally, switching the resolvers to return `LocationSpec` rather than `Location`

[GitHub] brooklyn-client pull request: Close config file object (deferred c...

GitHub user lyubenblagoev opened a pull request: https://github.com/apache/brooklyn-client/pull/9 Close config file object (deferred close) You can merge this pull request into a Git repository by running: $ git pull https://github.com/lyubenblagoev/brooklyn-client

[GitHub] brooklyn-server pull request: [OSGi] Enable Swagger

Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/56#issuecomment-197808496 Re guava version change - haven't looked at the specific API changes between versions, but would expect that they would lead to a compile error if something used

[GitHub] brooklyn-docs pull request: Add mention of location wizard into th...

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/30#discussion_r56407749 --- Diff: guide/ops/locations/index.md --- @@ -17,7 +17,8 @@ Brooklyn supports a wide range of locations: specifying already-existing hosts to

[GitHub] brooklyn-server pull request: [OSGi] Make EmbeddedFelixFramework p...

Github user geomacy commented on the pull request: https://github.com/apache/brooklyn-server/pull/66#issuecomment-198432796 :+1: I like it - like the move to having the common interface, and then loading the appropriate implementation based on which mode you are running in. LGTM.

[GitHub] brooklyn-ui pull request: Location wizard

Github user shartzel commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-198190837 sorry for the late reply; re: localhost, if I'm following, I believe I agree with what @ahgittin is saying. I understand the logic in remaining consistent with the

[GitHub] brooklyn-server pull request: fix location leak - use LocationSpec...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/70#discussion_r56633005 --- Diff: api/src/main/java/org/apache/brooklyn/api/location/LocationRegistry.java --- @@ -86,25 +94,62 @@ public boolean

[GitHub] brooklyn-docs pull request: Add mention of location wizard into th...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Jenkins build is still unstable: brooklyn-master-windows #17

See

[GitHub] brooklyn-server pull request: fix location leak - use LocationSpec...

Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-server/pull/70#issuecomment-198008891 fixed, ready for review very good if this, and the ui feature it enables https://github.com/apache/brooklyn-ui/issues/18 can make it into 090 /cc

Build failed in Jenkins: brooklyn-master-windows #15

See Changes: [alex.heneveld] update license [alex.heneveld] bump to tips of branches -- [...truncated 13775 lines...] [INFO] Brooklyn Groovy Utilities . SUCCESS [

[GitHub] brooklyn-ui pull request: Move jQuery code inside a closure manage...

Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-ui/pull/20#issuecomment-198390400 good fix. merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server pull request: fix location leak - use LocationSpec...

Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-server/pull/70#issuecomment-198162264 new unrelated failure, not very enlightening logs: ``` 2016-03-17 19:52:16,292 INFO Starting RestMockSimpleEntity{id=fh3xdiFS} on machine

[GitHub] brooklyn-ui pull request: Improve catalog locations info and edita...

Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/18#issuecomment-198309051 Oh wait, do I need to run the server with https://github.com/apache/brooklyn-server/pull/70? --- If your project is set up for it, you can reply to this email and

[GitHub] brooklyn-server pull request: Service loader updates

Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/65#issuecomment-197975733 Minor comments only, good to merge. If we have chosen to use factories for the services instead of exporting them directly, then the reference counting

[GitHub] brooklyn-ui pull request: Location wizard

Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-197866956 Added the reference to `easy-autocomplete`, see my last commit --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-dist pull request: Essential updates and some improvement...

Github user richardcloudsoft commented on the pull request: https://github.com/apache/brooklyn-dist/pull/21#issuecomment-198305099 BTW @ahgittin commit 2f19749 changes something that you had added previously - wanted to draw your attention to it so you have the opportunity to object!

[GitHub] brooklyn-client pull request: Close config file object (deferred c...

Github user lyubenblagoev commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/9#discussion_r56662228 --- Diff: io/config.go --- @@ -64,6 +65,8 @@ func (config *Config) Read() { if err != nil { error_handler.ErrorExit(err)

Build failed in Jenkins: brooklyn-client-master #8

See Changes: [lblagoev] Close config file object (deferred close) -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on ubuntu-us1 (Ubuntu ubuntu

[GitHub] brooklyn-server pull request: Fix SshMachineLocation cleanup

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/67 Fix SshMachineLocation cleanup Previously if a temporary location was created (i.e. using CREATE_UNMANAGED=true) then the cleanup task would execute immediately and would close the

[GitHub] brooklyn-server pull request: Disable tests on Windows

GitHub user neykov opened a pull request: https://github.com/apache/brooklyn-server/pull/71 Disable tests on Windows Windows doesn't support the expected file attributes, disable tests. because of https://builds.apache.org/view/Brooklyn/job/brooklyn-master-windows/10 You

[GitHub] brooklyn-server pull request: Test clocker

Github user aledsage commented on the pull request: https://github.com/apache/brooklyn-server/pull/59#issuecomment-198795436 Note that last commit duplicates https://github.com/apache/brooklyn-server/pull/72, but is needed to make the tests here pass (so we don't try to execute

[GitHub] brooklyn-server pull request: Test clocker

GitHub user aledsage reopened a pull request: https://github.com/apache/brooklyn-server/pull/59 Test clocker This has (for testing only) a cut-down version of the Clocker entity and location structure, and some tests that it works - especially for rebind. The second commit shows

[GitHub] brooklyn-ui pull request: Location wizard

Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-197946011 > maybe it's a huge time delay or my machine. for me it only popped up once and then vanished. other times i couldn't get anything to show. > > is it

[GitHub] brooklyn-server pull request: Fix SshMachineLocation cleanup

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request: Remove DISCLAIMER remnant

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/64 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request: [OSGi] Make EmbeddedFelixFramework p...

Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/66#issuecomment-197875433 With this change next error when deploying MachineEntity is: ``` java.lang.NoClassDefFoundError: com/maxmind/db/Reader$FileMode at

[GitHub] brooklyn-server pull request: Generate random password if no secur...

GitHub user neykov opened a pull request: https://github.com/apache/brooklyn-server/pull/69 Generate random password if no security provider configured Replicate classical launcher behaviour. Note that when accessing from localhost username will still be requested, but will accept

Re: ServerPool entity refactor

+1 on the changes This will obviously help Clocker as well; thanks, Aled. Andrew. On Thu, 17 Mar 2016 at 14:11 Sam Corbett wrote: > I think this would be a sensible change. > > The fact that the entity is still annotated @Beta almost two years after > its

Build failed in Jenkins: brooklyn-master-windows #5

See -- Started by user svet [EnvInject] - Loading node environment variables. Building remotely on windows1 (Windows) in workspace > git

[GitHub] brooklyn-client pull request: Close config file object (deferred c...

Github user lyubenblagoev commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/9#discussion_r56662094 --- Diff: io/config.go --- @@ -48,12 +49,12 @@ func GetConfig() (config *Config) { } func (config *Config) Write() { -

[GitHub] brooklyn-dist pull request: Fix config file permissions

GitHub user alrick87 opened a pull request: https://github.com/apache/brooklyn-dist/pull/23 Fix config file permissions Fixing the bug with incorrect file permissions on config files in `/etc/brooklyn/` directory. You can merge this pull request into a Git repository by running:

[GitHub] brooklyn-ui pull request: Location wizard

Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-197925582 Technical: - What is the issue with the autocomplete? Works ok after at least one character for me. Cosmetic: - Will change for all words in initial

[GitHub] brooklyn-ui pull request: Location wizard

Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-197937906 > What is the issue with the autocomplete? Works ok after at least one character for me. maybe it's a huge time delay or my machine. for me it only popped

[GitHub] brooklyn-ui pull request: Improve catalog locations info and edita...

Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/18#issuecomment-198308800 The code looks good but - I cannot edit any locations I manually added. - properties don't show up for locations I manually added. It that normal

[GitHub] brooklyn-dist pull request: Essential updates and some improvement...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs pull request: Add mention of location wizard into th...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/30#discussion_r56475766 --- Diff: guide/ops/locations/index.md --- @@ -17,7 +17,8 @@ Brooklyn supports a wide range of locations: specifying already-existing hosts to

[GitHub] brooklyn-dist pull request: Essential updates and some improvement...

Github user johnmccabe commented on the pull request: https://github.com/apache/brooklyn-dist/pull/21#issuecomment-19822 @ahgittin @rdowner looking at the Vagrant stuff (not the build env) is on my radar, I wanted to try getting a test blueprint running using Softlayer Bare-Metal

[GitHub] brooklyn-server pull request: fix location leak - use LocationSpec...

Github user ahgittin closed the pull request at: https://github.com/apache/brooklyn-server/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request: Disable tests on Windows

Github user sjcorbett commented on the pull request: https://github.com/apache/brooklyn-server/pull/71#issuecomment-198016697 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-dist pull request: Essential updates and some improvement...

Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-dist/pull/21#issuecomment-197867723 I've just eyeballed the changes, thinking it's better to have these in than not, and it is still evolving quite rapidly. We'll be testing vagrant and

Error with quickstart sample: starting jboss on localhost on Windows

Hello,I fired up Brooklyn (0.8.0-incubating) on my Windows7 laptop and tried this sample : name: simple-appserverlocation: localhostservices:- type: org.apache.brooklyn.entity.webapp.jboss.JBoss7Server I made sure that I can do passphraseless ssh to localhost. But I get this error. Is it because

[GitHub] brooklyn-server pull request: fix location leak - use LocationSpec...

Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-server/pull/70#issuecomment-198284683 great comments - thanks. will merge as soon as https://github.com/apache/brooklyn-ui/pull/17 lands. --- If your project is set up for it, you can reply to

[GitHub] brooklyn-server pull request: Service loader updates

Github user CMoH commented on the pull request: https://github.com/apache/brooklyn-server/pull/65#issuecomment-197428459 Well, my comment on `ServiceTracker` was about completing the list of alternatives, not about the current solution - which I think works just fine for the intended

[GitHub] brooklyn-server pull request: Service loader updates

Github user CMoH commented on the pull request: https://github.com/apache/brooklyn-server/pull/65#issuecomment-197356327 I haven't tested it, but it looks like it would work. One comment though: when calling `BundleContext.getService()` the reference count for the service in

Re: Call for release: 0.9.0

+1 Hadrian On 03/15/2016 10:37 AM, Richard Downer wrote: All, It's about time we had a new release of Apache Brooklyn - our first as a graduated TLP. We have lots of great new features to share :-) Is there anything that we know about that would block a release? Are there any outstanding

[GitHub] brooklyn-client pull request: Close config file object (deferred c...

Github user lyubenblagoev commented on the pull request: https://github.com/apache/brooklyn-client/pull/9#issuecomment-198671695 @aledsage, I've completed and submitted ICLA by email, as described in the link provided by @rdowner. --- If your project is set up for it, you can reply

[GitHub] brooklyn-docs pull request: Describe SoftLayerSameVlanLocationCust...

GitHub user grkvlt opened a pull request: https://github.com/apache/brooklyn-docs/pull/31 Describe SoftLayerSameVlanLocationCustomizer configuration Documentation for the changes made in https://github.com/apache/brooklyn-server/pull/53 You can merge this pull request into a Git

[GitHub] brooklyn-ui pull request: Location wizard

Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-197965666 @ahgittin autocomplete => the screenshot I have taken is one Chrome... Would be better if other people could test it then. --- If your project is set up for it,

[GitHub] brooklyn-ui pull request: Location wizard

Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-197405281 Related PR: https://github.com/apache/brooklyn-server/pull/62 => To be merge atfer this one. --- If your project is set up for it, you can reply to this email and

[GitHub] brooklyn-dist pull request: Add UI library reference for licensing...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (BROOKLYN-241) Many tests taking too long to run due to OSGi

[ https://issues.apache.org/jira/browse/BROOKLYN-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199386#comment-15199386 ] Alex Heneveld commented on BROOKLYN-241: I use this test fragment added to

[GitHub] brooklyn-ui pull request: Location wizard

GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/17 Location wizard Add a location wizard:  This will be display on:

[GitHub] brooklyn-dist pull request: Add UI library reference for licensing...

GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-dist/pull/22 Add UI library reference for licensing purposes To be merged **after** https://github.com/apache/brooklyn-ui/pull/17 You can merge this pull request into a Git repository by running: $

[GitHub] brooklyn-docs pull request: Add mention of location wizard into th...

Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-docs/pull/30#issuecomment-197415838 To be merged **after** https://github.com/apache/brooklyn-ui/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] brooklyn-server pull request: fix location leak - use LocationSpec...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/70#discussion_r56633147 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/proxy/SpecialBrooklynObjectConstructor.java --- @@ -0,0 +1,80 @@ +/* + *

[GitHub] brooklyn-ui pull request: Location wizard

Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-198286661 @ahgittin Pushed latest changes. Hopefully it includes everything now. --- If your project is set up for it, you can reply to this email and have your reply appear

Build failed in Jenkins: brooklyn-master-windows #14

See -- [...truncated 216 lines...] at sun.nio.fs.WindowsFileSystemProvider.implDelete(Unknown Source) at sun.nio.fs.AbstractFileSystemProvider.delete(Unknown Source) at

[GitHub] brooklyn-ui pull request: Location wizard

Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-197866283 builds fine now, and works well as far as i've been able to test it. some comments so far... technical: * most of the time autocomplete does not

[GitHub] brooklyn-server pull request: Service loader updates

Github user CMoH commented on the pull request: https://github.com/apache/brooklyn-server/pull/65#issuecomment-197368109 Forgot to mention the use of `ServiceTracker` - which is the preferred alternative to using `ServiceReference`s, but someone reminded me. --- If your project is

[GitHub] brooklyn-ui pull request: Location wizard

Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-198308842 fantastic -- merging. minor tweaks to descriptions etc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] brooklyn-server pull request: [OSGi] Generate random password if n...

Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/69#issuecomment-197906874 With this and #41 merged should change `BrooklynUserWithRandomPasswordSecurityProvider` to always ask for a password. Otherwise the browser will ask for password

[GitHub] brooklyn-dist pull request: Fix RPM log dir

Github user alrick87 commented on the pull request: https://github.com/apache/brooklyn-dist/pull/24#issuecomment-198642856 @aledsage LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-client pull request: Close config file object (deferred c...

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/9#discussion_r56660301 --- Diff: io/config.go --- @@ -48,12 +49,12 @@ func GetConfig() (config *Config) { } func (config *Config) Write() { - //

[GitHub] brooklyn-server pull request: fix location leak - use LocationSpec...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/70#discussion_r56624484 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/proxy/SpecialBrooklynObjectConstructor.java --- @@ -0,0 +1,80 @@ +/* + * Licensed