Build failed in Jenkins: brooklyn-master-windows #134

See -- [...truncated 19104 lines...] 2016-06-08 02:48:45,585 INFO TESTNG PASSED: "Surefire test" -

[jira] [Commented] (BROOKLYN-291) Manually setting service.isUp is overwritten by enricher (causing non-deterministic test failures)

[ https://issues.apache.org/jira/browse/BROOKLYN-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319649#comment-15319649 ] ASF GitHub Bot commented on BROOKLYN-291: - Github user ahgittin commented on the issue:

[GitHub] brooklyn-server issue #187: BROOKLYN-291: don’t override manually-set serv...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/187 looks sensible. hopefully jenkins concurs! nice job tracking this down. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: Disable non-deterministic failing unit tests, while fixing them [BROOKLYN-272] <-- BROOKLYN-291

Hi all, TL;DR we hopefully have a fix for what might have caused many tests to fail non-deterministically. Please review. Having investigated a few non-deterministic tests, I think I've finally got to the bottom of what might be causing some/many of them to fail. I've raised a Jira and a

[GitHub] brooklyn-server issue #184: DO NOT MERGE: Disable non-deterministic GroupPic...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/184 This non-deterministic test (and hopefully many more!) is fixed by https://github.com/apache/brooklyn-server/pull/187. Assuming the review + merge of that goes ok, then I'll close this PR

[jira] [Commented] (BROOKLYN-291) Manually setting service.isUp is overwritten by enricher (causing non-deterministic test failures)

[ https://issues.apache.org/jira/browse/BROOKLYN-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319629#comment-15319629 ] ASF GitHub Bot commented on BROOKLYN-291: - GitHub user aledsage opened a pull request:

[GitHub] brooklyn-server pull request #187: BROOKLYN-291: don’t override manually-s...

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/187 BROOKLYN-291: don’t override manually-set service.isUp You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-server

[jira] [Created] (BROOKLYN-291) Manually setting service.isUp is overwritten by enricher (causing non-deterministic test failures)

Aled Sage created BROOKLYN-291: -- Summary: Manually setting service.isUp is overwritten by enricher (causing non-deterministic test failures) Key: BROOKLYN-291 URL: https://issues.apache.org/jira/browse/BROOKLYN-291

[GitHub] brooklyn-ui pull request #29: Use password input for sensitive information

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/29#discussion_r66147228 --- Diff: src/main/webapp/assets/tpl/apps/param.html --- @@ -34,6 +34,10 @@ <% } %> +<% } else if (sensitive

[GitHub] brooklyn-server pull request #185: Fix/effectors

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/185#discussion_r66146520 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/EffectorTransformer.java --- @@ -83,7 +84,8 @@ public static

[GitHub] brooklyn-server pull request #185: Fix/effectors

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/185#discussion_r66146158 --- Diff: api/src/main/java/org/apache/brooklyn/api/effector/ParameterType.java --- @@ -45,4 +47,6 @@ * @return The default value for

[GitHub] brooklyn-server pull request #185: Fix/effectors

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/185#discussion_r66145873 --- Diff: api/src/main/java/org/apache/brooklyn/api/effector/ParameterType.java --- @@ -45,4 +47,6 @@ * @return The default value for

[GitHub] brooklyn-server pull request #185: Fix/effectors

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/185#discussion_r66145442 --- Diff: launcher/src/test/java/org/apache/brooklyn/giulauncher/effectors/TestEntityWithEffectors.java --- @@ -0,0 +1,33 @@ +/* + *

[GitHub] brooklyn-server pull request #185: Fix/effectors

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/185#discussion_r66116549 --- Diff: launcher/src/test/java/org/apache/brooklyn/giulauncher/effectors/TestEntityWithEffectorsImpl.java --- @@ -0,0 +1,43 @@ +/* + *

[GitHub] brooklyn-server pull request #185: Fix/effectors

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/185#discussion_r66116521 --- Diff: launcher/src/test/java/org/apache/brooklyn/giulauncher/effectors/TestEntityWithEffectors.java --- @@ -0,0 +1,33 @@ +/* + *

[GitHub] brooklyn-server pull request #185: Fix/effectors

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/185#discussion_r66116469 --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/internal/TestEntityWithEffectorsImpl.java --- @@ -0,0 +1,42 @@ +/* + *

[GitHub] brooklyn-server pull request #185: Fix/effectors

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/185#discussion_r66116298 --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/internal/TestEntityWithEffectors.java --- @@ -0,0 +1,34 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #185: Fix/effectors

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/185#discussion_r66116186 --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/BasicParameterType.java --- @@ -44,6 +45,7 @@ public BasicParameterType(Map

[GitHub] brooklyn-server pull request #185: Fix/effectors

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/185#discussion_r66115978 --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/BasicParameterType.java --- @@ -44,6 +45,7 @@ public BasicParameterType(Map

[GitHub] brooklyn-ui pull request #29: Use password input for sensitive information

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/29#discussion_r66115710 --- Diff: src/main/webapp/assets/tpl/apps/param.html --- @@ -34,6 +34,10 @@ <% } %> +<% } else if

[GitHub] brooklyn-server pull request #185: Fix/effectors

Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/185#discussion_r66115696 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/EffectorSummary.java --- @@ -61,6 +64,10 @@ public String getType() {

[GitHub] brooklyn-docs pull request #76: Docs/rename test ssh command

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Build failed in Jenkins: brooklyn-master-windows #133

See -- [...truncated 19345 lines...] === Surefire test Tests run: 1670, Failures: 2, Skips: 1 ===

[GitHub] brooklyn-docs issue #76: Docs/rename test ssh command

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-docs/pull/76 👍 looks good to me, merge away as far as I see it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] brooklyn-docs pull request #76: Docs/rename test ssh command

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-docs/pull/76 Docs/rename test ssh command You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-docs docs/rename-TestSshCommand

[GitHub] brooklyn-server issue #185: Fix/effectors

Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/185 After when you have the code from this branch and brooklyn-ui you can use the blueprint bellow to check how it looks in the UI ```yaml location: localhost services: - type:

Jenkins build is back to normal : brooklyn-master-build #238

See

[GitHub] brooklyn-ui pull request #29: Use password input for sensitive information

GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-ui/pull/29 Use password input for sensitive information You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-ui

Build failed in Jenkins: brooklyn-server-master #118

See -- [...truncated 2060 lines...] jdk1.7.0_80/bin/jcmd jdk1.7.0_80/bin/jstatd jdk1.7.0_80/bin/javadoc jdk1.7.0_80/bin/xjc jdk1.7.0_80/bin/jarsigner jdk1.7.0_80/bin/jstack jdk1.7.0_80/bin/keytool

Build failed in Jenkins: brooklyn-server-master #117

See Changes: [aled.sage] Rename SimpleShellCommandTest to TestSshCommand [aled.sage] Adds TestSshCommand.SHELL_ENVIRONMENT -- [...truncated 2060 lines...] jdk1.7.0_80/bin/jcmd

[GitHub] brooklyn-library pull request #42: Refactoring test dependencies

GitHub user iyovcheva opened a pull request: https://github.com/apache/brooklyn-library/pull/42 Refactoring test dependencies You can merge this pull request into a Git repository by running: $ git pull https://github.com/iyovcheva/brooklyn-library

[GitHub] brooklyn-server pull request #186: Rename SimpleShellCommandTest to TestSshC...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/186 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #186: Rename SimpleShellCommandTest to TestSshCommand

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/186 Test failure is unrelated - `ConfigYamlTest.testDeferredSupplierToAttributeWhenReady`. This is getting ridiculous! I strongly suspect there is an underlying problem in

Jenkins build is back to normal : brooklyn-library-master #30

See

[GitHub] brooklyn-library pull request #33: Allow creating roles for PostgreSQL

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r66081409 --- Diff: software/database/pom.xml --- @@ -144,11 +144,24 @@ +${jclouds.groupId}.provider ---

[GitHub] brooklyn-library pull request #33: Allow creating roles for PostgreSQL

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r66079073 --- Diff: software/database/pom.xml --- @@ -144,11 +144,24 @@ +${jclouds.groupId}.provider ---

[GitHub] brooklyn-library pull request #33: Allow creating roles for PostgreSQL

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r66078817 --- Diff: software/database/pom.xml --- @@ -144,11 +144,24 @@ +${jclouds.groupId}.provider ---

[GitHub] brooklyn-library pull request #33: Allow creating roles for PostgreSQL

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r66078600 --- Diff: software/database/pom.xml --- @@ -144,11 +144,24 @@ +${jclouds.groupId}.provider +

[GitHub] brooklyn-library pull request #33: Allow creating roles for PostgreSQL

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-library/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-library issue #33: Allow creating roles for PostgreSQL

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-library/pull/33 Thanks @iyovcheva - merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-library pull request #33: Allow creating roles for PostgreSQL

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r66077096 --- Diff: qa/src/test/resources/java-web-app-and-db-with-function.yaml --- @@ -21,12 +21,13 @@ location: localhost services: - type:

[GitHub] brooklyn-server pull request #186: Rename SimpleShellCommandTest to TestSshC...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/186#discussion_r66075624 --- Diff: test-framework/src/main/java/org/apache/brooklyn/test/framework/TestSshCommandImpl.java --- @@ -0,0 +1,269 @@ +/* + * Licensed

[GitHub] brooklyn-server issue #186: Rename SimpleShellCommandTest to TestSshCommand

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/186 `TestSshCommandIntegrationTest.shouldCaptureStdoutAndStderrOfScript ` is a real failure - that should have been marked as `groups="Integration"`. --- If your project is set up for it, you

[GitHub] brooklyn-library pull request #33: Allow creating roles for PostgreSQL

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r66071993 --- Diff: qa/src/test/resources/java-web-app-and-db-with-function.yaml --- @@ -17,18 +17,20 @@ # under the License. # name:

[GitHub] brooklyn-library pull request #33: Allow creating roles for PostgreSQL

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r66071641 --- Diff: qa/src/test/resources/java-web-app-and-db-with-function.yaml --- @@ -17,18 +17,20 @@ # under the License. # name:

[GitHub] brooklyn-library pull request #33: Allow creating roles for PostgreSQL

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r66071462 --- Diff: qa/src/test/resources/java-web-app-and-db-with-function.yaml --- @@ -17,18 +17,20 @@ # under the License. # name:

[GitHub] brooklyn-server issue #186: Rename SimpleShellCommandTest to TestSshCommand

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/186 👍 Looks like a good change to me. Will require matching updates in the brooklyn-docs. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server pull request #186: Rename SimpleShellCommandTest to TestSshC...

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/186#discussion_r66069064 --- Diff: test-framework/src/main/java/org/apache/brooklyn/test/framework/TestSshCommandImpl.java --- @@ -0,0 +1,269 @@ +/* + * Licensed to

[GitHub] brooklyn-library issue #33: Allow creating roles for PostgreSQL

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-library/pull/33 @iyovcheva there's a merge conflict - can you rebase against master please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: [PROPOSAL] Rename SimpleShellCommandTest to TestSshCommand

Thanks all. See https://github.com/apache/brooklyn-server/pull/186 for the change. I've also rewritten the tests as unit tests (rather than integration tests) by using the RecordingSshTool so it doesn't require ssh access to any machine (and have left a couple of integration tests for

[GitHub] brooklyn-server pull request #186: Rename SimpleShellCommandTest to TestSshC...

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/186 Rename SimpleShellCommandTest to TestSshCommand You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-server

Re: [PROPOSAL] Rename SimpleShellCommandTest to TestSshCommand

Sounds fine to me. +1 Gnu PGP key - http://is.gd/uI > On 7 Jun 2016, at 10:37, Aled Sage wrote: > > Hi all, > > I suggest we rename the entity SimpleShellCommandTest [1] to TestSshCommand. > This would make it more consistent with the naming of

Re: [PROPOSAL] Rename SimpleShellCommandTest to TestSshCommand

+1 On 07/06/2016 11:37, Aled Sage wrote: Hi all, I suggest we rename the entity SimpleShellCommandTest [1] to TestSshCommand. This would make it more consistent with the naming of things like ShellFeed [2] and SshFeed [3]: "shell" means executing a command on the local brooklyn server,

Re: [PROPOSAL] Rename SimpleShellCommandTest to TestSshCommand

+1 On 7 June 2016 at 10:40, Svetoslav Neykov < svetoslav.ney...@cloudsoftcorp.com> wrote: > +1 > > Also agree having an environment will simplify writing the tests. > > Svet. > > > > On 7.06.2016 г., at 12:37, Aled Sage wrote: > > > > Hi all, > > > > I suggest we rename the

Re: [PROPOSAL] Rename SimpleShellCommandTest to TestSshCommand

+1 Also agree having an environment will simplify writing the tests. Svet. > On 7.06.2016 г., at 12:37, Aled Sage wrote: > > Hi all, > > I suggest we rename the entity SimpleShellCommandTest [1] to TestSshCommand. > This would make it more consistent with the naming of

[PROPOSAL] Rename SimpleShellCommandTest to TestSshCommand

Hi all, I suggest we rename the entity SimpleShellCommandTest [1] to TestSshCommand. This would make it more consistent with the naming of things like ShellFeed [2] and SshFeed [3]: "shell" means executing a command on the local brooklyn server, whereas "ssh" means executing a command on the

[GitHub] brooklyn-library issue #33: Allow creating roles for PostgreSQL

Github user iyovcheva commented on the issue: https://github.com/apache/brooklyn-library/pull/33 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-server pull request #185: Fix/effectors

GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/185 Fix/effectors For review. @ygy can you check it? You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-server