[GitHub] brooklyn-server issue #821: REST API for accessing adjuncts (including highl...

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/821 BTW, I just realised that there is no tests coverage for the new endpoints `Entity Adjuncts` and `Entity Adjuncts Config`. Can you add that please @ahgittin ? ---

[GitHub] brooklyn-server issue #816: Tasks code improvements - prep for better presen...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/816 @aledsage I think this resolves nearly everything. BTW the existing WIP test I think can be made to work by moving the cancel, but I'll do that as part of #835 since the test also

[GitHub] brooklyn-server issue #816: Tasks code improvements - prep for better presen...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/816 aha the "is immediate submission safe" question is already answered by `allowImmediateExecution` in `ValueResolver`, so callers should use that with `immediate(true)` if they want to

[GitHub] brooklyn-server issue #816: Tasks code improvements - prep for better presen...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/816 Think I've addressed everything except `getImmediately(unsubmittedTask)`. > My expectation for what getImmediately(task) should do is: try to evaluate the task immediately, but if

[GitHub] brooklyn-dist issue #110: Improve verify brooklyn RC script

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/110 retest this please ---

[GitHub] brooklyn-dist pull request #108: Fix release scripts

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/108#discussion_r141639106 --- Diff: release/Vagrantfile --- @@ -76,7 +78,7 @@ Vagrant.configure(2) do |config| apt-get install -y default-jdk git subversion

[GitHub] brooklyn-dist pull request #108: Fix release scripts

Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/108#discussion_r141637687 --- Diff: release/Vagrantfile --- @@ -76,7 +78,7 @@ Vagrant.configure(2) do |config| apt-get install -y default-jdk git subversion

[GitHub] brooklyn-server issue #816: Tasks code improvements - prep for better presen...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/816 pushing fixes to most things now; two remaining big items: * in `BasicTask` change `setSubmittedByTask(Maybe)` to `setSubmittedByTask(Maybe, String taskId)` * what should

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141632615 --- Diff: core/src/test/java/org/apache/brooklyn/util/core/task/BasicTasksFutureTest.java --- @@ -174,29 +175,53 @@ public T call() { }

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141631128 --- Diff: core/src/test/java/org/apache/brooklyn/core/effector/EffectorSayHiTest.java --- @@ -99,6 +99,23 @@ public void testInvokeEffectors1()

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141630014 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java --- @@ -434,7 +434,11 @@ protected boolean

[GitHub] brooklyn-library pull request #131: Fix tests tearDown (to always stop manag...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-library/pull/131 ---

[GitHub] brooklyn-server issue #830: Add support for kubernetes helm

Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/830 retest this please ---

[GitHub] brooklyn-server issue #826: Move chef from brooklyn-software-base to own mod...

Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/826 retest this please ---

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141623079 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicTask.java --- @@ -327,11 +328,10 @@ public synchronized boolean

Jenkins build is back to normal : brooklyn-server-master #749

See

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141622166 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicTask.java --- @@ -256,6 +246,17 @@ public synchronized void

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141621308 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java --- @@ -706,19 +719,23 @@ public void run() {

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141620123 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/repeat/Repeater.java --- @@ -269,6 +274,21 @@ public Boolean call() throws Exception

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141618905 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -110,48 +248,53 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141617249 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #844: Fix machine customizers

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/844 ---

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141615127 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141614008 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141613114 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

Build failed in Jenkins: brooklyn-server-master #748

See Changes: [graeme.miller] Fix BasicBrooklynCatalog create Spec -- [...truncated 3.57 MB...] 2017-09-28 13:12:55,119 INFO in-mem-test-iS4b requesting list nodes

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141612764 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -66,23 +75,37 @@ final Set tags = new

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141602412 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/AdjunctSummary.java --- @@ -0,0 +1,150 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141604648 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/AdjunctResource.java --- @@ -0,0 +1,264 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141602765 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogEntitySummary.java --- @@ -27,6 +27,8 @@ import

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141596041 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java --- @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141607044 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/util/BrooklynRestResourceUtils.java --- @@ -130,6 +143,36 @@ public Policy

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141604605 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/AdjunctResource.java --- @@ -0,0 +1,264 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141604635 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/AdjunctResource.java --- @@ -0,0 +1,264 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141604725 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/AdjunctResource.java --- @@ -0,0 +1,264 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141605849 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/CatalogTransformer.java --- @@ -71,6 +71,8 @@ import

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141594992 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java --- @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141602792 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogLocationSummary.java --- @@ -26,6 +26,8 @@ import

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141602780 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogItemSummary.java --- @@ -36,6 +36,8 @@ * see also, subclasses

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141588659 --- Diff: api/src/main/java/org/apache/brooklyn/api/sensor/Feed.java --- @@ -43,7 +43,7 @@ /** * True if everything has

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141602725 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogEnricherSummary.java --- @@ -27,6 +27,8 @@ import

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141601297 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/PolicyApi.java --- @@ -36,6 +36,8 @@ @Api("Entity Policies")

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141589379 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/EntityInternal.java --- @@ -189,7 +189,7 @@ void remove(AttributeSensor

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141604573 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/AdjunctResource.java --- @@ -0,0 +1,264 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141595948 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java --- @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141602815 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogPolicySummary.java --- @@ -27,6 +27,8 @@ import

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141590729 --- Diff: core/src/main/java/org/apache/brooklyn/core/policy/Policies.java --- @@ -81,11 +85,27 @@ public void setEntity(EntityLocal entity) {

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141595976 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java --- @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141590904 --- Diff: core/src/main/java/org/apache/brooklyn/core/policy/Policies.java --- @@ -81,11 +85,27 @@ public void setEntity(EntityLocal entity) {

[GitHub] brooklyn-server pull request #845: Fix BasicBrooklynCatalog create Spec

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/845 ---

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141596090 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicTask.java --- @@ -256,6 +246,17 @@ public synchronized void

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141578971 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -110,48 +248,53 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141606551 --- Diff: core/src/test/java/org/apache/brooklyn/util/core/task/BasicTasksFutureTest.java --- @@ -174,29 +175,53 @@ public T call() { }

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141560042 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141579426 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -110,48 +248,53 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141585797 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -110,48 +248,53 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r140607423 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -66,23 +75,37 @@ final Set tags = new

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r140607801 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141594847 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141576522 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141586350 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java --- @@ -253,8 +261,13 @@ protected boolean

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r140608998 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/repeat/Repeater.java --- @@ -269,6 +274,21 @@ public Boolean call() throws Exception

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141592263 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java --- @@ -706,19 +719,23 @@ public void run() {

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141596718 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicTask.java --- @@ -327,11 +328,10 @@ public synchronized boolean

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141587409 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java --- @@ -448,36 +470,46 @@ public Object call() {

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141603195 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java --- @@ -434,7 +434,11 @@ protected boolean

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141573429 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141605052 --- Diff: core/src/test/java/org/apache/brooklyn/core/effector/EffectorSayHiTest.java --- @@ -99,6 +99,23 @@ public void testInvokeEffectors1()

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r140609179 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/guava/Maybe.java --- @@ -183,29 +183,40 @@ public T get() {

[GitHub] brooklyn-server issue #821: REST API for accessing adjuncts (including highl...

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/821 Cool, thanks @ahgittin. I'm reviewing it right now. ---

[GitHub] brooklyn-server issue #821: REST API for accessing adjuncts (including highl...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/821 @tbouron It's up to date. Primarily it is still just the one commit adding the Adjunct API -- it does have a lot of lines but they are mostly boilerplate (like a couple hundred just to

[GitHub] brooklyn-server issue #821: REST API for accessing adjuncts (including highl...

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/821 @ahgittin The description says `This is then just one commit (currently) which:` but there is still 1000+ additions. Is this up to date and rebase on master? ---

Jenkins build is back to normal : brooklyn-dist-master #118

See

Jenkins build is back to normal : brooklyn-client-master #65

See

[GitHub] brooklyn-server issue #826: Move chef from brooklyn-software-base to own mod...

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/826 Looks like something is wrong on Jenkins @aledsage ``` org.apache.brooklyn.camp.brooklyn.VanillaSoftwareProcessYamlTest.testAlternativeServiceUpPolling() Build timed out (after

Re: Fixing BROOKLYN-534: service.state.expected value on error?

I'd vote for option 2 for sure, it's the one that respects the meaning of "expected state". The code at [2] is more or less misusing the expected state, saying "I know I should be stopped, but something went wrong, so now I expect to be on-fire". This is counter to the design of the relationship

[GitHub] brooklyn-server issue #826: Move chef from brooklyn-software-base to own mod...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/826 retest this please ---

[GitHub] brooklyn-server issue #826: Move chef from brooklyn-software-base to own mod...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/826 Jenkins failed for reasons related to build environment, rather than this PR: ``` GitHub pull request #826 of commit d113c7f856c1c3a9855d1fb71c5188234fba3561, no merge conflicts.