[GitHub] brooklyn-docs pull request #222: Migrate docs to Gitbook

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/222 ---

[GitHub] brooklyn-docs issue #222: Migrate docs to Gitbook

2017-10-25 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-docs/pull/222 Thanks @tbouron merging now ---

[GitHub] brooklyn-server issue #868: WIP - allow types from different bundles if equi...

2017-10-25 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/868 above notes are implemented, and tests fixed, and concurrency issues resolved given that we had several tests fail i'm comfortable with the level of testing this gets

[GitHub] brooklyn-server issue #868: WIP - allow types from different bundles if equi...

2017-10-25 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/868 there's a few more subtle fixes in progress, but one i want to record here. consider: 1) i upload a BOM containing `type1` and `type2` without a bundle name, say it becomes

[GitHub] brooklyn-server pull request #869: Reverted code for selecting subnet hostna...

2017-10-25 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/869 Reverted code for selecting subnet hostname for non aws clouds A change was made to how Brooklyn retrieves the subnet hostname in https://github.com/apache/brooklyn-server/pull/849.

[GitHub] brooklyn-server issue #869: Reverted code for selecting subnet hostname for ...

2017-10-25 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/869 @tbouron and @andreaturli it would be good to get your opinion on this. ---

Re: Blueprint project structure

2017-10-25 Thread Geoff Macartney
The phrase "win - win" springs to mind. I'm not sure we need to go quite so far as saying that 2 is always best practice. I'd tend toward using your description as the basis for a new page in the docs that explains how projects can be structured and the significance of having the `catalog.bom`

Blueprint project structure

2017-10-25 Thread Alex Heneveld
Hi All- With the move towards bundles, people have been experimenting with project structure, and there seem to be two schools: (1) use maven, include a `pom.xml` in root, and put the `catalog.bom` and blueprints into either `src/main/resources/` or a custom resources directory eg

[GitHub] brooklyn-library pull request #134: Add Apache ActiveMQ Artemis catalog item

2017-10-25 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/134#discussion_r146811142 --- Diff: software/messaging/src/main/resources/catalog.bom --- @@ -25,6 +25,56 @@ brooklyn.catalog: type:

[GitHub] brooklyn-library pull request #134: Add Apache ActiveMQ Artemis catalog item

2017-10-25 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/134#discussion_r146811001 --- Diff: software/messaging/src/main/resources/catalog.bom --- @@ -25,6 +25,56 @@ brooklyn.catalog: type:

[GitHub] brooklyn-library pull request #134: Add Apache ActiveMQ Artemis catalog item

2017-10-25 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/134#discussion_r146810295 --- Diff: software/messaging/src/main/resources/catalog.bom --- @@ -25,6 +25,56 @@ brooklyn.catalog: type:

[jira] [Commented] (BROOKLYN-541) ActiveMQ Artemis Component

2017-10-25 Thread Michael Andre Pearce (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218356#comment-16218356 ] Michael Andre Pearce commented on BROOKLYN-541: --- [~andreaturli] at this time its a feature

[GitHub] brooklyn-docs issue #222: Migrate docs to Gitbook

2017-10-25 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-docs/pull/222 Thanks @m4rkmckenna ! However, can you hold off a wee bit more? I just realised that while internal relative links are perfectly fine for the docs, it might cause issues for