Build failed in Jenkins: brooklyn-library-master #485

2017-11-07 Thread Apache Jenkins Server
See -- [...truncated 553.32 KB...] Uploaded: https://repository.apache.org/content/repositories/snapshots/org/apache/brooklyn/brooklyn-qa/maven-metadata.xml (471 B at 0.4 KB/sec)

Build failed in Jenkins: brooklyn-server-master #789

2017-11-07 Thread Apache Jenkins Server
See Changes: [graeme.miller] Add brooklyn-cli as a feature to karaf -- [...truncated 8.64 MB...] 2017-11-07 21:45:30,550 INFO TESTNG PASSED: "Surefire test" -

[GitHub] brooklyn-server issue #884: Add brooklyn-cli as a feature to karaf

2017-11-07 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/884 I think you are right @aledsage, I clearly didn't think this through with #882. I would remove this dependency and add those item into `brooklyn-library` or `brooklyn-core` instead ---

[GitHub] brooklyn-server issue #884: Add brooklyn-cli as a feature to karaf

2017-11-07 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/884 Turns out this might only be working because of an error in https://github.com/apache/brooklyn-server/blob/master/server-cli/pom.xml#L118 - there's a missing comma, so this seems to behave

[GitHub] brooklyn-server pull request #884: Add brooklyn-cli as a feature to karaf

2017-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/884 ---

[GitHub] brooklyn-server issue #884: Add brooklyn-cli as a feature to karaf

2017-11-07 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/884 LGTM; merging. ---

[GitHub] brooklyn-server pull request #884: Add brooklyn-cli as a feature to karaf

2017-11-07 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/884 Add brooklyn-cli as a feature to karaf https://github.com/apache/brooklyn-server/pull/882 added brooklyn-cli to a catalog.bom. This causes brooklyn to fail to start, as karaf can't

[GitHub] brooklyn-docs pull request #232: Fix typo + syntax highlighting

2017-11-07 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-docs/pull/232 Fix typo + syntax highlighting Fix typo in the first YAML example (`:` at the end of the location) + add syntax highlighting You can merge this pull request into a Git repository by

[GitHub] brooklyn-server pull request #883: Deprecates use of Task in ConfigKey

2017-11-07 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/883 Deprecates use of Task in ConfigKey Also avoid `StackOverflowError` in `ExecutionContext.getImmediately(task)` When a non-`BasicTask` is passed in. --- The motivation for

[GitHub] brooklyn-server pull request #877: update maven-bundle-plugin to include hea...

2017-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/877 ---

[GitHub] brooklyn-server issue #877: update maven-bundle-plugin to include headers fo...

2017-11-07 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/877 Agreed this should be safe, and agree it's the right default. Merging. --- For the record, my reasoning is... bundles that are shipped in brooklyn will be automatically

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149334438 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryEffector.java --- @@ -0,0 +1,440 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149335124 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryEffector.java --- @@ -0,0 +1,440 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149344781 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryEffector.java --- @@ -0,0 +1,440 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149326857 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/PropagatePrimaryEnricher.java --- @@ -0,0 +1,204 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149317018 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryPolicy.java --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149319256 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryPolicy.java --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149317795 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryPolicy.java --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149332837 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryEffector.java --- @@ -0,0 +1,440 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149353377 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/policies/ha/brooklyn/ElectPrimaryTest.java --- @@ -0,0 +1,379 @@ +/*

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149327198 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/PropagatePrimaryEnricher.java --- @@ -0,0 +1,204 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149349474 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryEffector.java --- @@ -0,0 +1,440 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149329523 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/PropagatePrimaryEnricher.java --- @@ -0,0 +1,204 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149320932 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryPolicy.java --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149326658 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/PropagatePrimaryEnricher.java --- @@ -0,0 +1,204 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149314968 --- Diff: api/src/main/java/org/apache/brooklyn/api/mgmt/ManagementContext.java --- @@ -309,8 +310,14 @@ /** As {@link #lookup(String,

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149336035 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryConfig.java --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149350380 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryPolicy.java --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149328337 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/PropagatePrimaryEnricher.java --- @@ -0,0 +1,204 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149341592 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryEffector.java --- @@ -0,0 +1,440 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149324342 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/PropagatePrimaryEnricher.java --- @@ -0,0 +1,204 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149351458 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/PrimaryRunningEnricher.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149314895 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/AbstractManagementContext.java --- @@ -536,8 +538,52 @@ public BrooklynObject

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149340800 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryEffector.java --- @@ -0,0 +1,440 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149315793 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryPolicy.java --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149324681 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/PropagatePrimaryEnricher.java --- @@ -0,0 +1,204 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149328640 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/PropagatePrimaryEnricher.java --- @@ -0,0 +1,204 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149336746 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryConfig.java --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149312203 --- Diff: api/src/main/java/org/apache/brooklyn/api/mgmt/ManagementContext.java --- @@ -309,8 +310,14 @@ /** As {@link #lookup(String,

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149326090 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/PropagatePrimaryEnricher.java --- @@ -0,0 +1,204 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149351706 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/PropagatePrimaryEnricher.java --- @@ -0,0 +1,204 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-07 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149323199 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ElectPrimaryPolicy.java --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server issue #873: Upgrade types and bundles as per bundle manifest...

2017-11-07 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/873 Thanks @aledsage @robertgmoss - comments addressed and merged ---

[GitHub] brooklyn-server pull request #873: Upgrade types and bundles as per bundle m...

2017-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/873 ---

[GitHub] brooklyn-server pull request #873: Upgrade types and bundles as per bundle m...

2017-11-07 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/873#discussion_r149347708 --- Diff: launcher/src/test/java/org/apache/brooklyn/launcher/BrooklynLauncherRebindCatalogOsgiTest.java --- @@ -740,20 +744,82 @@ public void

[GitHub] brooklyn-server pull request #873: Upgrade types and bundles as per bundle m...

2017-11-07 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/873#discussion_r149347438 --- Diff: core/src/main/java/org/apache/brooklyn/core/typereg/BundleUpgradeParser.java --- @@ -312,6 +335,90 @@ public static boolean

[GitHub] brooklyn-server pull request #873: Upgrade types and bundles as per bundle m...

2017-11-07 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/873#discussion_r149346988 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/XmlMementoSerializer.java --- @@ -341,7 +371,7 @@ public void marshal(Object

[jira] [Updated] (BROOKLYN-548) Brooklyn node ID changes on restart

2017-11-07 Thread Thomas Bouron (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Bouron updated BROOKLYN-548: --- Attachment: (was: screenshot-1.png) > Brooklyn node ID changes on restart >

[jira] [Updated] (BROOKLYN-548) Brooklyn node ID changes on restart

2017-11-07 Thread Thomas Bouron (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Bouron updated BROOKLYN-548: --- Description: I was testing Brooklyn HA and noticed something odd: when restarting an HA

[jira] [Updated] (BROOKLYN-548) Brooklyn node ID changes on restart

2017-11-07 Thread Thomas Bouron (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Bouron updated BROOKLYN-548: --- Description: I was testing Brooklyn HA and noticed something odd: when restarting an HA

[jira] [Updated] (BROOKLYN-548) Brooklyn node ID changes on restart

2017-11-07 Thread Thomas Bouron (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Bouron updated BROOKLYN-548: --- Description: I was testing Brooklyn HA and noticed something odd: when restarting an HA

[jira] [Updated] (BROOKLYN-548) Brooklyn node ID changes on restart

2017-11-07 Thread Thomas Bouron (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Bouron updated BROOKLYN-548: --- Attachment: screenshot-1.png > Brooklyn node ID changes on restart >

[jira] [Created] (BROOKLYN-548) Brooklyn node ID changes on restart

2017-11-07 Thread Thomas Bouron (JIRA)
Thomas Bouron created BROOKLYN-548: -- Summary: Brooklyn node ID changes on restart Key: BROOKLYN-548 URL: https://issues.apache.org/jira/browse/BROOKLYN-548 Project: Brooklyn Issue Type: Bug

[GitHub] brooklyn-dist pull request #112: Reuse bundle's catalog.bom from server-cli ...

2017-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/112 ---

[GitHub] brooklyn-server issue #882: Reuse bundle's catalog.bom from server-cli modul...

2017-11-07 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/882 your comment must have came in at the same time as mine noting you removed the repetition & weren't responsible. i'll buy the idea that tutorial templates live in dist. good to merge

[GitHub] brooklyn-library pull request #139: Update visitors-creation-script.sql

2017-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-library/pull/139 ---

[GitHub] brooklyn-server pull request #874: avoid UpdatingMapTest non-det failure

2017-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/874 ---