[GitHub] brooklyn-server pull request #887: Config on entity dynamic goes on type aft...

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/887 ---

[GitHub] brooklyn-server issue #878: Misc enhancements - warnings and more lookup con...

2017-11-09 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/878 @aledsage suggest merge this when #879 is ready to go, which should be imminent #890 will then only really have the 2 relevant commits as this branch is merged in there - no need

[GitHub] brooklyn-server issue #890: REST `/applications/fetch` can request selected ...

2017-11-09 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/890 K - good to merge after #879 ---

[GitHub] brooklyn-server issue #887: Config on entity dynamic goes on type after pers...

2017-11-09 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/887 agree with comment - addressed, merging ---

[GitHub] brooklyn-server issue #879: Elect primary / failover policies

2017-11-09 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/879 Transition sensor added ---

Jenkins build is back to normal : brooklyn-master-build #1345

2017-11-09 Thread Apache Jenkins Server
See

[GitHub] brooklyn-client pull request #64: Default login port to 80/443 if not suppli...

2017-11-09 Thread geomacy
GitHub user geomacy opened a pull request: https://github.com/apache/brooklyn-client/pull/64 Default login port to 80/443 if not supplied You can merge this pull request into a Git repository by running: $ git pull https://github.com/geomacy/brooklyn-client defaultports

[GitHub] brooklyn-server pull request #856: [WIP] clean up startup logging around cat...

2017-11-09 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/856#discussion_r150102381 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java --- @@ -103,8 +103,8 @@ private

Build failed in Jenkins: brooklyn-master-build #1344

2017-11-09 Thread Apache Jenkins Server
See -- [...truncated 8.41 MB...] [INFO] Brooklyn CM Integration Root ... SKIPPED [INFO] Brooklyn Network Software Entities . SKIPPED [INFO]

[GitHub] brooklyn-server pull request #856: [WIP] clean up startup logging around cat...

2017-11-09 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/856#discussion_r150099749 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java --- @@ -128,10 +128,12 @@ private

[GitHub] brooklyn-server pull request #878: Misc enhancements - warnings and more loo...

2017-11-09 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/878#discussion_r150097102 --- Diff: api/src/main/java/org/apache/brooklyn/api/mgmt/ManagementContext.java --- @@ -309,8 +310,14 @@ /** As {@link #lookup(String,

[GitHub] brooklyn-server issue #878: Misc enhancements - warnings and more lookup con...

2017-11-09 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/878 retest this please ---

[GitHub] brooklyn-server issue #890: REST `/applications/fetch` can request selected ...

2017-11-09 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/890 Last two commits here LGTM. ---

[GitHub] brooklyn-server pull request #891: guard against possible NPE when rebinding...

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/891 ---

[GitHub] brooklyn-server pull request #887: Config on entity dynamic goes on type aft...

2017-11-09 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/887#discussion_r150017538 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/dto/BasicEntityMemento.java --- @@ -163,8 +165,27 @@ protected

[GitHub] brooklyn-server pull request #891: guard against possible NPE when rebinding...

2017-11-09 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/891 guard against possible NPE when rebinding legacy catalog items You can merge this pull request into a Git repository by running: $ git pull

[GitHub] brooklyn-server issue #879: Elect primary / failover policies

2017-11-09 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/879 Simplification, rebind support and test all now completed ---

[GitHub] brooklyn-server issue #890: REST `/applications/fetch` can request selected ...

2017-11-09 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/890 Note it's just the last two commits here; the others come from #878 (we now use the `lookup(Predicate)` convenience in the test) ---

[GitHub] brooklyn-server pull request #890: REST `/applications/fetch` can request se...

2017-11-09 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/890 REST `/applications/fetch` can request selected sensors This allows clients to efficiently get selected sensors they are interested in. Does this by adding a `@JsonAnyGetter` map

[jira] [Assigned] (BROOKLYN-553) Make br CLI default the port for Brooklyn

2017-11-09 Thread Geoff Macartney (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoff Macartney reassigned BROOKLYN-553: Assignee: Geoff Macartney > Make br CLI default the port for Brooklyn >

[jira] [Created] (BROOKLYN-553) Make br CLI default the port for Brooklyn

2017-11-09 Thread Geoff Macartney (JIRA)
Geoff Macartney created BROOKLYN-553: Summary: Make br CLI default the port for Brooklyn Key: BROOKLYN-553 URL: https://issues.apache.org/jira/browse/BROOKLYN-553 Project: Brooklyn Issue

Re: Slack channel available

2017-11-09 Thread Andrea Turli
Not sure about the future of it, Thomas! I guess they want to see adoptions and then they will decide. Thanks! On 9 November 2017 at 17:17, Thomas Bouron wrote: > Wow, that's a great news! > I didn't see this news before, is there an ML thread for this PoC? Do

Re: Slack channel available

2017-11-09 Thread Thomas Bouron
Wow, that's a great news! I didn't see this news before, is there an ML thread for this PoC? Do you know the official status of it? Is it supposed to replace IRC in the long term? Anyway, thanks for the tip Andrea, just signed it. Best. On Thu, 9 Nov 2017 at 15:45 Andrea Turli

[GitHub] brooklyn-docs pull request #235: Update outdated blueprint examples

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/235 ---

[jira] [Commented] (BROOKLYN-552) Tomcat entity stop / start fails as entity id changes which update run_dir but tc obviously not moved

2017-11-09 Thread Duncan Grant (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245908#comment-16245908 ] Duncan Grant commented on BROOKLYN-552: --- Much more stable on gce - solr restarts fine every time.

[GitHub] brooklyn-docs pull request #235: Update outdated blueprint examples

2017-11-09 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-docs/pull/235 Update outdated blueprint examples Updated example war's URL + fix wrong config key's name You can merge this pull request into a Git repository by running: $ git pull

Slack channel available

2017-11-09 Thread Andrea Turli
Hi! There is an experimental slack workspace for the Apache Software Foundation. It is still a PoC, but anyone is welcome to join if interested. I've just created a #brooklyn channel there. Anyone with an @apache.org email address can register to "the-asf.slack.com", and once registered anyone

[jira] [Commented] (BROOKLYN-552) Tomcat entity stop / start fails as entity id changes which update run_dir but tc obviously not moved

2017-11-09 Thread Duncan Grant (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245804#comment-16245804 ] Duncan Grant commented on BROOKLYN-552: --- Having also tested with solr I see different issues:

[GitHub] brooklyn-library pull request #141: Mysql update password

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-library/pull/141 ---

[GitHub] brooklyn-server pull request #889: Revert @JsonInclude annotations to what i...

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/889 ---

[GitHub] brooklyn-server issue #889: Revert @JsonInclude annotations to what it was i...

2017-11-09 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/889 LGTM ---

Re: Brooklyn REST API - omitting fields in JSON objects

2017-11-09 Thread Thomas Bouron
Hi all. I opened a PR for option 2[1] which is very small, that's a good thing I guess. Best. [1] https://github.com/apache/brooklyn-server/pull/889 On Wed, 8 Nov 2017 at 13:16 Robert Moss wrote: > Agree now is the best time to do this. > > Robert > > On 8 November

[GitHub] brooklyn-library issue #141: Mysql update password

2017-11-09 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-library/pull/141 Thanks @geomacy, I agree about the TODO. The shortcomings of the MySQL entity have already been identified in PRs such as #76 and I think a re-write in YAML is the best course of action.

[GitHub] brooklyn-server pull request #889: Revert @JsonInclude annotations to what i...

2017-11-09 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-server/pull/889 Revert @JsonInclude annotations to what it was in 0.12.0 for backward compatibility As per as [the discussion on the

[GitHub] brooklyn-docs pull request #232: Fix typo + syntax highlighting

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/232 ---

[GitHub] brooklyn-docs pull request #233: Update outdated blueprint examples

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/233 ---

[GitHub] brooklyn-docs pull request #234: Update YAML example to newer syntax

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/234 ---

[GitHub] brooklyn-server issue #879: Elect primary / failover policies

2017-11-09 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/879 Regarding a primaryTransitioning sensor... I agree that long-term it may not be the right way to indicate it, but I don't think we're going to solve the rerun-failed-tasks in time

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

2017-11-09 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/879#discussion_r149962511 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/failover/PropagatePrimaryEnricher.java --- @@ -0,0 +1,208 @@ +/* + * Licensed

[GitHub] brooklyn-server issue #879: Elect primary / failover policies

2017-11-09 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/879 I still think we should delete the support for propagating effectors from `PropagatePrimaryEnricher` - I don't think "it's handy" is a compelling enough reason to include this complexity,

[jira] [Commented] (BROOKLYN-549) Rebind policy fails when uses DSL to reference owning entity

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245580#comment-16245580 ] ASF GitHub Bot commented on BROOKLYN-549: - GitHub user aledsage opened a pull request:

[GitHub] brooklyn-server pull request #888: BROOKLYN-549: adds failing test

2017-11-09 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/888 BROOKLYN-549: adds failing test Adds test, marked as "Broken" so not run by jenkins, which demonstrates the bug reported at https://issues.apache.org/jira/browse/BROOKLYN-549 You can

[GitHub] brooklyn-library issue #141: Mysql update password

2017-11-09 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-library/pull/141 I've tested this by starting this blueprint: ``` brooklyn.catalog: version: "1.0.0-SNAPSHOT" items: - id: test version: "1.0.0-SNAPSHOT" itemType:

Jenkins build is back to normal : brooklyn-master-build #1340

2017-11-09 Thread Apache Jenkins Server
See

[jira] [Commented] (BROOKLYN-552) Tomcat entity stop / start fails as entity id changes which update run_dir but tc obviously not moved

2017-11-09 Thread Duncan Grant (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245534#comment-16245534 ] Duncan Grant commented on BROOKLYN-552: --- The entity id has changed - I should have made that clear

[jira] [Commented] (BROOKLYN-552) Tomcat entity stop / start fails as entity id changes which update run_dir but tc obviously not moved

2017-11-09 Thread Alex Heneveld (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245532#comment-16245532 ] Alex Heneveld commented on BROOKLYN-552: almost certain this has been working. why does the

[jira] [Commented] (BROOKLYN-548) Brooklyn node ID changes on restart

2017-11-09 Thread Thomas Bouron (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245531#comment-16245531 ] Thomas Bouron commented on BROOKLYN-548: Thanks [~svet], I get that for the planeId. But it

[jira] [Resolved] (BROOKLYN-551) Cannot add location

2017-11-09 Thread Duncan Godwin (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Godwin resolved BROOKLYN-551. Resolution: Cannot Reproduce > Cannot add location > --- > >

[jira] [Commented] (BROOKLYN-551) Cannot add location

2017-11-09 Thread Alex Heneveld (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245528#comment-16245528 ] Alex Heneveld commented on BROOKLYN-551: [~drigodwin] debug exceptions aren't necessarily a

[jira] [Commented] (BROOKLYN-551) Cannot add location

2017-11-09 Thread Alex Heneveld (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245527#comment-16245527 ] Alex Heneveld commented on BROOKLYN-551: [~drigodwin] debug exceptions aren't necessarily a

[GitHub] brooklyn-dist pull request #113: add license info for icons added to brookly...

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/113 ---

[GitHub] brooklyn-dist issue #113: add license info for icons added to brooklyn-serve...

2017-11-09 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/113 LGTM, thanks @ahgittin ---

[GitHub] brooklyn-server pull request #885: Icons for adjuncts, and descriptions

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/885 ---

[GitHub] brooklyn-server issue #878: Misc enhancements - warnings and more lookup con...

2017-11-09 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/878 still working on rebind, but note that this now also depends on https://github.com/apache/brooklyn-server/pull/887 ---

[GitHub] brooklyn-server pull request #887: Config on entity dynamic goes on type aft...

2017-11-09 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/887 Config on entity dynamic goes on type after persistence Fixes two issues noted with rebind of dynamic config. See first commit first for failing test, then the others which fix it and

[jira] [Created] (BROOKLYN-552) Tomcat entity stop / start fails as entity id changes which update run_dir but tc obviously not moved

2017-11-09 Thread Duncan Grant (JIRA)
Duncan Grant created BROOKLYN-552: - Summary: Tomcat entity stop / start fails as entity id changes which update run_dir but tc obviously not moved Key: BROOKLYN-552 URL:

[jira] [Updated] (BROOKLYN-551) Cannot add location

2017-11-09 Thread Duncan Godwin (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Godwin updated BROOKLYN-551: --- Description: I cannot add a location either through the add yaml to catalog using: {code}

[jira] [Created] (BROOKLYN-551) Cannot add location

2017-11-09 Thread Duncan Godwin (JIRA)
Duncan Godwin created BROOKLYN-551: -- Summary: Cannot add location Key: BROOKLYN-551 URL: https://issues.apache.org/jira/browse/BROOKLYN-551 Project: Brooklyn Issue Type: Bug Affects

Build failed in Jenkins: brooklyn-master-build #1339

2017-11-09 Thread Apache Jenkins Server
See -- [...truncated 8.71 MB...] [INFO] Total time: 14:36 min [INFO] Finished at: 2017-11-09T10:43:46+00:00 [INFO] Final Memory: 165M/478M [INFO]

[GitHub] brooklyn-client pull request #63: Fixes index out of range issue

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-client/pull/63 ---

[GitHub] brooklyn-docs pull request #234: Update YAML example to newer syntax

2017-11-09 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-docs/pull/234 Update YAML example to newer syntax Does 3 things: - update `serviceType` to `type` - update `start.latch` to `latch.start` - use backticks to have syntax highlighting on YAML

[GitHub] brooklyn-client pull request #63: Fixes index out of range issue

2017-11-09 Thread duncangrant
GitHub user duncangrant opened a pull request: https://github.com/apache/brooklyn-client/pull/63 Fixes index out of range issue Wasn't handling calls where there were only flag params e.g. br -v You can merge this pull request into a Git repository by running: $ git pull

[GitHub] brooklyn-client issue #62: Fixes index out of range issue

2017-11-09 Thread duncangrant
Github user duncangrant commented on the issue: https://github.com/apache/brooklyn-client/pull/62 Closing because would still panic if you ran br --help -v ---

[GitHub] brooklyn-client pull request #62: Fixes index out of range issue

2017-11-09 Thread duncangrant
Github user duncangrant closed the pull request at: https://github.com/apache/brooklyn-client/pull/62 ---