[GitHub] brooklyn-server issue #927: Bundle type endpoint

2018-01-08 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/927 I did but looks like I messed up my env somehow. Everything is fine now, sorry for the noise @ahgittin ---

[GitHub] brooklyn-server issue #927: Bundle type endpoint

2018-01-08 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/927 v strange. are you sure it was built correctly @tbouron ? it maybe had a `mvn clean install` pull down a slightly-old snapshot jar? adding a new `*Resource` class needs updates in a few

[GitHub] brooklyn-server issue #927: Bundle type endpoint

2018-01-08 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/927 Actually @ahgittin, it seems the new endpoint is now available: I get a 404 and it does not appear on the swagger page. Not sure what's going on here ---

[GitHub] brooklyn-server issue #928: Allow deprecation as the catalog item level

2018-01-08 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/928 retest this please ---

[GitHub] brooklyn-server pull request #928: Allow deprecation as the catalog item lev...

2018-01-08 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-server/pull/928 Allow deprecation as the catalog item level In YAML, one can mark a catalog item as `deprecated` but it works only when the flag it set as the `brooklyn.catalog` level. This

[GitHub] brooklyn-server issue #909: Bump jclouds dependency from v2.0.2 to 2.0.3

2018-01-08 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/909 @richardcloudsoft @andreaturli is there any reason why this shouldn't be merged now? ---

[jira] [Created] (BROOKLYN-572) Brooklyn CLI has problems on windows

2018-01-08 Thread Duncan Godwin (JIRA)
Duncan Godwin created BROOKLYN-572: -- Summary: Brooklyn CLI has problems on windows Key: BROOKLYN-572 URL: https://issues.apache.org/jira/browse/BROOKLYN-572 Project: Brooklyn Issue Type:

Build failed in Jenkins: brooklyn-server-master-docker #31

2018-01-08 Thread Apache Jenkins Server
See Changes: [alex.heneveld] rest tests for same types added [alex.heneveld] adds bundle-specific type endpoint -- [...truncated 7.01 MB...] at

[GitHub] brooklyn-server pull request #927: Bundle type endpoint

2018-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/927 ---

[GitHub] brooklyn-server issue #927: Bundle type endpoint

2018-01-08 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/927 Yep, the `latest` for bundles is not in the scope of this PR so I'm happy if there is another one for this. Merging ---

[GitHub] brooklyn-server pull request #927: Bundle type endpoint

2018-01-08 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/927#discussion_r160129168 --- Diff: rest/rest-resources/src/test/java/org/apache/brooklyn/rest/resources/BundleAndTypeResourcesTest.java --- @@ -1095,4 +1110,268 @@ private

[GitHub] brooklyn-server pull request #927: Bundle type endpoint

2018-01-08 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/927#discussion_r160128983 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/BundleResource.java --- @@ -107,6 +113,42 @@ protected

[GitHub] brooklyn-server pull request #926: [WIP] remove PortableTemplateBuilder

2018-01-08 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/926#discussion_r160125927 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/pool/MachinePoolPredicates.java --- @@ -82,40 +83,31 @@ public

[GitHub] brooklyn-server pull request #926: [WIP] remove PortableTemplateBuilder

2018-01-08 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/926#discussion_r160127430 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/JcloudsSshMachineLocationStubbedTest.java --- @@ -76,29 +76,12 @@

[GitHub] brooklyn-server pull request #926: [WIP] remove PortableTemplateBuilder

2018-01-08 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/926#discussion_r160126361 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -2609,7 +2609,7 @@ protected

[GitHub] brooklyn-server issue #927: Bundle type endpoint

2018-01-08 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/927 +1 to supporting `latest` on bundle version -- i'll add that. i think all other comments addressed. `latest` bundle support could be new PR if you're happy to merge this now @tbouron .

[GitHub] brooklyn-server pull request #927: Bundle type endpoint

2018-01-08 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/927#discussion_r160127197 --- Diff: rest/rest-resources/src/test/java/org/apache/brooklyn/rest/resources/BundleAndTypeResourcesTest.java --- @@ -1095,4 +1110,268 @@

[GitHub] brooklyn-server pull request #927: Bundle type endpoint

2018-01-08 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/927#discussion_r160126592 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/BundleResource.java --- @@ -107,6 +113,42 @@ protected

[GitHub] brooklyn-server pull request #927: Bundle type endpoint

2018-01-08 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/927#discussion_r160126515 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/BundleApi.java --- @@ -88,6 +90,51 @@ public BundleSummary detail(

[GitHub] brooklyn-server pull request #927: Bundle type endpoint

2018-01-08 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/927#discussion_r160111321 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/BundleApi.java --- @@ -88,6 +90,51 @@ public BundleSummary detail(

[GitHub] brooklyn-server pull request #927: Bundle type endpoint

2018-01-08 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/927#discussion_r160116429 --- Diff: rest/rest-resources/src/test/java/org/apache/brooklyn/rest/resources/BundleAndTypeResourcesTest.java --- @@ -1095,4 +1110,268 @@ private

[GitHub] brooklyn-server pull request #927: Bundle type endpoint

2018-01-08 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/927#discussion_r160111698 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/BundleResource.java --- @@ -107,6 +113,42 @@ protected