[GitHub] [brooklyn-server] aledsage commented on a change in pull request #1052: Bump groovy-eclipse-batch from 2.4.3-01 to 2.5.8-02

2019-12-11 Thread GitBox
aledsage commented on a change in pull request #1052: Bump groovy-eclipse-batch from 2.4.3-01 to 2.5.8-02 URL: https://github.com/apache/brooklyn-server/pull/1052#discussion_r356464034 ## File path: parent/pom.xml ## @@ -146,6 +146,16 @@ + +

[GitHub] [brooklyn-server] aledsage commented on a change in pull request #1052: Bump groovy-eclipse-batch from 2.4.3-01 to 2.5.8-02

2019-12-11 Thread GitBox
aledsage commented on a change in pull request #1052: Bump groovy-eclipse-batch from 2.4.3-01 to 2.5.8-02 URL: https://github.com/apache/brooklyn-server/pull/1052#discussion_r356470921 ## File path: core/pom.xml ## @@ -119,7 +119,13 @@ org.codehaus

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #150: add time information to application data to allow ordering launch time

2019-12-12 Thread GitBox
tbouron commented on a change in pull request #150: add time information to application data to allow ordering launch time URL: https://github.com/apache/brooklyn-ui/pull/150#discussion_r357173695 ## File path: ui-modules/app-inspector/app/views/main/main.template.html ##

[GitHub] [brooklyn-ui] tbouron merged pull request #153: Fix importer linting

2019-12-12 Thread GitBox
tbouron merged pull request #153: Fix importer linting URL: https://github.com/apache/brooklyn-ui/pull/153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [brooklyn-ui] tbouron merged pull request #152: Fix composer open

2019-12-12 Thread GitBox
tbouron merged pull request #152: Fix composer open URL: https://github.com/apache/brooklyn-ui/pull/152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #154: add custom onChange directive to correct file uploader bug

2019-12-12 Thread GitBox
tbouron commented on a change in pull request #154: add custom onChange directive to correct file uploader bug URL: https://github.com/apache/brooklyn-ui/pull/154#discussion_r357184722 ## File path: ui-modules/utils/catalog-uploader/catalog-uploader.js ## @@ -208,3 +211,20

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #154: add custom onChange directive to correct file uploader bug

2019-12-12 Thread GitBox
tbouron commented on a change in pull request #154: add custom onChange directive to correct file uploader bug URL: https://github.com/apache/brooklyn-ui/pull/154#discussion_r357184351 ## File path: ui-modules/utils/catalog-uploader/catalog-uploader.js ## @@ -120,7 +121,9

[GitHub] [brooklyn-docs] tbouron commented on issue #297: Add sample pom.xml for dependency generation

2019-12-12 Thread GitBox
tbouron commented on issue #297: Add sample pom.xml for dependency generation URL: https://github.com/apache/brooklyn-docs/pull/297#issuecomment-565037966 FYI, build failure can safely be ignored as I didn't setup properly Jenkins to build the docs, or website -

[GitHub] [brooklyn-docs] tbouron merged pull request #297: Add sample pom.xml for dependency generation

2019-12-12 Thread GitBox
tbouron merged pull request #297: Add sample pom.xml for dependency generation URL: https://github.com/apache/brooklyn-docs/pull/297 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [brooklyn-ui] frogfather commented on a change in pull request #154: add custom onChange directive to correct file uploader bug

2019-12-12 Thread GitBox
frogfather commented on a change in pull request #154: add custom onChange directive to correct file uploader bug URL: https://github.com/apache/brooklyn-ui/pull/154#discussion_r357189050 ## File path: ui-modules/utils/catalog-uploader/catalog-uploader.js ## @@ -120,7 +121

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #154: add custom onChange directive to correct file uploader bug

2019-12-12 Thread GitBox
tbouron commented on a change in pull request #154: add custom onChange directive to correct file uploader bug URL: https://github.com/apache/brooklyn-ui/pull/154#discussion_r357189935 ## File path: ui-modules/utils/catalog-uploader/catalog-uploader.js ## @@ -120,7 +121,9

[GitHub] [brooklyn-ui] frogfather commented on a change in pull request #154: add custom onChange directive to correct file uploader bug

2019-12-12 Thread GitBox
frogfather commented on a change in pull request #154: add custom onChange directive to correct file uploader bug URL: https://github.com/apache/brooklyn-ui/pull/154#discussion_r357190762 ## File path: ui-modules/utils/catalog-uploader/catalog-uploader.js ## @@ -208,3 +211

[GitHub] [brooklyn-ui] frogfather commented on a change in pull request #154: add custom onChange directive to correct file uploader bug

2019-12-12 Thread GitBox
frogfather commented on a change in pull request #154: add custom onChange directive to correct file uploader bug URL: https://github.com/apache/brooklyn-ui/pull/154#discussion_r357201777 ## File path: ui-modules/utils/catalog-uploader/catalog-uploader.js ## @@ -120,7 +121

[GitHub] [brooklyn-ui] frogfather commented on a change in pull request #150: add time information to application data to allow ordering launch time

2019-12-12 Thread GitBox
frogfather commented on a change in pull request #150: add time information to application data to allow ordering launch time URL: https://github.com/apache/brooklyn-ui/pull/150#discussion_r357263854 ## File path: ui-modules/app-inspector/app/views/main/main.template.html #

[GitHub] [brooklyn-ui] tbouron merged pull request #154: add custom onChange directive to correct file uploader bug

2019-12-13 Thread GitBox
tbouron merged pull request #154: add custom onChange directive to correct file uploader bug URL: https://github.com/apache/brooklyn-ui/pull/154 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [brooklyn-ui] dependabot[bot] commented on issue #147: Bump eslint from 3.19.0 to 6.6.0 in /ui-modules/blueprint-composer

2019-12-13 Thread GitBox
dependabot[bot] commented on issue #147: Bump eslint from 3.19.0 to 6.6.0 in /ui-modules/blueprint-composer URL: https://github.com/apache/brooklyn-ui/pull/147#issuecomment-565361488 Sorry, only users with push access can use that command. --

[GitHub] [brooklyn-ui] ahgittin commented on issue #147: Bump eslint from 3.19.0 to 6.6.0 in /ui-modules/blueprint-composer

2019-12-13 Thread GitBox
ahgittin commented on issue #147: Bump eslint from 3.19.0 to 6.6.0 in /ui-modules/blueprint-composer URL: https://github.com/apache/brooklyn-ui/pull/147#issuecomment-565361481 @dependabot ignore this major version This is an

[GitHub] [brooklyn-ui] ahgittin opened a new pull request #156: minor cleanups with version + NPE

2019-12-13 Thread GitBox
ahgittin opened a new pull request #156: minor cleanups with version + NPE URL: https://github.com/apache/brooklyn-ui/pull/156 - if using quick launcher or catalog "deploy", it ignored the version; now it respects the version - in composer, it could break if a config value was null, now

[GitHub] [brooklyn-ui] frogfather commented on issue #156: minor cleanups with version + NPE

2019-12-13 Thread GitBox
frogfather commented on issue #156: minor cleanups with version + NPE URL: https://github.com/apache/brooklyn-ui/pull/156#issuecomment-565406575 @ahgittin LGTM - still waiting for tests to pass. Will merge once done. This is a

[GitHub] [brooklyn-server] ahgittin opened a new pull request #1075: Tidies - adjunct destroy, and better error messages

2019-12-13 Thread GitBox
ahgittin opened a new pull request #1075: Tidies - adjunct destroy, and better error messages URL: https://github.com/apache/brooklyn-server/pull/1075 Fixes a few minor things I've encountered: * When invalid plans were sent, the error messages were awful. Now they are more concise

[GitHub] [brooklyn-ui] asfgit merged pull request #156: minor cleanups with version + NPE

2019-12-13 Thread GitBox
asfgit merged pull request #156: minor cleanups with version + NPE URL: https://github.com/apache/brooklyn-ui/pull/156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [brooklyn-ui] asfgit merged pull request #156: minor cleanups with version + NPE

2019-12-13 Thread GitBox
asfgit merged pull request #156: minor cleanups with version + NPE URL: https://github.com/apache/brooklyn-ui/pull/156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [brooklyn-server] aledsage commented on a change in pull request #1052: Bump groovy-eclipse-batch from 2.4.3-01 to 2.5.8-02

2019-12-13 Thread GitBox
aledsage commented on a change in pull request #1052: Bump groovy-eclipse-batch from 2.4.3-01 to 2.5.8-02 URL: https://github.com/apache/brooklyn-server/pull/1052#discussion_r357728088 ## File path: core/pom.xml ## @@ -119,7 +119,13 @@ org.codehaus

[GitHub] [brooklyn-server] ahgittin commented on issue #1073: Fix session error

2019-12-13 Thread GitBox
ahgittin commented on issue #1073: Fix session error URL: https://github.com/apache/brooklyn-server/pull/1073#issuecomment-565559382 looks good to me This is an automated message from the Apache Git Service. To respond to the

[GitHub] [brooklyn-server] asfgit merged pull request #1073: Fix session error

2019-12-13 Thread GitBox
asfgit merged pull request #1073: Fix session error URL: https://github.com/apache/brooklyn-server/pull/1073 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [brooklyn-ui] ahgittin commented on issue #150: add time information to application data to allow ordering launch time

2019-12-13 Thread GitBox
ahgittin commented on issue #150: add time information to application data to allow ordering launch time URL: https://github.com/apache/brooklyn-ui/pull/150#issuecomment-565562524 would it be easier to add the start-time server-side e.g. with a `result.setExtraField("startTimeUtc", ...)` i

[GitHub] [brooklyn-ui] frogfather commented on issue #150: add time information to application data to allow ordering launch time

2019-12-13 Thread GitBox
frogfather commented on issue #150: add time information to application data to allow ordering launch time URL: https://github.com/apache/brooklyn-ui/pull/150#issuecomment-565629663 > would it be easier to add the start-time server-side e.g. with a `result.setExtraField("startTimeUtc", ...

[GitHub] [brooklyn-ui] frogfather edited a comment on issue #150: add time information to application data to allow ordering launch time

2019-12-16 Thread GitBox
frogfather edited a comment on issue #150: add time information to application data to allow ordering launch time URL: https://github.com/apache/brooklyn-ui/pull/150#issuecomment-565629663 > would it be easier to add the start-time server-side e.g. with a `result.setExtraField("startTimeUt

[GitHub] [brooklyn-server] tbouron commented on issue #1074: Upgrade jclouds to 2.1.2 (from 2.1.0)

2019-12-16 Thread GitBox
tbouron commented on issue #1074: Upgrade jclouds to 2.1.2 (from 2.1.0) URL: https://github.com/apache/brooklyn-server/pull/1074#issuecomment-565987352 Thank you @aledsage. I tested basic VM deployments on AWS, Azure ARM and GCE and it works as expected so merging.

[GitHub] [brooklyn-server] tbouron merged pull request #1074: Upgrade jclouds to 2.1.2 (from 2.1.0)

2019-12-16 Thread GitBox
tbouron merged pull request #1074: Upgrade jclouds to 2.1.2 (from 2.1.0) URL: https://github.com/apache/brooklyn-server/pull/1074 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [brooklyn-dist] tbouron commented on issue #150: BROOKLYN-597 Remove md5/sha1 - DO NOT MERGE

2019-12-16 Thread GitBox
tbouron commented on issue #150: BROOKLYN-597 Remove md5/sha1 - DO NOT MERGE URL: https://github.com/apache/brooklyn-dist/pull/150#issuecomment-566007447 Hi @geomacy, are you happy with this? Let me know what you want to do :)

[GitHub] [brooklyn-server] frogfather opened a new pull request #1076: add time data to returned data

2019-12-16 Thread GitBox
frogfather opened a new pull request #1076: add time data to returned data URL: https://github.com/apache/brooklyn-server/pull/1076 Adds creationTime key to returned data to allow ui to sort applications by creation time. PR# 150 in brooklyn-ui implements the sorting. --

[GitHub] [brooklyn-ui] frogfather commented on issue #150: add time information to application data to allow ordering launch time

2019-12-16 Thread GitBox
frogfather commented on issue #150: add time information to application data to allow ordering launch time URL: https://github.com/apache/brooklyn-ui/pull/150#issuecomment-566015548 This has now been refactored to use time information returned from the rest server. PR #1076 on brooklyn-ser

[GitHub] [brooklyn-ui] tbouron commented on issue #150: add time information to application data to allow ordering launch time

2019-12-16 Thread GitBox
tbouron commented on issue #150: add time information to application data to allow ordering launch time URL: https://github.com/apache/brooklyn-ui/pull/150#issuecomment-566018258 FYI: https://github.com/apache/brooklyn-server/pull/1076 needs to be merged first

[GitHub] [brooklyn-server] aledsage opened a new pull request #1077: Upgrade CXF from 3.2.8 to 3.3.2

2019-12-16 Thread GitBox
aledsage opened a new pull request #1077: Upgrade CXF from 3.2.8 to 3.3.2 URL: https://github.com/apache/brooklyn-server/pull/1077 ... and bump related versions. This is so our CXF version matches the one listed for Karaf 4.2.7 (see https://karaf.apache.org/news.html). It requ

[GitHub] [brooklyn-server] aledsage commented on a change in pull request #1077: Upgrade CXF from 3.2.8 to 3.3.2

2019-12-16 Thread GitBox
aledsage commented on a change in pull request #1077: Upgrade CXF from 3.2.8 to 3.3.2 URL: https://github.com/apache/brooklyn-server/pull/1077#discussion_r358191983 ## File path: pom.xml ## @@ -180,16 +180,15 @@ 2.5 1.4.0 0.4.1 -1.10 +

[GitHub] [brooklyn-server] asfgit merged pull request #1076: add time data to returned data

2019-12-16 Thread GitBox
asfgit merged pull request #1076: add time data to returned data URL: https://github.com/apache/brooklyn-server/pull/1076 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [brooklyn-server] asfgit closed pull request #1076: add time data to returned data

2019-12-16 Thread GitBox
asfgit closed pull request #1076: add time data to returned data URL: https://github.com/apache/brooklyn-server/pull/1076 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [brooklyn-server] ahgittin commented on issue #1076: add time data to returned data

2019-12-16 Thread GitBox
ahgittin commented on issue #1076: add time data to returned data URL: https://github.com/apache/brooklyn-server/pull/1076#issuecomment-566030512 useful. merging. This is an automated message from the Apache Git Service. To r

[GitHub] [brooklyn-server] ahgittin commented on issue #1077: Upgrade CXF from 3.2.8 to 3.3.2

2019-12-16 Thread GitBox
ahgittin commented on issue #1077: Upgrade CXF from 3.2.8 to 3.3.2 URL: https://github.com/apache/brooklyn-server/pull/1077#issuecomment-566045877 eyeballing this it looks good. it's definitely a step in the right direction. will merge then do more investigation of resulting artifacts to

[GitHub] [brooklyn-server] asfgit closed pull request #1077: Upgrade CXF from 3.2.8 to 3.3.2

2019-12-16 Thread GitBox
asfgit closed pull request #1077: Upgrade CXF from 3.2.8 to 3.3.2 URL: https://github.com/apache/brooklyn-server/pull/1077 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [brooklyn-server] asfgit merged pull request #1077: Upgrade CXF from 3.2.8 to 3.3.2

2019-12-16 Thread GitBox
asfgit merged pull request #1077: Upgrade CXF from 3.2.8 to 3.3.2 URL: https://github.com/apache/brooklyn-server/pull/1077 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [brooklyn-dist] geomacy commented on issue #150: BROOKLYN-597 Remove md5/sha1 - DO NOT MERGE

2019-12-16 Thread GitBox
geomacy commented on issue #150: BROOKLYN-597 Remove md5/sha1 - DO NOT MERGE URL: https://github.com/apache/brooklyn-dist/pull/150#issuecomment-566046815 hi @tbouron, sorry, I have very much had it in my mind to try to get that script working to test this out, but I have not managed to make

[GitHub] [brooklyn-server] ahgittin commented on issue #1077: Upgrade CXF from 3.2.8 to 3.3.2

2019-12-16 Thread GitBox
ahgittin commented on issue #1077: Upgrade CXF from 3.2.8 to 3.3.2 URL: https://github.com/apache/brooklyn-server/pull/1077#issuecomment-566051570 The following are all the bundles and versions which are wanted as deps, indicating what is used in the case of multiples: ``` -aopall

[GitHub] [brooklyn-server] tbouron opened a new pull request #1078: Update Jenkinsfile

2019-12-16 Thread GitBox
tbouron opened a new pull request #1078: Update Jenkinsfile URL: https://github.com/apache/brooklyn-server/pull/1078 This does the following: - add the pipeline trigger on comment only if we are building a PR - not deploy artifacts when building master. This will be taken care of duri

[GitHub] [brooklyn-library] tbouron opened a new pull request #177: Update Jenkinsfile

2019-12-16 Thread GitBox
tbouron opened a new pull request #177: Update Jenkinsfile URL: https://github.com/apache/brooklyn-library/pull/177 This does the following: - add the pipeline trigger on comment only if we are building a PR - not deploy artifacts when building master. This will be taken care of durin

[GitHub] [brooklyn-client] tbouron opened a new pull request #81: Update Jenkinsfile to:

2019-12-16 Thread GitBox
tbouron opened a new pull request #81: Update Jenkinsfile to: URL: https://github.com/apache/brooklyn-client/pull/81 This does the following: - add the pipeline trigger on comment only if we are building a PR - not deploy artifacts when building master. This will be taken care of duri

[GitHub] [brooklyn-ui] tbouron opened a new pull request #157: Update Jenkinsfile

2019-12-16 Thread GitBox
tbouron opened a new pull request #157: Update Jenkinsfile URL: https://github.com/apache/brooklyn-ui/pull/157 This does the following: - add the pipeline trigger on comment only if we are building a PR - not deploy artifacts when building master. This will be taken care of during the

[GitHub] [brooklyn-dist] tbouron opened a new pull request #151: Update Jenkinsfile

2019-12-16 Thread GitBox
tbouron opened a new pull request #151: Update Jenkinsfile URL: https://github.com/apache/brooklyn-dist/pull/151 This does the following: - add the pipeline trigger on comment only if we are building a PR - not deploy artifacts when building master. This will be taken care of during t

[GitHub] [brooklyn-server] ahgittin closed pull request #1047: comment out CXF logging feature

2019-12-16 Thread GitBox
ahgittin closed pull request #1047: comment out CXF logging feature URL: https://github.com/apache/brooklyn-server/pull/1047 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [brooklyn-server] ahgittin commented on issue #1047: comment out CXF logging feature

2019-12-16 Thread GitBox
ahgittin commented on issue #1047: comment out CXF logging feature URL: https://github.com/apache/brooklyn-server/pull/1047#issuecomment-566055217 dropping now we use 3.3.2. can reopen if this problem reemerges. This is an au

[GitHub] [brooklyn-dist] tbouron commented on issue #150: BROOKLYN-597 Remove md5/sha1 - DO NOT MERGE

2019-12-16 Thread GitBox
tbouron commented on issue #150: BROOKLYN-597 Remove md5/sha1 - DO NOT MERGE URL: https://github.com/apache/brooklyn-dist/pull/150#issuecomment-566060485 Sure, no problem @geomacy, I'll try to build on my local machine with your PR and get back to you with the findings

[GitHub] [brooklyn-server] ahgittin commented on issue #1077: Upgrade CXF from 3.2.8 to 3.3.2

2019-12-16 Thread GitBox
ahgittin commented on issue #1077: Upgrade CXF from 3.2.8 to 3.3.2 URL: https://github.com/apache/brooklyn-server/pull/1077#issuecomment-566072895 the assembly in dist includes duplicate versions for some things which is a little bit worrying but it looks like this has always been the case.

[GitHub] [brooklyn-server] ahgittin commented on issue #1077: Upgrade CXF from 3.2.8 to 3.3.2

2019-12-16 Thread GitBox
ahgittin commented on issue #1077: Upgrade CXF from 3.2.8 to 3.3.2 URL: https://github.com/apache/brooklyn-server/pull/1077#issuecomment-566074035 seems to build and run fine though :) This is an automated message from the Apa

[GitHub] [brooklyn-ui] tbouron opened a new pull request #158: Update frontend-maven-plugin version

2019-12-16 Thread GitBox
tbouron opened a new pull request #158: Update frontend-maven-plugin version URL: https://github.com/apache/brooklyn-ui/pull/158 Version 1.3 was causing NPE under some environment. The latest version fixes this issue + a couple of others

[GitHub] [brooklyn-dist] tbouron commented on issue #150: BROOKLYN-597 Remove md5/sha1 - DO NOT MERGE

2019-12-16 Thread GitBox
tbouron commented on issue #150: BROOKLYN-597 Remove md5/sha1 - DO NOT MERGE URL: https://github.com/apache/brooklyn-dist/pull/150#issuecomment-566082562 @geomacy The script worked for me. Just had to do 3 things: - manually update `make-release-artifacts.sh` to add `-Drpm -Ddeb` to the

[GitHub] [brooklyn-dist] geomacy commented on issue #150: BROOKLYN-597 Remove md5/sha1 - DO NOT MERGE

2019-12-17 Thread GitBox
geomacy commented on issue #150: BROOKLYN-597 Remove md5/sha1 - DO NOT MERGE URL: https://github.com/apache/brooklyn-dist/pull/150#issuecomment-566456000 that's terrific @tbouron I will give that a go tonight and include the changes you suggested; will look at ui#158 --

[GitHub] [brooklyn-ui] geomacy merged pull request #158: Update frontend-maven-plugin version

2019-12-17 Thread GitBox
geomacy merged pull request #158: Update frontend-maven-plugin version URL: https://github.com/apache/brooklyn-ui/pull/158 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [brooklyn-ui] tbouron merged pull request #150: add time information to application data to allow ordering launch time

2019-12-17 Thread GitBox
tbouron merged pull request #150: add time information to application data to allow ordering launch time URL: https://github.com/apache/brooklyn-ui/pull/150 This is an automated message from the Apache Git Service. To respon

[GitHub] [brooklyn-dist] geomacy commented on issue #150: BROOKLYN-597 Remove md5/sha1 - DO NOT MERGE

2019-12-17 Thread GitBox
geomacy commented on issue #150: BROOKLYN-597 Remove md5/sha1 - DO NOT MERGE URL: https://github.com/apache/brooklyn-dist/pull/150#issuecomment-566806880 Well unfortunately I still don't have this going. I caught up to latest masters and added the `rpm` and `deb` flags to the build; this ti

[GitHub] [brooklyn-server] jcabrerizo opened a new pull request #1079: Adding logic to manage a max session age

2019-12-18 Thread GitBox
jcabrerizo opened a new pull request #1079: Adding logic to manage a max session age URL: https://github.com/apache/brooklyn-server/pull/1079 Allow set up the max age for the cookies using the propertie ``` org.apache.brooklyn.server.maxSessionAge = XX # in seconds ``` Also anot

[GitHub] [brooklyn-ui] jcabrerizo opened a new pull request #159: Manage backend errors including expired sessions

2019-12-18 Thread GitBox
jcabrerizo opened a new pull request #159: Manage backend errors including expired sessions URL: https://github.com/apache/brooklyn-ui/pull/159 Manages the errors that the back end send using the code on this PR: https://github.com/apache/brooklyn-server/pull/1079

[GitHub] [brooklyn-server] frogfather opened a new pull request #1080: add check for missing endpoint

2019-12-19 Thread GitBox
frogfather opened a new pull request #1080: add check for missing endpoint URL: https://github.com/apache/brooklyn-server/pull/1080 Azure-ARM locations with no defined `endpoint` led to extreme server performance issues at app deployment time. Eventually causes OOME, Jackson serialisation

[GitHub] [brooklyn-ui] geomacy opened a new pull request #160: add relativePath to parent for release make

2019-12-19 Thread GitBox
geomacy opened a new pull request #160: add relativePath to parent for release make URL: https://github.com/apache/brooklyn-ui/pull/160 This adds back the `relativePath` to the parent in the pom, to allow the `make_release_artifacts.sh` to work. This is required to get https://github.com/

[GitHub] [brooklyn-ui] geomacy commented on issue #160: add relativePath to parent for release make

2019-12-20 Thread GitBox
geomacy commented on issue #160: add relativePath to parent for release make URL: https://github.com/apache/brooklyn-ui/pull/160#issuecomment-567866553 > @geomacy @ahgittin what about adding back the relative path (because Brooklyn needs it) but adding a profile (something like `branded`) w

[GitHub] [brooklyn-ui] tbouron commented on issue #160: add relativePath to parent for release make

2019-12-20 Thread GitBox
tbouron commented on issue #160: add relativePath to parent for release make URL: https://github.com/apache/brooklyn-ui/pull/160#issuecomment-567867335 @geomacy I think so. Let me try quickly This is an automated message from

[GitHub] [brooklyn-ui] tbouron edited a comment on issue #160: add relativePath to parent for release make

2019-12-20 Thread GitBox
tbouron edited a comment on issue #160: add relativePath to parent for release make URL: https://github.com/apache/brooklyn-ui/pull/160#issuecomment-567870966 @geomacy Seems to work by using a property, referenced in `${relative.path}`. By default, the property is set to `../brooklyn-serv

[GitHub] [brooklyn-ui] tbouron commented on issue #160: add relativePath to parent for release make

2019-12-20 Thread GitBox
tbouron commented on issue #160: add relativePath to parent for release make URL: https://github.com/apache/brooklyn-ui/pull/160#issuecomment-567870966 @geomacy Seems to works by using a property, referenced in `${relative.path. By default, the property is set to ./brooklyn-server/parent/p

[GitHub] [brooklyn-ui] frogfather opened a new pull request #161: require endpoint when provider is azure-arm

2019-12-20 Thread GitBox
frogfather opened a new pull request #161: require endpoint when provider is azure-arm URL: https://github.com/apache/brooklyn-ui/pull/161 Causes the endpoint field to be required when the provider is azure-arm. This is an au

[GitHub] [brooklyn-ui] tbouron commented on issue #160: add relativePath to parent for release make

2019-12-20 Thread GitBox
tbouron commented on issue #160: add relativePath to parent for release make URL: https://github.com/apache/brooklyn-ui/pull/160#issuecomment-567892302 retest this please This is an automated message from the Apache Git Servic

[GitHub] [brooklyn-dist] tbouron commented on issue #150: BROOKLYN-597 Remove md5/sha1

2019-12-20 Thread GitBox
tbouron commented on issue #150: BROOKLYN-597 Remove md5/sha1 URL: https://github.com/apache/brooklyn-dist/pull/150#issuecomment-567895583 Tested with the last commits, it now works, great job @geomacy 👏 Although as you said, it requires https://github.com/apache/brooklyn-ui/pull/16

[GitHub] [brooklyn-ui] ahgittin commented on issue #160: add relativePath to parent for release make

2019-12-20 Thread GitBox
ahgittin commented on issue #160: add relativePath to parent for release make URL: https://github.com/apache/brooklyn-ui/pull/160#issuecomment-567953269 nice answer re properties @tbouron -- maven says > Properties are not supported in the following XPath elements: > `/project(/par

[GitHub] [brooklyn-ui] tbouron commented on issue #160: add relativePath to parent for release make

2019-12-20 Thread GitBox
tbouron commented on issue #160: add relativePath to parent for release make URL: https://github.com/apache/brooklyn-ui/pull/160#issuecomment-567955148 @ahgittin In normal circonstances, it is not needed because as you said, maven is able to fetch the parent pom by the version. Howev

[GitHub] [brooklyn-ui] ahgittin commented on issue #160: add relativePath to parent for release make

2019-12-20 Thread GitBox
ahgittin commented on issue #160: add relativePath to parent for release make URL: https://github.com/apache/brooklyn-ui/pull/160#issuecomment-567957290 thanks @tbouron -- not 100% clear though, even when cutting a new version, we build `brooklyn-server` before `brooklyn-ui`, so `brooklyn-s

[GitHub] [brooklyn-ui] tbouron commented on issue #160: add relativePath to parent for release make

2019-12-20 Thread GitBox
tbouron commented on issue #160: add relativePath to parent for release make URL: https://github.com/apache/brooklyn-ui/pull/160#issuecomment-567958917 Maybe we do something wrong. What I know is that, with the current state, if you try to follow the release instructions (by changing the ve

[GitHub] [brooklyn-ui] tbouron commented on issue #160: add relativePath to parent for release make

2019-12-20 Thread GitBox
tbouron commented on issue #160: add relativePath to parent for release make URL: https://github.com/apache/brooklyn-ui/pull/160#issuecomment-567959079 Maybe this is an issue with our script @ahgittin but in this case, I don't know how to fix this. -

[GitHub] [brooklyn-ui] ahgittin commented on issue #160: add relativePath to parent for release make

2019-12-20 Thread GitBox
ahgittin commented on issue #160: add relativePath to parent for release make URL: https://github.com/apache/brooklyn-ui/pull/160#issuecomment-567959949 thanks. i'll see if there's anything that jumps out in the make without `relativePath` but where i've been testing i think your property

[GitHub] [brooklyn-ui] ahgittin commented on issue #160: add relativePath to parent for release make

2019-12-20 Thread GitBox
ahgittin commented on issue #160: add relativePath to parent for release make URL: https://github.com/apache/brooklyn-ui/pull/160#issuecomment-567966459 > Maven looks for the parent pom first in the reactor of currently building projects Seems ^ isn't happening so it does need `relat

[GitHub] [brooklyn-ui] ahgittin opened a new pull request #162: Relative path configurable

2019-12-20 Thread GitBox
ahgittin opened a new pull request #162: Relative path configurable URL: https://github.com/apache/brooklyn-ui/pull/162 extends #160 offering a way for downstream projects to customize relative path if it causes issues This i

[GitHub] [brooklyn-ui] ahgittin commented on issue #162: Relative path configurable

2019-12-20 Thread GitBox
ahgittin commented on issue #162: Relative path configurable URL: https://github.com/apache/brooklyn-ui/pull/162#issuecomment-567968684 thanks @tbouron for the suggestion in #160 , implemented here This is an automated message

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #162: Relative path configurable

2019-12-20 Thread GitBox
tbouron commented on a change in pull request #162: Relative path configurable URL: https://github.com/apache/brooklyn-ui/pull/162#discussion_r360433627 ## File path: pom.xml ## @@ -85,6 +84,8 @@ 1.0.0-SNAPSHOT ${revision} Apache Brooklyn +

[GitHub] [brooklyn-ui] ahgittin commented on issue #161: require endpoint when provider is azure-arm

2019-12-20 Thread GitBox
ahgittin commented on issue #161: require endpoint when provider is azure-arm URL: https://github.com/apache/brooklyn-ui/pull/161#issuecomment-567978859 LGTM This is an automated message from the Apache Git Service. To respond

[GitHub] [brooklyn-ui] ahgittin commented on a change in pull request #162: Relative path configurable

2019-12-20 Thread GitBox
ahgittin commented on a change in pull request #162: Relative path configurable URL: https://github.com/apache/brooklyn-ui/pull/162#discussion_r360441133 ## File path: pom.xml ## @@ -85,6 +84,8 @@ 1.0.0-SNAPSHOT ${revision} Apache Brooklyn +

[GitHub] [brooklyn-ui] ahgittin commented on issue #157: Update Jenkinsfile

2019-12-20 Thread GitBox
ahgittin commented on issue #157: Update Jenkinsfile URL: https://github.com/apache/brooklyn-ui/pull/157#issuecomment-567979624 LGTM This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [brooklyn-ui] asfgit merged pull request #157: Update Jenkinsfile

2019-12-20 Thread GitBox
asfgit merged pull request #157: Update Jenkinsfile URL: https://github.com/apache/brooklyn-ui/pull/157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [brooklyn-ui] asfgit merged pull request #162: Relative path configurable

2019-12-20 Thread GitBox
asfgit merged pull request #162: Relative path configurable URL: https://github.com/apache/brooklyn-ui/pull/162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [brooklyn-ui] asfgit closed pull request #160: add relativePath to parent for release make

2019-12-20 Thread GitBox
asfgit closed pull request #160: add relativePath to parent for release make URL: https://github.com/apache/brooklyn-ui/pull/160 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [brooklyn-ui] asfgit merged pull request #161: require endpoint when provider is azure-arm

2019-12-20 Thread GitBox
asfgit merged pull request #161: require endpoint when provider is azure-arm URL: https://github.com/apache/brooklyn-ui/pull/161 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [brooklyn-ui] asfgit closed pull request #157: Update Jenkinsfile

2019-12-20 Thread GitBox
asfgit closed pull request #157: Update Jenkinsfile URL: https://github.com/apache/brooklyn-ui/pull/157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [brooklyn-dist] ahgittin commented on issue #150: BROOKLYN-597 Remove md5/sha1

2019-12-20 Thread GitBox
ahgittin commented on issue #150: BROOKLYN-597 Remove md5/sha1 URL: https://github.com/apache/brooklyn-dist/pull/150#issuecomment-567980706 merging -- great stuff! This is an automated message from the Apache Git Service. To r

[GitHub] [brooklyn-dist] asfgit merged pull request #151: Update Jenkinsfile

2019-12-20 Thread GitBox
asfgit merged pull request #151: Update Jenkinsfile URL: https://github.com/apache/brooklyn-dist/pull/151 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [brooklyn-dist] asfgit closed pull request #144: Make integration tests run on Jenkins

2019-12-20 Thread GitBox
asfgit closed pull request #144: Make integration tests run on Jenkins URL: https://github.com/apache/brooklyn-dist/pull/144 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [brooklyn-dist] asfgit merged pull request #150: BROOKLYN-597 Remove md5/sha1

2019-12-20 Thread GitBox
asfgit merged pull request #150: BROOKLYN-597 Remove md5/sha1 URL: https://github.com/apache/brooklyn-dist/pull/150 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [brooklyn] ahgittin commented on issue #35: Updates NOTICE for 1.0.0 release

2019-12-20 Thread GitBox
ahgittin commented on issue #35: Updates NOTICE for 1.0.0 release URL: https://github.com/apache/brooklyn/pull/35#issuecomment-567983144 as @tbouron notes this shouldn't have the duplicate, and it should have picked up a bunch more version changes. i suggest closing this @nakomis and

[GitHub] [brooklyn-ui] tbouron closed pull request #155: DO NOT MERGE - This is to test the new Jenkins job

2019-12-20 Thread GitBox
tbouron closed pull request #155: DO NOT MERGE - This is to test the new Jenkins job URL: https://github.com/apache/brooklyn-ui/pull/155 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [brooklyn-server] asfgit merged pull request #1078: Update Jenkinsfile

2019-12-20 Thread GitBox
asfgit merged pull request #1078: Update Jenkinsfile URL: https://github.com/apache/brooklyn-server/pull/1078 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [brooklyn-client] asfgit merged pull request #81: Update Jenkinsfile

2019-12-20 Thread GitBox
asfgit merged pull request #81: Update Jenkinsfile URL: https://github.com/apache/brooklyn-client/pull/81 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [brooklyn-client] asfgit merged pull request #81: Update Jenkinsfile

2019-12-20 Thread GitBox
asfgit merged pull request #81: Update Jenkinsfile URL: https://github.com/apache/brooklyn-client/pull/81 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [brooklyn-server] asfgit merged pull request #1080: add check for missing endpoint

2019-12-20 Thread GitBox
asfgit merged pull request #1080: add check for missing endpoint URL: https://github.com/apache/brooklyn-server/pull/1080 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [brooklyn-server] asfgit merged pull request #1080: add check for missing endpoint

2019-12-20 Thread GitBox
asfgit merged pull request #1080: add check for missing endpoint URL: https://github.com/apache/brooklyn-server/pull/1080 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

<    4   5   6   7   8   9   10   11   12   13   >