Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r46664936
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2537,28 +2563,53 @@ protected
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r46675443
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1608,7 +1606,35 @@ protected
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1086
Fix: winrm and jclouds to private-VMs, and miscelaneous
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1086#issuecomment-161750080
Thanks @bostko - merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1085#issuecomment-162660854
@m4rkmckenna I've submitted a PR against your branch to add a test:
https://github.com/m4rkmckenna/incubator-brooklyn/pull/2
---
If your project is set
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1085#issuecomment-161744052
I'm looking at how we test this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/#issuecomment-165240744
Thanks @neykov - looks straightforward; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1018#issuecomment-165244406
@rdowner @neykov See
https://github.com/apache/incubator-brooklyn/pull/1112, which gives an
alternative implemention. I believe that replaces this PR, so
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1085#issuecomment-164840430
@m4rkmckenna I'm reviewing and testing this out now, and am adding a couple
more unit tests. Will create a PR against your branch shortly.
---
If your
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1113#discussion_r47854311
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java ---
@@ -217,6 +217,10 @@ public ConfigInheritance
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1110#issuecomment-165446246
@ahgittin thanks. Interesting we weren't getting any
`ConcurrentModificationException`s that I noticed. Instead we just had some
subset of the 100
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1110
Fix concurrent use of entity.setAttribute()
Previously we were using a vanilla LinkedHashMap for storing attributes
(ever since
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1082#issuecomment-165156285
@neykov @ahgittin I've done various updates (including getting this working
for `JcloudsWinRmMachineLocation`) and fixed some live tests. Can you take
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1018#issuecomment-165162790
@neykov @rdowner I'm having a look at this - looking at neykov's suggestion.
---
If your project is set up for it, you can reply to this email and have
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1120#discussion_r48551193
--- Diff:
brooklyn-server/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/DslAndRebindYamlTest.java
---
@@ -83,15 +95,14
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1120#issuecomment-169709323
Thanks @googlielmo - merging now (and will check about tabs versus spaces
after that).
---
If your project is set up for it, you can reply to this email
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1120#issuecomment-167899413
See suggested additional tests, and alterations to tests, in
https://github.com/googlielmo/incubator-brooklyn/pull/2
---
If your project is set up
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1101#discussion_r48200161
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupCustomizer.java
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1117
Fix cassandra on aws
And some other minor improvements as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166862353
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1106#issuecomment-165434559
Build failure unrelated: `Build timed out (after 40 minutes). Marking the
build as aborted.` while checking out git repo.
---
If your project is set up
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1109#discussion_r47893741
--- Diff:
core/src/main/java/org/apache/brooklyn/core/entity/EntityFunctions.java ---
@@ -154,7 +154,23 @@ protected
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1104#discussion_r47897382
--- Diff:
usage/launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynLauncher.java
---
@@ -710,32 +719,42 @@ private void
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1093#issuecomment-165434986
@alasdairhodge any progress on including that test and getting it to pass?
Ping me if you want to discuss or pair.
---
If your project is set up
GitHub user aledsage reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1112
support for external config in BrooklynProperties
An alternative implementation to
https://github.com/apache/incubator-brooklyn/pull/1018 (i.e. replaces that PR).
You can merge
Github user aledsage closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1104#issuecomment-165434366
@sjcorbett Looks good - one very minor comment about an improvement to a
log message. Good to merge.
---
If your project is set up for it, you can reply
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1106#issuecomment-165434748
Looks good; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1134#issuecomment-170010680
Looks sensible; merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1130#issuecomment-170855532
Thanks @iyovcheva - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/189
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/177#discussion_r66324459
--- Diff:
core/src/main/java/org/apache/brooklyn/core/location/access/PublicNetworkFaceEnricher.java
---
@@ -0,0 +1,373
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/191
Thanks @nakomis - merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/177#discussion_r66329854
--- Diff:
core/src/main/java/org/apache/brooklyn/core/network/OnPublicNetworkEnricher.java
---
@@ -0,0 +1,496 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/177#discussion_r66331540
--- Diff:
core/src/main/java/org/apache/brooklyn/core/network/OnPublicNetworkEnricher.java
---
@@ -0,0 +1,496 @@
+/*
+ * Licensed
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/192
Adds OnSubnetNetworkEnricher
Some entities publish their endpoint using the public hostname (e.g.
`MySqlNode` publishes `datastore.url` using the sensor `host.name`). If trying
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/191
See https://github.com/brooklyncentral/advanced-networking/pull/99 for an
example usage of this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/190
@bostko @nakomis can you review this please? We now hit the NPE after
merging #185, because some `ParameterType`s of effectors have null parameter
names, it seems!
Merging now
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/186
Rename SimpleShellCommandTest to TestSshCommand
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
rename
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/33
@iyovcheva there's a merge conflict - can you rebase against master please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/173#discussion_r65873101
--- Diff:
core/src/main/java/org/apache/brooklyn/core/entity/internal/EntityConfigMap.java
---
@@ -111,47 +110,107 @@ public EntityConfigMap
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/171
LGTM - I saw this in action when pairing with @duncangrant so will merge
now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/187
Thanks @ahgittin - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/184
#187 is now merged, so closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66145442
--- Diff:
launcher/src/test/java/org/apache/brooklyn/giulauncher/effectors/TestEntityWithEffectors.java
---
@@ -0,0 +1,33
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-ui/pull/29#discussion_r66147228
--- Diff: src/main/webapp/assets/tpl/apps/param.html ---
@@ -34,6 +34,10 @@
<% } %>
+<% } else if (
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66146520
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/EffectorTransformer.java
---
@@ -83,7 +84,8 @@ public static
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66145873
--- Diff:
api/src/main/java/org/apache/brooklyn/api/effector/ParameterType.java ---
@@ -45,4 +47,6 @@
* @return The default value
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66235488
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/BasicParameterType.java ---
@@ -32,6 +32,7 @@
private Class type
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/188
BROOKLYN-293: web-console disables directory listing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/188
Thanks all. Jenkins built successfully, so am merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/184
This non-deterministic test (and hopefully many more!) is fixed by
https://github.com/apache/brooklyn-server/pull/187. Assuming the review + merge
of that goes ok, then I'll close this PR
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/187
BROOKLYN-291: donât override manually-set service.isUp
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server fix
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/150#discussion_r66239158
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessWinRmDriver.java
---
@@ -321,12 +332,21
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/150#discussion_r66239387
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java
---
@@ -49,15 +50,29
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/185
Thanks @bostko - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/29
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/33#discussion_r66071641
--- Diff: qa/src/test/resources/java-web-app-and-db-with-function.yaml ---
@@ -17,18 +17,20 @@
# under the License.
#
name: java
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/33#discussion_r66071993
--- Diff: qa/src/test/resources/java-web-app-and-db-with-function.yaml ---
@@ -17,18 +17,20 @@
# under the License.
#
name: java
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/33#discussion_r66071462
--- Diff: qa/src/test/resources/java-web-app-and-db-with-function.yaml ---
@@ -17,18 +17,20 @@
# under the License.
#
name: java
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/173#discussion_r65891559
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigInheritanceYamlTest.java
---
@@ -300,14 +338,212 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/181#discussion_r65896243
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2617,15 +2616,10 @@ public void run
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/75
BROOKLYN-286: docs for entity-config merging
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-docs entity-config
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/181
LGTM.
Build failure is an unrelated test, which we should mark as "Broken" in a
separate PR.
Happy for Andrew's rename comments to be addressed in a separate PR in t
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/33#discussion_r66078600
--- Diff: software/database/pom.xml ---
@@ -144,11 +144,24 @@
+${jclouds.groupId}.provider
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/33#discussion_r66078817
--- Diff: software/database/pom.xml ---
@@ -144,11 +144,24 @@
+${jclouds.groupId}.provider
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/186
Test failure is unrelated -
`ConfigYamlTest.testDeferredSupplierToAttributeWhenReady`. This is getting
ridiculous! I strongly suspect there is an underlying problem
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/186
`TestSshCommandIntegrationTest.shouldCaptureStdoutAndStderrOfScript ` is a
real failure - that should have been marked as `groups="Integration"`.
---
If your project is set up f
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/186#discussion_r66075624
--- Diff:
test-framework/src/main/java/org/apache/brooklyn/test/framework/TestSshCommandImpl.java
---
@@ -0,0 +1,269 @@
+/*
+ * Licensed
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/33
Thanks @iyovcheva - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/33#discussion_r66077096
--- Diff: qa/src/test/resources/java-web-app-and-db-with-function.yaml ---
@@ -21,12 +21,13 @@ location: localhost
services:
- type
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/33#discussion_r66081409
--- Diff: software/database/pom.xml ---
@@ -144,11 +144,24 @@
+${jclouds.groupId}.provider
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/76
Docs/rename test ssh command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-docs
docs/rename-TestSshCommand
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/33
@iyovcheva I've opened https://github.com/iyovcheva/brooklyn-library/pull/1
for some additional changes to the roles code. Can you take a look and see what
you think please
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/74
@neykov Makes sense, but in truth I'm not sure why
`DslComponent.component(String)` is deprecated. The method `component(String
scope, String id)` is not deprecated
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/192#discussion_r66600767
--- Diff:
core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java
---
@@ -0,0 +1,407 @@
+/*
+ * Licensed
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/180
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/180#discussion_r66537291
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/BrooklynTaskTags.java ---
@@ -190,9 +190,16 @@ protected WrappedStream(String streamType
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/150#discussion_r66581776
--- Diff:
software/winrm/src/main/java/org/apache/brooklyn/util/core/internal/winrm/WinRmTool.java
---
@@ -46,7 +46,7 @@
ConfigKey
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/150#discussion_r66579605
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java
---
@@ -49,15 +50,27
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-server/pull/160#issuecomment-222304714
Merging now (@neykov this PR incorporates the comments I made on #148 - if
you get a chance to review my commit here post-merge, that would be great
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/192#discussion_r66601272
--- Diff:
core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java
---
@@ -0,0 +1,407 @@
+/*
+ * Licensed
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/192
Thanks all - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/37
LGTM. Merging.
When hitting something serious such as a deadlock, I like to include a copy
of the stacktraces in a jira issue (or at least in the comment of the pull
request
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/38
LGTM - merging. Thanks @kiuby88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/146
LGTM, thanks @kiuby88 - merging. I incorrectly marked BROOKLYN-271 as
resolved before this PR (and
https://github.com/apache/brooklyn-library/pull/38) were merged - sorry about
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/34
@tbouron what do you think of @neykov 's comments?
What problem do you hit with the old code, and on what environment(s)?
I believe the old code is trying to support OSX
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/195
Whoever merges this, please look at marking
https://issues.apache.org/jira/browse/BROOKLYN-282 as resolved.
---
If your project is set up for it, you can reply to this email and have your
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/198
Change org.apache.cxf log level to ERROR
The previous change to âSEVEREâ doesnât work, because that is not a
logbook logging level.
In the stdout of Brooklyn, we were
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/200
Move DEFAULT_DISPLAY_NAME from app to entity
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
entity
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/196#discussion_r67018475
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBomScanner.java
---
@@ -268,7 +268,7 @@ private void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/196#discussion_r67017851
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/AbstractYamlTest.java
---
@@ -125,7 +125,7 @@ protected Entity
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/196#discussion_r67019434
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/crypto/SecureKeys.java ---
@@ -78,11 +78,11 @@ public static X509Principal
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/196
Unconvinced of the change in `SecureKeys`. The rest looks really good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/200
Build failure looks like it's caused by infrastructure problems:
```
Modules changed, recalculating dependency graph
Build timed out (after 60 minutes). Marking the build
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/195
@bostko I've created https://github.com/bostko/brooklyn-server/pull/1 -
please review. If you merge it into your branch, then it should automatically
appear in this PR
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/196#discussion_r67138867
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/crypto/SecureKeys.java ---
@@ -78,11 +78,11 @@ public static X509Principal
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/195#discussion_r67142271
--- Diff:
core/src/test/java/org/apache/brooklyn/core/mgmt/internal/TestEntityWithEffectors.java
---
@@ -21,15 +21,77 @@
import
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/195
Unfortunately jenkins is not running PR builds. I ran `mvn clean install`
manually, and it worked. So merging.
---
If your project is set up for it, you can reply to this email and have
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/200#discussion_r67162187
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/EntityNameYamlTest.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed
1 - 100 of 1967 matches
Mail list logo
