GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/297
Add more assertions to SoftwareProcessEntityFeedRebindTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/297
Jenkins build successful - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74462257
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
---
@@ -0,0
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74462321
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
---
@@ -0,0
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74462494
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
---
@@ -0,0
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74462757
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
---
@@ -0,0
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74462950
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
---
@@ -0,0
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74463259
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
---
@@ -0,0
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74463540
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
---
@@ -0,0
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74479809
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
---
@@ -0,0
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74480185
--- Diff:
locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizerTest.java
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74480881
--- Diff:
locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizerTest.java
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/298
Add BrooklynNetworkUtils.portRulesToRanges(Collection)
This contains the first commit of
https://github.com/apache/brooklyn-server/pull/276 and
https://github.com/apache/brooklyn-server
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/292
Thanks @duncangrant - finished reviewing.
For the first commit, @bostko has incorporated those comments. I've created
https://github.com/apache/brooklyn-server/pull/298 to get
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/296
Thanks @neykov - incorporated comments and squashed. Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/291#discussion_r74489795
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java
---
@@ -327,25 +337,74
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/291#discussion_r74491248
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java
---
@@ -384,24 +445,48
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/291#discussion_r74491894
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ObjectsYamlTest.java
---
@@ -275,6 +288,57 @@ public void
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/291
@alasdairhodge looks good. Just one comment that I'm interested in before
this is merged: what is the purpose of calling `TypeCoercions.coerce(fields,
type)`?
---
If your project i
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/281
@grkvlt will you get a chance to look at this again soon?
Hopefully the tests I wrote and pasted into the comment will work for you.
They certainly failed in the right way without
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/280
@grkvlt when will you have a chance to look at this PR again?
I tried writing a test for you (adding it to `ConfigParametersYamlTest`),
but it fails:
```
@Test
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/280
The failing jenkins test looks unrelated -
`LoadBalancingPolicySoakTest.testLoadBalancingQuickTest`. We really need to
deal with that one!
---
If your project is set up for it, you can
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/279#discussion_r74495798
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -49,6 +50,68 @@
import
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/279
@grkvlt you said that you'd "add some more [tests] to illustrate the use of
resolvable entity config in a jclouds location context". Is that something you
plan to do for
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/137
@alasdairhodge can you rebase this please so we can see if all the tests
pass?
I'm still not sure about us calling `deferredSupplier.get()` inside coerce.
I have a couple o
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/125
@neykov if this is still an issue, then I suggest we create a jira for it,
update this PR to include a link to that jira, mark the test as
`@Test(groups={"Broken"})`, an
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/292
@duncangrant there are merge conflicts - can you rebase against master
please? (Jenkins won't run the tests until that conflict is resolved).
---
If your project is set up for it, yo
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74505759
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
---
@@ -0,0
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74505875
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
---
@@ -0,0
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/292
@duncangrant code looks good. A couple of minor parameter renames would
make it clearer. Once merge conflicts are dealt with and jenkins confirms tests
pass, then good to merge (ideally
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/298
Merging this. It was reviewed in #276 and #292 with some additional tidy in
this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/119
@bostko Ah, thanks for explaining the use-case. Could we instead fix that
with an overloaded method:
public Builder credentials(Supplier username,
Supplier password
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/276
I've merged #298 which has your first commit. Can you rebase against master
please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/291
@alasdairhodge we don't have a consistent convention for config key names.
We have three approaches being used:
* dot-separated - normally used as a hierarchy, but sometimes dots
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/301
Test+fix DeferredSuppliers in $brooklyn:object
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
test-and-fix
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/302
BROOKLYN-330: add failing test for dsl in HttpRequestSensor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/301#discussion_r74899592
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java
---
@@ -428,28 +430,44
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/301
Thanks @alasdairhodge - I'm incorporated those comments and also made a
couple more tidy-ups (see commits that change it to use the `TypeResolver`
utility, and that removes the st
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/292
Thanks @duncangrant - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/32
Thanks @m4rkmckenna @tbouron - merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/300
@grkvlt the nine test failures in jenkins look related - e.g.
`org.apache.brooklyn.entity.group.DynamicFabricTest.testDynamicFabricCreatesAndStartsEntityWhenGivenManyLocations`.
---
If
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/300#discussion_r75291309
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/LocationSpecConfiguration.java
---
@@ -0,0 +1,58
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/300#discussion_r75291679
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -84,51 +89,72 @@ public
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/300#discussion_r75291636
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -84,51 +89,72 @@ public
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/300#discussion_r75292142
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -84,51 +89,72 @@ public
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/300#discussion_r75292379
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -145,81 +171,88 @@ public
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/300
No tests have been added/updated - e.g. for the DSL to lookup locations,
and for testing what you're adding to `DynamicFabric`.
---
If your project is set up for it, you can reply to
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/300#discussion_r75293363
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -84,51 +89,72 @@ public
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/300
@grkvlt finished reviewing - a few minor comments; the biggest is about the
failing tests, and lack of new tests to cover the new functionality.
---
If your project is set up for it, you
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/299
The jenkins build failure is unrelated (e.g. `Could not start Jetty server
on port 9,998: Address already in use`).
LGTM; merging.
---
If your project is set up for it, you can
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/100
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/61
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/276#discussion_r75860988
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/NetworkingEffectors.java
---
@@ -0,0 +1,103
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/305
BROOKLYN-338: BrooklynApi fixes for karaf
These arenât enough to fix BROOKLYN-338, but itâs a start:
* Ensures rest-client imports the resteasy marshallers package,
which it
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/276#discussion_r75974892
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/NetworkingEffectors.java
---
@@ -0,0 +1,100
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/276
@bostko looks good to me. I'll merge now. Thanks for the amazingly fast
update to add `@Beta`, even late at night!
What are your thoughts on `openIptables`? It could well be
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/30
jenkins test failure is (presumably) unrelated: `java.io.IOException: No
space left on device`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/30
@m4rkmckenna @sjcorbett can you please review and merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/285#discussion_r76570589
--- Diff:
core/src/main/java/org/apache/brooklyn/core/location/AbstractLocation.java ---
@@ -718,6 +719,35 @@ public boolean removeChild(Location
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/305
Jenkins failure was for `OsTest.testDeleteRecursivelyEmptyDir`, failing for
the 1000 attempts like:
2016-08-23 22:38:29,719 WARN Attempt to create temp dir failed
/tmp/OsTest
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/285
LGTM - a few comments from @neykov that are not yet addressed. Have those
been discussed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/309
LGTM; tests pass locally for me. Merging now.
---
Failure in jenkins looks unrelated (a timeout):
Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/311
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/312#discussion_r76888634
--- Diff: karaf/init/src/main/resources/OSGI-INF/blueprint/blueprint.xml ---
@@ -33,7 +33,7 @@ limitations under the License
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/282
FYI this was discussed on the mail dev@brooklyn.apache.org mailing list
with subject "[PROPOSAL] $brooklyn:attributeWhenReady semantics".
---
If your project is set up for i
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/102#discussion_r76941138
--- Diff: guide/ops/starting-stopping-monitoring.md ---
@@ -3,81 +3,119 @@ title: Starting, Stopping and Monitoring
layout: website-normal
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/102#discussion_r76941188
--- Diff: guide/ops/starting-stopping-monitoring.md ---
@@ -3,81 +3,119 @@ title: Starting, Stopping and Monitoring
layout: website-normal
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/102#discussion_r76941399
--- Diff: guide/ops/starting-stopping-monitoring.md ---
@@ -3,81 +3,119 @@ title: Starting, Stopping and Monitoring
layout: website-normal
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/102#discussion_r76941471
--- Diff: guide/ops/starting-stopping-monitoring.md ---
@@ -3,81 +3,119 @@ title: Starting, Stopping and Monitoring
layout: website-normal
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/102#discussion_r76942117
--- Diff: guide/ops/troubleshooting/deployment.md ---
@@ -143,3 +152,27 @@ start tasks are completed).
See the [overview](overview.html
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/102#discussion_r76942684
--- Diff: guide/ops/troubleshooting/deployment.md ---
@@ -143,3 +152,27 @@ start tasks are completed).
See the [overview](overview.html
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/102
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/316
Set default minRam to 1gb
Also changes JcloudsLocationâs template building so that if
a config key has a default value then that will be used, if there is
no explicit value (or
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/103
Adds troubleshooting for chrome âwaiting for available socketâ
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/104
Instructions for openstack-mitaka-nova
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-docs openstack-mitaka
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/103
Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/103#discussion_r77082151
--- Diff: guide/ops/troubleshooting/web-console-issues.md ---
@@ -0,0 +1,23 @@
+---
+layout: website-normal
+title: Web Console Issues
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/106
Advise running ntpd on Brooklyn server
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-docs advise-running-ntpd
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/107
Tidy up example brooklyn.properties
* Tell people that the catalog is the recommended way to configure
locations.
* Move AWS out of âGetting Startedâ. The user can add a
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/106
Thanks; incorporated fixes - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/104
Thanks @geomacy - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/105
LGTM; merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/281
@ahgittin @grkvlt @sjcorbett @neykov This all sounds scarily complicated to
describe to users, with the actual behaviour of inheritance for a given
parent/child entity pair being unclear
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/281
@ahgittin (cc @grkvlt @sjcorbett @neykov) am I understanding your
terminology correctly (of `NOT_REINHERITED` vs `NEVER_INHERITED`) that the
former is about "child inheritance&quo
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/281
@grkvlt yes, that should still work: where children of a
VanillaSoftwareProcess do not want to see the parent's config. The config's
value would "not be re-inherited&qu
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/330
TypeCoerce string to byte[]
An alternative impl would have been to treat the given string as base64
encoded. But I don't think that is what people would expect as the default.
Ho
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/341
BROOKLYNâ349: fix DSL resolution in location
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-349
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/279
See https://issues.apache.org/jira/browse/BROOKLYN-349 for a description of
the underlying problem.
Also see https://github.com/apache/brooklyn-server/pull/341 for an
alternative
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/341
See #279 for an alternative fix (though no test - we could copy the test
from here into that PR).
We'll only want one of this PR or #279 to be merged, I think. @grkvlt
@ahg
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/340#discussion_r79983469
--- Diff: api/src/main/java/org/apache/brooklyn/api/objs/Configurable.java
---
@@ -97,5 +97,7 @@
* @see {@link #setConfig(ConfigKey
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/340#discussion_r79984670
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/internal/LazyContainerAndKeyValue.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/340#discussion_r79985449
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigInheritanceYamlTest.java
---
@@ -72,6 +72,7 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/340#discussion_r79985725
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigInheritanceYamlTest.java
---
@@ -326,53 +320,72 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/340#discussion_r79985918
--- Diff:
core/src/main/java/org/apache/brooklyn/core/internal/BrooklynProperties.java ---
@@ -298,15 +298,20 @@ private static void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/340#discussion_r79986232
--- Diff:
core/src/main/java/org/apache/brooklyn/core/internal/BrooklynPropertiesImpl.java
---
@@ -439,24 +442,45 @@ public void putAll(Map vals
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/340#discussion_r79986472
--- Diff:
core/src/main/java/org/apache/brooklyn/core/internal/BrooklynPropertiesImpl.java
---
@@ -439,24 +442,45 @@ public void putAll(Map vals
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/340#discussion_r79987168
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/340#discussion_r79987350
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/340#discussion_r79987656
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/config/ConfigInheritance.java ---
@@ -19,63 +19,198 @@
package
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/340#discussion_r79988149
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the
101 - 200 of 2333 matches
Mail list logo
