Github user sjcorbett closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user sjcorbett reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1104
Brooklyn properties files may be symlinks
The `?00` permissions check is enforced on the link's target rather than
the link itself.
You can merge this pull request into a Git
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1109#issuecomment-164813629
The failed test
(AbstractControllerTest.testUpdateCalledWhenChildHostnameAndPortChanges) passes
for me repeatedly when I run locally. I have opened
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1104#issuecomment-164138585
`Build timed out (after 40 minutes). Marking the build as aborted.`
---
If your project is set up for it, you can reply to this email and have your
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1099#issuecomment-163629680
@johnmccabe Seems to be working:
```
[INFO] There are 1 checkstyle errors.
[ERROR] BrooklynFeatureEnablement.java[21:1] (imports
GitHub user sjcorbett opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1109
Republish request count sensors on poll failure
Entities that use
`org.apache.brooklyn.entity.webapp.WebAppServiceMetrics#REQUEST_COUNT` are
configured to republish the existing
GitHub user sjcorbett opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1125
Update commons-lang3 to 3.3.2
Matches Alien4Cloud version, used by brooklyn-tosca.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169656161
brooklyn-server/rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/AccessSummary.java
I think it would be better to continue using
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166646696
@ahgittin There are a few unreliable tests on Jenkins. See
https://issues.apache.org/jira/browse/BROOKLYN-203,
https://issues.apache.org/jira/browse
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166650192
@johnmccabe I've seen 204 locally once or twice, none of the others.
---
If your project is set up for it, you can reply to this email and have your
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1110#discussion_r47898623
--- Diff:
core/src/main/java/org/apache/brooklyn/core/sensor/AttributeMap.java ---
@@ -59,7 +60,20 @@
* Creates a new AttributeMap
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/188
Looks good to me. The parameter is as described in [Jetty's
documentation](http://download.eclipse.org/jetty/stable-9/apidocs/org/eclipse/jetty/servlet/DefaultServlet.html).
Will wait
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-ui/pull/29#discussion_r66115710
--- Diff: src/main/webapp/assets/tpl/apps/param.html ---
@@ -34,6 +34,10 @@
<% } %>
+<
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66116469
--- Diff:
core/src/test/java/org/apache/brooklyn/core/mgmt/internal/TestEntityWithEffectorsImpl.java
---
@@ -0,0 +1,42
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66116549
--- Diff:
launcher/src/test/java/org/apache/brooklyn/giulauncher/effectors/TestEntityWithEffectorsImpl.java
---
@@ -0,0 +1,43
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66116521
--- Diff:
launcher/src/test/java/org/apache/brooklyn/giulauncher/effectors/TestEntityWithEffectors.java
---
@@ -0,0 +1,33
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66115978
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/BasicParameterType.java ---
@@ -44,6 +45,7 @@ public BasicParameterType(Map
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66116298
--- Diff:
core/src/test/java/org/apache/brooklyn/core/mgmt/internal/TestEntityWithEffectors.java
---
@@ -0,0 +1,34 @@
+/*
+ * Licensed
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66116186
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/BasicParameterType.java ---
@@ -44,6 +45,7 @@ public BasicParameterType(Map
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-server/pull/152#issuecomment-221933548
@grkvlt @neykov Thanks for your comments. This whole approach is flawed
because it doesn't survive rebind. Entity initialisers have been written to
fire once
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/152#discussion_r64778305
--- Diff:
core/src/main/java/org/apache/brooklyn/core/sensor/password/CreatePasswordSensor.java
---
@@ -33,23 +34,21 @@
public
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-library/pull/41
Fix test-app-with-enrichers-slightly-simpler.yaml
For changes in brooklyn-server/70d005c93acaf225e969552ffb8239200266a402
)(https://github.com/apache/brooklyn-server/pull/154).
You can
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-server/pull/159#issuecomment-222118498
@googlielmo the build is currently broken on master. I'm going to disable a
bunch of tests in a separate pull request.
---
If your project is set up
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-server/pull/154#issuecomment-222120490
Oh, I guess it wasn't caught because the test is in `brooklyn-library`. The
split repos make this difficult to track.
---
If your project is set up
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-server/pull/154#issuecomment-222119849
@aledsage This seems to break
`EnrichersSlightlySimplerYamlTest.testWithAppEnricher`:
```
testWithAppEnricher
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/924#issuecomment-221867474
@mogul This PR reached a natural stopping point. I don't think it would
take much more work to get it merged. We'd be happy to answer any questions you
Github user sjcorbett closed the pull request at:
https://github.com/apache/brooklyn-server/pull/152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/209
Test relative entities
Adds an entity for test cases that need to resolve their target from
another entity. For example, to make assertions on the child of a group member.
You can merge
Github user sjcorbett closed the pull request at:
https://github.com/apache/brooklyn-server/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/213
TestSshCommand checks all assertions rather than throwing first
Fixes build by restoring behaviour changed in #212, which broke
`TestSshCommandTest.shouldNotBeUpIfAssertionsFail` because
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/213
Going to merge this since it fixes the build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/212
Repeat ssh tests
`TestSshCommand` test repeatedly runs its command and assertions until
either all the assertions pass or the configured timeout expires. Previously
the class ran
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1125#issuecomment-170559341
@aledsage Thanks for checking this. I've excluded swagger-core's dependency
on commons-lang3. As far as I can tell - manual experimentation with various
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-172512885
@andreaturli Could you resolve the merge conflicts?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1141#issuecomment-172511587
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1153#issuecomment-172512228
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1168#discussion_r50426620
--- Diff:
brooklyn-library/software/webapp/src/main/java/org/apache/brooklyn/entity/proxy/AbstractControllerImpl.java
---
@@ -283,7 +283,7
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1174#discussion_r50962600
--- Diff:
brooklyn-server/core/src/test/java/org/apache/brooklyn/core/config/ConfigKeyConstraintTest.java
---
@@ -297,12 +299,17 @@ public
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/63
Minor miscellaneous additions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-server misc
Alternatively you can
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-server/pull/71#issuecomment-198016697
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/108
New PerUserEntitlementManager keyword: user
`PerUserEntitlementManager` transforms the "user" keyword into an
entitlement to everything but the most privileged actions (
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-docs/pull/43
Describe "user" entitlement group
Documentation for entitlements changes in
https://github.com/apache/brooklyn-server/pull/108.
You can merge this pull request into a Git
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/103#discussion_r58682355
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/JcloudsRebindWithExternalConfigTest.java
---
@@ -0,0 +1,139
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/103#discussion_r58681822
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/JcloudsRebindWithExternalConfigTest.java
---
@@ -0,0 +1,139
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/108#discussion_r59217258
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/entitlement/PerUserEntitlementManager.java
---
@@ -64,7 +64,7 @@ private static
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-docs/pull/45
Fixes handling of undefined values in templates
https://brooklyn.apache.org/learnmore/catalog is currently broken for
entities with config keys without default values (e.g.
[BrooklynNode
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/108#discussion_r59006737
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/entitlement/Entitlements.java
---
@@ -398,15 +420,17 @@ public static void
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-server/pull/108#issuecomment-207375960
@andreaturli Thanks.
@aledsage @ahgittin Any thoughts on terminology?
---
If your project is set up for it, you can reply to this email and have
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/112#discussion_r59355280
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/DynamicCluster.java ---
@@ -148,6 +148,11 @@
ConfigKey FACTORY
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/112#discussion_r59355178
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java ---
@@ -151,12 +151,14 @@ public ZoneFailureDetector apply
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/112#discussion_r59354661
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/DynamicCluster.java ---
@@ -148,6 +148,11 @@
ConfigKey FACTORY
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-server/pull/112#issuecomment-208845961
Thinking about this a bit more closely, you've deprecated a
`ConfigKey<Function<Collection, Entity>>` in favour of a
`ConfigKey`, but the `Rem
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-server/pull/112#issuecomment-208918399
Looks much cleaner. I'm wary that turning `defaultRemovalStrategy` from an
anonymous inner class to a named inner class will be problematic for anyone
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/109#discussion_r59178399
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/ssh/BashCommands.java ---
@@ -235,17 +235,33 @@ public static String
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-server/pull/95#issuecomment-206818451
@ahgittin @neykov Are you ready for this to be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/44#discussion_r59246331
--- Diff: guide/misc/osgi.md ---
@@ -0,0 +1,63 @@
+---
+title: FAQ
+layout: website-normal
+---
+
+# Running Apache Brooklin
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-docs/pull/44#issuecomment-208466458
Looks good. Do you want me to double check any of the instructions in
particular?
---
If your project is set up for it, you can reply to this email and have
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-library/pull/20
Fix KafkaZooKeeper archive directory name format
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-library kafka
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/99
Rest API location transformers use mutable map
LocationConfig contains null values which Guava's ImmutableMap rejects with
a NullPointerException.
This fixes an error observed
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-server/pull/99#issuecomment-205792423
Test failure unrelated. Filed at
https://issues.apache.org/jira/browse/BROOKLYN-247. Trying again.
---
If your project is set up for it, you can reply
GitHub user sjcorbett reopened a pull request:
https://github.com/apache/brooklyn-server/pull/99
Rest API location transformers use mutable map
LocationConfig contains null values which Guava's ImmutableMap rejects with
a NullPointerException.
This fixes an error observed
Github user sjcorbett closed the pull request at:
https://github.com/apache/brooklyn-server/pull/99
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/94#discussion_r58075531
--- Diff:
rest/rest-server-jersey/src/test/java/org/apache/brooklyn/rest/BrooklynRestApiLauncherTest.java
---
@@ -36,17 +36,17
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-server/pull/94#issuecomment-203993162
@neykov Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/114
Feature/runtime files directory
So blueprint writers can replace
```yaml
brooklyn.config:
runtimeTemplates:
/path/to/source1: dest1
/path/to/source2
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-ui/pull/26
Location wizard generates correct spec for Openstack
The wizard previously used `jclouds:openstack` and adding to the catalogue
threw an error with "Transformer for Brooklyn OASIS
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-docs/pull/71
Openstack network documentation
Repeats #67 against 0.9.0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-docs
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/152
Resolve AddSensor and AddEffector config
Resolves useful parameters of implementations of the `AddEffector` and
`AddSensor` entity initializers, meaning that their values can be sourced
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-docs/pull/63
Typos
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-docs fix/location-inline
Alternatively you can review
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-library/pull/37
Avoid deadlock in AbstractGeoDnsServiceImpl
See commit message in 2e1246a for details.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/132#discussion_r62503400
--- Diff:
core/src/main/java/org/apache/brooklyn/location/byon/FixedListMachineProvisioningLocation.java
---
@@ -147,8 +168,21 @@ public void
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/132#discussion_r62503507
--- Diff:
core/src/main/java/org/apache/brooklyn/location/byon/FixedListMachineProvisioningLocation.java
---
@@ -147,8 +168,21 @@ public void
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/132#discussion_r62505309
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsByonLocationResolver.java
---
@@ -61,129 +56,140
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/118
Use minimal management context in AbstractYamlTest
Speeds tests up a lot. Subclasses can enable OSGi by overriding
`disableOsgi`.
Build of `camp-brooklyn` took 2:38 before and 1
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-docs/pull/48
Typos
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-docs fix/location-inline
Alternatively you can review
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-docs/pull/47#issuecomment-212514613
@richardcloudsoft Is this good to be merged or do you want to incorporate
other pull requests first?
---
If your project is set up for it, you can reply
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-docs/pull/47#issuecomment-212514276
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-server/pull/121#issuecomment-212967413
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/122
Test case for resources used by vanilla software processes
@neykov Here's the test case for resources used by
`VanillaSoftwareProcesses`.
@rdowner The blueprint in this pull
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/209
I'll merge this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/97#discussion_r72660313
--- Diff: guide/start/policies.md ---
@@ -355,8 +355,8 @@ Tomcat on the vagrant VMs named "byon1" to "byon4":
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/281
+1 to this, it has caught me out in the past. It potentially breaks
existing blueprints though so should be raised on the mailing list.
The test failures are valid
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/288
@bostko Can you describe why we should change `/logout` from `POST` to
`GET`? For one it means that if I can find a way to inject HTML into the page I
can log every user that loads it out
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-docs/pull/93
@aledsage Looks good. Duncan's comments worth addressing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/209
@neykov Thank you for your comments. I have removed the `testSpec` config
key in favour of children, replaced the use of `Scope` with plain
`DslComponents` and reworked the use of `target
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/288
Test failure unrelated:
SpecParameterUnwrappingTest.testParameterDefaultsUsedInConfig. Will check
locally.
---
If your project is set up for it, you can reply to this email and have
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/288#discussion_r73669172
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/LogoutResource.java
---
@@ -37,32 +37,44 @@
@Context
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/288
Couple of questions / suggestions to answers then should be good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/288#discussion_r73668447
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/LogoutResource.java
---
@@ -37,32 +37,44 @@
@Context
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/57#discussion_r73696688
--- Diff:
software/database/src/main/java/org/apache/brooklyn/entity/database/mysql/MySqlNode.java
---
@@ -89,6 +92,12
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-docs/pull/84
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/224
Fix VanillaJavaApp's stdin and env
The output from the classpath gathering step currently includes Brooklyn's
"Executed ... , result: 0" info, which means that classpaths
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/224
This affects Brooklyn 0.8.0-incubating and 0.9.0 too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/224
I suppose though stupid it's not a fundamental flaw since these nonsense
entries will be ignored.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/299#discussion_r74765479
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1013,10 +1013,22 @@ protected
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/553#discussion_r100091981
--- Diff:
core/src/test/java/org/apache/brooklyn/util/core/json/MultimapSerializerTest.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/553
Thanks @geomacy
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/553#discussion_r100092325
--- Diff:
core/src/test/java/org/apache/brooklyn/util/core/json/MultimapSerializerTest.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/72
Thanks @neykov and @googlielmo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-client/pull/37
Thanks @neykov. The Jenkins error has been lost to time. I've verified that
the build passes locally.
---
If your project is set up for it, you can reply to this email and have your
reply
1 - 100 of 289 matches
Mail list logo
