[GitHub] brooklyn-server pull request #852: Merge initial catalog and persisted catal...

2017-10-12 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/852#discussion_r144297930 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogInitialization.java --- @@ -128,164 +146,255 @@ public void

[GitHub] brooklyn-server pull request #852: Merge initial catalog and persisted catal...

2017-10-12 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/852#discussion_r144315009 --- Diff: launcher/src/test/resources/rebind-test-empty-catalog.bom --- @@ -0,0 +1,25 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] brooklyn-server pull request #852: Merge initial catalog and persisted catal...

2017-10-12 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/852#discussion_r144315802 --- Diff: launcher/src/test/java/org/apache/brooklyn/launcher/AbstractBrooklynLauncherRebindTest.java --- @@ -0,0 +1,183

[GitHub] brooklyn-server pull request #852: Merge initial catalog and persisted catal...

2017-10-12 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/852#discussion_r144296911 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -1808,6 +1808,42 @@ public void addItem

[GitHub] brooklyn-server issue #862: Fix npr when reading streamed bundle

2017-10-13 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/862 retest this please ---

[GitHub] brooklyn-server issue #777: Removes `FIRST` sensors on children

2017-09-07 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/777 @ahgittin NP, I don't contest the why, I'm sure there was a good reason (confirmed by the above explanation) I was just surprised that this wasn't flagged before for downstream project

[GitHub] brooklyn-dist pull request #104: WIP - Improve RPM/DEB packages

2017-09-08 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-dist/pull/104 WIP - Improve RPM/DEB packages The aim of this PR is to: 1. use Karaf launcher 2. improve the package to to handle properly installations and upgrades This is spirit

[GitHub] brooklyn-dist pull request #104: Improve RPM/DEB packages

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/104#discussion_r138617661 --- Diff: karaf/apache-brooklyn/src/main/filtered-resources/etc/brooklyn.cfg --- @@ -0,0 +1,24

[GitHub] brooklyn-dist issue #104: Improve RPM/DEB packages

2017-09-13 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/104 @drigodwin Comment addressed except for the `Depends` package (see my comment above) ---

[GitHub] brooklyn-dist issue #105: Update Brooklyn vagrant

2017-09-13 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/105 retest this please ---

[GitHub] brooklyn-dist pull request #104: Improve RPM/DEB packages

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/104#discussion_r138617340 --- Diff: deb-packaging/deb/control/control --- @@ -19,6 +19,6 @@ Version: [[version]] Section: misc Priority: optional Architecture

[GitHub] brooklyn-server pull request #819: Improve config key descriptions

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/819#discussion_r138585632 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicFabric.java --- @@ -50,13 +51,20 @@ + "for each

[GitHub] brooklyn-server pull request #819: Improve config key descriptions

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/819#discussion_r138584451 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/Attributes.java --- @@ -52,11 +52,15 @@ // TODO these should switch

[GitHub] brooklyn-server pull request #819: Improve config key descriptions

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/819#discussion_r138584470 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/Attributes.java --- @@ -52,11 +52,15 @@ // TODO these should switch

[GitHub] brooklyn-server pull request #819: Improve config key descriptions

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/819#discussion_r138585654 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicFabric.java --- @@ -50,13 +51,20 @@ + "for each

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138633409 --- Diff: guide/start/running.md --- @@ -182,7 +182,7 @@ Apache Brooklyn should now have been installed and be running as a system servic

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138629659 --- Diff: guide/ops/configuration/https.md --- @@ -21,7 +21,7 @@ The passwords above should be changed to your own values. Omit those arguments

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138631937 --- Diff: guide/ops/high-availability/high-availability-supplemental.md --- @@ -12,34 +12,46 @@ and provides an example of how to configure a pair

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138628703 --- Diff: guide/ops/configuration/brooklyn_cfg.md --- @@ -214,7 +204,7 @@ or See [HTTPS Configuration](https.html) for general information

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138631625 --- Diff: guide/ops/high-availability/high-availability-supplemental.md --- @@ -12,34 +12,46 @@ and provides an example of how to configure a pair

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138628440 --- Diff: guide/ops/configuration/brooklyn_cfg.md --- @@ -33,7 +28,7 @@ brooklyn.webconsole.security.user.admin.password=AdminPassw0rd

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138631452 --- Diff: guide/ops/high-availability/high-availability-supplemental.md --- @@ -12,34 +12,46 @@ and provides an example of how to configure a pair

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138632642 --- Diff: guide/ops/security-guidelines.md --- @@ -37,7 +37,7 @@ relevant mount points, disks and directories. For credential storage

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138633481 --- Diff: guide/start/running.md --- @@ -205,19 +205,19 @@ The application should then output its logs to `/var/log/brooklyn/apache-brookly Now

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138629521 --- Diff: guide/ops/configuration/cors.md --- @@ -0,0 +1,45 @@ +--- +title: CORS Configuration +layout: website-normal

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138633454 --- Diff: guide/start/running.md --- @@ -195,7 +195,7 @@ Apache Brooklyn should now have been installed and be running as a system servic $ sudo

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138633009 --- Diff: guide/start/brooklyn.properties --- @@ -17,7 +17,7 @@ # under the License. # # This is Brooklyn's dot-properties file

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

2017-09-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138631341 --- Diff: guide/ops/high-availability/high-availability-supplemental.md --- @@ -12,34 +12,46 @@ and provides an example of how to configure a pair

[GitHub] brooklyn-dist pull request #105: Update Brooklyn vagrant

2017-09-12 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-dist/pull/105 Update Brooklyn vagrant This updates the vagrant configuration to: - use the latest CentOS - use the new RPM package to install Brooklyn. It requires #104 to be merged first

[GitHub] brooklyn-dist pull request #110: Improve verify brooklyn RC script

2017-09-25 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/110#discussion_r140713075 --- Diff: release/verify_brooklyn_rc.sh --- @@ -105,65 +115,74 @@ for ARCHIVE in $(find * -type f ! \( -name '*.asc' -o -name '*.md5' -o -name

[GitHub] brooklyn-docs pull request #212: Add update instructions for RPM/DEB and bin...

2017-09-25 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/212#discussion_r140823147 --- Diff: guide/ops/upgrade.md --- @@ -0,0 +1,356 @@ +--- +title: Upgrade +layout: website-normal +--- + +This guide provides

[GitHub] brooklyn-docs pull request #212: Add update instructions for RPM/DEB and bin...

2017-09-25 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/212#discussion_r140824045 --- Diff: guide/ops/upgrade.md --- @@ -0,0 +1,356 @@ +--- +title: Upgrade +layout: website-normal +--- + +This guide provides

[GitHub] brooklyn-docs pull request #212: Add update instructions for RPM/DEB and bin...

2017-09-25 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/212#discussion_r140823246 --- Diff: guide/ops/upgrade.md --- @@ -0,0 +1,356 @@ +--- +title: Upgrade +layout: website-normal +--- + +This guide provides

[GitHub] brooklyn-docs pull request #212: Add update instructions for RPM/DEB and bin...

2017-09-25 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/212#discussion_r140822950 --- Diff: guide/ops/upgrade.md --- @@ -0,0 +1,356 @@ +--- +title: Upgrade +layout: website-normal +--- + +This guide provides

[GitHub] brooklyn-docs issue #212: Add update instructions for RPM/DEB and bin distri...

2017-09-25 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-docs/pull/212 @aledsage Comments addressed ---

[GitHub] brooklyn-dist issue #110: Improve verify brooklyn RC script

2017-09-28 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/110 retest this please ---

[GitHub] brooklyn-server issue #821: REST API for accessing adjuncts (including highl...

2017-09-28 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/821 BTW, I just realised that there is no tests coverage for the new endpoints `Entity Adjuncts` and `Entity Adjuncts Config`. Can you add that please @ahgittin ? ---

[GitHub] brooklyn-server issue #834: Modular catalog.bom

2017-09-26 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/834 Indeed, just rebased on latest master @ahgittin ---

[GitHub] brooklyn-server pull request #829: [WIP] BROOKLYN-535: restarter policy when...

2017-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/829#discussion_r141829990 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ServiceRestarter.java --- @@ -133,6 +135,10 @@ protected synchronized void

[GitHub] brooklyn-server pull request #829: [WIP] BROOKLYN-535: restarter policy when...

2017-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/829#discussion_r141826617 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ServiceRestarter.java --- @@ -133,6 +135,10 @@ protected synchronized void

[GitHub] brooklyn-dist pull request #111: Fix vagrant installation folder when downlo...

2017-10-02 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-dist/pull/111 Fix vagrant installation folder when downloading dist version The name of the tar.gz archive is different for the dist version (i.e. `apache-brooklyn--bin`) and therefore, the name

[GitHub] brooklyn-library pull request #132: Update package for chef bean due to the ...

2017-10-02 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-library/pull/132 Update package for chef bean due to the move to brooklyn-library This fixes a little mistake I let in when I reviewed #129 You can merge this pull request into a Git repository by running

[GitHub] brooklyn-docs pull request #218: Add link to download the br CLI

2017-10-02 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-docs/pull/218 Add link to download the br CLI You can merge this pull request into a Git repository by running: $ git pull https://github.com/tbouron/brooklyn-docs patch-3 Alternatively you can

[GitHub] brooklyn-server issue #846: Delete unneeded catalog code

2017-10-02 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/846 LGTM. Tested by launching Brooklyn in both karaf and classic mode: couldn't see any issue in the logs ---

[GitHub] brooklyn-server pull request #849: Retrieve the right AWS metadata for priva...

2017-10-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/849#discussion_r142135330 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -2957,7 +2957,7 @@ String

[GitHub] brooklyn-server pull request #849: Retrieve the right AWS metadata for priva...

2017-10-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/849#discussion_r142150833 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -2957,7 +2957,7 @@ String

[GitHub] brooklyn-server pull request #849: Retrieve the right AWS metadata for priva...

2017-10-02 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-server/pull/849 Retrieve the right AWS metadata for private hostname In most conditions for AWS deployments (machine sshable) Brooklyn was retrieving the `public-hostname` [metadata](http

[GitHub] brooklyn-server pull request #849: Retrieve the right AWS metadata for priva...

2017-10-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/849#discussion_r142158986 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -2957,7 +2957,7 @@ String

[GitHub] brooklyn-server pull request #849: Retrieve the right AWS metadata for priva...

2017-10-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/849#discussion_r142170104 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -2957,7 +2957,7 @@ String

[GitHub] brooklyn-library pull request #133: Update config keys' deprecated names

2017-10-02 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-library/pull/133 Update config keys' deprecated names Since Brooklyn 0.12.0 ([this PR](https://github.com/apache/brooklyn-server/pull/819) precisely) some config keys' name have been deprecated generated

[GitHub] brooklyn-docs pull request #219: Update config keys' deprecated names

2017-10-02 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-docs/pull/219 Update config keys' deprecated names Since Brooklyn 0.12.0 ([this PR](https://github.com/apache/brooklyn-server/pull/819) precisely) some config keys' name have been deprecated generated

[GitHub] brooklyn-server pull request #851: Update config keys' deprecated names

2017-10-02 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-server/pull/851 Update config keys' deprecated names Since Brooklyn 0.12.0 ([this PR](https://github.com/apache/brooklyn-server/pull/819) precisely) some config keys' name have been deprecated generated

[GitHub] brooklyn-server pull request #849: Retrieve the right AWS metadata for priva...

2017-10-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/849#discussion_r142173795 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -2829,16 +2829,11 @@ protected String

[GitHub] brooklyn-server issue #821: REST API for accessing adjuncts (including highl...

2017-09-28 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/821 Cool, thanks @ahgittin. I'm reviewing it right now. ---

[GitHub] brooklyn-server issue #826: Move chef from brooklyn-software-base to own mod...

2017-09-28 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/826 Looks like something is wrong on Jenkins @aledsage ``` org.apache.brooklyn.camp.brooklyn.VanillaSoftwareProcessYamlTest.testAlternativeServiceUpPolling() Build timed out (after

[GitHub] brooklyn-server issue #821: REST API for accessing adjuncts (including highl...

2017-09-28 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/821 @ahgittin The description says `This is then just one commit (currently) which:` but there is still 1000+ additions. Is this up to date and rebase on master? ---

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141604573 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/AdjunctResource.java --- @@ -0,0 +1,264 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141595976 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java --- @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141590904 --- Diff: core/src/main/java/org/apache/brooklyn/core/policy/Policies.java --- @@ -81,11 +85,27 @@ public void setEntity(EntityLocal entity

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141604725 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/AdjunctResource.java --- @@ -0,0 +1,264 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141604605 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/AdjunctResource.java --- @@ -0,0 +1,264 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141604635 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/AdjunctResource.java --- @@ -0,0 +1,264 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141596041 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java --- @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141594992 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java --- @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141602792 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogLocationSummary.java --- @@ -26,6 +26,8 @@ import

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141602780 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogItemSummary.java --- @@ -36,6 +36,8 @@ * see also, subclasses

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141588659 --- Diff: api/src/main/java/org/apache/brooklyn/api/sensor/Feed.java --- @@ -43,7 +43,7 @@ /** * True if everything has

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141605849 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/CatalogTransformer.java --- @@ -71,6 +71,8 @@ import

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141595948 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java --- @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141589379 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/EntityInternal.java --- @@ -189,7 +189,7 @@ void remove(AttributeSensor

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141602725 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogEnricherSummary.java --- @@ -27,6 +27,8 @@ import

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141601297 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/PolicyApi.java --- @@ -36,6 +36,8 @@ @Api("Entity Policies")

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141602815 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogPolicySummary.java --- @@ -27,6 +27,8 @@ import

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141590729 --- Diff: core/src/main/java/org/apache/brooklyn/core/policy/Policies.java --- @@ -81,11 +85,27 @@ public void setEntity(EntityLocal entity

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141607044 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/util/BrooklynRestResourceUtils.java --- @@ -130,6 +143,36 @@ public Policy

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141604648 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/AdjunctResource.java --- @@ -0,0 +1,264 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141602765 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogEntitySummary.java --- @@ -27,6 +27,8 @@ import

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-09-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r141602412 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/AdjunctSummary.java --- @@ -0,0 +1,150 @@ +/* + * Licensed

[GitHub] brooklyn-server issue #821: REST API for accessing adjuncts (including highl...

2017-10-03 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/821 @ahgittin Sorry, I did miss your comment. I was suggesting type to be consistent with the `DELETE` method. I guess `adjunctType` is fine for now (`superType` is really confusing for me

[GitHub] brooklyn-server issue #849: Retrieve the right AWS metadata for private host...

2017-10-03 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/849 @andreaturli Looks like it works as expected :) https://user-images.githubusercontent.com/2082759/31118084-71611280-a82c-11e7-9862-dabf86a0cfbb.png;> ---

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-10-03 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r142349155 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java --- @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server issue #851: Update config keys' deprecated names

2017-10-03 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/851 retest this please ---

[GitHub] brooklyn-library pull request #123: Convert AnsibleEntity and SaltEntity to ...

2017-08-29 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-library/pull/123 Convert AnsibleEntity and SaltEntity to be real SoftwareProcess # Background Salt and Ansible are currently installed by Brooklyn and: - are used in masterless mode - use

[GitHub] brooklyn-library pull request #126: Highlights and load

2017-10-04 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/126#discussion_r142680824 --- Diff: software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/mongodb/sharding/MongoDBRouterClusterImpl.java --- @@ -56,12 +60,17

[GitHub] brooklyn-library pull request #126: Highlights and load

2017-10-04 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/126#discussion_r142681857 --- Diff: software/webapp/src/main/java/org/apache/brooklyn/entity/proxy/nginx/NginxControllerImpl.java --- @@ -178,6 +178,7 @@ protected void

[GitHub] brooklyn-library pull request #126: Highlights and load

2017-10-04 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/126#discussion_r142681908 --- Diff: software/webapp/src/main/java/org/apache/brooklyn/entity/proxy/AbstractNonProvisionedControllerImpl.java --- @@ -216,6 +218,7

[GitHub] brooklyn-server pull request #857: Deprecate `@Catalog` annotation

2017-10-09 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/857#discussion_r143427971 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -671,6 +671,8 @@ private void

[GitHub] brooklyn-server pull request #864: Separate dumper class

2017-10-18 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/864#discussion_r145357727 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/Entities.java --- @@ -302,305 +292,190 @@ public static boolean isTrivial(Object v

[GitHub] brooklyn-server pull request #864: Separate dumper class

2017-10-18 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/864#discussion_r145348481 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/Entities.java --- @@ -302,305 +292,190 @@ public static boolean isTrivial(Object v

[GitHub] brooklyn-server pull request #864: Separate dumper class

2017-10-18 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/864#discussion_r145347765 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/Dumper.java --- @@ -0,0 +1,379 @@ +/* + * Licensed to the Apache Software

[GitHub] brooklyn-server pull request #864: Separate dumper class

2017-10-18 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/864#discussion_r145348576 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/Entities.java --- @@ -302,305 +292,190 @@ public static boolean isTrivial(Object v

[GitHub] brooklyn-server pull request #864: Separate dumper class

2017-10-18 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/864#discussion_r145348526 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/Entities.java --- @@ -302,305 +292,190 @@ public static boolean isTrivial(Object v

[GitHub] brooklyn-docs pull request #231: document the new ElectPrimaryPolicy and rel...

2017-11-10 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/231#discussion_r150210273 --- Diff: guide/blueprints/_elect-primary-policies.md --- @@ -0,0 +1,146 @@ + +There are a collection of policies, enrichers, and effectors

[GitHub] brooklyn-library pull request #134: Add Apache ActiveMQ Artemis catalog item

2017-11-10 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/134#discussion_r150188836 --- Diff: software/messaging/src/main/resources/catalog.bom --- @@ -25,6 +25,56 @@ brooklyn.catalog: type

[GitHub] brooklyn-library pull request #134: Add Apache ActiveMQ Artemis catalog item

2017-11-10 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/134#discussion_r150189303 --- Diff: software/messaging/src/main/resources/catalog.bom --- @@ -25,6 +25,56 @@ brooklyn.catalog: type

[GitHub] brooklyn-docs pull request #228: add docs on upgrades esp new blueprint bund...

2017-11-10 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/228#discussion_r150210136 --- Diff: guide/ops/upgrades/index.md --- @@ -0,0 +1,22 @@ +--- +title: Upgrades +--- --- End diff -- Front-matter

[GitHub] brooklyn-server issue #830: Add support for kubernetes helm

2017-11-22 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/830 @andreaturli Might be completely off-base here but wouldn't it make more sense for this to be in the clocker project ---

[GitHub] brooklyn-server issue #750: Adds a policy to create locations from an entity

2017-11-22 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/750 @grkvlt Did you had the time to looks at @aledsage's comments for this PR? ---

[GitHub] brooklyn-server issue #856: [WIP] clean up startup logging around catalog

2017-11-22 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/856 @ahgittin Do you think you can look at the comments above? ---

[GitHub] brooklyn-docs pull request #238: Specify EBS boot volume size

2017-11-17 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/238#discussion_r151662096 --- Diff: guide/locations/_AWS.md --- @@ -42,6 +42,21 @@ Below are examples of configuration options that use values specific to AWS EC2

<    1   2   3   4   5   6   7   >