[GitHub] brooklyn-ui issue #54: Update Brooklyn codebase to build the newly donated U...

2018-07-27 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/54 retest this please ---

[GitHub] brooklyn-dist issue #124: Update Brooklyn codebase to build the newly donate...

2018-07-27 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/124 retest this please ---

[GitHub] brooklyn issue #17: switch order of build, so server before ui

2018-07-27 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn/pull/17 LGTM, thanks @ahgittin ---

[GitHub] brooklyn-docs pull request #264: Update website to match the new Brooklyn UI

2018-07-27 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-docs/pull/264 Update website to match the new Brooklyn UI This updates the web console screenshot with the new UI You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] brooklyn-ui pull request #55: Add .m2 folder in the list of ignore folders f...

2018-07-27 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/55 Add .m2 folder in the list of ignore folders for the RAT plugin As `brooklyn-ui` doesn't use `brooklyn-parent`, we need to add the local maven cache for the Jenkins build You can merge

[GitHub] brooklyn pull request #18: Add required dependencies for the new Brooklyn UI

2018-07-27 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn/pull/18 Add required dependencies for the new Brooklyn UI The new Brooklyn UI requires few other dependency to build able to build within a docker container (see https://github.com/apache/brooklyn-ui

[GitHub] brooklyn-library pull request #156: Update Brooklyn codebase to build the ne...

2018-07-26 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-library/pull/156 Update Brooklyn codebase to build the newly donated UI See discussion about the donated UI: https://lists.apache.org/thread.html/20d82876f7e84244c2c4d3464a1531a10af50ca3d20e9e1de97a5faf

[GitHub] brooklyn-ui pull request #54: Update Brooklyn codebase to build the newly do...

2018-07-26 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/54 Update Brooklyn codebase to build the newly donated UI Replace old UI by the new one. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] brooklyn-docs pull request #263: Update docs to match the new Brooklyn UI

2018-07-26 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-docs/pull/263 Update docs to match the new Brooklyn UI This is the required changes to match the newly donated Brooklyn UI (see https://lists.apache.org/thread.html

[GitHub] brooklyn-server pull request #974: Update Brooklyn codebase to build the new...

2018-07-26 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-server/pull/974 Update Brooklyn codebase to build the newly donated UI See discussion about the donated UI: https://lists.apache.org/thread.html/20d82876f7e84244c2c4d3464a1531a10af50ca3d20e9e1de97a5faf

[GitHub] brooklyn-server issue #974: Update Brooklyn codebase to build the newly dona...

2018-07-26 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/974 @ahgittin I voluntarily didn't touch the `BrooklynLauncher` as the "classic launcher" only has been deprecated in `0.12.0`. I think remove it should be part of another PR.

[GitHub] brooklyn-docs issue #263: Update docs to match the new Brooklyn UI

2018-07-26 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-docs/pull/263 @ahgittin Added back the web console issues page + updated the IDE setup ---

[GitHub] brooklyn-docs issue #263: Update docs to match the new Brooklyn UI

2018-07-26 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-docs/pull/263 > Fabulously thorough job. Thanks! > I think guide/ops/troubleshooting/web-console-issues.md is still relevant, so we shouldn't delete that page, should we? (Also, if

[GitHub] brooklyn-ui pull request #63: Fix bug with the DSL editor/viewer

2018-08-20 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/63 Fix bug with the DSL editor/viewer This fixes 2 bugs: 1. When adding a DSL for an entity spec, The DSL editor "Done" button was not redirecting to the spec editor. Th

[GitHub] brooklyn-ui pull request #63: Fix bug with the DSL editor/viewer

2018-08-20 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/63#discussion_r211312453 --- Diff: ui-modules/blueprint-composer/app/components/dsl-viewer/dsl-viewer.js --- @@ -51,7 +51,16 @@ export function dslViewerDirective

[GitHub] brooklyn-ui pull request #66: recognize memberSpec anywhere, and refresh blu...

2018-08-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/66#discussion_r213275020 --- Diff: ui-modules/blueprint-composer/app/components/util/model/entity.model.js --- @@ -19,9 +19,10 @@ import {Issue} from './issue.model

[GitHub] brooklyn-ui pull request #66: recognize memberSpec anywhere, and refresh blu...

2018-08-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/66#discussion_r213274760 --- Diff: ui-modules/blueprint-composer/app/components/util/model/entity.model.js --- @@ -115,6 +116,8 @@ export class Entity

[GitHub] brooklyn-ui pull request #66: recognize memberSpec anywhere, and refresh blu...

2018-08-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/66#discussion_r213275122 --- Diff: ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js --- @@ -302,13 +302,11 @@ function BlueprintService($log

[GitHub] brooklyn-ui pull request #66: recognize memberSpec anywhere, and refresh blu...

2018-08-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/66#discussion_r213224460 --- Diff: ui-modules/blueprint-composer/app/components/util/model/entity.model.js --- @@ -19,9 +19,10 @@ import {Issue} from './issue.model

[GitHub] brooklyn-ui pull request #66: recognize memberSpec anywhere, and refresh blu...

2018-08-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/66#discussion_r213224067 --- Diff: ui-modules/blueprint-composer/app/views/main/yaml/yaml.state.js --- @@ -46,6 +46,7 @@ function yamlStateController($scope, $rootScope

[GitHub] brooklyn-ui pull request #66: recognize memberSpec anywhere, and refresh blu...

2018-08-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/66#discussion_r213224315 --- Diff: ui-modules/blueprint-composer/app/components/util/model/entity.model.js --- @@ -115,6 +116,8 @@ export class Entity

[GitHub] brooklyn-ui pull request #66: recognize memberSpec anywhere, and refresh blu...

2018-08-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/66#discussion_r213224816 --- Diff: ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js --- @@ -302,13 +302,11 @@ function BlueprintService($log

[GitHub] brooklyn-ui pull request #66: recognize memberSpec anywhere, and refresh blu...

2018-08-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/66#discussion_r213274160 --- Diff: ui-modules/blueprint-composer/app/views/main/yaml/yaml.state.js --- @@ -46,6 +46,7 @@ function yamlStateController($scope, $rootScope

[GitHub] brooklyn-dist pull request #120: Fix build issue due the the addition of k8s...

2018-07-20 Thread tbouron
Github user tbouron closed the pull request at: https://github.com/apache/brooklyn-dist/pull/120 ---

[GitHub] brooklyn-dist issue #123: New license procedure

2018-07-17 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/123 @ahgittin LGTM, although it's very hard to do a throughout review with that amount of changes. I would like to have a second pair of eyes on this to verify it but I would be happy to merge. ---

[GitHub] brooklyn-dist issue #123: New license procedure

2018-07-17 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/123 One question though @ahgittin, is it expected that `NOTICE` and `LICENSE` file are now in a YAML format? ---

[GitHub] brooklyn-ui pull request #53: Add local .m2 cache to list of exclusion for R...

2018-07-23 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/53 Add local .m2 cache to list of exclusion for RAT plugin This is to fix the build on apache Jenkins: https://builds.apache.org/job/brooklyn-ui-master-docker/ You can merge this pull request

[GitHub] brooklyn-docs pull request #266: Clean up docs

2018-08-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/266#discussion_r213967673 --- Diff: guide/blueprints/example_yaml/vanilla-bash-netcat-w-client.yaml --- @@ -66,7 +66,7 @@ services: name: sayHiNetcat

[GitHub] brooklyn-docs pull request #266: Clean up docs

2018-08-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/266#discussion_r213939941 --- Diff: guide/blueprints/example_yaml/vanilla-bash-netcat-w-client.yaml --- @@ -66,7 +66,7 @@ services: name: sayHiNetcat

[GitHub] brooklyn-server issue #939: BROOKLYN-576: decrease amount of debug logging

2018-01-23 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/939 LGTM, thanks @aledsage. Merging ---

[GitHub] brooklyn-library pull request #148: Fix issue with JBoss 7 installation

2018-03-08 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-library/pull/148 Fix issue with JBoss 7 installation The `jboss-modules.jar` that comes with jBoss 7.1.1 is of version `1.1.1.GA`. However, this has issue on initialisation when one launches the server

[GitHub] brooklyn-library pull request #150: Deprecate JBoss 6 entity

2018-03-09 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-library/pull/150 Deprecate JBoss 6 entity Same reason with #149, but this version is even older You can merge this pull request into a Git repository by running: $ git pull https://github.com/tbouron

[GitHub] brooklyn-library pull request #149: Deprecate JBoss 7 entity

2018-03-09 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-library/pull/149 Deprecate JBoss 7 entity As the title, this deprecates JBoss 7, mainly because it is EOF. See discussion here: https://lists.apache.org/thread.html

[GitHub] brooklyn-dist issue #119: fix dependencies for brooklyn-all

2018-04-11 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/119 Tested with https://github.com/apache/brooklyn-server/pull/830 and work as advertised, thanks @andreaturli ---

[GitHub] brooklyn-server issue #830: Add support for kubernetes helm

2018-04-11 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/830 Just tested, works like a charm, thanks @andreaturli ! Just need to make Jenkins happy again and I'll merge it 👍 ---

[GitHub] brooklyn-server issue #830: Add support for kubernetes helm

2018-04-11 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/830 retest this please ---

[GitHub] brooklyn-dist pull request #120: Fix build issue due the the addition of k8s...

2018-04-13 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-dist/pull/120 Fix build issue due the the addition of k8s helm This was missing from #116 (and https://github.com/apache/brooklyn-server/pull/830) You can merge this pull request into a Git repository

[GitHub] brooklyn-server pull request #955: Fix build issue due the the addition of k...

2018-04-13 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-server/pull/955 Fix build issue due the the addition of k8s helm This was missing from #830 You can merge this pull request into a Git repository by running: $ git pull https://github.com/tbouron

[GitHub] brooklyn-docs issue #251: Add ApacheCon logo button to landing page

2018-04-17 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-docs/pull/251 Cool, I'll merge yours ---

[GitHub] brooklyn-docs issue #251: Add ApacheCon logo button to landing page

2018-04-17 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-docs/pull/251 @geomacy LGTM. While this is very nice, I took the liberty to play a bit with it and ended up with this: ![screencapture-127-0-0-1-4000-2018-04-17-16_44_32](https://user

[GitHub] brooklyn-docs pull request #252: Update event notice styling

2018-04-17 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-docs/pull/252 Update event notice styling This builds on top of #251 ![screencapture-127-0-0-1-4000-2018-04-17-16_44_32](https://user-images.githubusercontent.com/2082759/38882250-90a4af92-4261

[GitHub] brooklyn-server issue #955: Fix build issue due the the addition of k8s helm

2018-04-16 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/955 This has been merged (and reverted) so closing manually ---

[GitHub] brooklyn-server pull request #955: Fix build issue due the the addition of k...

2018-04-16 Thread tbouron
Github user tbouron closed the pull request at: https://github.com/apache/brooklyn-server/pull/955 ---

[GitHub] brooklyn-library issue #149: Deprecate JBoss 7 entity

2018-03-26 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-library/pull/149 @geomacy Done! ---

[GitHub] brooklyn-library issue #150: Deprecate JBoss 6 entity

2018-03-26 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-library/pull/150 @geomacy Done! ---

[GitHub] brooklyn-docs pull request #246: Add page with information about GSoC 2018

2018-02-27 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/246#discussion_r171078463 --- Diff: community/gsoc.md --- @@ -0,0 +1,60 @@ +--- +layout: website-normal +title: Google Summer of Code

[GitHub] brooklyn-docs pull request #246: Add page with information about GSoC 2018

2018-02-27 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/246#discussion_r171078075 --- Diff: community/gsoc.md --- @@ -0,0 +1,60 @@ +--- +layout: website-normal +title: Google Summer of Code

[GitHub] brooklyn-ui issue #84: New layout for the blueprint composer

2018-10-23 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/84 @ahgittin Are you talking about the action palette (as in where the items are displayed) or the toolbar on the left to switch between palette sections? The former actually takes all

[GitHub] brooklyn-ui issue #88: Allow to resolve different virtual type according to ...

2018-10-23 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/88 I'm not following your suggestion @ahgittin, could you develop on that please? ---

[GitHub] brooklyn-ui issue #90: DSL editor: allow ref to entity anywhere

2018-10-24 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/90 retest this please (as been aborted because build time > 40min. I tweaked the config to allow for more time) ---

[GitHub] brooklyn-ui pull request #91: Add callback for customising catalog save conf...

2018-10-24 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/91#discussion_r227809083 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -54,11 +57,17 @@ export function

[GitHub] brooklyn-ui pull request #91: Add callback for customising catalog save conf...

2018-10-24 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/91#discussion_r227807161 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -54,11 +57,17 @@ export function

[GitHub] brooklyn-ui issue #84: New layout for the blueprint composer

2018-10-23 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/84 @ahgittin This PR does change the behaviour for the `catalog-selector`, it was already doing this before my change. Agree it's not optimal but it get really complicated to check for the actual

[GitHub] brooklyn-ui pull request #92: Expand relationship support to memberspecs

2018-10-24 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/92 Expand relationship support to memberspecs As the title say, this expand the relationship support to memberspecs, i.e. if a memberspec has a DSL pointing to any other entity, it will now

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229348023 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -110,6 +110,38 @@ export function

[GitHub] brooklyn-ui pull request #91: Add callback for customising catalog save conf...

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/91#discussion_r229303730 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -54,11 +57,17 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229348593 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -30,15 +47,43 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229350690 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -30,15 +47,43 @@ export function

[GitHub] brooklyn-ui pull request #93: new layout (separable palette) tidies

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/93#discussion_r229345048 --- Diff: ui-modules/blueprint-composer/app/views/main/graphical/edit/add/add.js --- @@ -27,17 +27,18 @@ export const graphicalEditAddState

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229351508 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -230,16 +248,85 @@ function controller

[GitHub] brooklyn-ui pull request #93: new layout (separable palette) tidies

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/93#discussion_r229344894 --- Diff: ui-modules/blueprint-composer/app/views/main/graphical/edit/add/add.js --- @@ -51,8 +52,11 @@ export function GraphicalEditAddController

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229345898 --- Diff: ui-modules/blueprint-composer/app/components/providers/recently-used-service.provider.js --- @@ -0,0 +1,62 @@ +/* + * Licensed

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229351261 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -127,15 +135,15 @@ function controller

[GitHub] brooklyn-ui issue #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/94 Ah makes sense, you want the height therefore the template must be compiled. `$scope.$applyAsync` is executing at the beginning of a digest cycle therefore this info is not available

[GitHub] brooklyn-ui issue #93: new layout (separable palette) tidies

2018-10-30 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/93 Thanks @ahgittin, merging ---

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229267319 --- Diff: ui-modules/blueprint-composer/app/components/providers/recently-used-service.provider.js --- @@ -0,0 +1,62 @@ +/* + * Licensed

[GitHub] brooklyn-dist issue #128: Fix additional surefire configurations

2018-11-04 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/128 LGTM, thanks @kemitix ---

[GitHub] brooklyn-dist pull request #129: Update docker instructions to mount the doc...

2018-11-04 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-dist/pull/129 Update docker instructions to mount the docker socket This is because #118 now build docker, therefore the container needs to be able to access the docker engine on the host You can merge

[GitHub] brooklyn pull request #24: Update docker instructions to mount the docker so...

2018-11-04 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn/pull/24 Update docker instructions to mount the docker socket This is because https://github.com/apache/brooklyn-dist/pull/118 now build docker, therefore the container needs to be able to access

[GitHub] brooklyn-dist issue #118: add docker image generation

2018-11-04 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/118 Tested this again and it works like a charm. The plugin (https://github.com/spotify/docker-maven-plugin) come with all the flag necessary to disable the build and push directly the image we

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230342561 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -247,11 +266,23 @@ function controller

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230340611 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -88,23 +89,42 @@ export function

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230340735 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -88,23 +89,42 @@ export function

[GitHub] brooklyn-server issue #1012: Fix for SUREFIRE-1588

2018-11-02 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/1012 LGTM @kemitix and Jenkins is happy, thanks 👍 ---

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230348970 --- Diff: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html --- @@ -341,7 +341,9 @@ No matching configuration

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230340646 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -88,23 +89,42 @@ export function

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230342731 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.template.html --- @@ -157,6 +157,7 @@ {{freeFormTile

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230349133 --- Diff: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html --- @@ -398,10 +403,13 @@ No policies mat

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230349155 --- Diff: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html --- @@ -431,7 +439,13 @@ No enrichers

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230340893 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -88,23 +89,42 @@ export function

[GitHub] brooklyn-dist issue #127: Fix for SUREFIRE-1588

2018-11-02 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/127 Same as the others, fixes up the build. Thanks @kemitix 👍 ---

[GitHub] brooklyn-ui issue #89: spec editor hook

2018-10-29 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/89 LGTM, thanks @frogfather ---

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228903921 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -30,15 +47,43 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228903041 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector-palette-footer.html --- @@ -0,0 +1,60

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228905867 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -230,16 +248,85 @@ function controller

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228904969 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -65,58 +110,21 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228904564 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -30,15 +47,43 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228909725 --- Diff: ui-modules/blueprint-composer/package.json --- @@ -60,7 +60,8 @@ "lodash": "^4.16.4", &q

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228903327 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector-palette-footer.html --- @@ -0,0 +1,60

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228903437 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector-palette-footer.html --- @@ -0,0 +1,60

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228905287 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -127,15 +135,15 @@ function controller

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228905899 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -230,16 +248,85 @@ function controller

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228905790 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -230,16 +248,85 @@ function controller

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228904299 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -30,15 +47,43 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228908739 --- Diff: ui-modules/blueprint-composer/app/components/providers/recently-used-service.provider.js --- @@ -0,0 +1,62 @@ +/* + * Licensed

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228903286 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector-palette-footer.html --- @@ -0,0 +1,60

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228903493 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector-palette-footer.html --- @@ -0,0 +1,60

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228907223 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.template.html --- @@ -30,44 +30,83

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228905605 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -230,16 +248,85 @@ function controller

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228908909 --- Diff: ui-modules/blueprint-composer/app/components/providers/recently-used-service.provider.js --- @@ -0,0 +1,62 @@ +/* + * Licensed

<    1   2   3   4   5   6   7   >