Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/949
@andreaturli looks good. I've left two minor comments that needn't stop
this being merged if you wish.
---
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/949#discussion_r170685601
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/DefaultConnectivityResolver.java
---
@@ -212,8 +217,10 @@ public
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/949#discussion_r170685134
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/DefaultConnectivityResolver.java
---
@@ -181,24 +183,27 @@ public
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/951
Support iteration of hashes in templates
DotSplittingTemplateModel implements `TemplateHashModelEx2` (rather than
just `TemplateHashModel`), meaning config/sensor map key/vals can
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/949#discussion_r169928209
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/DefaultConnectivityResolver.java
---
@@ -342,7 +343,12 @@ void
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/949#discussion_r169910351
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/DefaultConnectivityResolver.java
---
@@ -342,7 +343,12 @@ void
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/942
Fix wording of sensor description
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-server sensor-typo
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/936
The default behaviour of the `getTypesAnnotatedWith` method in reflections
was flipped in 0.9.10 to include unannotated classes that implement annotated
interfaces. This meant
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/936
Update Reflections dependency
0.9.9-RC1 is unable to read classes containing lambda functions. This meant
that `brooklyn list-objects` did not output all classes. Refer to
ronmamo
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/925
Fix reporting of master ID when web API used before persistence is ready
ServerResource#getHighAvailabilityPlaneStates obtains a new plane sync
record when the master node ID
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/916#discussion_r158319056
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java ---
@@ -799,6 +795,14 @@ protected Entity replaceMember
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-docs/pull/242
Describe authentication options for catalog libraries
Reworks the catalogue schema documentation to make it easier to read and
adds a note on how to provide credentials for libraries
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-docs/pull/241
@drigodwin would you mind checking this?
---
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-docs/pull/241
Quote included file name
Without the quotes `npm run book` fails cryptically: "template names must
be a string: NaN"
You can merge this pull request into a Git repository
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/918
Blueprints can include username and password for catalog libraries
For example:
```yaml
brooklyn.catalog:
id: simple-example
version: "1.0"
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/916#discussion_r156409964
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java ---
@@ -799,6 +795,12 @@ protected Entity replaceMember
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/916
DynamicCluster's max size applies to all calls to grow
Previously the limit was ignored by resizeByDelta.
You can merge this pull request into a Git repository by running:
$ git
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/783
cc @ahgittin since you deprecated the methods in
https://github.com/apache/brooklyn-server/commit/1e615f55c71f23dfc8f65d8ddd2bb79254fce71a
and
https://github.com/apache/brooklyn-server
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-client/pull/59
Move Resteasy dependency management to java module pom
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-client java
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/783
Restore HTTP annotations to deprecated API methods
The missing annotations mean that brooklyn-client is unable to proxy the
affected classes (since Resteasy expects to work with every
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-dist/pull/102
Fix build warnings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-dist build-warning
Alternatively you can review
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-client/pull/58
Fix handling of global flags in scope definition
Previously the presence of global flags in a command like `br --flag app a
ent b sensor c` caused the CLI to run the command for app
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-client/pull/57
Add flags for verbose output of HTTP request data
Adds global new flags `--verbose` and `--vverbose` (very verbose) configure
the network library to write data about API requests
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-client/pull/56
Set ContentType header when adding .yaml and .bom files to the catalog
Using application/x-yaml saves the Brooklyn server the hassle of guessing.
At the moment it's too smart for its own
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
Thanks @geomacy. Will merge this. Printing usage when someone writes `br
--skipSslChecks` or `br --json` can be a future improvement.
---
If your project is set up for it, you can reply
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
`requiresLogin` should check that the command isn't `help`. It also needs
to handle invocations of the program that set global options but don't give a
command. I think that of the options
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-ui/pull/47
Fix app wizard configuration load
The endpoint used was changed to require a version. Assume latest.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
Alternatively open a separate pull request for the `logout` command. It's
tangential to the rest of the PR, which is ready to merge.
---
If your project is set up for it, you can reply
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@geomacy I was right on the cusp of merging this when I realised that
logging out means you can't view help text:
```
$ br version
0.12.0-SNAPSHOT
$ br
NAME:
br
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/760
Add DigitalOcean2 and ProfitBricks features to Karaf build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-server
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/696
Looks good, thanks @aledsage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/694
See my comment on
https://github.com/apache/brooklyn-server/pull/651#discussion_r114961921 for
why these failures are likelier to occur with a short timeout.
---
If your project is set
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/677
Those projects are both licensed to Cloudsoft so are perhaps not the best
examples but my question stands: should we encourage cloud-specific features in
core Brooklyn?
---
If your
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/677
Is an AWS-specific feature something we want in Brooklyn or should it be
provided in a self-contained repository? There's some precedent for the latter.
- https://github.com/cloudsoft
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-docs/pull/178
@drigodwin @rdowner thanks. I've addressed all your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-docs/pull/178
@rdowner I think this is something you were looking at previously.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-docs/pull/178
Guide to template files
A full guide to using template files in blueprints.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/651#discussion_r114961921
--- Diff:
locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/DefaultConnectivityResolverTest.java
---
@@ -147,10 +149,9
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/668
Minor CatalogResource and ApplicationResource fixes
CatalogResource closes ZipFiles cleanly and ApplicationResource checks the
invoke-effector permission before invoking the start
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/164#discussion_r114841357
--- Diff: guide/ops/catalog/index.md ---
@@ -371,6 +372,155 @@ increment an internal version number for the catalog
item.
When referencing
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/164#discussion_r114839724
--- Diff: guide/ops/catalog/index.md ---
@@ -371,6 +372,155 @@ increment an internal version number for the catalog
item.
When referencing
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/164#discussion_r114828307
--- Diff: guide/ops/catalog/index.md ---
@@ -371,6 +372,155 @@ increment an internal version number for the catalog
item.
When referencing
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-docs/pull/164
@nakomis can you rebase this on master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
On the current master:
```
$ ./target/bin/br login http://ldsn3e
Get http://ldsn3e/v1/server/version: dial tcp: lookup ldsn3e on
66.28.0.45:53: no such host
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/616
There's not a good parallel in the downstream project at the moment. It
only has the config bag to use, not a location. I think I'll just take a copy
of the previous version of the class
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/616
@aledsage Why should `BlobStoreContextFactory` be regarded as an internal
interface? It's already being used in a downstream project that this PR has
broken. Should the project use
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-docs/pull/161
Documentation on greaterThan and lessThan test assertions
Accompanies https://github.com/apache/brooklyn-server/pull/619.
You can merge this pull request into a Git repository by running
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-client/pull/42#discussion_r109663969
--- Diff: cli/commands/login.go ---
@@ -84,7 +100,8 @@ func (cmd *Login) Run(scope scope.Scope, c *cli.Context
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/602
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/607
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/610
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-dist/pull/88
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/594
@ahgittin In the test's current form it sounds like the qa project is
sensible. Alternatively you could rephrase it to drop the use of Redis. It was
coincidental that I found the problem
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/592
The Jenkins failure was due to the environment:
```
Java HotSpot(TM) 64-Bit Server VM warning: INFO:
os::commit_memory(0xd000, 536870912, 0) failed; error='Cannot
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/592
Fix publication of EC2 host address in DefaultConnectivityResolver
Publish Attributes.ADDRESS before guessing the EC2 hostname.
Fixes the case where host.address was set to the FQDN
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/590
Use boolean Options correctly in ItemLister
Replaces list-objects' `--catalog-only` and `--ignore-impls` arguments with
`--all-classes` and `--include-impls` respectively
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/573
Regarding `RedisClusterIntegrationTest`, it specifically only failed when
run through the http server. The same blueprint passed when tested with
`AbstractYamlTest`.
---
If your project
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/374
I've run into the issues discussed above. Was either issue filed? Is
Brooklyn able to persist to SoftLayer's object store?
---
If your project is set up for it, you can reply
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
@bostko thanks for the update. I've confirmed that the browser requires
re-authentication in both cases.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/578
I'll leave this while brooklyn-ui#36 is still open.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
@bostko Looks like this negatively impacts logging out of the non-Karaf
distribution. After logging out I've found that:
* master non-karaf: prompts for re-authentication.
* master
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/578
@bostko looks good. Will test and merge if ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
@bostko looks good. Will test and merge if ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/580
Looks good. `WinRmMachineLocationLiveTest` passed for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sjcorbett closed the pull request at:
https://github.com/apache/brooklyn-server/pull/318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/572
@geomacy @neykov could you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/572
wip: debug ReachableSocketFinderTest.getReachableSockets
Don't merge.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/91#discussion_r102723143
--- Diff: examples/webapps/hello-world-sql/src/main/webapp/redis.jsp ---
@@ -0,0 +1,80 @@
+<%@ page import="java.util.List" %&g
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/91
@justinThompson looks good thanks. I've left a couple of minor comments.
Will test the feature out before merging.
---
If your project is set up for it, you can reply to this email
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/91#discussion_r102722987
--- Diff: examples/webapps/hello-world-sql/src/main/webapp/redis.jsp ---
@@ -0,0 +1,80 @@
+<%@ page import="java.util.List" %&g
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-library/pull/93
Rename jboss_logo.png jboss-logo.png.
Fixes various references to the file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/529#discussion_r101334570
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BasicLocationNetworkInfoCustomizer.java
---
@@ -0,0 +1,472
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/529#discussion_r101047658
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -625,6 +630,30 @@ public
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/553#discussion_r100092325
--- Diff:
core/src/test/java/org/apache/brooklyn/util/core/json/MultimapSerializerTest.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/553#discussion_r100091981
--- Diff:
core/src/test/java/org/apache/brooklyn/util/core/json/MultimapSerializerTest.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/553
Thanks @geomacy
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/553
MultimapSerializer works with non-String keys
MultimapSerializer works with non-String keys
You can merge this pull request into a Git repository by running:
$ git pull https
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-client/pull/37
Thanks @neykov. The Jenkins error has been lost to time. I've verified that
the build passes locally.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/72
Thanks @neykov and @googlielmo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-docs/pull/146
Thanks @neykov, looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/541
Thanks @aledsage, looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/88
@neykov could you rebase master once #87 is merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/88
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/520
@neykov looks good. I'm going to merge this. Could I ask you to add a
couple of lines describing the new feature to the section on latches in the
docs (https://brooklyn.apache.org/v
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/497
@neykov I've updated again. Took a little reworking due to the uncertainty
introduced about when the executor was allowed to shut down. Resorted to having
each call to `tryReachable` use
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/529#discussion_r97610554
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2607,24 +2522,32 @@ public boolean
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/529#discussion_r97603990
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -625,6 +630,30 @@ public
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/497#discussion_r97567977
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/net/ReachableSocketFinder.java
---
@@ -69,86 +65,113 @@ public
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/497#discussion_r97568128
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/net/ReachableSocketFinder.java
---
@@ -69,86 +65,113 @@ public
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/497#discussion_r97561966
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/net/ReachableSocketFinder.java
---
@@ -69,86 +65,113 @@ public
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/505
Looks good; will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/505#discussion_r97524799
--- Diff:
core/src/main/java/org/apache/brooklyn/core/internal/BrooklynProperties.java ---
@@ -181,6 +181,7 @@ public static Builder
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
@bostko could you revisit Alex and Svet's comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/505
@aledsage could you rebase on master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/520#discussion_r97337170
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java
---
@@ -444,15
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/527
Looks good. Would be nice to be able to make an assertion on the effect of
the effector, but perhaps that's one for another time.
---
If your project is set up for it, you can reply
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/532
Looks good to me. Anything more to come @neykov?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/520#discussion_r97049449
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessDriverLifecycleEffectorTasks.java
---
@@ -169,7
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/87
You need to update `ChefLifecycleEffectorTasks`, `ChefPostgreSqlLifecycle`
and
`org.apache.brooklyn.entity.software.base.test.mysql.DynamicToyMySqlEntityBuilder.MySqlEntityInitializer
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/520
Jenkins is failing on `SoftwareProcessEntityLatchTest.testConcurrency` and
`testReleaseableLatchBlocks`
By the way, can we get rid of `maxConcurrentChildCommands` when
1 - 100 of 289 matches
Mail list logo
