Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/520#discussion_r97049449
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessDriverLifecycleEffectorTasks.java
---
@@ -169,7 +173,7 @@ protected String startProcessesAtMachine(final
Supplier<MachineLocation> machine
}
@Override
- protected void postStartCustom() {
+ protected void postStartCustom(AtomicReference<ReleaseableLatch>
startLatchRef) {
--- End diff --
We could force subclasses to error at compile time by leaving the removed
methods in place and making them `final`. I'd prefer that to silently ignoring
the method. Your suggestion of continuing to call the deprecated method seems
like the least bad approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
