[GitHub] brooklyn-ui pull request #112: DSL editor: support referencing `brooklyn.par...

2018-11-23 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/112#discussion_r235930249 --- Diff: ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js --- @@ -512,6 +514,16 @@ function BlueprintService($log

[GitHub] brooklyn-ui pull request #113: Fix template overrides - decorate `script` di...

2018-11-23 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/113#discussion_r235922436 --- Diff: ui-modules/utils/script-tag-non-overwrite/script-tag-non-overwrite.js --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software

[GitHub] brooklyn-ui pull request #113: Fix template overrides - decorate `script` di...

2018-11-23 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/113#discussion_r235904114 --- Diff: ui-modules/utils/script-tag-non-overwrite/script-tag-non-overwrite.js --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software

[GitHub] brooklyn-ui pull request #113: Fix template overrides - decorate `script` di...

2018-11-23 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/113#discussion_r235903512 --- Diff: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js --- @@ -79,7 +82,7 @@ export function specEditorDirective

[GitHub] brooklyn-ui pull request #112: DSL editor: support referencing `brooklyn.par...

2018-11-21 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/112#discussion_r235510831 --- Diff: ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js --- @@ -512,6 +514,16 @@ function BlueprintService($log

[GitHub] brooklyn-ui issue #99: make palette icons have a light border not a shadow

2018-11-21 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/99 Sounds good. Thank you @ahgittin, I'm happy with that Merging now ---

[GitHub] brooklyn-ui issue #99: make palette icons have a light border not a shadow

2018-11-20 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/99 You are right, elevation doesn't necessarily means draggable. What I meant is that MD is based on our physical world, for instance: - the canvas is a sheet of paper - the side panel

[GitHub] brooklyn-ui issue #99: make palette icons have a light border not a shadow

2018-11-20 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/99 @ahgittin Ah I didn't realise you were talking about the rectangles! I get your point and it is valid. Or rather it was valid until https://github.com/apache/brooklyn-ui/pull/96. Items

[GitHub] brooklyn-ui issue #109: catalog saver to support 'application', 'template', ...

2018-11-20 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/109 @aledsage Are you happy to address your comment in a subsequent PR? I'm ok to merge this one but would like to check with you first. ---

[GitHub] brooklyn-ui issue #109: catalog saver to support 'application', 'template', ...

2018-11-20 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/109 @ahgittin I'm wondering if the tooltip texts should include the item type, the same way you describe them in your previous comment. I think it's a good compromise so users have a reference

[GitHub] brooklyn-ui pull request #109: catalog saver to support 'application', 'temp...

2018-11-20 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/109#discussion_r234939255 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -42,14 +42,15 @@ const TYPES

[GitHub] brooklyn-ui issue #110: add UI support for {required,forbidden}UnlessAnyOf, ...

2018-11-20 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/110 Ah cool, thanks @ahgittin. Merging now ---

[GitHub] brooklyn-ui pull request #109: catalog saver to support 'application', 'temp...

2018-11-20 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/109#discussion_r234928083 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -42,14 +42,15 @@ const TYPES

[GitHub] brooklyn-ui pull request #109: catalog saver to support 'application', 'temp...

2018-11-20 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/109#discussion_r234928669 --- Diff: ui-modules/blueprint-composer/app/views/main/main.controller.js --- @@ -105,16 +105,31 @@ export function MainController($scope, $element

[GitHub] brooklyn-ui issue #110: add UI support for {required,forbidden}UnlessAnyOf, ...

2018-11-20 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/110 LGTM, thanks @ahgittin 👍 One question though, do we have support on the server for `{required,forbidden}UnlessAnyOf`? I didn't see those before? Could you point me to this code? ---

[GitHub] brooklyn-dist issue #130: Update dockerfile-maven-plugin to 1.4.3 to fix bui...

2018-11-20 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/130 Tested, LGTM. Thanks @geomacy ---

[GitHub] brooklyn-client issue #72: Switch to dep for br dependency management

2018-11-20 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-client/pull/72 Tested, works great! Thanks @geomacy it is much cleaner that way :) ---

[GitHub] brooklyn-dist issue #118: add docker image generation

2018-11-18 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/118 Hi @geomacy. Indeed, the plugin updated to the latest version when I retested it which worked. Should we bump the version? ---

[GitHub] brooklyn-dist issue #118: add docker image generation

2018-11-18 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/118 Aaaah just saw your PR @geomacy, never mind then :) ---

[GitHub] brooklyn-ui pull request #108: improve logic and ui for inferring bundle and...

2018-11-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/108#discussion_r232966239 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.modal.template.html --- @@ -57,19 +60,17 @@ {{getTitle

[GitHub] brooklyn-ui pull request #108: improve logic and ui for inferring bundle and...

2018-11-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/108#discussion_r232965561 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -223,3 +228,7 @@ function templateCache

[GitHub] brooklyn-ui pull request #108: improve logic and ui for inferring bundle and...

2018-11-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/108#discussion_r232966244 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.modal.template.html --- @@ -57,19 +60,17 @@ {{getTitle

[GitHub] brooklyn-ui issue #99: make palette icons have a light border not a shadow

2018-11-09 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/99 The box shadow is there to indicate a notion of hierarchy. The side panels come on top of the canvas, not beside it, i.e. they don't push the canvas to left or right. Material design says

[GitHub] brooklyn-ui pull request #106: Update save to catalog action

2018-11-09 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/106#discussion_r232251461 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -64,8 +64,44 @@ export function

[GitHub] brooklyn-ui pull request #106: Update save to catalog action

2018-11-09 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/106#discussion_r232209479 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -64,8 +64,44 @@ export function

[GitHub] brooklyn-ui pull request #106: Update save to catalog action

2018-11-09 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/106#discussion_r232208108 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -60,12 +60,47 @@ export function

[GitHub] brooklyn-ui pull request #106: Update save to catalog action

2018-11-09 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/106#discussion_r232211854 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -64,8 +64,44 @@ export function

[GitHub] brooklyn-ui pull request #106: Update save to catalog action

2018-11-09 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/106#discussion_r232209888 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -64,8 +64,44 @@ export function

[GitHub] brooklyn-ui pull request #97: Generalise usage of $templateCache for bluepri...

2018-11-07 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/97 Generalise usage of $templateCache for blueprint composer This updated all directives within the blueprint composer to use `$templateCache` service for their templates. It allows downstream

[GitHub] brooklyn-ui issue #96: Relevance and other composer tweaks

2018-11-06 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/96 LGTM. There are couple of thing I want to change but I'll do this in a separate PR shortly. Merging this in the meantime ---

[GitHub] brooklyn pull request #24: Update docker instructions to mount the docker so...

2018-11-04 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn/pull/24 Update docker instructions to mount the docker socket This is because https://github.com/apache/brooklyn-dist/pull/118 now build docker, therefore the container needs to be able to access

[GitHub] brooklyn-dist pull request #129: Update docker instructions to mount the doc...

2018-11-04 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-dist/pull/129 Update docker instructions to mount the docker socket This is because #118 now build docker, therefore the container needs to be able to access the docker engine on the host You can merge

[GitHub] brooklyn-dist issue #118: add docker image generation

2018-11-04 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/118 Tested this again and it works like a charm. The plugin (https://github.com/spotify/docker-maven-plugin) come with all the flag necessary to disable the build and push directly the image we

[GitHub] brooklyn-dist issue #128: Fix additional surefire configurations

2018-11-04 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/128 LGTM, thanks @kemitix ---

[GitHub] brooklyn-dist issue #127: Fix for SUREFIRE-1588

2018-11-02 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/127 Same as the others, fixes up the build. Thanks @kemitix 👍 ---

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230342561 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -247,11 +266,23 @@ function controller

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230340611 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -88,23 +89,42 @@ export function

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230340735 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -88,23 +89,42 @@ export function

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230348970 --- Diff: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html --- @@ -341,7 +341,9 @@ No matching configuration

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230340646 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -88,23 +89,42 @@ export function

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230342731 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.template.html --- @@ -157,6 +157,7 @@ {{freeFormTile

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230349133 --- Diff: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html --- @@ -398,10 +403,13 @@ No policies mat

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230349155 --- Diff: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html --- @@ -431,7 +439,13 @@ No enrichers

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks

2018-11-02 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/96#discussion_r230340893 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -88,23 +89,42 @@ export function

[GitHub] brooklyn-server issue #1012: Fix for SUREFIRE-1588

2018-11-02 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/1012 LGTM @kemitix and Jenkins is happy, thanks 👍 ---

[GitHub] brooklyn-ui issue #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/94 Ah makes sense, you want the height therefore the template must be compiled. `$scope.$applyAsync` is executing at the beginning of a digest cycle therefore this info is not available

[GitHub] brooklyn-ui issue #93: new layout (separable palette) tidies

2018-10-30 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/93 Thanks @ahgittin, merging ---

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229351508 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -230,16 +248,85 @@ function controller

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229351261 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -127,15 +135,15 @@ function controller

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229350690 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -30,15 +47,43 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229348023 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -110,6 +110,38 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229348593 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -30,15 +47,43 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229345898 --- Diff: ui-modules/blueprint-composer/app/components/providers/recently-used-service.provider.js --- @@ -0,0 +1,62 @@ +/* + * Licensed

[GitHub] brooklyn-ui pull request #93: new layout (separable palette) tidies

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/93#discussion_r229345048 --- Diff: ui-modules/blueprint-composer/app/views/main/graphical/edit/add/add.js --- @@ -27,17 +27,18 @@ export const graphicalEditAddState

[GitHub] brooklyn-ui pull request #93: new layout (separable palette) tidies

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/93#discussion_r229344894 --- Diff: ui-modules/blueprint-composer/app/views/main/graphical/edit/add/add.js --- @@ -51,8 +52,11 @@ export function GraphicalEditAddController

[GitHub] brooklyn-ui pull request #91: Add callback for customising catalog save conf...

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/91#discussion_r229303730 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -54,11 +57,17 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229267319 --- Diff: ui-modules/blueprint-composer/app/components/providers/recently-used-service.provider.js --- @@ -0,0 +1,62 @@ +/* + * Licensed

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228908909 --- Diff: ui-modules/blueprint-composer/app/components/providers/recently-used-service.provider.js --- @@ -0,0 +1,62 @@ +/* + * Licensed

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228903493 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector-palette-footer.html --- @@ -0,0 +1,60

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228907223 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.template.html --- @@ -30,44 +30,83

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228905605 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -230,16 +248,85 @@ function controller

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228909725 --- Diff: ui-modules/blueprint-composer/package.json --- @@ -60,7 +60,8 @@ "lodash": "^4.16.4", &q

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228903327 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector-palette-footer.html --- @@ -0,0 +1,60

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228903437 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector-palette-footer.html --- @@ -0,0 +1,60

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228905287 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -127,15 +135,15 @@ function controller

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228905899 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -230,16 +248,85 @@ function controller

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228905790 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -230,16 +248,85 @@ function controller

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228904299 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -30,15 +47,43 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228908739 --- Diff: ui-modules/blueprint-composer/app/components/providers/recently-used-service.provider.js --- @@ -0,0 +1,62 @@ +/* + * Licensed

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228903286 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector-palette-footer.html --- @@ -0,0 +1,60

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228903921 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -30,15 +47,43 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228903041 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector-palette-footer.html --- @@ -0,0 +1,60

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228905867 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -230,16 +248,85 @@ function controller

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228904969 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -65,58 +110,21 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

2018-10-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r228904564 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -30,15 +47,43 @@ export function

[GitHub] brooklyn-ui issue #89: spec editor hook

2018-10-29 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/89 LGTM, thanks @frogfather ---

[GitHub] brooklyn-ui pull request #92: Expand relationship support to memberspecs

2018-10-24 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/92 Expand relationship support to memberspecs As the title say, this expand the relationship support to memberspecs, i.e. if a memberspec has a DSL pointing to any other entity, it will now

[GitHub] brooklyn-ui pull request #91: Add callback for customising catalog save conf...

2018-10-24 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/91#discussion_r227809083 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -54,11 +57,17 @@ export function

[GitHub] brooklyn-ui pull request #91: Add callback for customising catalog save conf...

2018-10-24 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/91#discussion_r227807161 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -54,11 +57,17 @@ export function

[GitHub] brooklyn-ui issue #90: DSL editor: allow ref to entity anywhere

2018-10-24 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/90 retest this please (as been aborted because build time > 40min. I tweaked the config to allow for more time) ---

[GitHub] brooklyn-ui issue #84: New layout for the blueprint composer

2018-10-23 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/84 @ahgittin This PR does change the behaviour for the `catalog-selector`, it was already doing this before my change. Agree it's not optimal but it get really complicated to check for the actual

[GitHub] brooklyn-ui issue #88: Allow to resolve different virtual type according to ...

2018-10-23 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/88 I'm not following your suggestion @ahgittin, could you develop on that please? ---

[GitHub] brooklyn-ui issue #84: New layout for the blueprint composer

2018-10-23 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/84 @ahgittin Are you talking about the action palette (as in where the items are displayed) or the toolbar on the left to switch between palette sections? The former actually takes all

[GitHub] brooklyn-ui pull request #84: New layout for the blueprint composer

2018-10-11 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/84 New layout for the blueprint composer This allows to: - add multiple visualisations, if we wish to. Will be added as tabs - customise palettes. Add/remove sections, they are on the left

[GitHub] brooklyn-ui pull request #83: Fix the remove button within overflow menu for...

2018-10-11 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/83 Fix the remove button within overflow menu for adjuncts Previously, the `Remove` item present within the overflow menu (top right) of the `spec-editor` wasn't removing an adjunct. There was 2

[GitHub] brooklyn-ui pull request #82: Fix image animation for memberspec when there ...

2018-10-10 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/82 Fix image animation for memberspec when there are children to the cluster Previously, there was an issue on the memberspec node's animation when a cluster had more than one child. This fixes

[GitHub] brooklyn-ui issue #74: Support for karaf 4.2.1 and running under JDK 11

2018-10-10 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/74 retest this please ---

[GitHub] brooklyn-ui issue #80: Add binary requirement to README

2018-10-09 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/80 FYI, failure unrelated, there is no space left on the Jenkins box. Merging ---

[GitHub] brooklyn-ui issue #81: Fix firefox multi-lines issue in configuration text-a...

2018-10-09 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/81 Tested on both Firefox and Chrome, works like a charm! Thank you @ludop-usharesoft 👍 I'll merge this now. In the meantime, can you make sure you sign your ICLA? Thanks again! ---

[GitHub] brooklyn-ui issue #80: Add binary requirement to README

2018-10-09 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/80 Good point @kemitix, I'll add that and merge ---

[GitHub] brooklyn-server issue #1007: Fix a bad-formatted title in readme

2018-10-09 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/1007 Thanks @cinlloc, LGTM. I'll merge this now. Can you make sure you sign and submit your ICLA in the meantime? Thanks 👍 ---

[GitHub] brooklyn-ui pull request #80: Add binary requirement to README

2018-10-09 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/80 Add binary requirement to README This was only notified on the `doc/skinning` docs! I'll make this resurface here. We also need this on the Brooklyn docs You can merge this pull

[GitHub] brooklyn-ui pull request #79: Implement missing endpoint for palette API

2018-10-09 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/79 Implement missing endpoint for palette API The palette API was missing crusial endpoints used to load blueprint from the catalog UI module. This also fixes a typo

[GitHub] brooklyn-ui issue #74: Support for karaf 4.2.1 and running under JDK 11

2018-09-26 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/74 LGTM, thanks a lot @kemitix ! Jenkins failed but that is because this requires https://github.com/apache/brooklyn-server/pull/1002 to be merged first. Will trigger another build then ---

[GitHub] brooklyn-ui issue #73: Adding travis config file for an easier build

2018-09-26 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/73 Hi @Numerinico. I just checked the subscriber list and I cannot see you there. But I'm not entirely sure of the email address you used to subscribe so I might be wrong. Could you send en email

[GitHub] brooklyn-library issue #160: jenkins: don't bind mount .m2

2018-09-24 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-library/pull/160 This looks fine @aledsage but I can see 2 issues there: 1. what about the `settings.xml`? In the PR context, we don't care because we don't push artifacts to maven central but as soon

[GitHub] brooklyn-library issue #159: Jenkins docker: use non-root user

2018-09-24 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-library/pull/159 One thing though, could you port the change to the other submodule @aledsage ? ---

[GitHub] brooklyn-library issue #159: Jenkins docker: use non-root user

2018-09-24 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-library/pull/159 LGTM and follow what docs for the maven image: https://hub.docker.com/_/maven/ "Running as non-root" As Jenkins seems happy, I'm happy and I'll merge this. Thanks @aledsage ---

[GitHub] brooklyn-ui pull request #72: More constraints

2018-09-24 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/72#discussion_r219833039 --- Diff: ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js --- @@ -287,8 +297,28 @@ function BlueprintService($log

[GitHub] brooklyn-ui pull request #72: More constraints

2018-09-24 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/72#discussion_r219832729 --- Diff: ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js --- @@ -287,8 +297,28 @@ function BlueprintService($log

  1   2   3   4   5   6   7   >