Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/104#issuecomment-206395613
thanks @johnmccabe, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user johnmccabe commented on the pull request:
https://github.com/apache/brooklyn-server/pull/104#issuecomment-206395204
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user johnmccabe commented on the pull request:
https://github.com/apache/brooklyn-server/pull/104#issuecomment-206395066
@aledsage looks like something messed up my side... it works as expected
now.
Previously I was deleting then pulling the pr into a branch on
Github user johnmccabe commented on the pull request:
https://github.com/apache/brooklyn-server/pull/104#issuecomment-206390410
@aledsage I've deleted my PR branch and am rebuilding again (I'd rebuilt
earlier to sanity check my observations... third time lucky)
---
If your project
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-server/pull/104#issuecomment-206389822
@johnmccabe your example works for me when I build and run brooklyn
locally. I don't have any files not committed or anything like that.
---
If your project
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/104#issuecomment-206376601
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user johnmccabe commented on the pull request:
https://github.com/apache/brooklyn-server/pull/104#issuecomment-206374347
I pulled and built a few minutes ago and tried with this catalog:
```
brooklyn.catalog:
version: 0.1.2
items:
- id: loc-common-base
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-server/pull/104#issuecomment-206365759
Good to review and merge now (assuming jenkins doesn't find any problems).
---
If your project is set up for it, you can reply to this email and have your
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-server/pull/104#issuecomment-206331907
STILL DO NOT MERGE. I've added more test cases, and reverted the change to
`CampResolver`, because that broke things for entities. But the new tests for a
app
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-server/pull/104#issuecomment-206318007
DO NOT MERGE: although this fixes it for the location test case, it breaks
the expected behaviour for locations (see failing jenkins test).
---
If your
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/104
BROOKLYN-248: fix location displayName inheritance
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
11 matches
Mail list logo
