Re: [VOTE] Release Apache brpc(incubating) 0.9.7-rc03

2020-01-20 Thread 牟盖东
+1 binding Gosling Von 于2020年1月21日周二 下午2:33写道: > Hi, > > > Before vote +1, we must make clear that Category B license including in > brpc. I found there is one paragraph said on the website[1]. I would like > to leave my last vote on this issue :-) > > > “ Unless otherwise specified, all

Re: [VOTE] Release Apache brpc(incubating) 0.9.7-rc03

2020-01-20 Thread Gosling Von
Hi, Before vote +1, we must make clear that Category B license including in brpc. I found there is one paragraph said on the website[1]. I would like to leave my last vote on this issue :-) “ Unless otherwise specified, all Category B licensed works should be included in binary-only form in

[GitHub] [incubator-brpc] guangpec1 commented on issue #1035: 在一个服务中使用两个Task Control 是否会有影响?

2020-01-20 Thread GitBox
guangpec1 commented on issue #1035: 在一个服务中使用两个Task Control 是否会有影响? URL: https://github.com/apache/incubator-brpc/issues/1035#issuecomment-576510871 主要将计算的部分拆分出来,主要是业务架构的需要. 比如说既有重调度的任务,又有重计算的任务. 将重计算和调度分开成两个Task Control. 降低互相影响. @cdjingit

[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #1005: ignore ELIMIT for circuit breaker

2020-01-20 Thread GitBox
TousakaRin commented on a change in pull request #1005: ignore ELIMIT for circuit breaker URL: https://github.com/apache/incubator-brpc/pull/1005#discussion_r368798772 ## File path: src/brpc/circuit_breaker.cpp ## @@ -172,6 +175,16 @@ CircuitBreaker::CircuitBreaker() }

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #1005: ignore ELIMIT for circuit breaker

2020-01-20 Thread GitBox
zyearn commented on a change in pull request #1005: ignore ELIMIT for circuit breaker URL: https://github.com/apache/incubator-brpc/pull/1005#discussion_r368795982 ## File path: src/brpc/circuit_breaker.cpp ## @@ -172,6 +175,16 @@ CircuitBreaker::CircuitBreaker() }

[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #1005: ignore ELIMIT for circuit breaker

2020-01-20 Thread GitBox
TousakaRin commented on a change in pull request #1005: ignore ELIMIT for circuit breaker URL: https://github.com/apache/incubator-brpc/pull/1005#discussion_r368795402 ## File path: src/brpc/circuit_breaker.cpp ## @@ -15,10 +15,16 @@ // specific language governing

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #1005: ignore ELIMIT for circuit breaker

2020-01-20 Thread GitBox
jamesge commented on a change in pull request #1005: ignore ELIMIT for circuit breaker URL: https://github.com/apache/incubator-brpc/pull/1005#discussion_r368793073 ## File path: src/brpc/circuit_breaker.cpp ## @@ -15,10 +15,16 @@ // specific language governing

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #1005: ignore ELIMIT for circuit breaker

2020-01-20 Thread GitBox
jamesge commented on a change in pull request #1005: ignore ELIMIT for circuit breaker URL: https://github.com/apache/incubator-brpc/pull/1005#discussion_r368792573 ## File path: src/brpc/circuit_breaker.cpp ## @@ -172,6 +178,16 @@ CircuitBreaker::CircuitBreaker() }

[GitHub] [incubator-brpc] hairet commented on issue #1034: add support for rwlock, a classic approach

2020-01-20 Thread GitBox
hairet commented on issue #1034: add support for rwlock, a classic approach URL: https://github.com/apache/incubator-brpc/pull/1034#issuecomment-576493800 > > Sometime there is some environment problem in travis-ci, i had restarted the travis-ci task of #1031. please check whether it can

[GitHub] [incubator-brpc] cdjingit commented on issue #1035: 在一个服务中使用两个Task Control 是否会有影响?

2020-01-20 Thread GitBox
cdjingit commented on issue #1035: 在一个服务中使用两个Task Control 是否会有影响? URL: https://github.com/apache/incubator-brpc/issues/1035#issuecomment-576491790 > 戈神,我们自己内部实现了,现在测试还没有发现问题,我详细描述一下场景. 建立两个 Task Control 分别是 T1 和 T2. T1 中处理网络请求,然后T1将“算力较大”的部分发给 T2, T1 发给T2的只是function和arg, T2 执行funciton

[GitHub] [incubator-brpc] TousakaRin commented on issue #1003: limit minimum value of max_concurrency for auto_cl

2020-01-20 Thread GitBox
TousakaRin commented on issue #1003: limit minimum value of max_concurrency for auto_cl URL: https://github.com/apache/incubator-brpc/pull/1003#issuecomment-576491535 已经确认所有对_max_concurrency 的直接赋值都替换为函数AdjustMaxConcurrency

[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #1005: ignore ELIMIT for circuit breaker

2020-01-20 Thread GitBox
TousakaRin commented on a change in pull request #1005: ignore ELIMIT for circuit breaker URL: https://github.com/apache/incubator-brpc/pull/1005#discussion_r368785730 ## File path: src/brpc/circuit_breaker.cpp ## @@ -171,6 +206,10 @@ CircuitBreaker::CircuitBreaker() }

[GitHub] [incubator-brpc] guangpec1 edited a comment on issue #1035: 在一个服务中使用两个Task Control 是否会有影响?

2020-01-20 Thread GitBox
guangpec1 edited a comment on issue #1035: 在一个服务中使用两个Task Control 是否会有影响? URL: https://github.com/apache/incubator-brpc/issues/1035#issuecomment-576208924 戈神,我们自己内部实现了,现在测试还没有发现问题,我详细描述一下场景. 建立两个 Task Control 分别是 T1 和 T2. T1 中处理网络请求,然后T1将“算力较大”的部分发给 T2, T1 发给T2的只是function和arg, T2

[GitHub] [incubator-brpc] guangpec1 edited a comment on issue #1035: 在一个服务中使用两个Task Control 是否会有影响?

2020-01-20 Thread GitBox
guangpec1 edited a comment on issue #1035: 在一个服务中使用两个Task Control 是否会有影响? URL: https://github.com/apache/incubator-brpc/issues/1035#issuecomment-576208924 戈神,我们自己内部实现了,现在测试还没有发现问题,我详细描述一下场景. 建立两个 Task Control 分别是 T1 和 T2. T1 中处理网络请求,然后T1将“算力较大”的部分发给 T2, T1 发给T2的只是function和arg, T2

[GitHub] [incubator-brpc] guangpec1 commented on issue #1035: 在一个服务中使用两个Task Control 是否会有影响?

2020-01-20 Thread GitBox
guangpec1 commented on issue #1035: 在一个服务中使用两个Task Control 是否会有影响? URL: https://github.com/apache/incubator-brpc/issues/1035#issuecomment-576208924 戈神,我们自己内部实现了,现在测试还没有发现问题,我详细描述一下场景. 建立两个 Task Control 分别是 T1 和 T2. T1 中处理网络请求,然后T1将“算力较大”的部分发给 T2, T1 发给T2的只是function和arg, T2 执行funciton

[GitHub] [incubator-brpc] xiaosage079 closed pull request #1034: add support for rwlock, a classic approach

2020-01-20 Thread GitBox
xiaosage079 closed pull request #1034: add support for rwlock, a classic approach URL: https://github.com/apache/incubator-brpc/pull/1034 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-brpc] xiaosage079 commented on issue #1034: add support for rwlock, a classic approach

2020-01-20 Thread GitBox
xiaosage079 commented on issue #1034: add support for rwlock, a classic approach URL: https://github.com/apache/incubator-brpc/pull/1034#issuecomment-576181771 > Sometime there is some environment problem in travis-ci, i had restarted the travis-ci task of #1031. please check whether it

[GitHub] [incubator-brpc] jamesge commented on issue #1035: 在一个服务中使用两个Task Control 是否会有影响?

2020-01-20 Thread GitBox
jamesge commented on issue #1035: 在一个服务中使用两个Task Control 是否会有影响? URL: https://github.com/apache/incubator-brpc/issues/1035#issuecomment-576169081 不可行,不要尝试。有一些变量是在pthread-local中的,如果要支持多套TaskControl,那些变量就得组织成数组,很麻烦。 This is an

[GitHub] [incubator-brpc] guangpec1 opened a new issue #1035: 在一个服务中使用两个Task Control 是否会有影响?

2020-01-20 Thread GitBox
guangpec1 opened a new issue #1035: 在一个服务中使用两个Task Control 是否会有影响? URL: https://github.com/apache/incubator-brpc/issues/1035 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** 由于项目需要,服务需要保留原有的Task Control 的基础上,新增加一个Task Control,两个task control 对bthread

[GitHub] [incubator-brpc] zyearn commented on issue #1034: add support for rwlock, a classic approach

2020-01-20 Thread GitBox
zyearn commented on issue #1034: add support for rwlock, a classic approach URL: https://github.com/apache/incubator-brpc/pull/1034#issuecomment-576160507 Sometime there is some environment problem in travis-ci, i had restarted the travis-ci task of #1031. please check whether it can pass