Tuvie commented on issue #2031:
URL:
https://github.com/apache/incubator-brpc/issues/2031#issuecomment-1336313733
> How to improve it? What's the backend mechanism?
As I said, we create QPs at the beginning to reduce the overhead of
ibv_create_qp at runtime. You don't need to care
changchengx commented on issue #2031:
URL:
https://github.com/apache/incubator-brpc/issues/2031#issuecomment-1336312495
@Tuvie
>
> But in order to improve the performance of connection establishment
>
How to improve it? What's the backend mechanism?
--
This is an automated
Tuvie commented on issue #2031:
URL:
https://github.com/apache/incubator-brpc/issues/2031#issuecomment-1336312248
> 1. Is it normal to run two server processes and use one client process to
connect with the two server processes when running rdma_performance with using
RDMA to get the
jiangdongzi commented on issue #2032:
URL:
https://github.com/apache/incubator-brpc/issues/2032#issuecomment-1336312066
> 我觉得合理，但是你可以根据userid做个hash，这样execution_queue的数量就是可调整的了，不用和userid一一对应。
thx
--
This is an automated message from the Apache Git Service.
To respond to the
yanglimingcn commented on issue #2032:
URL:
https://github.com/apache/incubator-brpc/issues/2032#issuecomment-1336302105
我觉得合理，但是你可以根据userid做个hash，这样execution_queue的数量就是可调整的了，不用和userid一一对应。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
jiangdongzi commented on issue #2032:
URL:
https://github.com/apache/incubator-brpc/issues/2032#issuecomment-1336299056
> 严格有序
我们现在有一种需求, 同一userId的请求需要串行执行, 我们又想得到尽可能高的并发, 所以目前的想法是创建大量的ExecutionQueue,
比如1000, 同一userId的请求就哈希到对应的 ExecutionQueue, 这样是合理可行的吧
--
This is an automated
yanglimingcn commented on issue #2032:
URL:
https://github.com/apache/incubator-brpc/issues/2032#issuecomment-1336280419
严格有序
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zhaocc1106 opened a new issue, #2033:
URL: https://github.com/apache/incubator-brpc/issues/2033
**Describe the bug (描述bug)**
thrift模式下，想通过done->Run()调用提前返回给客户端，之后再做一些其他工作，但是看起来不能提前返回，代码如下：
SillyBoyenjoy commented on issue #2025:
URL:
https://github.com/apache/incubator-brpc/issues/2025#issuecomment-1336130225
应该打开了，dyld是ios系统main执行前的动态链接器？我把LINK_SO打开后bt好像详细了点，问题似乎出在class_name.cpp里面？
* thread 1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS
(code=1,
jiangdongzi opened a new issue, #2032:
URL: https://github.com/apache/incubator-brpc/issues/2032
还是A B可能会并发执行
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
yanglimingcn commented on issue #1895:
URL:
https://github.com/apache/incubator-brpc/issues/1895#issuecomment-1335170504
这个啥时候发pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
wwbmmm merged PR #2005:
URL: https://github.com/apache/incubator-brpc/pull/2005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Tuvie commented on PR #2005:
URL: https://github.com/apache/incubator-brpc/pull/2005#issuecomment-1335067131
Has resolved conflict. Any plan to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
changchengx commented on issue #2031:
URL:
https://github.com/apache/incubator-brpc/issues/2031#issuecomment-1334955599
@wwbmmm
1. Is it normal to run two server processes and use one client process to
connect with the two server processes when running rdma_performance with using
RDMA
wwbmmm commented on code in PR #2027:
URL: https://github.com/apache/incubator-brpc/pull/2027#discussion_r1037924057
##
src/brpc/policy/timeout_concurrency_limiter.cpp:
##
@@ -0,0 +1,161 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
wwbmmm commented on code in PR #2027:
URL: https://github.com/apache/incubator-brpc/pull/2027#discussion_r1037923288
##
src/brpc/policy/timeout_concurrency_limiter.cpp:
##
@@ -0,0 +1,161 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
wwbmmm commented on issue #2031:
URL:
https://github.com/apache/incubator-brpc/issues/2031#issuecomment-1334944220
the rdma-old branch is no longer maintained
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wwbmmm commented on issue #2029:
URL:
https://github.com/apache/incubator-brpc/issues/2029#issuecomment-1334939533
你是指istio的xds协议吗？
那个是grpc stream协议，目前还不支持
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wwbmmm commented on code in PR #1975:
URL: https://github.com/apache/incubator-brpc/pull/1975#discussion_r1037882245
##
src/bthread/shared_mutex.h:
##
@@ -0,0 +1,47 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
yanglimingcn commented on code in PR #2027:
URL: https://github.com/apache/incubator-brpc/pull/2027#discussion_r1037875128
##
src/brpc/policy/timeout_concurrency_limiter.cpp:
##
@@ -0,0 +1,161 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
yanglimingcn commented on code in PR #2027:
URL: https://github.com/apache/incubator-brpc/pull/2027#discussion_r1037862874
##
src/brpc/policy/timeout_concurrency_limiter.cpp:
##
@@ -0,0 +1,161 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
wwbmmm commented on code in PR #2027:
URL: https://github.com/apache/incubator-brpc/pull/2027#discussion_r1037833869
##
src/brpc/concurrency_limiter.h:
##
@@ -33,7 +33,7 @@ class ConcurrencyLimiter {
// false when the concurrency reaches the upper limit, otherwise it
wwbmmm commented on code in PR #2027:
URL: https://github.com/apache/incubator-brpc/pull/2027#discussion_r1037832851
##
test/brpc_timeout_concurrency_limiter_unittest.cpp:
##
@@ -0,0 +1,92 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
Review Comment:
wwbmmm commented on code in PR #2027:
URL: https://github.com/apache/incubator-brpc/pull/2027#discussion_r1037831763
##
src/brpc/policy/timeout_concurrency_limiter.cpp:
##
@@ -0,0 +1,161 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
changchengx opened a new issue, #2031:
URL: https://github.com/apache/incubator-brpc/issues/2031
**Describe the bug (描述bug)**
When running rdma_performance built from rdma-old, it reports below errro:
```
example/rdma_performance/client.cpp:155] RPC call failed: [E1008]Reached
zwkno1 commented on issue #2029:
URL:
https://github.com/apache/incubator-brpc/issues/2029#issuecomment-1334792279
brp能不能支持调用xds服务
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
liyichao commented on PR #1975:
URL: https://github.com/apache/incubator-brpc/pull/1975#issuecomment-1334775241
@wwbmmm I have merged master, the workflows need approval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
leaf-potato commented on issue #2025:
URL:
https://github.com/apache/incubator-brpc/issues/2025#issuecomment-1334723850
看着不太像，编译没开debug吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wwbmmm commented on PR #1975:
URL: https://github.com/apache/incubator-brpc/pull/1975#issuecomment-1334680122
> @wwbmmm I have fixed the build, the CI failure seems unrelated to this
patch, please help check it.
@liyichao the master branch has fixed the CI issue, please merge master
wwbmmm merged PR #2030:
URL: https://github.com/apache/incubator-brpc/pull/2030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guodongxiaren commented on PR #1975:
URL: https://github.com/apache/incubator-brpc/pull/1975#issuecomment-1333912138
I have fixed this issue in #2030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
guodongxiaren opened a new pull request, #2030:
URL: https://github.com/apache/incubator-brpc/pull/2030
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance
wwbmmm commented on PR #1975:
URL: https://github.com/apache/incubator-brpc/pull/1975#issuecomment-1333639271
@guodongxiaren Please help to see this CI failure, the error is so strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yanglimingcn commented on code in PR #2027:
URL: https://github.com/apache/incubator-brpc/pull/2027#discussion_r1036974970
##
src/brpc/concurrency_limiter.h:
##
@@ -33,7 +33,7 @@ class ConcurrencyLimiter {
// false when the concurrency reaches the upper limit, otherwise it
yanglimingcn commented on code in PR #2027:
URL: https://github.com/apache/incubator-brpc/pull/2027#discussion_r1036974970
##
src/brpc/concurrency_limiter.h:
##
@@ -33,7 +33,7 @@ class ConcurrencyLimiter {
// false when the concurrency reaches the upper limit, otherwise it
zwkno1 opened a new issue, #2029:
URL: https://github.com/apache/incubator-brpc/issues/2029
support XDS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
liyichao commented on PR #1975:
URL: https://github.com/apache/incubator-brpc/pull/1975#issuecomment-1333155303
@wwbmmm I have fixed the build, the CI failure seems to unrelated to this
patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please
SillyBoyenjoy commented on issue #2025:
URL:
https://github.com/apache/incubator-brpc/issues/2025#issuecomment-1333150885
是mac才会有的问题，以下是lldb的backtrace：
* frame #0: 0x
frame #1: 0x0001ab00f718 libobjc.A.dylib`load_images + 1616
frame #2:
serverglen commented on code in PR #2027:
URL: https://github.com/apache/incubator-brpc/pull/2027#discussion_r1036648918
##
src/brpc/concurrency_limiter.h:
##
@@ -33,7 +33,7 @@ class ConcurrencyLimiter {
// false when the concurrency reaches the upper limit, otherwise it
fansehep commented on PR #1996:
URL: https://github.com/apache/incubator-brpc/pull/1996#issuecomment-1332931959
> Hi, What's the status on it? Could you update the latest code?
In fact, this is ok. I have tried some other methods, but none of them seem
very elegant. So I thinks it
zyearn commented on PR #1996:
URL: https://github.com/apache/incubator-brpc/pull/1996#issuecomment-1332816766
Hi, What's the status on it? Could you update the latest code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lorinlee merged PR #1965:
URL: https://github.com/apache/incubator-brpc/pull/1965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lorinlee merged PR #2019:
URL: https://github.com/apache/incubator-brpc/pull/2019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lorinlee merged PR #2028:
URL: https://github.com/apache/incubator-brpc/pull/2028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lorinlee commented on PR #2024:
URL: https://github.com/apache/incubator-brpc/pull/2024#issuecomment-1332207105
summary的quantile写avg是Prometheus支持的吗，这个有相关文档不，我搜了下只找到了quantile里是百分比数字的，还有_sum和_count
--
This is an automated message from the Apache Git Service.
To respond to the message,
chenBright opened a new pull request, #2028:
URL: https://github.com/apache/incubator-brpc/pull/2028
### What problem does this PR solve?
Issue Number:None
Problem Summary: Found some typos
### What is changed and the side effects?
Changed: Fix typos in
TousakaRin commented on issue #1887:
URL:
https://github.com/apache/incubator-brpc/issues/1887#issuecomment-1331870232
具体什么依赖版本不匹配呢，我觉得大部分时候还是用发行版里给的版本会更好。
常见有问题的是gflag/glog/protobuf，brpc在动态库里引用了静态库是有点容易出问题
--
This is an automated message from the Apache Git Service.
To respond to
372046933 commented on code in PR #2005:
URL: https://github.com/apache/incubator-brpc/pull/2005#discussion_r1035702725
##
src/butil/iobuf.cpp:
##
@@ -1206,7 +1211,14 @@ int IOBuf::appendv(const const_iovec* vec, size_t n) {
return 0;
}
-int
serverglen commented on PR #2024:
URL: https://github.com/apache/incubator-brpc/pull/2024#issuecomment-1331655819
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
yanglimingcn commented on code in PR #2027:
URL: https://github.com/apache/incubator-brpc/pull/2027#discussion_r1035456329
##
src/brpc/concurrency_limiter.h:
##
@@ -33,7 +33,7 @@ class ConcurrencyLimiter {
// false when the concurrency reaches the upper limit, otherwise it
serverglen commented on code in PR #2027:
URL: https://github.com/apache/incubator-brpc/pull/2027#discussion_r1035447279
##
src/brpc/concurrency_limiter.h:
##
@@ -33,7 +33,7 @@ class ConcurrencyLimiter {
// false when the concurrency reaches the upper limit, otherwise it
fusying-hwang commented on issue #1918:
URL:
https://github.com/apache/incubator-brpc/issues/1918#issuecomment-1330910950
one caveat is that they used a bazel defined variable to control if building
with glog or not. I didn't find a good way to pass this variable to brpc when
built as an
fusying-hwang commented on issue #1918:
URL:
https://github.com/apache/incubator-brpc/issues/1918#issuecomment-1330904025
oh, that's my customized http_archive, because I already had those
dependencies in my workspace (some other projects already depended on them).
but I think you
guodongxiaren commented on PR #2016:
URL: https://github.com/apache/incubator-brpc/pull/2016#issuecomment-1330729699
> 这个PR还需要吗？
先留着吧，gcc的ut有点问题，还没合入master @zyearn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
leaf-potato commented on issue #2025:
URL:
https://github.com/apache/incubator-brpc/issues/2025#issuecomment-1330685155
贴下core栈信息：
1. `ulimit -c unlimited` 开启coredump
2. `gdb echo_server ${coredump}` 查看core栈信息
--
This is an automated message from the Apache Git Service.
To respond
fansehep commented on issue #1918:
URL:
https://github.com/apache/incubator-brpc/issues/1918#issuecomment-1330585434
> alright, it turns out to be my problem. They do support building as an
external lib from source. My humble bazel knowledge limits my ability to
appreciate this project.
yanglimingcn commented on issue #2013:
URL:
https://github.com/apache/incubator-brpc/issues/2013#issuecomment-1330040099
#2027 @wwbmmm 我提交了一个PR，还没有写单测，你先大概Review以下，看看是否合理。其实都是基于auto concurrency
limiter修改的。
--
This is an automated message from the Apache Git Service.
To respond to the
yanglimingcn opened a new pull request, #2027:
URL: https://github.com/apache/incubator-brpc/pull/2027
#2013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jamesge merged PR #2026:
URL: https://github.com/apache/incubator-brpc/pull/2026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zyearn merged PR #2009:
URL: https://github.com/apache/incubator-brpc/pull/2009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zyearn commented on PR #2024:
URL: https://github.com/apache/incubator-brpc/pull/2024#issuecomment-1329340427
> > 这个可能得加在其它地方，这个函数export的是Histogram 类型
https://prometheus.io/docs/concepts/metric_types/#histogram
>
> 应该不是Histogram，是Summary类型
old-bear opened a new pull request, #2026:
URL: https://github.com/apache/incubator-brpc/pull/2026
Make BUTIL_RAPIDJSON_NAMESPACE_BEGIN::GenericDocument's handler method
public to enable outside custom parser/writer
### What problem does this PR solve?
Issue Number: None
wwbmmm commented on PR #2024:
URL: https://github.com/apache/incubator-brpc/pull/2024#issuecomment-1328990128
> 这个可能得加在其它地方，这个函数export的是Histogram 类型
https://prometheus.io/docs/concepts/metric_types/#histogram
应该不是Histogram，是Summary类型
zyearn merged PR #2023:
URL: https://github.com/apache/incubator-brpc/pull/2023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zyearn commented on PR #2024:
URL: https://github.com/apache/incubator-brpc/pull/2024#issuecomment-1328976572
这个可能得加在其它地方，这个函数export的是Histogram
类型 https://prometheus.io/docs/concepts/metric_types/#histogram
--
This is an automated message from the Apache Git Service.
To respond to the
zyearn commented on issue #2012:
URL:
https://github.com/apache/incubator-brpc/issues/2012#issuecomment-1328974433
这个当时是按照 https://prometheus.io/docs/concepts/metric_types/#histogram
实现的，客户端可以通过设置 sum/count来实现latency的效果
--
This is an automated message from the Apache Git Service.
To
wwbmmm commented on code in PR #2009:
URL: https://github.com/apache/incubator-brpc/pull/2009#discussion_r1033284565
##
src/butil/iobuf.cpp:
##
@@ -1211,6 +1211,9 @@ int IOBuf::append_user_data(void* data, size_t size, void
(*deleter)(void*)) {
LOG(FATAL) <<
372046933 commented on code in PR #2009:
URL: https://github.com/apache/incubator-brpc/pull/2009#discussion_r1033277806
##
src/butil/iobuf.cpp:
##
@@ -1211,6 +1211,9 @@ int IOBuf::append_user_data(void* data, size_t size, void
(*deleter)(void*)) {
LOG(FATAL) <<
SillyBoyenjoy opened a new issue, #2025:
URL: https://github.com/apache/incubator-brpc/issues/2025
**Describe the bug (描述bug)**
请问为什么我用cmake编译example里echo_c++里的echo_server进程启动即Segmentation fault:
11，但是直接用Makefile的make编译正常？
**Versions (各种版本)**
OS:macOS Monterey 12.2.1
wwbmmm commented on issue #2012:
URL:
https://github.com/apache/incubator-brpc/issues/2012#issuecomment-1328621078
@xiaohei520321 可以试试PR #2024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Huixxi commented on PR #2024:
URL: https://github.com/apache/incubator-brpc/pull/2024#issuecomment-1328616643
Fix #2012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Huixxi opened a new pull request, #2024:
URL: https://github.com/apache/incubator-brpc/pull/2024
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance
wwbmmm commented on PR #2019:
URL: https://github.com/apache/incubator-brpc/pull/2019#issuecomment-1328444529
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
wwbmmm commented on code in PR #2009:
URL: https://github.com/apache/incubator-brpc/pull/2009#discussion_r1033064042
##
src/butil/iobuf.cpp:
##
@@ -1211,6 +1211,9 @@ int IOBuf::append_user_data(void* data, size_t size, void
(*deleter)(void*)) {
LOG(FATAL) <<
wwbmmm merged PR #2020:
URL: https://github.com/apache/incubator-brpc/pull/2020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
372046933 commented on code in PR #2009:
URL: https://github.com/apache/incubator-brpc/pull/2009#discussion_r1033061895
##
src/butil/iobuf.cpp:
##
@@ -1211,6 +1211,9 @@ int IOBuf::append_user_data(void* data, size_t size, void
(*deleter)(void*)) {
LOG(FATAL) <<
guodongxiaren opened a new pull request, #2023:
URL: https://github.com/apache/incubator-brpc/pull/2023
### What problem does this PR solve?
Issue Number: #1963 #2018
Problem Summary:
### What is changed and the side effects?
Changed:
- 增加GitHub Action的Badge
serverglen commented on PR #2020:
URL: https://github.com/apache/incubator-brpc/pull/2020#issuecomment-1328413233
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zyearn commented on code in PR #2009:
URL: https://github.com/apache/incubator-brpc/pull/2009#discussion_r1033001219
##
src/butil/iobuf.cpp:
##
@@ -1211,6 +1211,9 @@ int IOBuf::append_user_data(void* data, size_t size, void
(*deleter)(void*)) {
LOG(FATAL) <<
zyearn opened a new issue, #2022:
URL: https://github.com/apache/incubator-brpc/issues/2022
Detail:
*
https://github.com/apache/incubator-brpc/actions/runs/3557931214/jobs/5976258953
*
https://github.com/apache/incubator-brpc/actions/runs/3557931214/jobs/5976259297
--
This is an
zyearn opened a new issue, #2021:
URL: https://github.com/apache/incubator-brpc/issues/2021
Detail:
https://github.com/apache/incubator-brpc/actions/runs/3557931214/jobs/5976259135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
zyearn opened a new pull request, #2020:
URL: https://github.com/apache/incubator-brpc/pull/2020
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance
zyearn commented on PR #2018:
URL: https://github.com/apache/incubator-brpc/pull/2018#issuecomment-1328318544
以及github主页上的build link应该要改成指向Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zyearn commented on PR #2016:
URL: https://github.com/apache/incubator-brpc/pull/2016#issuecomment-1328318321
这个PR还需要吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zyearn merged PR #2018:
URL: https://github.com/apache/incubator-brpc/pull/2018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zyearn commented on PR #2018:
URL: https://github.com/apache/incubator-brpc/pull/2018#issuecomment-1328318092
赞，之后提个PR把老的travis删掉应该就好了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
guodongxiaren commented on PR #2018:
URL: https://github.com/apache/incubator-brpc/pull/2018#issuecomment-1328227202
@zyearn 修改了，有空看下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ZeroLiu2018 closed pull request #1806: support channel option: health_check_path
URL: https://github.com/apache/incubator-brpc/pull/1806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zyearn commented on PR #2018:
URL: https://github.com/apache/incubator-brpc/pull/2018#issuecomment-1328099489
install-all-dependences 和 install-dependences 的区别是all包含非必要的依赖，可以换个名字比如：
* install-essential-dependences
* install-all-dependences
zyearn commented on PR #2018:
URL: https://github.com/apache/incubator-brpc/pull/2018#issuecomment-1328098448
>
针对make编译，额外调用一次protoc来处理mcpack2pb中的proto，因为make的编译不稳定，经常报错src/mcpack2pb/generator.cpp:30:10:
fatal error: idl_options.pb.h: No such file or directory
Side effects:
yyweii opened a new pull request, #2019:
URL: https://github.com/apache/incubator-brpc/pull/2019
> ERR_get_error() returns the earliest error code from the thread's error
queue and removes the entry. This function can be called repeatedly until there
are no more error codes to return.
guodongxiaren opened a new pull request, #2018:
URL: https://github.com/apache/incubator-brpc/pull/2018
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance
guodongxiaren closed pull request #2017: all opt
URL: https://github.com/apache/incubator-brpc/pull/2017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
guodongxiaren opened a new pull request, #2017:
URL: https://github.com/apache/incubator-brpc/pull/2017
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance
wwbmmm commented on issue #2000:
URL:
https://github.com/apache/incubator-brpc/issues/2000#issuecomment-1327211987
>
> 我测试了一下，确实worker少的时候，write的开销也较小。深层原因是什么呢？线程数越少？write落在同一个CPU核上的概率越高，cpu
cache失效的概率越低，性能越好？对吗？
是的
--
This is an automated message from the Apache Git Service.
zhouyanghere commented on issue #2000:
URL:
https://github.com/apache/incubator-brpc/issues/2000#issuecomment-1327196831
补充开销统计：
1个worker ProcessEvent：9us， Write：5us
2个worker ProcessEvent：12us， Write：7us
4个worker ProcessEvent：29us， Write：16us
8个worker ProcessEvent：28us，
zhouyanghere commented on issue #2000:
URL:
https://github.com/apache/incubator-brpc/issues/2000#issuecomment-1327159647
> 独立的io线程性能不一定会好，因为存在io线程和process线程之间同步的开销 你这里减小pthread
worker的数量（最小是4），应该会好一些
我测试了一下，确实worker少的时候，write的开销也较小。深层原因是什么呢？线程数越少？write落在同一个CPU核上的概率越高，cpu
wwbmmm closed issue #1543: 开启cpu profiler后导出的pdf文件异常简洁
URL: https://github.com/apache/incubator-brpc/issues/1543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
wwbmmm closed issue #1596: controller->ErrorCode cannot set over 256?
URL: https://github.com/apache/incubator-brpc/issues/1596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
wwbmmm commented on issue #1596:
URL:
https://github.com/apache/incubator-brpc/issues/1596#issuecomment-1327086093
测试了一下，master并没有这个问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
301 - 400 of 7562 matches
Mail list logo
