[GitHub] [incubator-brpc] wwbmmm merged pull request #2075: fix some typos

2023-01-08 Thread GitBox
wwbmmm merged PR #2075: URL: https://github.com/apache/incubator-brpc/pull/2075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-brpc] TousakaRin commented on issue #2051: 应用层如何感知连接的断开和重连

2023-01-08 Thread GitBox
TousakaRin commented on issue #2051: URL: https://github.com/apache/incubator-brpc/issues/2051#issuecomment-1375042065 @yongxiangzheng

[GitHub] [incubator-brpc] Tuvie commented on issue #2073: 关于append_user_data中使用引用计数内存的问题

2023-01-08 Thread GitBox
Tuvie commented on issue #2073: URL: https://github.com/apache/incubator-brpc/issues/2073#issuecomment-1375016238 目前IOBuf还不支持帮外部内存做引用技术 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-brpc] chenBright opened a new pull request, #2075: fix some typos

2023-01-08 Thread GitBox
chenBright opened a new pull request, #2075: URL: https://github.com/apache/incubator-brpc/pull/2075 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance

[GitHub] [incubator-brpc] xiaoyuxee opened a new issue, #2074: 客户端请求比较耗时的case 时,rpc E1010错误,500 Internal Server

2023-01-08 Thread GitBox
xiaoyuxee opened a new issue, #2074: URL: https://github.com/apache/incubator-brpc/issues/2074 **Describe the bug (描述bug)** server 端响应时间超过一定阈值时,client 收到 rpc 错误:E1010。如果请求server 端处理时间较少的case,client 端 则可以接受到正常响应。 rpc 错误时,client 端 controller 错误信息如下: ``` E20230108

[GitHub] [incubator-brpc] luliyucoordinate opened a new issue, #2073: 关于append_user_data数据的生命周期问题

2023-01-08 Thread GitBox
luliyucoordinate opened a new issue, #2073: URL: https://github.com/apache/incubator-brpc/issues/2073 我看到现有iobuf里面如果想要使用一个申请好的内存可以使用append_user_data,这个方法需要传入一个delete的析构(是一个`void(void*)`函数,传入raw数据地址)。

[GitHub] [incubator-brpc-website] dependabot[bot] opened a new pull request, #124: Bump json5 from 1.0.1 to 1.0.2

2023-01-08 Thread GitBox
dependabot[bot] opened a new pull request, #124: URL: https://github.com/apache/incubator-brpc-website/pull/124 Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. Release notes Sourced from https://github.com/json5/json5/releases;>json5's releases. v1.0.2

[GitHub] [incubator-brpc] ljcui closed issue #2068: stream rpc java

2023-01-05 Thread GitBox
ljcui closed issue #2068: stream rpc java URL: https://github.com/apache/incubator-brpc/issues/2068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-brpc] ljcui commented on issue #2068: stream rpc java

2023-01-05 Thread GitBox
ljcui commented on issue #2068: URL: https://github.com/apache/incubator-brpc/issues/2068#issuecomment-1373152637 找到解决方法了,issue我关闭掉。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-brpc] EricPengShuai commented on issue #1392: brpc编译错误

2023-01-05 Thread GitBox
EricPengShuai commented on issue #1392: URL: https://github.com/apache/incubator-brpc/issues/1392#issuecomment-1373137313 是不是 gflags 版本不支持 2.2.2 的,我看 [getting_started.md](https://github.com/apache/incubator-brpc/blob/master/docs/cn/getting_started.md#gflags-20-221) 文档上写的 gflags 版本是

[GitHub] [incubator-brpc] wwbmmm commented on issue #2072: error: unknown type name 'greg_t'

2023-01-05 Thread GitBox
wwbmmm commented on issue #2072: URL: https://github.com/apache/incubator-brpc/issues/2072#issuecomment-1373077519 brpc does not support FreeBSD now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-brpc] leaf-potato commented on issue #2052: 传输大量数据必须用butil::IOBuf 吗?

2023-01-05 Thread GitBox
leaf-potato commented on issue #2052: URL: https://github.com/apache/incubator-brpc/issues/2052#issuecomment-1373070266 > 也就是发送数据量 >=2G 的时候在发送端的 copy 无法消除,其他的 copy 都可以消除,这样可以更高效。 序列化数据拷贝到attachment可以看下IOBuf的`append_user_data`方法是否可以解决

[GitHub] [incubator-brpc] cmdmspaint closed issue #2069: 如何将brpc controller中的信息传递到上层应用程序?

2023-01-05 Thread GitBox
cmdmspaint closed issue #2069: 如何将brpc controller中的信息传递到上层应用程序? URL: https://github.com/apache/incubator-brpc/issues/2069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-brpc] yurivict opened a new issue, #2072: error: unknown type name 'greg_t'

2023-01-05 Thread GitBox
yurivict opened a new issue, #2072: URL: https://github.com/apache/incubator-brpc/issues/2072 **Describe the bug (描述bug)** ``` /usr/ports/devel/brpc/work/incubator-brpc-1.3.0/src/butil/debug/stack_trace_posix.cc:291:5: error: unknown type name 'greg_t' greg_t value; ^

[GitHub] [incubator-brpc] yurivict opened a new issue, #2071: error: cannot initialize return object of type 'uint64_t' (aka 'unsigned long') with an rvalue of type 'pthread_t'

2023-01-05 Thread GitBox
yurivict opened a new issue, #2071: URL: https://github.com/apache/incubator-brpc/issues/2071 **Describe the bug (描述bug)** ``` /usr/ports/devel/brpc/work/incubator-brpc-1.3.0/src/butil/compat.h:85:12: error: cannot initialize return object of type 'uint64_t' (aka 'unsigned long')

[GitHub] [incubator-brpc] yurivict opened a new issue, #2070: Bash shebangs are wrong: they should be #!/usr/bin/env bash

2023-01-05 Thread GitBox
yurivict opened a new issue, #2070: URL: https://github.com/apache/incubator-brpc/issues/2070 [Here](https://github.com/apache/incubator-brpc/blob/master/tools/get_brpc_revision.sh#L1) and in all other shell scripts -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] cmdmspaint commented on issue #2069: 如何将brpc controller中的信息传递到上层应用程序?

2023-01-05 Thread GitBox
cmdmspaint commented on issue #2069: URL: https://github.com/apache/incubator-brpc/issues/2069#issuecomment-1372212270 > > > > 是不是头文件没有更新? 这是我们程序中的头文件 ![image](https://user-images.githubusercontent.com/50624748/210789815-81b33547-afd2-48fb-b656-8ff734574d98.png)

[GitHub] [incubator-brpc] cmdmspaint commented on issue #2069: 如何将brpc controller中的信息传递到上层应用程序?

2023-01-05 Thread GitBox
cmdmspaint commented on issue #2069: URL: https://github.com/apache/incubator-brpc/issues/2069#issuecomment-1372209552 > > > > 是不是头文件没有更新? 指的的controller.h 更新吗 还是我们程序中的头文件 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-brpc] serverglen commented on issue #2069: 如何将brpc controller中的信息传递到上层应用程序?

2023-01-05 Thread GitBox
serverglen commented on issue #2069: URL: https://github.com/apache/incubator-brpc/issues/2069#issuecomment-1372200305 > 是不是头文件没有更新? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-brpc] cmdmspaint commented on issue #2069: 如何将brpc controller中的信息传递到上层应用程序?

2023-01-05 Thread GitBox
cmdmspaint commented on issue #2069: URL: https://github.com/apache/incubator-brpc/issues/2069#issuecomment-1372196211 > 应该是服务端打点,想在客户端获取打点信息吧? 这种的话只能通过 修改 PB协议,增加对应的repeat类型字段,传递给客户端,在客户端ProcessXXXResponse函数中解包,从PB对象中获取打点数据,然后设置到cntl中。 在controller中添加方法需要类似 register的操作吗 --

[GitHub] [incubator-brpc] cmdmspaint commented on issue #2069: 如何将brpc controller中的信息传递到上层应用程序?

2023-01-05 Thread GitBox
cmdmspaint commented on issue #2069: URL: https://github.com/apache/incubator-brpc/issues/2069#issuecomment-1372185670 还有一个疑问是controller.h 中 Client-side methods Server-side methods. Both-side methods.的区别是什么呢,为什么要划分client sever 和both 。是因为client server特点导致 还是有什么限制呢? -- This is an

[GitHub] [incubator-brpc] ravenxrz closed issue #2067: client stub.Func(controller, req, rsp, done) 参数的controller为空时,行为是什么呢?

2023-01-05 Thread GitBox
ravenxrz closed issue #2067: client stub.Func(controller, req, rsp, done) 参数的controller为空时,行为是什么呢? URL: https://github.com/apache/incubator-brpc/issues/2067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-brpc] ravenxrz commented on issue #2067: client stub.Func(controller, req, rsp, done) 参数的controller为空时,行为是什么呢?

2023-01-05 Thread GitBox
ravenxrz commented on issue #2067: URL: https://github.com/apache/incubator-brpc/issues/2067#issuecomment-1372142585 ok, get. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-brpc] cmdmspaint commented on issue #2069: 如何将brpc controller中的信息传递到上层应用程序?

2023-01-05 Thread GitBox
cmdmspaint commented on issue #2069: URL: https://github.com/apache/incubator-brpc/issues/2069#issuecomment-1372139568 > 应该是服务端打点,想在客户端获取打点信息吧? 这种的话只能通过 修改 PB协议,增加对应的repeat类型字段,传递给客户端,在客户端ProcessXXXResponse函数中解包,从PB对象中获取打点数据,然后设置到cntl中。 但是 在我们程序中通过brpc::controller取用的时候就出现了 编译报错的情况

[GitHub] [incubator-brpc] cmdmspaint commented on issue #2069: 如何将brpc controller中的信息传递到上层应用程序?

2023-01-05 Thread GitBox
cmdmspaint commented on issue #2069: URL: https://github.com/apache/incubator-brpc/issues/2069#issuecomment-1372135886 > 应该是服务端打点,想在客户端获取打点信息吧? 这种的话只能通过 修改 PB协议,增加对应的repeat类型字段,传递给客户端,在客户端ProcessXXXResponse函数中解包,从PB对象中获取打点数据,然后设置到cntl中。 我们是一个存储程序,远程过程调用使用的是brpc。想把在bprc

[GitHub] [incubator-brpc] cmdmspaint commented on issue #2069: 如何将brpc controller中的信息传递到上层应用程序?

2023-01-05 Thread GitBox
cmdmspaint commented on issue #2069: URL: https://github.com/apache/incubator-brpc/issues/2069#issuecomment-1372113352 > 应该是服务端打点,想在客户端获取打点信息吧? 这种的话只能通过 修改 PB协议,增加对应的repeat类型字段,传递给客户端,在客户端ProcessXXXResponse函数中解包,从PB对象中获取打点数据,然后设置到cntl中。 正常情况下 是直接取用就可以吗 -- This is an automated

[GitHub] [incubator-brpc] cmdmspaint commented on issue #2069: 如何将brpc controller中的信息传递到上层应用程序?

2023-01-05 Thread GitBox
cmdmspaint commented on issue #2069: URL: https://github.com/apache/incubator-brpc/issues/2069#issuecomment-1372112897 > 应该是服务端打点,想在客户端获取打点信息吧? 这种的话只能通过 修改 PB协议,增加对应的repeat类型字段,传递给客户端,在客户端ProcessXXXResponse函数中解包,从PB对象中获取打点数据,然后设置到cntl中。 cntl中已经设置上信息了 但是取的时候 编译报错了

[GitHub] [incubator-brpc] serverglen commented on issue #2069: 如何将brpc controller中的信息传递到上层应用程序?

2023-01-05 Thread GitBox
serverglen commented on issue #2069: URL: https://github.com/apache/incubator-brpc/issues/2069#issuecomment-1372099116 应该是服务端打点,想在客户端获取打点信息吧? 这种的话只能通过 修改 PB协议,增加对应的repeat类型字段,传递给客户端,在客户端ProcessXXXResponse函数中解包,从PB对象中获取打点数据,然后设置到cntl中。 -- This is an automated message from the Apache

[GitHub] [incubator-brpc] cmdmspaint opened a new issue, #2069: 如何将brpc controller中的信息传递到上层应用程序?

2023-01-05 Thread GitBox
cmdmspaint opened a new issue, #2069: URL: https://github.com/apache/incubator-brpc/issues/2069 背景:在程序压测过程中发现了性能瓶颈,对程序进行打点分析。一开始是通过traceprintf打印到rpcz中,但是rpcz打印到浏览器的信息一直在刷新。我们想把统计的耗时,传到我们上层的程序中进行统一分析。 这是在controller中添加了一个map

[GitHub] [incubator-brpc] ljcui commented on issue #2068: stream rpc java

2023-01-04 Thread GitBox
ljcui commented on issue #2068: URL: https://github.com/apache/incubator-brpc/issues/2068#issuecomment-1371824785 场景是客户端是java,服务端是brpc。客户端先给服务端发送一个request,服务端收到request后,给客户端发送响应数据,只不过这个数据很大,服务端需要持续不断地发送,客户端侧持续不断的接收。有什么好的方法吗 -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] ljcui commented on issue #2068: stream rpc java

2023-01-04 Thread GitBox
ljcui commented on issue #2068: URL: https://github.com/apache/incubator-brpc/issues/2068#issuecomment-1371748915 https://github.com/apache/incubator-brpc/tree/master/example/streaming_echo_c++ 这个有java 版本的例子吗 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-brpc] ljcui opened a new issue, #2068: stream rpc java

2023-01-04 Thread GitBox
ljcui opened a new issue, #2068: URL: https://github.com/apache/incubator-brpc/issues/2068 brpc的java sdk 是哪个?另外 java sdk 支持 stream rpc的使用方式吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-brpc] serverglen closed issue #2054: Pb2JsonOptions的注释与实际相反

2023-01-04 Thread GitBox
serverglen closed issue #2054: Pb2JsonOptions的注释与实际相反 URL: https://github.com/apache/incubator-brpc/issues/2054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [incubator-brpc] wwbmmm merged pull request #2027: add timeout concurrency limiter

2023-01-04 Thread GitBox
wwbmmm merged PR #2027: URL: https://github.com/apache/incubator-brpc/pull/2027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-brpc] serverglen commented on pull request #2027: add timeout concurrency limiter

2023-01-04 Thread GitBox
serverglen commented on PR #2027: URL: https://github.com/apache/incubator-brpc/pull/2027#issuecomment-1371721339 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-brpc] serverglen commented on issue #2067: client stub.Func(controller, req, rsp, done) 参数的controller为空时,行为是什么呢?

2023-01-04 Thread GitBox
serverglen commented on issue #2067: URL: https://github.com/apache/incubator-brpc/issues/2067#issuecomment-1371654774 controller为空指针的话,会直接core掉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-brpc] Aaaaaaron commented on pull request #1947: split large data when using brpc streaming

2023-01-04 Thread GitBox
Aaron commented on PR #1947: URL: https://github.com/apache/incubator-brpc/pull/1947#issuecomment-1370983961 @wwbmmm 好的 谢谢 不好意思最近比较忙 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-brpc] ravenxrz opened a new issue, #2067: client stub.Func(controller, req, rsp, done) 参数的controller为空时,行为是什么呢?

2023-01-04 Thread GitBox
ravenxrz opened a new issue, #2067: URL: https://github.com/apache/incubator-brpc/issues/2067 如题,看代码时,发现了这样的代码,不太理解。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-brpc] leaf-potato commented on issue #2052: 传输大量数据必须用butil::IOBuf 吗?

2023-01-03 Thread GitBox
leaf-potato commented on issue #2052: URL: https://github.com/apache/incubator-brpc/issues/2052#issuecomment-1369936547 > Q3:通过 perf,我们看到 bthread 中的 sys call 占总体 sys call 的 20% 左右,不知道是我们使用姿势有问题,或者是有优化参数可以控制? 可以参考

[GitHub] [incubator-brpc] leaf-potato commented on issue #2052: 传输大量数据必须用butil::IOBuf 吗?

2023-01-03 Thread GitBox
leaf-potato commented on issue #2052: URL: https://github.com/apache/incubator-brpc/issues/2052#issuecomment-1369923528 > 也就是发送数据量 >=2G 的时候在发送端的 copy 无法消除,其他的 copy 都可以消除,这样可以更高效。 我理解不管使用PB还是attachment发送数据都会涉及到一次拷贝,只是这个拷贝发生的地方不同: 1. PB发送数据:用户设置PB => PB序列化(框架)=>

[GitHub] [incubator-brpc] fzhedu commented on issue #2052: 传输大量数据必须用butil::IOBuf 吗?

2023-01-03 Thread GitBox
fzhedu commented on issue #2052: URL: https://github.com/apache/incubator-brpc/issues/2052#issuecomment-1369506674 @leaf-potato 感谢您的回复。Q2 已经没疑问了,但是 Q1 中关于用 iobuf 和直接 chunkPB 传输的性能方面还有疑问,因为我们传输的是 chunkPB list,它由多个 chunkPB 组成,可以直接传输 chunkPB list。如果用IObuf,现有 Starrocks 中将 chunkPB list 中的每个

[GitHub] [incubator-brpc-website] Huixxi commented on pull request #123: Bump json5 and postcss-loader

2023-01-02 Thread GitBox
Huixxi commented on PR #123: URL: https://github.com/apache/incubator-brpc-website/pull/123#issuecomment-1369424753 > 感觉合并也不会有问题 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-brpc-website] wasphin commented on pull request #123: Bump json5 and postcss-loader

2023-01-02 Thread GitBox
wasphin commented on PR #123: URL: https://github.com/apache/incubator-brpc-website/pull/123#issuecomment-1369326320 @Huixxi 这些自动提交的更新依赖的 PR 能合吗?或者关掉? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-brpc-website] dependabot[bot] opened a new pull request, #123: Bump json5 and postcss-loader

2023-01-02 Thread GitBox
dependabot[bot] opened a new pull request, #123: URL: https://github.com/apache/incubator-brpc-website/pull/123 Removes [json5](https://github.com/json5/json5). It's no longer used after updating ancestor dependency [postcss-loader](https://github.com/webpack-contrib/postcss-loader). These

[GitHub] [incubator-brpc] describe2022 commented on issue #1097: Stream 的on_received_messages怎么进行错误处理?

2022-12-30 Thread GitBox
describe2022 commented on issue #1097: URL: https://github.com/apache/incubator-brpc/issues/1097#issuecomment-1367840584 > btw:StreamClose这里有个坑,因为client端上层传给brpc的是handler的指针,有可能上层析构了on_closed还会被调用,有可能访问到已经析构了的数据,这块需要处理一下 请问一下这块怎么处理呢?现在只要调用StreamClose,如您说的handler被紧接着析构掉的话就会发生段错误。

[GitHub] [incubator-brpc] wwbmmm commented on issue #1991: support https alpn

2022-12-29 Thread GitBox
wwbmmm commented on issue #1991: URL: https://github.com/apache/incubator-brpc/issues/1991#issuecomment-1367693392 > @wwbmmm 对这个需求比较感兴趣,想尝试去实现,提PR的话社区是否会考虑合入呢 欢迎~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-brpc] leaf-potato commented on issue #1991: support https alpn

2022-12-29 Thread GitBox
leaf-potato commented on issue #1991: URL: https://github.com/apache/incubator-brpc/issues/1991#issuecomment-1367230634 @wwbmmm 对这个需求比较感兴趣,想尝试去实现,提PR的话社区是否会考虑合入呢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-brpc] serverglen merged pull request #2065: Optimize reference docs

2022-12-28 Thread GitBox
serverglen merged PR #2065: URL: https://github.com/apache/incubator-brpc/pull/2065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-brpc] TousakaRin merged pull request #2066: update oncall.md from Dec 19th to Dec 25th

2022-12-28 Thread GitBox
TousakaRin merged PR #2066: URL: https://github.com/apache/incubator-brpc/pull/2066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-brpc] TousakaRin opened a new pull request, #2066: update oncall.md from Dec 19th to Dec 25th

2022-12-28 Thread GitBox
TousakaRin opened a new pull request, #2066: URL: https://github.com/apache/incubator-brpc/pull/2066 Signed-off-by: lei he ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side

[GitHub] [incubator-brpc] cdjingit closed issue #2055: 使用DynamicPartitionChannel时,request map的接口没有提供分片总数

2022-12-28 Thread GitBox
cdjingit closed issue #2055: 使用DynamicPartitionChannel时,request map的接口没有提供分片总数 URL: https://github.com/apache/incubator-brpc/issues/2055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-brpc] cdjingit opened a new pull request, #2065: Optimize reference docs

2022-12-28 Thread GitBox
cdjingit opened a new pull request, #2065: URL: https://github.com/apache/incubator-brpc/pull/2065 ### What problem does this PR solve? Optimize reference docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-brpc] wwbmmm merged pull request #2049: fix rpc maybe error: " libbrpc.so: undefined symbol: pthread_mutex_lo…

2022-12-28 Thread GitBox
wwbmmm merged PR #2049: URL: https://github.com/apache/incubator-brpc/pull/2049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-brpc] wwbmmm merged pull request #2057: Optimize parallel channel request map method

2022-12-28 Thread GitBox
wwbmmm merged PR #2057: URL: https://github.com/apache/incubator-brpc/pull/2057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-brpc] serverglen commented on pull request #2057: Optimize parallel channel request map method

2022-12-28 Thread GitBox
serverglen commented on PR #2057: URL: https://github.com/apache/incubator-brpc/pull/2057#issuecomment-1366564022 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-brpc] cdjingit commented on a diff in pull request #2057: Optimize parallel channel request map method

2022-12-27 Thread GitBox
cdjingit commented on code in PR #2057: URL: https://github.com/apache/incubator-brpc/pull/2057#discussion_r1058087993 ## src/brpc/parallel_channel.h: ## @@ -94,10 +94,20 @@ struct SubCall { class CallMapper : public SharedObject { public: virtual SubCall Map(int

[GitHub] [incubator-brpc] gydong commented on a diff in pull request #2057: Optimize parallel channel request map method

2022-12-27 Thread GitBox
gydong commented on code in PR #2057: URL: https://github.com/apache/incubator-brpc/pull/2057#discussion_r1058086480 ## src/brpc/parallel_channel.h: ## @@ -94,10 +94,20 @@ struct SubCall { class CallMapper : public SharedObject { public: virtual SubCall Map(int

[GitHub] [incubator-brpc] leaf-potato commented on issue #1991: support https alpn

2022-12-27 Thread GitBox
leaf-potato commented on issue #1991: URL: https://github.com/apache/incubator-brpc/issues/1991#issuecomment-1365971073 比较好奇,rpc什么场景下需要协议版本的协商呢?发送或者接受某一方为类似nginx这样的http服务? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-brpc] serverglen closed issue #2060: example中logoff_ms参数的作用

2022-12-26 Thread GitBox
serverglen closed issue #2060: example中logoff_ms参数的作用 URL: https://github.com/apache/incubator-brpc/issues/2060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [incubator-brpc] wwbmmm merged pull request #2064: delete deprecated logoff_ms gflag in example folder

2022-12-26 Thread GitBox
wwbmmm merged PR #2064: URL: https://github.com/apache/incubator-brpc/pull/2064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-brpc] serverglen commented on pull request #2064: delete deprecated logoff_ms gflag in example folder

2022-12-26 Thread GitBox
serverglen commented on PR #2064: URL: https://github.com/apache/incubator-brpc/pull/2064#issuecomment-1365553587 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-brpc] leaf-potato opened a new pull request, #2064: delete deprecated logoff_ms gflag in example folder

2022-12-26 Thread GitBox
leaf-potato opened a new pull request, #2064: URL: https://github.com/apache/incubator-brpc/pull/2064 ### What problem does this PR solve? Issue Number: #2060 Problem Summary: logoff_ms gflag in example is not used. ### What is changed and the side effects?

[GitHub] [incubator-brpc] leaf-potato closed pull request #2063: delete deprecated logoff_ms gflag in example folder

2022-12-26 Thread GitBox
leaf-potato closed pull request #2063: delete deprecated logoff_ms gflag in example folder URL: https://github.com/apache/incubator-brpc/pull/2063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-brpc] leaf-potato opened a new pull request, #2063: delete deprecated logoff_ms gflag in example folder

2022-12-26 Thread GitBox
leaf-potato opened a new pull request, #2063: URL: https://github.com/apache/incubator-brpc/pull/2063 ### What problem does this PR solve? Issue Number: #2060 Problem Summary: logoff_ms gflag in example is not used. ### What is changed and the side effects?

[GitHub] [incubator-brpc] yongxiangzheng commented on issue #2051: 应用层如何感知连接的断开和重连

2022-12-26 Thread GitBox
yongxiangzheng commented on issue #2051: URL: https://github.com/apache/incubator-brpc/issues/2051#issuecomment-1364977475 现在采用定时调用checkhealth接口,进行判断连接状态,觉得这样做能感知连接状态,但是实时性不强,以及开启定时器会有一些额外性能开销。底层是为什么做这个屏蔽,是因为rpc调用规则吗 -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] cdjingit commented on issue #2051: 应用层如何感知连接的断开和重连

2022-12-25 Thread GitBox
cdjingit commented on issue #2051: URL: https://github.com/apache/incubator-brpc/issues/2051#issuecomment-1364961953 brpc对于底层连接的建立,释放,共享等对于应用层是屏蔽的,可能需要你自己在应用层做一些处理来感知。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-brpc] 17336 commented on issue #2062: 多维度bvar支持http内置服务查看吗?

2022-12-25 Thread GitBox
17336 commented on issue #2062: URL: https://github.com/apache/incubator-brpc/issues/2062#issuecomment-1364960013 > 通过/brpc_metrics dump出来的multi bvar的数量,默认是0 好的,十分感谢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-brpc] cdjingit commented on issue #2062: 多维度bvar支持http内置服务查看吗?

2022-12-25 Thread GitBox
cdjingit commented on issue #2062: URL: https://github.com/apache/incubator-brpc/issues/2062#issuecomment-1364952872 bvar_max_dump_multi_dimension_metric_number 这个控制可以通过/brpc_metrics dump出来的multi bvar的数量,默认是0 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-brpc] wwbmmm commented on issue #2060: example中logoff_ms参数的作用

2022-12-25 Thread GitBox
wwbmmm commented on issue #2060: URL: https://github.com/apache/incubator-brpc/issues/2060#issuecomment-1364924124 可以的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-brpc] leaf-potato commented on issue #2060: example中logoff_ms参数的作用

2022-12-25 Thread GitBox
leaf-potato commented on issue #2060: URL: https://github.com/apache/incubator-brpc/issues/2060#issuecomment-1364866285 这样的话是否可以提个PR删掉example中的这个gflag呢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-brpc] 17336 opened a new issue, #2062: 多维度bvar支持http内置服务查看吗?

2022-12-25 Thread GitBox
17336 opened a new issue, #2062: URL: https://github.com/apache/incubator-brpc/issues/2062 github里多维度bvar文档里说支持 ![image](https://user-images.githubusercontent.com/74393844/209496436-1e391a38-712b-409d-aece-52f3f105a2c4.png)

[GitHub] [incubator-brpc] wwbmmm commented on issue #2060: example中logoff_ms参数的作用

2022-12-25 Thread GitBox
wwbmmm commented on issue #2060: URL: https://github.com/apache/incubator-brpc/issues/2060#issuecomment-1364831593 这个是用来传递给Server::Stop方法的参数,不过按照注释,这个参数已不再使用 ```cpp // Stop accepting new connections and requests from existing connections. // Returns 0 on success, -1

[GitHub] [incubator-brpc] 17336 commented on issue #2059: 请问bvar变量的expose接口有什么用呢?

2022-12-25 Thread GitBox
17336 commented on issue #2059: URL: https://github.com/apache/incubator-brpc/issues/2059#issuecomment-1364826368 > 使用的多维度bvar?能否给下使用代码例子? 我知道了,源码里Window类型的bvar会在初始化时自动expose,但是Adder不行,需要手动expose。 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-brpc] 17336 closed issue #2059: 请问bvar变量的expose接口有什么用呢?

2022-12-25 Thread GitBox
17336 closed issue #2059: 请问bvar变量的expose接口有什么用呢? URL: https://github.com/apache/incubator-brpc/issues/2059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [incubator-brpc] 17336 commented on issue #2059: 请问bvar变量的expose接口有什么用呢?

2022-12-25 Thread GitBox
17336 commented on issue #2059: URL: https://github.com/apache/incubator-brpc/issues/2059#issuecomment-1364823171 > 使用的多维度bvar?能否给下使用代码例子? 不是,单维度的bvar ``` namespace other_metric { bvar::Adder time; bvar::Window > time_minitue("metric", "time", , 60); }

[GitHub] [incubator-brpc] serverglen merged pull request #2058: optimize mbvar doc

2022-12-25 Thread GitBox
serverglen merged PR #2058: URL: https://github.com/apache/incubator-brpc/pull/2058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-brpc] wasphin merged pull request #2061: fix http_client.md duplicate error

2022-12-25 Thread GitBox
wasphin merged PR #2061: URL: https://github.com/apache/incubator-brpc/pull/2061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-brpc] leaf-potato opened a new pull request, #2061: fix http_client.md duplicate error

2022-12-25 Thread GitBox
leaf-potato opened a new pull request, #2061: URL: https://github.com/apache/incubator-brpc/pull/2061 ### What problem does this PR solve? Issue Number: no Problem Summary: some words repeated. ### What is changed and the side effects? Changed: delete duplicate

[GitHub] [incubator-brpc] leaf-potato commented on issue #2052: 传输大量数据必须用butil::IOBuf 吗?

2022-12-24 Thread GitBox
leaf-potato commented on issue #2052: URL: https://github.com/apache/incubator-brpc/issues/2052#issuecomment-1364497672 重新看了下文档,`chunk_PB`在使用异步请求时,`CallMethod`结束后可以释放,前提在done中不需要`chunkPB`信息

[GitHub] [incubator-brpc] leaf-potato opened a new issue, #2060: example中logoff_ms参数的作用

2022-12-23 Thread GitBox
leaf-potato opened a new issue, #2060: URL: https://github.com/apache/incubator-brpc/issues/2060 在example目录下大多数例子的`server.cpp`中都定义了`logoff_ms`这个gflag, 但似乎没有地方使用了这个参数。想问下这个参数在什么地方发挥作用呢? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-brpc] leaf-potato commented on issue #2052: 传输大量数据必须用butil::IOBuf 吗?

2022-12-23 Thread GitBox
leaf-potato commented on issue #2052: URL: https://github.com/apache/incubator-brpc/issues/2052#issuecomment-1363987901 Q1:在client、server两端都是brpc的前提下,attachment更算是proto message的一种补充。proto官方给出大小是有限制的,默认是64MB,硬制是2GB。在限制范围内,attachment和proto的区别在于序列化和反序列化,如果attachment是传proto序列化后的数据,理论上两者差距不大。

[GitHub] [incubator-brpc] leaf-potato commented on issue #2059: 请问bvar变量的expose接口有什么用呢?

2022-12-23 Thread GitBox
leaf-potato commented on issue #2059: URL: https://github.com/apache/incubator-brpc/issues/2059#issuecomment-1363967074 使用的多维度bvar?能否给下使用代码例子? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-brpc] 17336 opened a new issue, #2059: 请问bvar变量的expose接口有什么用呢?

2022-12-23 Thread GitBox
17336 opened a new issue, #2059: URL: https://github.com/apache/incubator-brpc/issues/2059 我初始化了一个bvar变量,没有经过expose也能在http网页上观察到bvar的变化,所以expose接口有什么用呢 ![image](https://user-images.githubusercontent.com/74393844/209327675-c06fd1c8-5ce8-4ad2-be36-27800eb6075b.png) -- This is an

[GitHub] [incubator-brpc] cdjingit opened a new pull request, #2058: optimize mbvar doc

2022-12-23 Thread GitBox
cdjingit opened a new pull request, #2058: URL: https://github.com/apache/incubator-brpc/pull/2058 补充mbvar文档 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-brpc] cdjingit commented on issue #2055: 使用DynamicPartitionChannel时,request map的接口没有提供分片总数

2022-12-23 Thread GitBox
cdjingit commented on issue #2055: URL: https://github.com/apache/incubator-brpc/issues/2055#issuecomment-1363801275 #2057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [incubator-brpc] wwbmmm opened a new pull request, #2056: Remove incubator

2022-12-22 Thread GitBox
wwbmmm opened a new pull request, #2056: URL: https://github.com/apache/incubator-brpc/pull/2056 Since bRPC has graduated, we can remove `incubator` in the source code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-brpc] wasphin commented on issue #2054: Pb2JsonOptions的注释与实际相反

2022-12-22 Thread GitBox
wasphin commented on issue #2054: URL: https://github.com/apache/incubator-brpc/issues/2054#issuecomment-1363630416 > ``` > 1、single_repeated_to_array字段的注释中,default是false。 > 2、但是实际使用时发现,默认是开启的。例如 > "my_field": ["value1"],

[GitHub] [incubator-brpc] cdjingit commented on issue #2055: 使用DynamicPartitionChannel时,request map的接口没有提供分片总数

2022-12-22 Thread GitBox
cdjingit commented on issue #2055: URL: https://github.com/apache/incubator-brpc/issues/2055#issuecomment-1363581493 可以 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-brpc] wwbmmm commented on issue #2055: 使用DynamicPartitionChannel时,request map的接口没有提供分片总数

2022-12-22 Thread GitBox
wwbmmm commented on issue #2055: URL: https://github.com/apache/incubator-brpc/issues/2055#issuecomment-1363580219 是否可以改为 ```cpp virtual SubCall Map(int channel_index/*starting from 0*/, int /*channel_count*/, const

[GitHub] [incubator-brpc] cdjingit opened a new issue, #2055: 使用DynamicPartitionChannel时,request map的接口没有提供分片总数

2022-12-22 Thread GitBox
cdjingit opened a new issue, #2055: URL: https://github.com/apache/incubator-brpc/issues/2055 **Describe the bug (描述bug)** 使用DynamicPartitionChannel时,各个片库的分片数是变化的, Request Map里只有channel_idx, 没有分片总数的信息。

[GitHub] [incubator-brpc] serverglen merged pull request #2053: Fix typo

2022-12-22 Thread GitBox
serverglen merged PR #2053: URL: https://github.com/apache/incubator-brpc/pull/2053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-brpc] mrwhyxxk opened a new issue, #2054: Pb2JsonOptions的注释与实际相反

2022-12-22 Thread GitBox
mrwhyxxk opened a new issue, #2054: URL: https://github.com/apache/incubator-brpc/issues/2054 **Describe the bug (描述bug)** ``` 1、single_repeated_to_array字段的注释中,default是false。 2、但是实际使用时发现,默认是开启的。例如 "my_field": ["value1"],

[GitHub] [incubator-brpc] thinh2 opened a new pull request, #2053: Fix typo

2022-12-21 Thread GitBox
thinh2 opened a new pull request, #2053: URL: https://github.com/apache/incubator-brpc/pull/2053 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance

[GitHub] [incubator-brpc] fzhedu opened a new issue, #2052: 传输大量数据必须用butil::IOBuf 吗?

2022-12-21 Thread GitBox
fzhedu opened a new issue, #2052: URL: https://github.com/apache/incubator-brpc/issues/2052 每个 chunk 的 size 在 100KB ~ 100MB 之间,chunk 先序列化成 protobuf chunkPB。 Q1: chunkPB 有必要 copy 到 butil::IOBuf 中通过 attachment 传输吗?还是直接传输 chunkPB 结构?这两种方式哪种更高效? (我理解两种方式都可以,直接传输chunkPB 更高效) Q2:调用

[GitHub] [incubator-brpc] serverglen merged pull request #2050: fix: small typo

2022-12-20 Thread GitBox
serverglen merged PR #2050: URL: https://github.com/apache/incubator-brpc/pull/2050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-brpc] yongxiangzheng opened a new issue, #2051: 应用层如何感知连接的断开和重连

2022-12-20 Thread GitBox
yongxiangzheng opened a new issue, #2051: URL: https://github.com/apache/incubator-brpc/issues/2051 目前有需求,在客户端连接成功服务端后,主动推送客户端一些基本信息到服务端,所以需要应用层能感知建立连接或者重连事件通知,我看日志输出,断开和重连都会打印,跟踪了代码,并没有对应用层抛出事件通知,请问应用层如何去感知连接状态呢?

[GitHub] [incubator-brpc] 0xflotus opened a new pull request, #2050: fix: small typo

2022-12-20 Thread GitBox
0xflotus opened a new pull request, #2050: URL: https://github.com/apache/incubator-brpc/pull/2050 Did you mean `introduction`? ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed:

[GitHub] [incubator-brpc] xihaishibei commented on issue #2048: 用户态tcp实现是否会开源呢?

2022-12-18 Thread GitBox
xihaishibei commented on issue #2048: URL: https://github.com/apache/incubator-brpc/issues/2048#issuecomment-1357130976 关键点是改了线程模型,改成了 RTC + polling,高性能的框架基本上都要走这条路,资源切分不共享,绑核 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-brpc] xihaishibei commented on issue #1769: brpc作为客户端与go-grpc服务端通信经过Nginx负载均衡后,brpc无法解析数据了

2022-12-18 Thread GitBox
xihaishibei commented on issue #1769: URL: https://github.com/apache/incubator-brpc/issues/1769#issuecomment-1357038511 > 请问下这个怎么解决的呢,遇到了同样的问题 我们把Nginx的负载均衡由7层配置成了4层,就解决了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-brpc] xihaishibei commented on issue #1769: brpc作为客户端与go-grpc服务端通信经过Nginx负载均衡后,brpc无法解析数据了

2022-12-18 Thread GitBox
xihaishibei commented on issue #1769: URL: https://github.com/apache/incubator-brpc/issues/1769#issuecomment-1357038066 我们把Nginx的负载均衡由7层配置成了4层,就解决了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

<    1   2   3   4   5   6   7   8   9   10   >