Re: Re: [DISCUSS] Refactor how planner rules are parameterized

2020-06-14 Thread Haisheng Yuan
Druid adapter rules are not used by Druid. As far as I know, only Hive uses these rules, I even think they should be moved to Hive project. :) If any other projects other than Hive are using them, please let us know. Basically, these Druid rules are not generally applicable. The PR changed many

Re: Why migrate from Maven to Gradle

2020-06-14 Thread Danny Chan
Thanks, are there some building functionalities that grade can do but maven can not ? Gradle is not that user friendly for new uses but I works well, it has better flexibility than maven with many custom plugins. Best, Danny Chan 在 2020年6月13日 +0800 AM1:31,丁小冬(比古) ,写道: > > Hi, Calcite developers

Re: Re: [DISCUSS] Refactor how planner rules are parameterized

2020-06-14 Thread Stamatis Zampetakis
Hello, Thanks for putting this together Julian. I went quickly over the PR just to grasp better the idea and here are some first thoughts. I really like the fact that rules creation is now much more uniform than before. I also like the fact that in some cases subclassing can be avoided thanks

Re: Re: [DISCUSS] Refactor how planner rules are parameterized

2020-06-14 Thread Haisheng Yuan
Hi Julian, Thanks for working on this. We haven't reached a consensus yet. Frankly speaking, I agree with what Stamatis said earlier. Flexibility doesn't come with no cost. Admittedly, with this patch, any rule constructor refactoring won't need to deprecate old constructors and break