Re: [DISCUSS] Trolls and community

I echo Jacques’ nice and decent comments on this. *"""* *- I think Julian and Vladimir are far and above the most prolificcontributors on the project (by any measure I can use: code, commits, emailresponses, longevity, consistency, releases, etc). [3]- I think Julian and Vladimir

Re: [DISCUSS] Extends RelDistribution to support more distribution types

Hi Jinpeng, Thanks a lot for your response. > If you don't handle traits derivations correctly, your new queries may not perform as well as those old queries using classic distribution types. Exactly, Thanks for reminding me. I would handle trait derivations carefully for the new added

Re: Why not make the "test" namespace public, or move to a separate Maven module that main pulls in as a "testOnly" dependency?

Julian, this is awesome to hear -- and thank you for the pointers to this "FixtureTest" file, I hadn't found that one yet =) A couple of the helper methods and patterns seem particularly useful, like this one for setting everything up with a particular test schema: final SchemaPlus rootSchema

Re: Why not make the "test" namespace public, or move to a separate Maven module that main pulls in as a "testOnly" dependency?

Gavin, I’m working on this in https://issues.apache.org/jira/browse/CALCITE-4885 . Take a look at FixtureTest [1] to get an idea of how parser, validator, sql-to-rel or rule tests would look in your project. My one concern is that once we

Re: [DISCUSS] Trolls and community

>[2] http://ceki.blogspot.com/2010/05/forces-and-vulnerabilites-of-apache.html ^^ It is a must-read indeed. I wish I read it much earlier than a week ago. Julian, as I see you did not reply to [1]. It implies you ignore my suggestions in that thread, or you think they are worse than what you

Re: Release notes preparation via release-drafter

-1 Please don’t commit anything just yet. Rather than adding tools, can we discuss what’s wrong and right about the current process. > On Dec 22, 2021, at 3:36 AM, Vladimir Sitnikov > wrote: > > Hi, > > I suggest we start using Release Drafter [1] for the preparation of the > release

Re: [DISCUSS] Trolls and community

This is a hard message to respond to. Hopefully my comments will reduce the friction for others to share their own observations. Something that I will reiterate here is that Julian posted this on a public forum which is a request to not only get feedback from committers and PMC members but the

Re: Clean up Metadata type boiler plate and removing generic from MetadataHandler

Hi James, I think it is great that you are pushing this effort forward. I have a few requests: - Can we have detailed discussions around code, etc on Jira instead of the ml? It's really hard to read here and also tends to get lost over time. - If we think we need to make one or more breaking

[DISCUSS] Trolls and community

Hey community, I need your help. You might have noticed that Vladimir and I are fighting it out in a long email thread [1]. I find it stressful and time-consuming to be involved in threads such as this with Vladimir. And I find myself taking out my frustrations on my family. I should not have to

Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)

Hello everyone, thank you Rui for all the work as a release manager! +1 (non-binding): - checked signature and checksum: OK - ./gradlew build (copied gradlew and gradle folder from "master"): OK - visual inspection of uploaded artifacts: OK - release notes: OK (but I agree with the observations

Re: Why not make the "test" namespace public, or move to a separate Maven module that main pulls in as a "testOnly" dependency?

Gavin, Please check sample schemata in https://github.com/apache/calcite/tree/7a7b37fc1f4bd2121643539b0fd8e9c4f0f8ed09/testkit/src/main/java/org/apache/calcite/test/schemata If you find useful schemas, don't hesitate filing a PR to add samples to /testkit/ Vladimir

Why not make the "test" namespace public, or move to a separate Maven module that main pulls in as a "testOnly" dependency?

I am still learning the fundamentals of Calcite's API, and I've found that there are pre-made schemas and other utilities meant for testing inside of the Calcite repo. Unfortunately it seems like a lot of these objects are private, because they aren't meant to be a part of the public API. I've

Re: Release notes preparation via release-drafter

We can’t request our contributor have a good branch name、title with fixed bug or body include this JIRA number when submitting a PR. So If we want it to work, we need The Contributor who merges the PR to confirm this PR has an appropriate label.

Re: Release notes preparation via release-drafter

Looks like I find it : https://github.com/marketplace/actions/release-drafter . Autolabeler Thanks.

Re: Release notes preparation via release-drafter

>I'm afraid this is not accurate. Nothing is accurate, so what do you suggest? Vladimir

Re: Release notes preparation via release-drafter

> Release drafter can automatically add labels based on the filenames. If we add new feature in class and modify the test class to add the feature unit test in one PR. Then the tools can labels this PR is a new feature or fix a bug? I want to know how “automatically” add labels based on the

Re: Release notes preparation via release-drafter

>This is an accurate label ? I just want to confirm. Please rephrase. I don't understand it. Vladimir

Re: Release notes preparation via release-drafter

> Release drafter can automatically add labels based on the filenames. This is an accurate label ? I just want to confirm.

Re: Release notes preparation via release-drafter

>This will request to add another Label to every PR Release drafter can automatically add labels based on the filenames. PRs without labels are still acceptable, so having labels is not a requirement. Vladimir

Re: Release notes preparation via release-drafter

Hi Vladimir, The example results looks very friendly. This will request to add another Label to every PR Then it can auto genarate the release notes. If this can work in Calcite, I am expected. > 2021年12月22日 下午7:36，Vladimir Sitnikov 写道： > > Hi, > > I suggest we start using Release Drafter

Release notes preparation via release-drafter

Hi, I suggest we start using Release Drafter [1] for the preparation of the release notes. I'm going to submit and merge a PR soon, however, I would appreciate it if somebody else would do that (see [2] for a minimal commit) I am sure it would significantly increase the quality of the release

Re: [DISCUSS] Java 16 and 17 support

Julian, Please refrain from insisting that others should follow the manual procedures you create. If you want to have certain manual steps for your own safety, that is fine. However, don't expect the others will be following all the manual steps you invent. I suggest we gather a meetup to

[jira] [Created] (CALCITE-4958) bad performance execute plan when use dynamic parameters in query

hujiahua created CALCITE-4958: - Summary: bad performance execute plan when use dynamic parameters in query Key: CALCITE-4958 URL: https://issues.apache.org/jira/browse/CALCITE-4958 Project: Calcite

Re: Use Calcite to generate queries for different data sources

In the test suite, we use Hook.QUERY_PLAN to add handlers. You could do the same. The Elasticsearch adapter will call the handler with the query. See https://github.com/apache/calcite/blob/4bc916619fd286b2c0cc4d5c653c96a68801d74e/core/src/main/java/org/apache/calcite/runtime/Hook.java#L95

Use Calcite to generate queries for different data sources

Hi, I am new to Apache Calcite and have been exploring it's usage. I wanted to figure out if there is a way to capture the Elasticsearch query generated by Calcite. I see that we can plugin our own optimizers and validators - but wanted to know how to get the final Elasticsearch query that is

Re: [DISCUSS] Java 16 and 17 support

Vladimir, Apparently there *is* a need to raise mail threads. Your comments in https://issues.apache.org/jira/browse/CALCITE-4575 indicated that you were not prepared to accept simple solutions: > If you absolutely want `howto` page to

Re: [DISCUSS] Java 16 and 17 support

>For Gradle upgrades, there’s only one place to modify. Juilan, Are you willing to keep the place updated? If so, there's no need to raise mail threads, please just update it. Vladimir

Re: Introduction and picking an issue

Hi Abhishek, and welcome! We don't use the newbie label systematically [1], so it may be easier to find something by looking at more recent JIRAs. Best, Stamatis [1] https://lists.apache.org/thread/pqnyqyt1w3s7os7ltckjsgqz7f8c0zdt On Tue, Dec 21, 2021 at 2:11 AM Jacques Nadeau wrote: > Hey