Re: [DISCUSS] Drop unused branches from git repos

2023-01-27 Thread Chunwei Lei
+1 for the cleanup. Best, Chunwei On Thu, Jan 26, 2023 at 9:05 AM Benchao Li wrote: > +1, thanks for the effort. > > Sergey Nuyanzin 于2023年1月23日周一 20:02写道: > > > +1 for cleanup > > > > On Mon, Jan 23, 2023 at 9:53 AM Ruben Q L wrote: > > > > > +1 for the cleanup. > > > > > > Best, > > >

Re: [ANNOUNCE] New committer: Istvan Toth

2023-01-27 Thread Chunwei Lei
Congrats and welcome Istvan! Best, Chunwei On Fri, Jan 27, 2023 at 12:58 AM Istvan Toth wrote: > Thanks for the warm welcome to everyone! > > A few words about myself: > > I am from Hungary, and I work for Cloudera. > My focus is Apache Phoenix, and its sub-projects, but I also contribute to

Re: [ANNOUNCE] Benchao Li joins Calcite PMC

2023-01-27 Thread Chunwei Lei
Congrats, Benchao! Best, Chunwei On Fri, Jan 27, 2023 at 9:01 PM Michael Mior wrote: > Congratulations and welcome Benchao! > > -- > Michael Mior > mm...@apache.org > > > On Fri, Jan 27, 2023 at 4:51 AM Stamatis Zampetakis > wrote: > > > I am pleased to announce that Benchao has accepted an

Re: several JavaCC warnings "Choice conflict involving two expansions"

2023-01-27 Thread Julian Hyde
Good catch. Yes, we want to stay on top of these kinds of warnings. (See broken windows theory [1].) Probably introduced by https://issues.apache.org/jira/browse/CALCITE-5450. Probably missing one or two LOOKAHEAD directives in the parser. Can you log a JIRA case please. Julian [1]

Re: [SUPPORT] Semantics change when applying ConverterRule in CheapestPlanReplacer

2023-01-27 Thread Julian Hyde
Done. Let's continue the conversation at CALCITE-5503. On Fri, Jan 27, 2023 at 10:08 AM Moritz Mack wrote: > > Julian, I’ve created CALCITE-5503 as suggested. > > Would you be able to add me as a contributor in Jira and assign the ticket to > me. > I opened a PR with the test case you’ve asked

Re: array literal in spark dialect

2023-01-27 Thread Julian Hyde
Thanks Guillaume. We'd love a fix. I saw you logged https://issues.apache.org/jira/browse/CALCITE-5504 so let's continue the conversation there. On Fri, Jan 27, 2023 at 3:05 PM Guillaume Masse wrote: > > Array literals are unparsed incorrectly for the spark dialect. > > They should be in the

array literal in spark dialect

2023-01-27 Thread Guillaume Masse
Array literals are unparsed incorrectly for the spark dialect. They should be in the form: array(1, 2, 3) However, they are unparsed as ARRAY[1, 2, 3] https://spark.apache.org/docs/latest/api/sql/#array I would be happy to submit a fix, Guillaume

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-27 Thread Julian Hyde
The particular failure I was referring to was this one: > Task :druid:javadoc Picked up _JAVA_OPTIONS: -XX:GCTimeLimit=90 -XX:GCHeapFreeLimit=35 error: Error fetching URL: https://docs.oracle.com/en/java/javase/17/docs/api/ (java.net.SocketException: Connection reset) in the "macOS (JDK

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-27 Thread Alessandro Solimando
Hello, I think that Julian was referring to CALCITE-5501 for the intermittent CI issue, a PR fixing it is now available. I have no problem waiting for the release to be rolled out before merging it, just wanted to reach out to see if you prefer

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-27 Thread Jess Balint
Thanks, will get the release notes PR up shortly. On Thu, Jan 26, 2023 at 7:29 PM Julian Hyde wrote: > I have merged a fix for CALCITE-5489. Thanks to Tanner and TJ for their > help. > > There is one failure in the build, but I'm pretty sure it is > intermittent and is related to CI

[jira] [Created] (CALCITE-5504) Array literals are unparsed incorrectly for the spark dialect

2023-01-27 Thread Jira
Guillaume Massé created CALCITE-5504: Summary: Array literals are unparsed incorrectly for the spark dialect Key: CALCITE-5504 URL: https://issues.apache.org/jira/browse/CALCITE-5504 Project:

Re: [SUPPORT] Semantics change when applying ConverterRule in CheapestPlanReplacer

2023-01-27 Thread Moritz Mack
Julian, I’ve created CALCITE-5503 as suggested. Would you be able to add me as a contributor in Jira and assign the ticket to me. I opened a PR with the test case you’ve asked for and a rather trivial fix. https://github.com/apache/calcite/pull/3050 Thanks, Moritz On 27.01.23, 10:00, "Moritz

[jira] [Created] (CALCITE-5503) Memoize visited nodes in CheapestPlanReplacer

2023-01-27 Thread Moritz Mack (Jira)
Moritz Mack created CALCITE-5503: Summary: Memoize visited nodes in CheapestPlanReplacer Key: CALCITE-5503 URL: https://issues.apache.org/jira/browse/CALCITE-5503 Project: Calcite Issue

Fwd: several JavaCC warnings "Choice conflict involving two expansions"

2023-01-27 Thread Alessandro Solimando
Hello everyone, while checking CI logs I have noticed that we have lots of JavaCC warnings related to ambiguous prefixes in the productions of one of our grammars. They also seem related to time functions, for which I have seen several related developments for BigQuery lately. Have we verified

Re: [ANNOUNCE] Benchao Li joins Calcite PMC

2023-01-27 Thread Michael Mior
Congratulations and welcome Benchao! -- Michael Mior mm...@apache.org On Fri, Jan 27, 2023 at 4:51 AM Stamatis Zampetakis wrote: > I am pleased to announce that Benchao has accepted an invitation to join > the Calcite PMC. Benchao has been a consistent and helpful figure in > the Calcite

Re: [ANNOUNCE] Benchao Li joins Calcite PMC

2023-01-27 Thread Ruben Q L
Congratulations Benchao! You have become a very important and valuable figure in the community. Thanks for your help and your contributions! Best, Ruben On Fri, Jan 27, 2023 at 10:29 AM Sergey Nuyanzin wrote: > Congratulations, Benchao! > > On Fri, Jan 27, 2023 at 11:27 AM Francis Chuang >

Re: [ANNOUNCE] Benchao Li joins Calcite PMC

2023-01-27 Thread Sergey Nuyanzin
Congratulations, Benchao! On Fri, Jan 27, 2023 at 11:27 AM Francis Chuang wrote: > Congrats, Benchao! > > On 27/01/2023 9:26 pm, Alessandro Solimando wrote: > > Congratulations Benchao, very well deserved! > > > > Best regards, > > Alessandro > > > > On Fri, 27 Jan 2023 at 10:51, Stamatis

Re: [ANNOUNCE] Benchao Li joins Calcite PMC

2023-01-27 Thread Francis Chuang
Congrats, Benchao! On 27/01/2023 9:26 pm, Alessandro Solimando wrote: Congratulations Benchao, very well deserved! Best regards, Alessandro On Fri, 27 Jan 2023 at 10:51, Stamatis Zampetakis wrote: I am pleased to announce that Benchao has accepted an invitation to join the Calcite PMC.

Re: [ANNOUNCE] Benchao Li joins Calcite PMC

2023-01-27 Thread Alessandro Solimando
Congratulations Benchao, very well deserved! Best regards, Alessandro On Fri, 27 Jan 2023 at 10:51, Stamatis Zampetakis wrote: > I am pleased to announce that Benchao has accepted an invitation to join > the Calcite PMC. Benchao has been a consistent and helpful figure in > the Calcite

[ANNOUNCE] Benchao Li joins Calcite PMC

2023-01-27 Thread Stamatis Zampetakis
I am pleased to announce that Benchao has accepted an invitation to join the Calcite PMC. Benchao has been a consistent and helpful figure in the Calcite community for which we are very grateful. We look forward to the continued contributions and support. Please join me in congratulating Benchao!

Re: [SUPPORT] Semantics change when applying ConverterRule in CheapestPlanReplacer

2023-01-27 Thread Moritz Mack
Thanks a lot, Julian. I’ll look into that the next few days. /Moritz On 25.01.23, 17:04, "Julian Hyde" wrote: It would seem a reasonable and useful enhancement if CheapestPlanReplacer did some memoization. If it sees the same RelNode twice it should emit the same result. I would be