Re: [Question] Derived type from string expression with NULL parameter

2024-01-16 Thread stanilovsky evgeny
got it, thanks for clarifications. There is no clear spec of what the type should be, so it's hard to say whether this is a bug. The NULL type that is inferred can be interpreted as correct given the context, that expression indeed will evaluate to NULL. It is more specific than VARCHAR,

Re: [Question] Unknown cost calculation/propagation in RelSubsets

2024-01-16 Thread Julian Hyde
Tony, You’re asking about how the Volcano algorithm computes metadata for equivalence classes (what Calcite calls subsets) and to my knowledge it’s not been spelled out explicitly (either in the Volcano/Cascades papers or in Calcite discussions). Calcite needs various kinds of metadata, such

Re: PR 3495 (Make single-row rels unique) Review Request

2024-01-16 Thread Julian Hyde
I merged the PR. Thank you for the contribution! > On Jan 11, 2024, at 12:16 PM, Paul Jackson > wrote: > > I fixed the checker framework problems. One of the last ones - continuous > integration - ran out of memory. Is that flakiness or something I need to fix? > > Thanks, > -Paul > > > On

Re: [Question] Unknown cost calculation/propagation in RelSubsets

2024-01-16 Thread Thomas Rebele
Hello, The RuleMatchVisualizer uses the planner to get the cost [1], and the Volcano planner uses the bestCost attribute for RelSubset [2]. The color depends on the steps: * For intermediate steps, the purple color shows which nodes have been matched by the rule. Light blue shows added nodes. *

Re: Review requests

2024-01-16 Thread Alessandro Solimando
Hello Mihai, not exactly my area of expertise but I will nonetheless take a look in the next few days if nobody gets to it before me, as I agree that this is an important issue and is needed to fix related pending issues (thanks for all your efforts, btw). Best regards, Alessandro On Tue, 16 Jan

[jira] [Created] (CALCITE-6207) Improve JDBC connection resource in JDBCUtils

2024-01-16 Thread xy (Jira)
xy created CALCITE-6207: --- Summary: Improve JDBC connection resource in JDBCUtils Key: CALCITE-6207 URL: https://issues.apache.org/jira/browse/CALCITE-6207 Project: Calcite Issue Type: Improvement