Re: [DISCUSS] Towards Calcite 1.35.0

Hi All, I have prepared the release log in https://github.com/apache/calcite/pull/3315/files . Please review it. If have any questions or advices, please let me know. xiong duan 于2023年7月13日周四 18:25写道： > Hi All, > > The RC build process is starting and therefore the main branch is in code >

Re: [DISCUSS] Towards Calcite 1.35.0

Sorry to miss this message, I just pushed a commit to main ( https://github.com/apache/calcite/commit/91ca42fbccafe044fb122427848a62e4c30a3eea), and I've force-pushed to revert it now. I hope I did not bring any trouble to you. xiong duan 于2023年7月13日周四 18:25写道： > Hi All, > > The RC build

Re: [DISCUSS] Towards Calcite 1.35.0

Hi All, The RC build process is starting and therefore the main branch is in code freeze until further notice. Guillaume Masse 于2023年7月10日周一 22:12写道： > Hi All, > > I did a second pass at named_struct runtime implementation: > https://github.com/apache/calcite/pull/3295 > > The idea is to

Re: [DISCUSS] Towards Calcite 1.35.0

Hi All, I did a second pass at named_struct runtime implementation: https://github.com/apache/calcite/pull/3295 The idea is to branch on the implementation when the runtime structure is not a java class (the item operator would use reflection to fetch the field). In this case, I send to the

Re: [DISCUSS] Towards Calcite 1.35.0

Hi, Developer, I will start the 1.35.0 release process on July 13, 2023. Please feel free to merge the PR before that. Julian Hyde 于2023年7月6日周四 02:34写道： > I’ve been working on a few lint improvements in > https://github.com/julianhyde/calcite/tree/-lint. I’ll merge those in > (rules and

Re: [DISCUSS] Towards Calcite 1.35.0

I’ve been working on a few lint improvements in https://github.com/julianhyde/calcite/tree/-lint. I’ll merge those in (rules and fixes) before the release. > On Jul 5, 2023, at 11:26 AM, Julian Hyde wrote: > > I don’t think CALCITE-5701 (named_struct) is ready. (I had imagined that it >

Re: [DISCUSS] Towards Calcite 1.35.0

I don’t think CALCITE-5701 (named_struct) is ready. (I had imagined that it would be syntactic sugar for ROW. Guillaume’s latest PR adds a new runtime class so that the struct values can be introspected at runtime as beans, and I think that is the wrong path. I’ll add more discussion in the

Re: [DISCUSS] Towards Calcite 1.35.0

[1] Is ready for merging, approvals are obtained. [1] https://github.com/apache/calcite/pull/3211 I finished CALCITE-5701 Add NAMED_STRUCT function (enabled in Spark library) I hope it's not too late for the release: https://github.com/apache/calcite/pull/3295 The CI passes, it just needs

Re: [DISCUSS] Towards Calcite 1.35.0

I finished CALCITE-5701 Add NAMED_STRUCT function (enabled in Spark library) I hope it's not too late for the release: https://github.com/apache/calcite/pull/3295 The CI passes, it just needs a re-run on the last commit. On Fri, Jun 30, 2023 at 5:26 PM Gian Merlino wrote: > Of the open

Re: [DISCUSS] Towards Calcite 1.35.0

Of the open tickets, I reviewed CALCITE-5708 and CALCITE-5727, which are two I felt I understood well enough to review. On 2023/06/28 19:36:16 Julian Hyde wrote: > I have taken care of 1, 2, 3, 4. > > Tanner, can you do 5. > > Of the 12 open issues that are open and have fixVersion = 1.35,

Re: [DISCUSS] Towards Calcite 1.35.0

#5 should be marked as resolved now. I also think I made the mistake of closing issues rather than resolving them in the past, apologies for that. -Tanner On Wed, Jun 28, 2023 at 12:37 PM Julian Hyde wrote: > I have taken care of 1, 2, 3, 4. > > Tanner, can you do 5. > > Of the 12 open issues

Re: [DISCUSS] Towards Calcite 1.35.0

I have taken care of 1, 2, 3, 4. Tanner, can you do 5. Of the 12 open issues that are open and have fixVersion = 1.35, most have PRs ready for review [1]. Can a few committers each take say 3 cases each and review their PRs? Julian [1]

Re: [DISCUSS] Towards Calcite 1.35.0

Hello, Thanks for checking Xiong Duan, I have taken care of 6,7,8. Contributors, please remember that after completing a ticket, the Jira needs to be set to "Resolved", not "Closed" (they will be moved to Closed by the Release Manager, once the next release is produced). Apart from that, our

Re: [DISCUSS] Towards Calcite 1.35.0

In order to release 1.35.0, I reviewed all the fixed issues in this version, Here are some issue statuses that need to be resolved: 1. https://issues.apache.org/jira/browse/CALCITE-5764(The PR has merge.But issue is IN PROGRESS). (Assigine Julian Hyde) 2.

Re: [DISCUSS] Towards Calcite 1.35.0

hi @xiong duan: thanks for your review and merged very much, and i forgot there are also have one pr https://github.com/apache/calcite/pull/3262 do you also have time to have a look？ xiong duan 于2023年6月25日周日 19:45写道： > I have reviewed: > https://github.com/apache/calcite/pull/3238 >

Re: [DISCUSS] Towards Calcite 1.35.0

Hello everyone, I am done reviewing PR#3264 ( CALCITE-5756 ), I will merge within 24 hours if no objections arise. Best regards, Alessandro On Sun, 25 Jun 2023 at 13:45, xiong duan wrote: > I have

Re: [DISCUSS] Towards Calcite 1.35.0

I have reviewed: https://github.com/apache/calcite/pull/3238 https://github.com/apache/calcite/pull/3263 If no other problem, I will merge it tomorrow. Ruben Q L 于2023年6月25日周日 17:20写道： > I'd like to include CALCITE-5789 in 1.35. I'll try to finalize it > today/tomorrow. > > > > El dom, 25 jun

Re: [DISCUSS] Towards Calcite 1.35.0

I'd like to include CALCITE-5789 in 1.35. I'll try to finalize it today/tomorrow. El dom, 25 jun 2023, 6:33, Jacky Lau escribió: > could we review this pr, so that it could be merged in 1.35. then the 1.35 > will almost have the full spark collection function. > I would very appreciate a

Re: [DISCUSS] Towards Calcite 1.35.0

could we review this pr, so that it could be merged in 1.35. then the 1.35 will almost have the full spark collection function. I would very appreciate a review. if someone has time. https://github.com/apache/calcite/pull/3238 https://github.com/apache/calcite/pull/3263 xiong duan

Re: [DISCUSS] Towards Calcite 1.35.0

I have created CALCITE-5797 to release 1.35.0. If there are no objections, I will create an RC in the following days. [1]:https://issues.apache.org/jira/browse/CALCITE-5797 If there are other must fix for 1.35.0 please let us know so that we can plan accordingly. Julian Hyde 于2023年6月24日周六

Re: [DISCUSS] Towards Calcite 1.35.0

We said ‘mid-June’. Time to get this release rolling? > On Jun 20, 2023, at 10:34 PM, Gian Merlino wrote: > > I committed the patch for CALCITE-5477. I would appreciate a review on > CALCITE-5479, if someone has a chance. > > On 2023/06/07 09:53:08 Gian Merlino wrote: >> Some more detail: >>

Re: [DISCUSS] Towards Calcite 1.35.0

I committed the patch for CALCITE-5477. I would appreciate a review on CALCITE-5479, if someone has a chance. On 2023/06/07 09:53:08 Gian Merlino wrote: > Some more detail: > > - the PR for CALCITE-5477 is https://github.com/apache/calcite/pull/3249 > - the PR for CALCITE-5479 is

Re: [DISCUSS] Towards Calcite 1.35.0

Some more detail: - the PR for CALCITE-5477 is https://github.com/apache/calcite/pull/3249 - the PR for CALCITE-5479 is https://github.com/apache/calcite/pull/3030 I've just pushed up some updates to reflect the new approach we discussed for guava backwards-compat in CALCITE-5477, and to sync

Re: [DISCUSS] Towards Calcite 1.35.0

We (Apache Druid) would also like https://issues.apache.org/jira/browse/CALCITE-5479 and https://issues.apache.org/jira/browse/CALCITE-5477 to be fixed in 1.35.0. There are PRs for both of these fixes. We are working on addressing review comments and just need a few days of time. On Thu, Jun 1,

Re: [DISCUSS] Towards Calcite 1.35.0

There's one Jira case we should fix: https://issues.apache.org/jira/browse/CALCITE-5737 (support JDK 19 and 20). Can someone take that on? Julian On 2023/05/30 08:33:23 xiong duan wrote: > Yes. I can release 1.35.0 when the PR is handled. > > Julian Hyde 于2023年5月30日周二 05:46写道： > > >

Re: [DISCUSS] Towards Calcite 1.35.0

Yes. I can release 1.35.0 when the PR is handled. Julian Hyde 于2023年5月30日周二 05:46写道： > Mid-June sounds like a good idea. > > I would like to see the following Jira cases finished: > * 5701 NAMED_STRUCT (MasseGuillaume) > * 5640 SAFE_ADD (DanZou) > * 5625 SEARCH (olivrlee) > * 5626

Re: [DISCUSS] Towards Calcite 1.35.0

Mid-June sounds like a good idea. I would like to see the following Jira cases finished: * 5701 NAMED_STRUCT (MasseGuillaume) * 5640 SAFE_ADD (DanZou) * 5625 SEARCH (olivrlee) * 5626 Fully-qualified names (herunkang2018) * 5615 SQL Logic Test (mbudiu) * 5607 JSON serialization (olivrlee) *

[DISCUSS] Towards Calcite 1.35.0

It's been a bit more than 2 months since our last release [1] and there are currently 80+ new commits in master. As usual, according to our Jira dashboard [2] and Github [3], there are many pending issues that could / should be part of the release. I'd propose to make a collective effort to try