Re: AggregateProjectPullUpConstantsRule not working with the Volcano Planner

2023-08-04 Thread Nick Riasanovsky
Hi Alessandro, The issue that I saw was that getPredicates() for a RelSubset has a section of code that returns an empty list if Bug.CALCITE_1048_FIXED isn't set to True. I thought this was my configuration issue because I am working on a project that isn't using the latest calcite release and I

Re: AggregateProjectPullUpConstantsRule not working with the Volcano Planner

2023-08-04 Thread Alessandro Solimando
Hey Nick, thanks for confirming! If possible, it would be great to share a few more details, like what was the misconfig and how you fixed it (while the symptoms are already described in the first message). Saying this because our dev-list is also part of the project documentation, your example

Re: AggregateProjectPullUpConstantsRule not working with the Volcano Planner

2023-08-03 Thread Nick Riasanovsky
Thank you for your response. There was an issue with my configuration that I was able to resolve. On Thu, Aug 3, 2023 at 4:33 PM Julian Hyde wrote: > The constraints on a RelSubset should be the union of the constraints of > all of the RelNodes in that subset. (I haven’t tested it, or read the

Re: AggregateProjectPullUpConstantsRule not working with the Volcano Planner

2023-08-03 Thread Julian Hyde
The constraints on a RelSubset should be the union of the constraints of all of the RelNodes in that subset. (I haven’t tested it, or read the code. But if it doesn’t do that, you’re probably seeing a bug, or you haven’r configured your metadata providers correctly.) > On Aug 3, 2023, at 9:33

AggregateProjectPullUpConstantsRule not working with the Volcano Planner

2023-08-03 Thread Nick Riasanovsky
Hello everyone, I am attempting to use AggregateProjectPullUpConstantsRule within an optimizer that is using the VolcanoPlanner. When doing so I encounter issues with what should be valid constants on the line `mq.getPulledUpPredicates()` because aggregate.getInput() is a RelSubset. As a result,