Re: How to test new datasource without "in memory/mock" implementation

2020-10-18 Thread Andrei Sereda
I agree with Julian. Not everybody has the option to run docker locally. Perhaps execute tests against embedded (or fake) instance as well as a real one (docker or externally managed) ? Like it is done in MongoDatabasePolicy.java [1] Currently tests for Elasticsearch, Geode and Mongo are all run

Re: How to test new datasource without "in memory/mock" implementation

2020-10-18 Thread Tugdual Grall
Ok I will look more into it On Sun, Oct 18, 2020 at 8:54 AM Julian Hyde wrote: > This would be inconvenient for me personally. My company does not allow me > to run Docker on my work computer. > > Julian > > > On Oct 17, 2020, at 11:31 PM, Tugdual Grall wrote: > > > > Hi > > > > I have

Re: How to test new datasource without "in memory/mock" implementation

2020-10-18 Thread Julian Hyde
This would be inconvenient for me personally. My company does not allow me to run Docker on my work computer. Julian > On Oct 17, 2020, at 11:31 PM, Tugdual Grall wrote: > > Hi > > I have created this PR to share with the community what could be done: > *

Re: How to test new datasource without "in memory/mock" implementation

2020-10-17 Thread Vladimir Sitnikov
Tugdual>Are we "allowed" to use containers in the tests, for example using TestContainers I believe Testcontainers-based tests are more than welcome, however, nobody implemented that yet. It would be great if you could contribute that. Vladimir

Re: How to test new datasource without "in memory/mock" implementation

2020-10-17 Thread Julian Hyde
We need a solution that everyone can use easily. Ideally, contributors to the rest of Calcite - say Calcite core - should not have to spend extra effort, or experience any extra delay or flakiness, in order to verify that they have not broken the Redis adapter. The nearest example we have today

How to test new datasource without "in memory/mock" implementation

2020-10-17 Thread Tugdual Grall
Hello, I am new to the Calcite (at least trying to contribute - I did use it indirectly a lot in Apache Drill ) I would like to enrich the Redis adapter (or create a new one) to support RediSearch ( http://redisearch.io ) since it provides richer features such as secondary indexing, querying and