Re: Progress on adding TUMBLE as table value function (CALCITE-3272)

2019-11-21 Thread Rui Wang
I didn't find such discussion in the SQL standard (maybe I have missed something). My current thought is not to convert "rowtime" to upper-case is the best: 1. for those not column name case-sensitive database, it works. 2. for those case-sensitive database, assume users are aware of their

Re: Progress on adding TUMBLE as table value function (CALCITE-3272)

2019-11-20 Thread Julian Hyde
If I write DESCRIPTOR(rowtime) and I am running Calcite’s parser in a mode that converts unquoted identifiers to upper-case, do you think that it should convert “rowtime” to upper-case? I am undecided. It’s possible that “rowtime” references a column in a case-sensitive database. Julian >

Re: Progress on adding TUMBLE as table value function (CALCITE-3272)

2019-11-20 Thread Rui Wang
Forgot to mention, the DESCRIPTOR support means the following query will be able to run: SELECT * FROM TABLE(Tumble( TABLE ORDERS , DESCRIPTOR(ROWTIME) , INTERVAL '1' MINUTES)) Note that the second parameter to indicate the watermarked column is changed from a string(varchar) to

Re: Progress on adding TUMBLE as table value function (CALCITE-3272)

2019-11-20 Thread Rui Wang
I have an update: I tried to add DESCRIPTOR support (CALCITE-3339). Amazingly it was not complicated at all to have a working version. So I created #1599[1], which is built on top of #1587[2], to demonstrate DESCRIPTOR. The PRs are separated because DESCRIPTOR support currently is less mature.

Progress on adding TUMBLE as table value function (CALCITE-3272)

2019-11-14 Thread Rui Wang
Hi community, I have created a new PR ( https://github.com/apache/calcite/pull/1587) to demonstrate the progress of TUMBLE table value function (CALCITE-3272). Julian suggested me to have a working version that adds a stream.iq and have an enumerable implementation. Those are in the PR. High