Re: Nested join support

2024-01-02 Thread Julian Hyde
What is 'this syntax' you think we should support? (Your query is poorly formatted, so I can't see what pattern in it is confusing the parser.) On Tue, Jan 2, 2024 at 11:46 AM Sean Broeder wrote: > > It looks like Calcite doesn't support the query > > select * from (values (1, 'John')) as > >

[MINOR]

2024-01-02 Thread Julian Hyde
Ralph Waldo Emerson once wrote: “A foolish consistency is the hobgoblin of little minds, adored by little statesmen and philosophers and divines." That said, people tend to bring conventions from other projects to Calcite, and we end up with chaos. By which I mean, lots of self-expression, but no

FilterableTable query planner question

2024-01-02 Thread Eric Berryman
Hello, I'm making a FilterableTable with LDAP as a backend. I noticed in the FilterableTable method: public Enumerable scan(DataContext root, List filters) The filters list is empty if the sql where clause is checking the same field in all tables. ie. select test1.field test2.field from test1

Nested join support

2024-01-02 Thread Sean Broeder
It looks like Calcite doesn't support the query select * from (values (1, 'John')) as "customer"(c_custkey, c_name) left outer join (values(100, 1)) as "orders"(o_orderkey, o_custkey) inner join (values (100, 'Random item')) as "lineitem"(l_orderkey, l_itemname) on o_orderkey = l_orderkey on

Re: [MINOR]

2024-01-02 Thread Tanner Clary
I like the [MINOR] prefix because it makes it easy to identify simple commits (via grep or ctrl+f), the same way [CALCITE-1234] makes it easy to find commits related to [CALCITE-1234]. I also like that it maintains the "[...]" styling at the beginning of the commit message. Neither of these

Re: Nested join support

2024-01-02 Thread Sean Broeder
Thank you for looking at this Julian. To be clear, I’m asking if this statement should be supported or not. I’m not suggesting that it should be. Hopefully this formatting is easier to read: SELECT * FROM ( VALUES (1, 'John')) AS "customer"(c_custkey,

Re: Nested join support

2024-01-02 Thread Julian Hyde
I'll replace the VALUES subqueries with tables and indent to make the intended operator precedence clearer: SELECT * FROM customer LEFT OUTER JOIN orders INNER JOIN lineitem ON o_orderkey = l_orderkey ON c_custkey = o_custkey Since 1.31 [1] we support parenthesized joins,