Re: How to merge pull request in github?

A committer also needs to ensure IP hygiene, make sure that the code builds and tests pass, and make sure that the feature is appropriately "complete" (subjective, but usually involves adequate tests and documentation), and make sure that the contribution is in the best interests of the

[jira] [Created] (CALCITE-1857) Implement CAST for Array

Ankit Singhal created CALCITE-1857: -- Summary: Implement CAST for Array Key: CALCITE-1857 URL: https://issues.apache.org/jira/browse/CALCITE-1857 Project: Calcite Issue Type: Bug

RE: How to merge pull request in github?

But I can't merge other people's pull requests in github, maybe I did not have the rights to commit? Or I think we should comiit pull request to apache git first . not in github . And github can sync patches from apache mirror. -Original Message- From: Jesus Camacho Rodriguez

Re: How to merge pull request in github?

If I understand your question right, you should probably rebase the PR before merging it into master. Then you should add to the commit message the reference to the PR, e.g., Close apache/calcite#xxx, and it will appear as merged. -Jesús On 6/23/17, 10:22 AM, "zhiqiang"

How to merge pull request in github?

Hi all How to merge pull requests in calcite github? I saw all pull request was closed. but not merged in github. All commits can be found in: https://git1-us-west.apache.org/repos/asf?p=calcite.git;a=summary but how to commit codes to apache git? Regards Zhiqiang He