Build failed in Jenkins: Calcite » Calcite-snapshots #317

2023-01-10 Thread Apache Jenkins Server 
See 


Changes:

[Kevin Risden] [CALCITE-5298] CalciteSystemProperty calcite.test.dataset path 
check fails under Java Security Manager


--
[...truncated 296.46 KB...]
at 
org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:163)
at 
org.apache.calcite.avatica.AvaticaStatement.execute(AvaticaStatement.java:217)
at 
org.apache.calcite.test.ServerTest.testVirtualColumnWithFunctions(ServerTest.java:508)
Next exception 1: [CIRCULAR REFERENCE SQLException]
Next exception 2: java.lang.IllegalArgumentException: Method not found: 
execute([class org.apache.calcite.sql.SqlNode, interface 
org.apache.calcite.jdbc.CalcitePrepare$Context])
at 
org.apache.calcite.util.ReflectUtil$2.lookupMethod(ReflectUtil.java:563)
at 
org.apache.calcite.util.ReflectUtil$2.invoke(ReflectUtil.java:527)
at 
org.apache.calcite.server.DdlExecutorImpl.executeDdl(DdlExecutorImpl.java:41)
at 
org.apache.calcite.prepare.CalcitePrepareImpl.executeDdl(CalcitePrepareImpl.java:372)
at 
org.apache.calcite.prepare.CalcitePrepareImpl.prepare2_(CalcitePrepareImpl.java:638)
at 
org.apache.calcite.prepare.CalcitePrepareImpl.prepare_(CalcitePrepareImpl.java:517)
at 
org.apache.calcite.prepare.CalcitePrepareImpl.prepareSql(CalcitePrepareImpl.java:487)
at 
org.apache.calcite.jdbc.CalciteConnectionImpl.parseQuery(CalciteConnectionImpl.java:236)
at 
org.apache.calcite.jdbc.CalciteMetaImpl.prepareAndExecute(CalciteMetaImpl.java:623)
at 
org.apache.calcite.avatica.AvaticaConnection.prepareAndExecuteInternal(AvaticaConnection.java:677)
at 
org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:156)
... 2 more
Caused by: [CIRCULAR REFERENCE IllegalArgumentException]

FAILURE   4.3sec, 
org.apache.calcite.test.ServerTest > testCreateFunction()
java.sql.SQLException: Error while executing SQL "create schema s": Method 
not found: execute([class org.apache.calcite.sql.SqlNode, interface 
org.apache.calcite.jdbc.CalcitePrepare$Context])
at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
at 
org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:163)
at 
org.apache.calcite.avatica.AvaticaStatement.execute(AvaticaStatement.java:217)
at 
org.apache.calcite.test.ServerTest.testCreateFunction(ServerTest.java:229)
Next exception 1: [CIRCULAR REFERENCE SQLException]
Next exception 2: java.lang.IllegalArgumentException: Method not found: 
execute([class org.apache.calcite.sql.SqlNode, interface 
org.apache.calcite.jdbc.CalcitePrepare$Context])
at 
org.apache.calcite.util.ReflectUtil$2.lookupMethod(ReflectUtil.java:563)
at 
org.apache.calcite.util.ReflectUtil$2.invoke(ReflectUtil.java:527)
at 
org.apache.calcite.server.DdlExecutorImpl.executeDdl(DdlExecutorImpl.java:41)
at 
org.apache.calcite.prepare.CalcitePrepareImpl.executeDdl(CalcitePrepareImpl.java:372)
at 
org.apache.calcite.prepare.CalcitePrepareImpl.prepare2_(CalcitePrepareImpl.java:638)
at 
org.apache.calcite.prepare.CalcitePrepareImpl.prepare_(CalcitePrepareImpl.java:517)
at 
org.apache.calcite.prepare.CalcitePrepareImpl.prepareSql(CalcitePrepareImpl.java:487)
at 
org.apache.calcite.jdbc.CalciteConnectionImpl.parseQuery(CalciteConnectionImpl.java:236)
at 
org.apache.calcite.jdbc.CalciteMetaImpl.prepareAndExecute(CalciteMetaImpl.java:623)
at 
org.apache.calcite.avatica.AvaticaConnection.prepareAndExecuteInternal(AvaticaConnection.java:677)
at 
org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:156)
... 2 more
Caused by: [CIRCULAR REFERENCE IllegalArgumentException]

  4.5sec, org.apache.calcite.test.ServerTest > 
testDropFunction()
  4.6sec, org.apache.calcite.test.ServerTest > 
testDropWithFullyQualifiedNameWhenSchemaDoesntExist()
  4.5sec, org.apache.calcite.test.ServerTest > 
testDropType()
  5.5sec, org.apache.calcite.test.ServerTest > 
testStatement()
  5.4sec, org.apache.calcite.test.ServerTest > 
testCreateType()
  5.4sec, org.apache.calcite.test.ServerTest > 
testInsertCreateNewCompositeUdt()
  5.6sec, org.apache.calcite.test.ServerTest >

Re: [ANNOUNCE] New committer: Alex Plehanov

2023-01-10 Thread Andrei Sereda 
Welcome, Alex!

On Tue, Jan 10, 2023, 11:01 Stamatis Zampetakis  wrote:

> Welcome Alex! Looking forward to working with you.
>
> Best,
> Stamatis
>
> On Tue, Jan 10, 2023 at 2:48 AM Chunwei Lei 
> wrote:
>
> > Welcome, Alex!
> >
> >
> > Best,
> > Chunwei
> >
> >
> > On Sun, Jan 8, 2023 at 3:59 PM Alex Plehanov 
> > wrote:
> >
> > > Hello,
> > >
> > > Thanks for the warm welcome! A couple of words about myself: In Apache
> > > Ignite we are developing the new SQL engine (based on Apache Calcite)
> as
> > a
> > > replacement for the old SQL engine. The old engine has some
> > > fundamental limitations which we can resolve with the help of Calcite.
> I
> > am
> > > one of the major contributors to this part of the Apache Ignite. The
> new
> > > SQL engine was first released with Ignite 2.13 (2022-04-26) but still
> in
> > > beta status. Our primary goal now - make it production ready.
> > >
> > > сб, 7 янв. 2023 г. в 08:45, Benchao Li :
> > >
> > > > Congratulations, Alex!
> > > >
> > > > Francis Chuang  于2023年1月7日周六 09:51写道：
> > > >
> > > > > Congrats, Alex!
> > > > >
> > > > > On 7/01/2023 5:17 am, Michael Mior wrote:
> > > > > > Welcome Alex!
> > > > > >
> > > > > > --
> > > > > > Michael Mior
> > > > > > mm...@apache.org
> > > > > >
> > > > > >
> > > > > > On Fri, Jan 6, 2023 at 6:04 AM Ruben Q L 
> > wrote:
> > > > > >
> > > > > >> Apache Calcite's Project Management Committee (PMC) has invited
> > Alex
> > > > > >> Plehanov to become a committer, and we are pleased to announce
> > that
> > > he
> > > > > has
> > > > > >> accepted the invitation.
> > > > > >>
> > > > > >> Alex is an Apache Ignite PMC member and the main author of the
> > > > > >> ignite-calcite module. He has done significant contributions on
> > > > Calcite,
> > > > > >> especially fixing bugs detected by Ignite.
> > > > > >>
> > > > > >> Alex, welcome, thank you for your contributions, and we look
> > forward
> > > > to
> > > > > >> your further interactions with the community! If you wish,
> please
> > > feel
> > > > > free
> > > > > >> to tell us a bit more about yourself and what you are currently
> > > > working
> > > > > on.
> > > > > >> As your first commit, you can add yourself to the contributors
> > list
> > > > [1]
> > > > > and
> > > > > >> the community page will re-generate [2].
> > > > > >>
> > > > > >> Ruben (on behalf of the Apache Calcite PMC)
> > > > > >>
> > > > > >> [1]
> > > > > >>
> > > >
> > https://github.com/apache/calcite/blob/main/site/_data/contributors.yml
> > > > > >> [2] https://calcite.apache.org/community/#project-members
> > > > > >>
> > > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > >
> > > > Best,
> > > > Benchao Li
> > > >
> > >
> >
>

Re: [ANNOUNCE] New committer: Alex Plehanov

2023-01-10 Thread Stamatis Zampetakis 
Welcome Alex! Looking forward to working with you.

Best,
Stamatis

On Tue, Jan 10, 2023 at 2:48 AM Chunwei Lei  wrote:

> Welcome, Alex!
>
>
> Best,
> Chunwei
>
>
> On Sun, Jan 8, 2023 at 3:59 PM Alex Plehanov 
> wrote:
>
> > Hello,
> >
> > Thanks for the warm welcome! A couple of words about myself: In Apache
> > Ignite we are developing the new SQL engine (based on Apache Calcite) as
> a
> > replacement for the old SQL engine. The old engine has some
> > fundamental limitations which we can resolve with the help of Calcite. I
> am
> > one of the major contributors to this part of the Apache Ignite. The new
> > SQL engine was first released with Ignite 2.13 (2022-04-26) but still in
> > beta status. Our primary goal now - make it production ready.
> >
> > сб, 7 янв. 2023 г. в 08:45, Benchao Li :
> >
> > > Congratulations, Alex!
> > >
> > > Francis Chuang  于2023年1月7日周六 09:51写道：
> > >
> > > > Congrats, Alex!
> > > >
> > > > On 7/01/2023 5:17 am, Michael Mior wrote:
> > > > > Welcome Alex!
> > > > >
> > > > > --
> > > > > Michael Mior
> > > > > mm...@apache.org
> > > > >
> > > > >
> > > > > On Fri, Jan 6, 2023 at 6:04 AM Ruben Q L 
> wrote:
> > > > >
> > > > >> Apache Calcite's Project Management Committee (PMC) has invited
> Alex
> > > > >> Plehanov to become a committer, and we are pleased to announce
> that
> > he
> > > > has
> > > > >> accepted the invitation.
> > > > >>
> > > > >> Alex is an Apache Ignite PMC member and the main author of the
> > > > >> ignite-calcite module. He has done significant contributions on
> > > Calcite,
> > > > >> especially fixing bugs detected by Ignite.
> > > > >>
> > > > >> Alex, welcome, thank you for your contributions, and we look
> forward
> > > to
> > > > >> your further interactions with the community! If you wish, please
> > feel
> > > > free
> > > > >> to tell us a bit more about yourself and what you are currently
> > > working
> > > > on.
> > > > >> As your first commit, you can add yourself to the contributors
> list
> > > [1]
> > > > and
> > > > >> the community page will re-generate [2].
> > > > >>
> > > > >> Ruben (on behalf of the Apache Calcite PMC)
> > > > >>
> > > > >> [1]
> > > > >>
> > >
> https://github.com/apache/calcite/blob/main/site/_data/contributors.yml
> > > > >> [2] https://calcite.apache.org/community/#project-members
> > > > >>
> > > > >
> > > >
> > >
> > >
> > > --
> > >
> > > Best,
> > > Benchao Li
> > >
> >
>

Re: [DISCUSS] Code quality/coverage with SonarCloud & JaCoCo

2023-01-10 Thread Stamatis Zampetakis 
Thanks for the feedback!

I would like to stretch the fact that at this point it is at the discretion
of the reviewer/committer to enforce or ignore the information provided by
Sonar.

Sonar, as other similar systems, has limitations thus there are always
going to be false positives. The rules/checks performed are fully
customisable so we can enable/disable them at will.

The two issues highlighted by Julian seem like true positives to me.
* The "New code" that was introduced recently is not covered sufficiently
by tests and that's a fact. Part of the problem seems to come from the
recent modifications in SqlOperatorTest [1]. The class is located under
src/main (and not under src/test) so it is considered as a production class
and coverage checks are applied. There are ways to exclude certain paths
from coverage but I would argue that the class shouldn't be there in the
first place; we should probably log a CALCITE ticket for moving out of
there.
* The instance of warning is something that we probably don't want/cannot
fix (for the reasons mentioned in the PR) but Sonar did well to bring this
up; it is problematic to do comparisons by relying on the class name.

I encourage others to share their thoughts/remarks as well so that we
improve as much as possible the developer experience.

Best,
Stamatis

[1]
https://github.com/apache/calcite/blob/be7135cf1fd3d87e4036b2dd6e58d2f1251f8959/testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java

On Tue, Jan 10, 2023 at 1:38 AM Julian Hyde  wrote:

> I see two false positives so far:
>  * The message on be7135cf "58.1% Coverage on New Code (is less than 80%)"
>  * The bug on PR 2942 "Use an "instanceof" comparison instead"
>
> Has Sonarcube had any true positives yet?
>
> Vladimir used to hate when I was skeptical of changes to the build
> system. But I have no tolerance for a lint system that makes extra
> work.
>
> Julian
>
>
>
>
> On Mon, Jan 9, 2023 at 2:46 PM Francis Chuang 
> wrote:
> >
> > Thanks for implementing this, Stamatis! Having code quality metrics on
> > our repos is a huge win.
> >
> > Francis
> >
> > On 10/01/2023 4:22 am, Stamatis Zampetakis wrote:
> > > I just merged the CALCITE-5427 [1] enabling Sonarcloud analysis for
> Calcite
> > > main branch and new PRs.
> > >
> > > I have left the default Sonar quality gates active so you may start
> seeing
> > > Sonar reporting errors in various cases.
> > >
> > > If you encounter problems or you would like things to work differently
> > > please create JIRA tickets and ping me if you need help.
> > >
> > > Once we are happy with how things work for Calcite we can also port the
> > > changes to Avatica.
> > >
> > > Note that all Calcite committers have administrative privileges to the
> > > Calcite project in Sonarcloud [2].
> > >
> > > Best,
> > > Stamatis
> > >
> > > [1]
> > >
> https://github.com/apache/calcite/commit/be7135cf1fd3d87e4036b2dd6e58d2f1251f8959
> > > [2] https://sonarcloud.io/project/roles?id=apache_calcite
> > >
> > > On Wed, Jan 4, 2023 at 5:44 PM Stamatis Zampetakis 
> > > wrote:
> > >
> > >> The integration is advancing well and I am hoping to merge the PR in
> the
> > >> coming days.
> > >> To avoid unpleasant surprises, I am planning to create a new remote
> branch
> > >> in the main calcite repo to test some things out. I will delete it as
> soon
> > >> as I am done with the tests.
> > >>
> > >> Best.
> > >> Stamatis
> > >>
> > >> On Wed, Dec 28, 2022 at 2:47 PM Michael Mior 
> wrote:
> > >>
> > >>> Thanks Stamatis! I haven't used SonarCloud before, but in general I
> think
> > >>> such tools can be quite useful.
> > >>>
> > >>> --
> > >>> Michael Mior
> > >>> mm...@apache.org
> > >>>
> > >>>
> > >>> On Sat, Dec 24, 2022 at 4:01 PM Stamatis Zampetakis <
> zabe...@gmail.com>
> > >>> wrote:
> > >>>
> >  Since there were no objections, I just logged INFRA-24038 [1] and
> plan
> > >>> to
> >  move this forward.
> > 
> >  Let me know if you have questions or concerns regarding the
> adoption of
> >  SonarCloud.
> > 
> >  Best,
> >  Stamatis
> > 
> >  [1] https://issues.apache.org/jira/browse/INFRA-24038
> > 
> >  On Sat, Dec 10, 2022 at 11:32 AM Benchao Li 
> > >>> wrote:
> > 
> > > Thanks Stamatis for bringing this up.
> > >
> > > I haven't used Sonar yet, but thanks for the demo[1] you provided,
> it
> >  looks
> > > really interesting. I think it's worth a try for Calcite.
> > >
> > > [1] https://github.com/zabetak/calcite/pull/9
> > >
> > > Alessandro Solimando 
> 于2022年12月10日周六
> > > 02:54写道：
> > >
> > >> Hi all,
> > >> thanks Stamatis for the proposal and the work, I am a huge fan of
> > >>> Sonar
> > > and
> > >> I really miss it on Calcite, so a big +1 from me on this.
> > >>
> > >> In Hive so far we have received good feedback, so I hope it will
> be
> > >> welcomed here too.
> > >>
> > >> Best regards,
> > >> Alessandro
> >