There's one other thing that I would personally find helpful. When a
committer is reviewing a PR, I propose assigning it to yourself on
GitHub. This serves two functions: 1) it makes it clear that someone
has taken responsibility for the PR, and 2) it lets you easily go back
and look at PRs you
Two things that we are doing that are working:
* Use the “pull-request-available” tag for JIRA cases;
* Beat down the number of open cases with the “pull-request-available” tag in
the lead up to the release.
Let’s continue doing these.
Shall we agree a target of number of open cases with
As of now, the open PRs and Calcite JIRAs are close enough to matching (96
vs 98). (There are a few for Avatica in the JIRA query). Thanks all those
that helped clean up.
Kevin Risden
On Thu, Feb 28, 2019 at 4:21 PM Kevin Risden wrote:
> One thing that I think would help is to add a Github PR
One thing that I think would help is to add a Github PR template [1]. We
did this for Apache Knox to help make sure that PRs follow some simple
guidelines. After the gitbox migration, PRs are automatically linked to
JIRA (which is good). I think we just had some PRs prior to gitbox
migration that
Francis> Our problem is mainly due to PRs not being reviewed.
Once upon a time I did try to pass over the PRs, and I added some randoms
here and there.
I'm not sure what others think of that, however we have:
17 "returned-with-feedback":
Julian,
Overall, I agree with you Julian and Francis. Ideally, we would find
the resources among committers to review all PRs. My +1 for the bot
mainly came from a desire to keep the list of open PRs as ones which
are actively being worked on. Perhaps many of the same goals would be
accomplished
I am also -1 on the bot per the reasons Julian has stated.
Our problem is mainly due to PRs not being reviewed. I think an
extension to the problem is that because PRs take a while to be
reviewed, contributors sometime lose context (and can't find time to
realign themselves with the current
-1 Using a robot to close stale PRs is solving the wrong problem.
The main reason that we have a lot of open PRs is that we - as a community of
committers - are not putting sufficient time into reviewing. I think that we
are giving PR submitters poor service, and they are being very patient
Thanks Kevin! That's an important task and one that few people are
willing to take on :)
And thanks Hongze for the pointer to Stale. Especially since other
Apache project are already using it, I'd be inclined to have a
discussion on the appropriate configuration and give it a go.
Personally, I
Good job Kevin! Hope to see a cleaner PR lists.
new life!
在 2019年2月28日 +0800 AM3:36，dev@calcite.apache.org，写道：
>
> Good idea Kevin!
There is a Github robot "Stale"[1][2] for closing inactive PRs automatically.
Below are some Apache projects already using it:
1. https://github.com/apache/incubator-druid/blob/master/.github/stale.yml
2. https://github.com/apache/airflow/blob/master/.github/stale.yml
3.
Thanks!
Kevin Risden
On Wed, Feb 27, 2019, 17:55 Stamatis Zampetakis wrote:
> I also went over the third page [1]. I am leaving the rest (first and
> second) to somebody else :)
>
> [1] https://github.com/apache/calcite/pulls?page=3=is%3Apr+is%3Aopen
>
> Στις Πέμ, 28 Φεβ 2019 στις 12:03 π.μ.,
I also went over the third page [1]. I am leaving the rest (first and
second) to somebody else :)
[1] https://github.com/apache/calcite/pulls?page=3=is%3Apr+is%3Aopen
Στις Πέμ, 28 Φεβ 2019 στις 12:03 π.μ., ο/η Stamatis Zampetakis <
zabe...@gmail.com> έγραψε:
> Good idea Kevin!
>
> I will give
Good idea Kevin!
I will give you a hand. I will go over the fourth page [1] of pull requests
right now.
[1] https://github.com/apache/calcite/pulls?page=4=is%3Apr+is%3Aopen
Στις Τετ, 27 Φεβ 2019 στις 11:13 μ.μ., ο/η Julian Hyde
έγραψε:
> +999!
>
> > On Feb 27, 2019, at 1:29 PM, Francis Chuang
+999!
> On Feb 27, 2019, at 1:29 PM, Francis Chuang wrote:
>
> Thanks for jumping on this, Kevin!
>
> On 28/02/2019 6:36 am, Kevin Risden wrote:
>> There are 105 open pull requests against apache/calcite repo [1]. There are
>> only 48 Calcite JIRAs labeled with pull-request-available [2].
>>
Thanks for jumping on this, Kevin!
On 28/02/2019 6:36 am, Kevin Risden wrote:
There are 105 open pull requests against apache/calcite repo [1]. There are
only 48 Calcite JIRAs labeled with pull-request-available [2].
I'm planning to go through in the next few days and make sure that we have
There are 105 open pull requests against apache/calcite repo [1]. There are
only 48 Calcite JIRAs labeled with pull-request-available [2].
I'm planning to go through in the next few days and make sure that we have
PRs that match open JIRAs and are labeled pull-request-available. If there
are PRs
17 matches
Mail list logo
