[GitHub] [camel-k] lburgazzoli commented on a diff in pull request #3163: operator: allow to configure the lock name

2022-04-04 Thread GitBox
lburgazzoli commented on code in PR #3163: URL: https://github.com/apache/camel-k/pull/3163#discussion_r841490794 ## pkg/cmd/operator.go: ## @@ -40,16 +41,18 @@ func newCmdOperator() (*cobra.Command, *operatorCmdOptions) { cmd.Flags().Int32("health-port", 8081, "The

[GitHub] [camel-k] squakez commented on a diff in pull request #3163: operator: allow to configure the lock name

2022-04-04 Thread GitBox
squakez commented on code in PR #3163: URL: https://github.com/apache/camel-k/pull/3163#discussion_r841464986 ## pkg/cmd/operator.go: ## @@ -40,16 +41,18 @@ func newCmdOperator() (*cobra.Command, *operatorCmdOptions) { cmd.Flags().Int32("health-port", 8081, "The port

[GitHub] [camel-k] astefanutti commented on a diff in pull request #3163: operator: allow to configure the lock name

2022-04-04 Thread GitBox
astefanutti commented on code in PR #3163: URL: https://github.com/apache/camel-k/pull/3163#discussion_r841459428 ## pkg/cmd/operator.go: ## @@ -40,16 +41,18 @@ func newCmdOperator() (*cobra.Command, *operatorCmdOptions) { cmd.Flags().Int32("health-port", 8081, "The

[GitHub] [camel-k] astefanutti commented on a diff in pull request #3158: Disable deprecate linters

2022-04-04 Thread GitBox
astefanutti commented on code in PR #3158: URL: https://github.com/apache/camel-k/pull/3158#discussion_r841442770 ## .golangci.yml: ## @@ -50,9 +52,13 @@ linters: - paralleltest - tagliatelle - tenv +- scopelint - testpackage - varnamelen -

[GitHub] [camel] davsclaus commented on a diff in pull request #7336: CAMEL-17885 camel google bigquery: Allow to read service account key file from resolver

2022-04-03 Thread GitBox
davsclaus commented on code in PR #7336: URL: https://github.com/apache/camel/pull/7336#discussion_r841368425 ## components/camel-google/camel-google-bigquery/src/main/java/org/apache/camel/component/google/bigquery/GoogleBigQueryConfiguration.java: ## @@ -16,29 +16,39 @@ */

[GitHub] [camel-k] tadayosi commented on a diff in pull request #3159: added trait example of services

2022-04-03 Thread GitBox
tadayosi commented on code in PR #3159: URL: https://github.com/apache/camel-k/pull/3159#discussion_r841355003 ## examples/traits/service/service.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license

[GitHub] [camel-k] tadayosi commented on a diff in pull request #3152: Example to show usage of prometheus trait

2022-04-03 Thread GitBox
tadayosi commented on code in PR #3152: URL: https://github.com/apache/camel-k/pull/3152#discussion_r841343432 ## examples/traits/prometheus/README.md: ## @@ -0,0 +1,19 @@ +# Camel K Prometheus Trait + +In this section you will find examples about fine tuning your `Integration`

[GitHub] [camel-k] tadayosi commented on a diff in pull request #3152: Example to show usage of prometheus trait

2022-04-03 Thread GitBox
tadayosi commented on code in PR #3152: URL: https://github.com/apache/camel-k/pull/3152#discussion_r841339359 ## Hello.java: ## @@ -0,0 +1,17 @@ +// camel-k: language=java Review Comment: I think this one is a leftover. Please remove it from your PR. -- This is an

[GitHub] [camel-kamelets] nicolaferraro opened a new pull request #8: chore: avoid spamming the dev mailing list (from next time)

2021-02-16 Thread GitBox
nicolaferraro opened a new pull request #8: URL: https://github.com/apache/camel-kamelets/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [camel-kamelets] nicolaferraro merged pull request #7: Fix links in documentation

2021-02-16 Thread GitBox
nicolaferraro merged pull request #7: URL: https://github.com/apache/camel-kamelets/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [camel-kamelets] nicolaferraro opened a new pull request #7: Fix links in documentation

2021-02-16 Thread GitBox
nicolaferraro opened a new pull request #7: URL: https://github.com/apache/camel-kamelets/pull/7 This fixes the links to Camel K installation and removes the unneeded tree node in left menu. This is an automated message

[GitHub] [camel-kamelets] nicolaferraro merged pull request #6: chore: fix generated YAML and required props

2021-02-16 Thread GitBox
nicolaferraro merged pull request #6: URL: https://github.com/apache/camel-kamelets/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [camel-kamelets] davsclaus commented on pull request #6: chore: fix generated YAML and required props

2021-02-16 Thread GitBox
davsclaus commented on pull request #6: URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779737440 > > > btw is the source code generated list of options in the same order as in the yaml file (eg so users may put the most important in the top). > > > > > > Well,

[GitHub] [camel-kamelets] nicolaferraro edited a comment on pull request #6: chore: fix generated YAML and required props

2021-02-16 Thread GitBox
nicolaferraro edited a comment on pull request #6: URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779733631 > > btw is the source code generated list of options in the same order as in the yaml file (eg so users may put the most important in the top). > > Well,

[GitHub] [camel-kamelets] nicolaferraro commented on pull request #6: chore: fix generated YAML and required props

2021-02-16 Thread GitBox
nicolaferraro commented on pull request #6: URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779733631 > > btw is the source code generated list of options in the same order as in the yaml file (eg so users may put the most important in the top). > > Well, currently

[GitHub] [camel-kamelets] nicolaferraro commented on pull request #6: chore: fix generated YAML and required props

2021-02-16 Thread GitBox
nicolaferraro commented on pull request #6: URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779733093 > btw is the source code generated list of options in the same order as in the yaml file (eg so users may put the most important in the top). Well, currently it

[GitHub] [camel-kamelets] davsclaus commented on pull request #6: chore: fix generated YAML and required props

2021-02-16 Thread GitBox
davsclaus commented on pull request #6: URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779710972 btw is the source code generated list of options in the same order as in the yaml file (eg so users may put the most important in the top).

[GitHub] [camel-kamelets] nicolaferraro opened a new pull request #6: chore: fix generated YAML and required props

2021-02-16 Thread GitBox
nicolaferraro opened a new pull request #6: URL: https://github.com/apache/camel-kamelets/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [camel-kamelets] nicolaferraro merged pull request #2: Auto-generate the Kamelet Catalog website

2021-02-15 Thread GitBox
nicolaferraro merged pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [camel-kamelets] nicolaferraro commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-15 Thread GitBox
nicolaferraro commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-779311323 Let's merge this to unlock: https://github.com/apache/camel-website/pull/536 This is an automated

[GitHub] [camel-kamelets] nicolaferraro merged pull request #5: Added ASF Yaml configuration

2021-02-15 Thread GitBox
nicolaferraro merged pull request #5: URL: https://github.com/apache/camel-kamelets/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [camel-kamelets] oscerd opened a new pull request #5: Added ASF Yaml configuration

2021-02-15 Thread GitBox
oscerd opened a new pull request #5: URL: https://github.com/apache/camel-kamelets/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [camel-kamelets] nicolaferraro merged pull request #4: chore: add some kamelets from existing examples

2021-02-15 Thread GitBox
nicolaferraro merged pull request #4: URL: https://github.com/apache/camel-kamelets/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [camel-kamelets] nicolaferraro opened a new pull request #4: chore: add some kamelets from existing examples

2021-02-15 Thread GitBox
nicolaferraro opened a new pull request #4: URL: https://github.com/apache/camel-kamelets/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [camel-kamelets] nicolaferraro merged pull request #3: chore: add CI configuration

2021-02-15 Thread GitBox
nicolaferraro merged pull request #3: URL: https://github.com/apache/camel-kamelets/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [camel-kamelets] nicolaferraro commented on pull request #3: chore: add CI configuration

2021-02-15 Thread GitBox
nicolaferraro commented on pull request #3: URL: https://github.com/apache/camel-kamelets/pull/3#issuecomment-779085842 Let's merge this to enable actions This is an automated message from the Apache Git Service. To respond

[GitHub] [camel-kamelets] nicolaferraro opened a new pull request #3: chore: add CI configuration

2021-02-12 Thread GitBox
nicolaferraro opened a new pull request #3: URL: https://github.com/apache/camel-kamelets/pull/3 This should setup a CI based on Github actions. I've added the test for the timer-source Kamelet. We should find a good solution for easily manage credentials before we can test the

[GitHub] [camel-kamelets] zregvart commented on a change in pull request #2: Auto-generate the Kamelet Catalog website

2021-02-12 Thread GitBox
zregvart commented on a change in pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#discussion_r575317959 ## File path: docs/generator/generator.go ## @@ -0,0 +1,307 @@ +package main + +import ( + "encoding/base64" + "fmt" + "io/ioutil" +

[GitHub] [camel-kamelets] zregvart commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-12 Thread GitBox
zregvart commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-778164854 I've created a PR to polish this against this PR: https://github.com/nicolaferraro/camel-kamelets/pull/1

[GitHub] [camel-kamelets] nicolaferraro commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-11 Thread GitBox
nicolaferraro commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777845389 > I'd like to polish this a bit, either as a PR on top of this PR (preferred) or as a followup PR. You're welcome to do so. Look also at

[GitHub] [camel-kamelets] zregvart commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-11 Thread GitBox
zregvart commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-15643 I'd like to polish this a bit, either as a PR on top of this PR (preferred) or as a followup PR. This is an

[GitHub] [camel-kamelets] nicolaferraro commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-11 Thread GitBox
nicolaferraro commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777409589 > > > @nicolaferraro perhaps you can start a pull request with the changes needed to the website on the website repository. Not sure what's to gain by adding those

[GitHub] [camel-kamelets] zregvart commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-11 Thread GitBox
zregvart commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777395928 > > @nicolaferraro perhaps you can start a pull request with the changes needed to the website on the website repository. Not sure what's to gain by adding those changes

[GitHub] [camel-kamelets] astefanutti commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-11 Thread GitBox
astefanutti commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777369635 Gorgeous ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [camel-kamelets] nicolaferraro commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-11 Thread GitBox
nicolaferraro commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777369043 > @nicolaferraro perhaps you can start a pull request with the changes needed to the website on the website repository. Not sure what's to gain by adding those changes

[GitHub] [camel-kamelets] zregvart commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-11 Thread GitBox
zregvart commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777359493 @nicolaferraro perhaps you can start a pull request with the changes needed to the website on the website repository. Not sure what's to gain by adding those changes here. Is

[GitHub] [camel-kamelets] lburgazzoli commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-11 Thread GitBox
lburgazzoli commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777351133 > > random thought: > > > > * we should probably have some way of grouping kamelets, i.e. there may be a number of telegram related kamelets > > * we shold think

[GitHub] [camel-kamelets] nicolaferraro commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-11 Thread GitBox
nicolaferraro commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777347111 > I'm not sure if it makes sense to have the same ui we are using on the camel website, just for visual identity, btw we need @zregvart to include it. Yeah, this

[GitHub] [camel-kamelets] oscerd commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-11 Thread GitBox
oscerd commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777344312 I'm not sure if it makes sense to have the same ui we are using on the camel website, just for visual identity, btw we need @zregvart to include it.

[GitHub] [camel-kamelets] nicolaferraro commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-11 Thread GitBox
nicolaferraro commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777343441 > random thought: > > * we should probably have some way of grouping kamelets, i.e. there may be a number of telegram related kamelets > * we shold think about

[GitHub] [camel-kamelets] lburgazzoli commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-11 Thread GitBox
lburgazzoli commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777338534 random thought: - we should probably have some way of grouping kamelets, i.e. there may be a number of telegram related kamelets - we shold think about versioning

[GitHub] [camel-kamelets] oscerd commented on pull request #2: Auto-generate the Kamelet Catalog website

2021-02-11 Thread GitBox
oscerd commented on pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777337272 We need @zregvart for including this somewhere in the website. This is an automated message from the Apache Git

[GitHub] [camel-kamelets] nicolaferraro opened a new pull request #2: Auto-generate the Kamelet Catalog website

2021-02-11 Thread GitBox
nicolaferraro opened a new pull request #2: URL: https://github.com/apache/camel-kamelets/pull/2 This generates an Antora module for the Kamelet catalog directly from the Kamelet YAML files. cc: @davsclaus , @oscerd , @astefanutti , @squakez , @doru1004 , @lburgazzoli, @christophd

[GitHub] [camel-kamelets] nicolaferraro merged pull request #1: Initial rules about the catalog

2021-02-10 Thread GitBox
nicolaferraro merged pull request #1: URL: https://github.com/apache/camel-kamelets/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [camel-kamelets] nicolaferraro commented on a change in pull request #1: Initial rules about the catalog

2021-02-08 Thread GitBox
nicolaferraro commented on a change in pull request #1: URL: https://github.com/apache/camel-kamelets/pull/1#discussion_r571967885 ## File path: README.md ## @@ -1,6 +1,126 @@ -# Apache Camel - Kamelet Repository +# Apache Camel - Kamelet Catalog -This repository contains

[GitHub] [camel-kamelets] davsclaus commented on a change in pull request #1: Initial rules about the catalog

2021-02-08 Thread GitBox
davsclaus commented on a change in pull request #1: URL: https://github.com/apache/camel-kamelets/pull/1#discussion_r571942138 ## File path: README.md ## @@ -1,6 +1,126 @@ -# Apache Camel - Kamelet Repository +# Apache Camel - Kamelet Catalog -This repository contains the

[GitHub] [camel-kamelets] nicolaferraro opened a new pull request #1: Initial rules about the catalog

2021-02-08 Thread GitBox
nicolaferraro opened a new pull request #1: URL: https://github.com/apache/camel-kamelets/pull/1 Some general rules for contributions to the official Kamelet catalog. cc: @davsclaus , @oscerd , @astefanutti , @squakez , @doru1004 , @lburgazzoli

[GitHub] [camel] Humbedooh commented on issue #3773: Send pull requests mails to the commits mailings list instead of to t…

2020-04-23 Thread GitBox
Humbedooh commented on issue #3773: URL: https://github.com/apache/camel/pull/3773#issuecomment-618576636 testing as well, hmm This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [camel] PascalSchumacher commented on issue #3773: Send pull requests mails to the commits mailings list instead of to t…

2020-04-23 Thread GitBox
PascalSchumacher commented on issue #3773: URL: https://github.com/apache/camel/pull/3773#issuecomment-618557165 another test comment This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [camel] PascalSchumacher commented on issue #3773: Send pull requests mails to the commits mailings list instead of to t…

2020-04-23 Thread GitBox
PascalSchumacher commented on issue #3773: URL: https://github.com/apache/camel/pull/3773#issuecomment-618547220 Test comment to see if the change is in effect. This is an automated message from the Apache Git Service. To

[GitHub] [camel] PascalSchumacher opened a new pull request #3773: Send pull requests mails to the commits mailings list instead of to t…

2020-04-23 Thread GitBox
.MDExOlB1bGxSZXF1ZXN0NDA2MDQxMzY0.gitbox%40gitbox.apache.org%3E are send to dev@camel.apache.org again. Therefore I created https://issues.apache.org/jira/browse/INFRA-20178. Infra suggested that we add a `.asf.yaml` file to configure it our self (see: https://cwiki.apache.org

[GitHub] [camel] djencks commented on issue #3669: resolves CAMEL-14771: unambiguous property name and some more source info

2020-04-23 Thread GitBox
djencks commented on issue #3669: URL: https://github.com/apache/camel/pull/3669#issuecomment-618490176 I'm going to have another look at 2.x, for generating index tables, and this might possibly be needed there lets leave this open for a few more days.

[GitHub] [camel] ppalaga opened a new pull request #3772: Camel 14934.3

2020-04-23 Thread GitBox
ppalaga opened a new pull request #3772: URL: https://github.com/apache/camel/pull/3772 CAMEL-14934, 3rd batch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [camel] omarsmak opened a new pull request #3771: CAMEL-14655: Add camel-azure-storage-queue component based on Azure v12 SDK

2020-04-23 Thread GitBox
omarsmak opened a new pull request #3771: URL: https://github.com/apache/camel/pull/3771 This is the separated second part of component [camel-azure, the queue component

[GitHub] [camel] tadayosi commented on issue #3770: camel-support - Add type-safe resolveEndpoint method

2020-04-23 Thread GitBox
tadayosi commented on issue #3770: URL: https://github.com/apache/camel/pull/3770#issuecomment-618406164 Thanks guys. That's the feedback that I expected! Withdrawing it and I'll only change the doc in a next commit. This

[GitHub] [camel] davsclaus commented on issue #3669: resolves CAMEL-14771: unambiguous property name and some more source info

2020-04-23 Thread GitBox
davsclaus commented on issue #3669: URL: https://github.com/apache/camel/pull/3669#issuecomment-618315691 This PR is getting stale and the doc work on 2.x has already been done. So lets close this? This is an automated

[GitHub] [camel] davsclaus commented on issue #3770: camel-support - Add type-safe resolveEndpoint method

2020-04-23 Thread GitBox
davsclaus commented on issue #3770: URL: https://github.com/apache/camel/pull/3770#issuecomment-618308987 Ah okay the doc should be changed to use `getEndpoint` This is an automated message from the Apache Git Service. To

[GitHub] [camel] oscerd commented on issue #3770: camel-support - Add type-safe resolveEndpoint method

2020-04-23 Thread GitBox
oscerd commented on issue #3770: URL: https://github.com/apache/camel/pull/3770#issuecomment-618308680 No need to reintroduce the method. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [camel] tadayosi commented on issue #3770: camel-support - Add type-safe resolveEndpoint method

2020-04-23 Thread GitBox
tadayosi commented on issue #3770: URL: https://github.com/apache/camel/pull/3770#issuecomment-618304773 @davsclaus The doc changing is the exact reason I submitted this. The current doc is out-of-date for 3.2.0. Now `CamelContext` doesn't have `resolveEndpoint` method at all, and I only

[GitHub] [camel] tadayosi opened a new pull request #3770: camel-support - Add type-safe resolveEndpoint method

2020-04-23 Thread GitBox
tadayosi opened a new pull request #3770: URL: https://github.com/apache/camel/pull/3770 It's too small changes to file a JIRA but I'd like you guys to check if I'm going in the right direction. This is an automated message

[GitHub] [camel] atoulme commented on issue #3760: [CAMEL-14932] Add new Splunk HEC component

2020-04-23 Thread GitBox
atoulme commented on issue #3760: URL: https://github.com/apache/camel/pull/3760#issuecomment-618213872 Thanks for updating and polishing my code, very appreciated. I look forward to using this connector! This is an

[GitHub] [camel] atoulme commented on issue #3760: [CAMEL-14932] Add new Splunk HEC component

2020-04-23 Thread GitBox
atoulme commented on issue #3760: URL: https://github.com/apache/camel/pull/3760#issuecomment-618212979 Thanks for merging. I think I didn't take care of `@UriPath` correctly, it's been a while. This is an automated message

[GitHub] [camel] oscerd commented on issue #3769: Update lifecycle.adoc

2020-04-23 Thread GitBox
oscerd commented on issue #3769: URL: https://github.com/apache/camel/pull/3769#issuecomment-618203218 Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [camel] johannesr124 opened a new pull request #3769: Update lifecycle.adoc

2020-04-23 Thread GitBox
johannesr124 opened a new pull request #3769: URL: https://github.com/apache/camel/pull/3769 grammatical error [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like

[GitHub] [camel] davsclaus commented on issue #3768: CAMEL-14934: (Batch 2) Improve Component, Language, Data format, etc.

2020-04-22 Thread GitBox
davsclaus commented on issue #3768: URL: https://github.com/apache/camel/pull/3768#issuecomment-617950539 Thanks this is really great to get better descriptions This is an automated message from the Apache Git Service. To

[GitHub] [camel] ppalaga opened a new pull request #3768: CAMEL-14934: (Batch 2) Improve Component, Language, Data format, etc.

2020-04-22 Thread GitBox
ppalaga opened a new pull request #3768: URL: https://github.com/apache/camel/pull/3768 CAMEL-14934, 2nd batch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [camel] davsclaus commented on issue #3697: [CAMEL-14818] fixes documentation for Camel Package Maven plugin

2020-04-22 Thread GitBox
davsclaus commented on issue #3697: URL: https://github.com/apache/camel/pull/3697#issuecomment-617761356 Thanks Jim this is great This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [camel] JiriOndrusek commented on issue #3767: CAMEL-14950 camel-undertow: secure with spring-security 5

2020-04-22 Thread GitBox
JiriOndrusek commented on issue #3767: URL: https://github.com/apache/camel/pull/3767#issuecomment-617747982 Hi @oscerd , @davsclaus I've prepared POC of integration of spring security into camel undertow. Feature contains of several changes in camel-undertow. -

[GitHub] [camel] jimothyGator commented on issue #3697: [CAMEL-14818] fixes documentation for Camel Package Maven plugin

2020-04-22 Thread GitBox
jimothyGator commented on issue #3697: URL: https://github.com/apache/camel/pull/3697#issuecomment-617735848 @oscerd @davsclaus Thank you both. I've managed to get my project building by having Maven re-compile after type converter loaders are generated. I've updated this branch

[GitHub] [camel] JiriOndrusek opened a new pull request #3767: CAMEL-14950 camel-undertow: secure with spring-security 5

2020-04-22 Thread GitBox
JiriOndrusek opened a new pull request #3767: URL: https://github.com/apache/camel/pull/3767 DO NOT MERGE - only draft to share idea [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).

[GitHub] [camel] oscerd commented on issue #3766: Fixed doc: option 'isImplicit' in FTPS implicit sample

2020-04-21 Thread GitBox
oscerd commented on issue #3766: URL: https://github.com/apache/camel/pull/3766#issuecomment-617558769 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [camel] gerdailger opened a new pull request #3766: Fixed doc: option 'isImplicit' in FTPS implicit sample

2020-04-21 Thread GitBox
gerdailger opened a new pull request #3766: URL: https://github.com/apache/camel/pull/3766 option was still called `isImplicit` (Camel 2.x). Changed to `implicit`. This is an automated message from the Apache Git Service. To

[GitHub] [camel] ppalaga opened a new pull request #3765: CAMEL-14934: Improve Component, Language, Data format, etc. descriptions

2020-04-21 Thread GitBox
ppalaga opened a new pull request #3765: URL: https://github.com/apache/camel/pull/3765 in Camel Catalog CAMEL-14934, the first batch of description improvements. This is an automated message from the Apache Git

[GitHub] [camel] djencks opened a new pull request #3764: Fixes CAMEL-14941: Camel 3.2.x issue 14940 core vs non core

2020-04-21 Thread GitBox
djencks opened a new pull request #3764: URL: https://github.com/apache/camel/pull/3764 This back ports the source changes for CAMEL-14874, CAMEL-14906, and CAMEL-14907 to the 3.2.x branch. It also fixes the user-manual faq xrefs so the build can succeed. As supportLevel is not available

[GitHub] [camel] davsclaus commented on a change in pull request #3760: [CAMEL-14932] Add new Splunk HEC component

2020-04-21 Thread GitBox
davsclaus commented on a change in pull request #3760: URL: https://github.com/apache/camel/pull/3760#discussion_r411867669 ## File path: components/camel-splunk-hec/src/main/java/org/apache/camel/component/splunkhec/SplunkHECEndpoint.java ## @@ -0,0 +1,103 @@ +/* + *

[GitHub] [camel] renjfk opened a new pull request #3763: CAMEL-14938: Added file name customization method to GroovyShellFactory for compiled classes

2020-04-21 Thread GitBox
renjfk opened a new pull request #3763: URL: https://github.com/apache/camel/pull/3763 Add file name customization to complied classes generated from Groovy expressions for debugging purposes. This is an automated message

[GitHub] [camel] davsclaus commented on a change in pull request #3760: [CAMEL-14932] Add new Splunk HEC component

2020-04-20 Thread GitBox
davsclaus commented on a change in pull request #3760: URL: https://github.com/apache/camel/pull/3760#discussion_r411867389 ## File path: components/camel-splunk-hec/src/main/java/org/apache/camel/component/splunkhec/SplunkHECConfiguration.java ## @@ -0,0 +1,117 @@ +/* + *

[GitHub] [camel] atoulme commented on a change in pull request #3760: [CAMEL-14932] Add new Splunk HEC component

2020-04-20 Thread GitBox
atoulme commented on a change in pull request #3760: URL: https://github.com/apache/camel/pull/3760#discussion_r411539438 ## File path: core/camel-componentdsl/src/generated/resources/metadata.json ## @@ -6612,6 +6612,28 @@ "producerOnly": false, "lenientProperties":

[GitHub] [camel] atoulme commented on a change in pull request #3760: [CAMEL-14932] Add new Splunk HEC component

2020-04-20 Thread GitBox
atoulme commented on a change in pull request #3760: URL: https://github.com/apache/camel/pull/3760#discussion_r411539558 ## File path: components/camel-splunk-hec/src/main/java/org/apache/camel/component/splunkhec/SplunkHECConfiguration.java ## @@ -0,0 +1,117 @@ +/* + *

[GitHub] [camel] atoulme commented on a change in pull request #3760: [CAMEL-14932] Add new Splunk HEC component

2020-04-20 Thread GitBox
atoulme commented on a change in pull request #3760: URL: https://github.com/apache/camel/pull/3760#discussion_r411537053 ## File path: components/camel-splunk-hec/src/main/java/org/apache/camel/component/splunkhec/SplunkHECProducer.java ## @@ -0,0 +1,122 @@ +/* + * Licensed

[GitHub] [camel] lburgazzoli opened a new pull request #3762: chore: replace dependencies versions with properties

2020-04-20 Thread GitBox
lburgazzoli opened a new pull request #3762: URL: https://github.com/apache/camel/pull/3762 [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA

[GitHub] [camel] lburgazzoli opened a new pull request #3761: CAMEL-14933: Remove dependencies on spring in GenerateConfigurerMojo

2020-04-20 Thread GitBox
lburgazzoli opened a new pull request #3761: URL: https://github.com/apache/camel/pull/3761 [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA

[GitHub] [camel] dmvolod commented on a change in pull request #3760: [CAMEL-14932] Add new Splunk HEC component

2020-04-20 Thread GitBox
dmvolod commented on a change in pull request #3760: URL: https://github.com/apache/camel/pull/3760#discussion_r411212681 ## File path: components/camel-splunk-hec/src/main/java/org/apache/camel/component/splunkhec/SplunkHECConfiguration.java ## @@ -0,0 +1,117 @@ +/* + *

[GitHub] [camel] omarsmak commented on a change in pull request #3760: [CAMEL-14932] Add new Splunk HEC component

2020-04-20 Thread GitBox
omarsmak commented on a change in pull request #3760: URL: https://github.com/apache/camel/pull/3760#discussion_r411163810 ## File path: components/camel-splunk-hec/src/main/java/org/apache/camel/component/splunkhec/SplunkHECProducer.java ## @@ -0,0 +1,122 @@ +/* + * Licensed

[GitHub] [camel] oscerd commented on a change in pull request #3760: [CAMEL-14932] Add new Splunk HEC component

2020-04-20 Thread GitBox
oscerd commented on a change in pull request #3760: URL: https://github.com/apache/camel/pull/3760#discussion_r411137346 ## File path: core/camel-componentdsl/src/generated/resources/metadata.json ## @@ -6612,6 +6612,28 @@ "producerOnly": false, "lenientProperties":

[GitHub] [camel] atoulme opened a new pull request #3760: [CAMEL-14932] Add new Splunk HEC component

2020-04-19 Thread GitBox
atoulme opened a new pull request #3760: URL: https://github.com/apache/camel/pull/3760 This adds a new component named `splunk-hec` after [Splunk HEC](https://dev.splunk.com/enterprise/docs/dataapps/httpeventcollector/). This allows sending data to Splunk using Apache Camel, over

[GitHub] [camel-examples] omarsmak merged pull request #1: Change to camel bom

2020-02-12 Thread GitBox
omarsmak merged pull request #1: Change to camel bom URL: https://github.com/apache/camel-examples/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [camel-examples] davsclaus commented on issue #1: Change to camel bom

2020-02-12 Thread GitBox
davsclaus commented on issue #1: Change to camel bom URL: https://github.com/apache/camel-examples/pull/1#issuecomment-585210233 Yay this is very good. Later we should add the BOM to each example so the end user only have the pom of each example to worry about. But this is a great

[GitHub] [camel-examples] omarsmak opened a new pull request #1: Change to camel bom

2020-02-12 Thread GitBox
omarsmak opened a new pull request #1: Change to camel bom URL: https://github.com/apache/camel-examples/pull/1 This changes to Camel BOM instead of using Camel parent. Next is to move specific examples building tools from main camel repo to the examples repo. FYI @davsclaus @oscerd

[GitHub] [camel-spring-boot] valdar merged pull request #6: Fixed build action schema generation error.

2020-02-11 Thread GitBox
valdar merged pull request #6: Fixed build action schema generation error. URL: https://github.com/apache/camel-spring-boot/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [camel-spring-boot] valdar opened a new pull request #6: Fixed build action schema generation error.

2020-02-11 Thread GitBox
valdar opened a new pull request #6: Fixed build action schema generation error. URL: https://github.com/apache/camel-spring-boot/pull/6 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [camel-spring-boot] jamesnetherton merged pull request #5: CAMEL-14502: Make jsr356 websocket component work with Spring Boot embedded servers

2020-02-06 Thread GitBox
jamesnetherton merged pull request #5: CAMEL-14502: Make jsr356 websocket component work with Spring Boot embedded servers URL: https://github.com/apache/camel-spring-boot/pull/5 This is an automated message from the Apache

[GitHub] [camel-spring-boot] jamesnetherton opened a new pull request #5: CAMEL-14502: Make jsr356 websocket component work with Spring Boot embedded servers

2020-02-06 Thread GitBox
jamesnetherton opened a new pull request #5: CAMEL-14502: Make jsr356 websocket component work with Spring Boot embedded servers URL: https://github.com/apache/camel-spring-boot/pull/5 This is an automated message from the

[GitHub] [camel-spring-boot] asfgit merged pull request #4: CAMEL-14481: camel-spring-boot: Remove camel-management to disable JM…

2020-02-05 Thread GitBox
asfgit merged pull request #4: CAMEL-14481: camel-spring-boot: Remove camel-management to disable JM… URL: https://github.com/apache/camel-spring-boot/pull/4 This is an automated message from the Apache Git Service. To

[GitHub] [camel-spring-boot] PascalSchumacher commented on issue #4: CAMEL-14481: camel-spring-boot: Remove camel-management to disable JM…

2020-02-04 Thread GitBox
PascalSchumacher commented on issue #4: CAMEL-14481: camel-spring-boot: Remove camel-management to disable JM… URL: https://github.com/apache/camel-spring-boot/pull/4#issuecomment-582120307 Yes, I will add this to

[GitHub] [camel-spring-boot] davsclaus commented on issue #4: CAMEL-14481: camel-spring-boot: Remove camel-management to disable JM…

2020-02-04 Thread GitBox
davsclaus commented on issue #4: CAMEL-14481: camel-spring-boot: Remove camel-management to disable JM… URL: https://github.com/apache/camel-spring-boot/pull/4#issuecomment-582118095 Can you add a note in the camel 3 upgrade guide. The doc is in the main repo under docs

[GitHub] [camel-spring-boot] PascalSchumacher opened a new pull request #4: CAMEL-14481: camel-spring-boot: Remove camel-management to disable JM…

2020-02-04 Thread GitBox
PascalSchumacher opened a new pull request #4: CAMEL-14481: camel-spring-boot: Remove camel-management to disable JM… URL: https://github.com/apache/camel-spring-boot/pull/4 …X by default Test and examples will not be able to detect anything broken by this change because

[GitHub] [camel-spring-boot] asfgit merged pull request #3: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes

2020-02-04 Thread GitBox
asfgit merged pull request #3: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes URL: https://github.com/apache/camel-spring-boot/pull/3 This is an automated message from the

[GitHub] [camel-spring-boot] PascalSchumacher commented on issue #3: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes

2020-02-02 Thread GitBox
PascalSchumacher commented on issue #3: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes URL: https://github.com/apache/camel-spring-boot/pull/3#issuecomment-581153165 Examples also still work with this change.

[GitHub] [camel-spring-boot] PascalSchumacher edited a comment on issue #3: WIP: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes

2020-02-02 Thread GitBox
PascalSchumacher edited a comment on issue #3: WIP: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes URL: https://github.com/apache/camel-spring-boot/pull/3#issuecomment-581144291 > Is the integration tests going well? Running a full

  1   2   3   4   5   6   7   8   9   10   >