lburgazzoli commented on code in PR #3163:
URL: https://github.com/apache/camel-k/pull/3163#discussion_r841490794
##
pkg/cmd/operator.go:
##
@@ -40,16 +41,18 @@ func newCmdOperator() (*cobra.Command, *operatorCmdOptions)
{
cmd.Flags().Int32("health-port", 8081, "The
squakez commented on code in PR #3163:
URL: https://github.com/apache/camel-k/pull/3163#discussion_r841464986
##
pkg/cmd/operator.go:
##
@@ -40,16 +41,18 @@ func newCmdOperator() (*cobra.Command, *operatorCmdOptions)
{
cmd.Flags().Int32("health-port", 8081, "The port
astefanutti commented on code in PR #3163:
URL: https://github.com/apache/camel-k/pull/3163#discussion_r841459428
##
pkg/cmd/operator.go:
##
@@ -40,16 +41,18 @@ func newCmdOperator() (*cobra.Command, *operatorCmdOptions)
{
cmd.Flags().Int32("health-port", 8081, "The
astefanutti commented on code in PR #3158:
URL: https://github.com/apache/camel-k/pull/3158#discussion_r841442770
##
.golangci.yml:
##
@@ -50,9 +52,13 @@ linters:
- paralleltest
- tagliatelle
- tenv
+- scopelint
- testpackage
- varnamelen
-
davsclaus commented on code in PR #7336:
URL: https://github.com/apache/camel/pull/7336#discussion_r841368425
##
components/camel-google/camel-google-bigquery/src/main/java/org/apache/camel/component/google/bigquery/GoogleBigQueryConfiguration.java:
##
@@ -16,29 +16,39 @@
*/
tadayosi commented on code in PR #3159:
URL: https://github.com/apache/camel-k/pull/3159#discussion_r841355003
##
examples/traits/service/service.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license
tadayosi commented on code in PR #3152:
URL: https://github.com/apache/camel-k/pull/3152#discussion_r841343432
##
examples/traits/prometheus/README.md:
##
@@ -0,0 +1,19 @@
+# Camel K Prometheus Trait
+
+In this section you will find examples about fine tuning your `Integration`
tadayosi commented on code in PR #3152:
URL: https://github.com/apache/camel-k/pull/3152#discussion_r841339359
##
Hello.java:
##
@@ -0,0 +1,17 @@
+// camel-k: language=java
Review Comment:
I think this one is a leftover. Please remove it from your PR.
--
This is an
nicolaferraro opened a new pull request #8:
URL: https://github.com/apache/camel-kamelets/pull/8
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nicolaferraro merged pull request #7:
URL: https://github.com/apache/camel-kamelets/pull/7
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nicolaferraro opened a new pull request #7:
URL: https://github.com/apache/camel-kamelets/pull/7
This fixes the links to Camel K installation and removes the unneeded tree
node in left menu.
This is an automated message
nicolaferraro merged pull request #6:
URL: https://github.com/apache/camel-kamelets/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
davsclaus commented on pull request #6:
URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779737440
> > > btw is the source code generated list of options in the same order as
in the yaml file (eg so users may put the most important in the top).
> >
> >
> > Well,
nicolaferraro edited a comment on pull request #6:
URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779733631
> > btw is the source code generated list of options in the same order as in
the yaml file (eg so users may put the most important in the top).
>
> Well,
nicolaferraro commented on pull request #6:
URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779733631
> > btw is the source code generated list of options in the same order as in
the yaml file (eg so users may put the most important in the top).
>
> Well, currently
nicolaferraro commented on pull request #6:
URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779733093
> btw is the source code generated list of options in the same order as in
the yaml file (eg so users may put the most important in the top).
Well, currently it
davsclaus commented on pull request #6:
URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779710972
btw is the source code generated list of options in the same order as in the
yaml file (eg so users may put the most important in the top).
nicolaferraro opened a new pull request #6:
URL: https://github.com/apache/camel-kamelets/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nicolaferraro merged pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nicolaferraro commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-779311323
Let's merge this to unlock: https://github.com/apache/camel-website/pull/536
This is an automated
nicolaferraro merged pull request #5:
URL: https://github.com/apache/camel-kamelets/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
oscerd opened a new pull request #5:
URL: https://github.com/apache/camel-kamelets/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nicolaferraro merged pull request #4:
URL: https://github.com/apache/camel-kamelets/pull/4
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nicolaferraro opened a new pull request #4:
URL: https://github.com/apache/camel-kamelets/pull/4
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nicolaferraro merged pull request #3:
URL: https://github.com/apache/camel-kamelets/pull/3
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nicolaferraro commented on pull request #3:
URL: https://github.com/apache/camel-kamelets/pull/3#issuecomment-779085842
Let's merge this to enable actions
This is an automated message from the Apache Git Service.
To respond
nicolaferraro opened a new pull request #3:
URL: https://github.com/apache/camel-kamelets/pull/3
This should setup a CI based on Github actions. I've added the test for the
timer-source Kamelet.
We should find a good solution for easily manage credentials before we can
test the
zregvart commented on a change in pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#discussion_r575317959
##
File path: docs/generator/generator.go
##
@@ -0,0 +1,307 @@
+package main
+
+import (
+ "encoding/base64"
+ "fmt"
+ "io/ioutil"
+
zregvart commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-778164854
I've created a PR to polish this against this PR:
https://github.com/nicolaferraro/camel-kamelets/pull/1
nicolaferraro commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777845389
> I'd like to polish this a bit, either as a PR on top of this PR
(preferred) or as a followup PR.
You're welcome to do so. Look also at
zregvart commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-15643
I'd like to polish this a bit, either as a PR on top of this PR (preferred)
or as a followup PR.
This is an
nicolaferraro commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777409589
> > > @nicolaferraro perhaps you can start a pull request with the changes
needed to the website on the website repository. Not sure what's to gain by
adding those
zregvart commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777395928
> > @nicolaferraro perhaps you can start a pull request with the changes
needed to the website on the website repository. Not sure what's to gain by
adding those changes
astefanutti commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777369635
Gorgeous !
This is an automated message from the Apache Git Service.
To respond to the message, please
nicolaferraro commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777369043
> @nicolaferraro perhaps you can start a pull request with the changes
needed to the website on the website repository. Not sure what's to gain by
adding those changes
zregvart commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777359493
@nicolaferraro perhaps you can start a pull request with the changes needed
to the website on the website repository. Not sure what's to gain by adding
those changes here. Is
lburgazzoli commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777351133
> > random thought:
> >
> > * we should probably have some way of grouping kamelets, i.e. there may
be a number of telegram related kamelets
> > * we shold think
nicolaferraro commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777347111
> I'm not sure if it makes sense to have the same ui we are using on the
camel website, just for visual identity, btw we need @zregvart to include it.
Yeah, this
oscerd commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777344312
I'm not sure if it makes sense to have the same ui we are using on the camel
website, just for visual identity, btw we need @zregvart to include it.
nicolaferraro commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777343441
> random thought:
>
> * we should probably have some way of grouping kamelets, i.e. there may be
a number of telegram related kamelets
> * we shold think about
lburgazzoli commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777338534
random thought:
- we should probably have some way of grouping kamelets, i.e. there may be a
number of telegram related kamelets
- we shold think about versioning
oscerd commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777337272
We need @zregvart for including this somewhere in the website.
This is an automated message from the Apache Git
nicolaferraro opened a new pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2
This generates an Antora module for the Kamelet catalog directly from the
Kamelet YAML files.
cc: @davsclaus , @oscerd , @astefanutti , @squakez , @doru1004 ,
@lburgazzoli, @christophd
nicolaferraro merged pull request #1:
URL: https://github.com/apache/camel-kamelets/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nicolaferraro commented on a change in pull request #1:
URL: https://github.com/apache/camel-kamelets/pull/1#discussion_r571967885
##
File path: README.md
##
@@ -1,6 +1,126 @@
-# Apache Camel - Kamelet Repository
+# Apache Camel - Kamelet Catalog
-This repository contains
davsclaus commented on a change in pull request #1:
URL: https://github.com/apache/camel-kamelets/pull/1#discussion_r571942138
##
File path: README.md
##
@@ -1,6 +1,126 @@
-# Apache Camel - Kamelet Repository
+# Apache Camel - Kamelet Catalog
-This repository contains the
nicolaferraro opened a new pull request #1:
URL: https://github.com/apache/camel-kamelets/pull/1
Some general rules for contributions to the official Kamelet catalog.
cc: @davsclaus , @oscerd , @astefanutti , @squakez , @doru1004 , @lburgazzoli
Humbedooh commented on issue #3773:
URL: https://github.com/apache/camel/pull/3773#issuecomment-618576636
testing as well, hmm
This is an automated message from the Apache Git Service.
To respond to the message, please log
PascalSchumacher commented on issue #3773:
URL: https://github.com/apache/camel/pull/3773#issuecomment-618557165
another test comment
This is an automated message from the Apache Git Service.
To respond to the message,
PascalSchumacher commented on issue #3773:
URL: https://github.com/apache/camel/pull/3773#issuecomment-618547220
Test comment to see if the change is in effect.
This is an automated message from the Apache Git Service.
To
.MDExOlB1bGxSZXF1ZXN0NDA2MDQxMzY0.gitbox%40gitbox.apache.org%3E
are send to dev@camel.apache.org again.
Therefore I created https://issues.apache.org/jira/browse/INFRA-20178. Infra
suggested that we add a `.asf.yaml` file to configure it our self (see:
https://cwiki.apache.org
djencks commented on issue #3669:
URL: https://github.com/apache/camel/pull/3669#issuecomment-618490176
I'm going to have another look at 2.x, for generating index tables, and this
might possibly be needed there lets leave this open for a few more days.
ppalaga opened a new pull request #3772:
URL: https://github.com/apache/camel/pull/3772
CAMEL-14934, 3rd batch
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
omarsmak opened a new pull request #3771:
URL: https://github.com/apache/camel/pull/3771
This is the separated second part of component [camel-azure, the queue
component
tadayosi commented on issue #3770:
URL: https://github.com/apache/camel/pull/3770#issuecomment-618406164
Thanks guys. That's the feedback that I expected! Withdrawing it and I'll
only change the doc in a next commit.
This
davsclaus commented on issue #3669:
URL: https://github.com/apache/camel/pull/3669#issuecomment-618315691
This PR is getting stale and the doc work on 2.x has already been done. So
lets close this?
This is an automated
davsclaus commented on issue #3770:
URL: https://github.com/apache/camel/pull/3770#issuecomment-618308987
Ah okay the doc should be changed to use `getEndpoint`
This is an automated message from the Apache Git Service.
To
oscerd commented on issue #3770:
URL: https://github.com/apache/camel/pull/3770#issuecomment-618308680
No need to reintroduce the method.
This is an automated message from the Apache Git Service.
To respond to the message,
tadayosi commented on issue #3770:
URL: https://github.com/apache/camel/pull/3770#issuecomment-618304773
@davsclaus The doc changing is the exact reason I submitted this. The
current doc is out-of-date for 3.2.0. Now `CamelContext` doesn't have
`resolveEndpoint` method at all, and I only
tadayosi opened a new pull request #3770:
URL: https://github.com/apache/camel/pull/3770
It's too small changes to file a JIRA but I'd like you guys to check if I'm
going in the right direction.
This is an automated message
atoulme commented on issue #3760:
URL: https://github.com/apache/camel/pull/3760#issuecomment-618213872
Thanks for updating and polishing my code, very appreciated. I look forward
to using this connector!
This is an
atoulme commented on issue #3760:
URL: https://github.com/apache/camel/pull/3760#issuecomment-618212979
Thanks for merging. I think I didn't take care of `@UriPath` correctly, it's
been a while.
This is an automated message
oscerd commented on issue #3769:
URL: https://github.com/apache/camel/pull/3769#issuecomment-618203218
Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
johannesr124 opened a new pull request #3769:
URL: https://github.com/apache/camel/pull/3769
grammatical error
[ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change
(usually before you start working on it). Trivial changes like
davsclaus commented on issue #3768:
URL: https://github.com/apache/camel/pull/3768#issuecomment-617950539
Thanks this is really great to get better descriptions
This is an automated message from the Apache Git Service.
To
ppalaga opened a new pull request #3768:
URL: https://github.com/apache/camel/pull/3768
CAMEL-14934, 2nd batch
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
davsclaus commented on issue #3697:
URL: https://github.com/apache/camel/pull/3697#issuecomment-617761356
Thanks Jim this is great
This is an automated message from the Apache Git Service.
To respond to the message, please
JiriOndrusek commented on issue #3767:
URL: https://github.com/apache/camel/pull/3767#issuecomment-617747982
Hi @oscerd , @davsclaus
I've prepared POC of integration of spring security into camel undertow.
Feature contains of several changes in camel-undertow.
-
jimothyGator commented on issue #3697:
URL: https://github.com/apache/camel/pull/3697#issuecomment-617735848
@oscerd @davsclaus
Thank you both. I've managed to get my project building by having Maven
re-compile after type converter loaders are generated. I've updated this branch
JiriOndrusek opened a new pull request #3767:
URL: https://github.com/apache/camel/pull/3767
DO NOT MERGE - only draft to share idea
[ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change
(usually before you start working on it).
oscerd commented on issue #3766:
URL: https://github.com/apache/camel/pull/3766#issuecomment-617558769
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
gerdailger opened a new pull request #3766:
URL: https://github.com/apache/camel/pull/3766
option was still called `isImplicit` (Camel 2.x). Changed to `implicit`.
This is an automated message from the Apache Git Service.
To
ppalaga opened a new pull request #3765:
URL: https://github.com/apache/camel/pull/3765
in Camel Catalog
CAMEL-14934, the first batch of description improvements.
This is an automated message from the Apache Git
djencks opened a new pull request #3764:
URL: https://github.com/apache/camel/pull/3764
This back ports the source changes for CAMEL-14874, CAMEL-14906, and
CAMEL-14907 to the 3.2.x branch. It also fixes the user-manual faq xrefs so
the build can succeed. As supportLevel is not available
davsclaus commented on a change in pull request #3760:
URL: https://github.com/apache/camel/pull/3760#discussion_r411867669
##
File path:
components/camel-splunk-hec/src/main/java/org/apache/camel/component/splunkhec/SplunkHECEndpoint.java
##
@@ -0,0 +1,103 @@
+/*
+ *
renjfk opened a new pull request #3763:
URL: https://github.com/apache/camel/pull/3763
Add file name customization to complied classes generated from Groovy
expressions for debugging purposes.
This is an automated message
davsclaus commented on a change in pull request #3760:
URL: https://github.com/apache/camel/pull/3760#discussion_r411867389
##
File path:
components/camel-splunk-hec/src/main/java/org/apache/camel/component/splunkhec/SplunkHECConfiguration.java
##
@@ -0,0 +1,117 @@
+/*
+ *
atoulme commented on a change in pull request #3760:
URL: https://github.com/apache/camel/pull/3760#discussion_r411539438
##
File path: core/camel-componentdsl/src/generated/resources/metadata.json
##
@@ -6612,6 +6612,28 @@
"producerOnly": false,
"lenientProperties":
atoulme commented on a change in pull request #3760:
URL: https://github.com/apache/camel/pull/3760#discussion_r411539558
##
File path:
components/camel-splunk-hec/src/main/java/org/apache/camel/component/splunkhec/SplunkHECConfiguration.java
##
@@ -0,0 +1,117 @@
+/*
+ *
atoulme commented on a change in pull request #3760:
URL: https://github.com/apache/camel/pull/3760#discussion_r411537053
##
File path:
components/camel-splunk-hec/src/main/java/org/apache/camel/component/splunkhec/SplunkHECProducer.java
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed
lburgazzoli opened a new pull request #3762:
URL: https://github.com/apache/camel/pull/3762
[ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change
(usually before you start working on it). Trivial changes like typos do not
require a JIRA
lburgazzoli opened a new pull request #3761:
URL: https://github.com/apache/camel/pull/3761
[ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change
(usually before you start working on it). Trivial changes like typos do not
require a JIRA
dmvolod commented on a change in pull request #3760:
URL: https://github.com/apache/camel/pull/3760#discussion_r411212681
##
File path:
components/camel-splunk-hec/src/main/java/org/apache/camel/component/splunkhec/SplunkHECConfiguration.java
##
@@ -0,0 +1,117 @@
+/*
+ *
omarsmak commented on a change in pull request #3760:
URL: https://github.com/apache/camel/pull/3760#discussion_r411163810
##
File path:
components/camel-splunk-hec/src/main/java/org/apache/camel/component/splunkhec/SplunkHECProducer.java
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed
oscerd commented on a change in pull request #3760:
URL: https://github.com/apache/camel/pull/3760#discussion_r411137346
##
File path: core/camel-componentdsl/src/generated/resources/metadata.json
##
@@ -6612,6 +6612,28 @@
"producerOnly": false,
"lenientProperties":
atoulme opened a new pull request #3760:
URL: https://github.com/apache/camel/pull/3760
This adds a new component named `splunk-hec` after [Splunk
HEC](https://dev.splunk.com/enterprise/docs/dataapps/httpeventcollector/).
This allows sending data to Splunk using Apache Camel, over
omarsmak merged pull request #1: Change to camel bom
URL: https://github.com/apache/camel-examples/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
davsclaus commented on issue #1: Change to camel bom
URL: https://github.com/apache/camel-examples/pull/1#issuecomment-585210233
Yay this is very good.
Later we should add the BOM to each example so the end user only have the
pom of each example to worry about. But this is a great
omarsmak opened a new pull request #1: Change to camel bom
URL: https://github.com/apache/camel-examples/pull/1
This changes to Camel BOM instead of using Camel parent. Next is to move
specific examples building tools from main camel repo to the examples repo.
FYI @davsclaus @oscerd
valdar merged pull request #6: Fixed build action schema generation error.
URL: https://github.com/apache/camel-spring-boot/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please
valdar opened a new pull request #6: Fixed build action schema generation error.
URL: https://github.com/apache/camel-spring-boot/pull/6
This is an automated message from the Apache Git Service.
To respond to the message,
jamesnetherton merged pull request #5: CAMEL-14502: Make jsr356 websocket
component work with Spring Boot embedded servers
URL: https://github.com/apache/camel-spring-boot/pull/5
This is an automated message from the Apache
jamesnetherton opened a new pull request #5: CAMEL-14502: Make jsr356 websocket
component work with Spring Boot embedded servers
URL: https://github.com/apache/camel-spring-boot/pull/5
This is an automated message from the
asfgit merged pull request #4: CAMEL-14481: camel-spring-boot: Remove
camel-management to disable JM…
URL: https://github.com/apache/camel-spring-boot/pull/4
This is an automated message from the Apache Git Service.
To
PascalSchumacher commented on issue #4: CAMEL-14481: camel-spring-boot: Remove
camel-management to disable JM…
URL: https://github.com/apache/camel-spring-boot/pull/4#issuecomment-582120307
Yes, I will add this to
davsclaus commented on issue #4: CAMEL-14481: camel-spring-boot: Remove
camel-management to disable JM…
URL: https://github.com/apache/camel-spring-boot/pull/4#issuecomment-582118095
Can you add a note in the camel 3 upgrade guide. The doc is in the main repo
under docs
PascalSchumacher opened a new pull request #4: CAMEL-14481: camel-spring-boot:
Remove camel-management to disable JM…
URL: https://github.com/apache/camel-spring-boot/pull/4
…X by default
Test and examples will not be able to detect anything broken by this change
because
asfgit merged pull request #3: CAMEL-14471: camel-spring-boot: Disable proxying
of bean methods for auto-configuration classes
URL: https://github.com/apache/camel-spring-boot/pull/3
This is an automated message from the
PascalSchumacher commented on issue #3: CAMEL-14471: camel-spring-boot: Disable
proxying of bean methods for auto-configuration classes
URL: https://github.com/apache/camel-spring-boot/pull/3#issuecomment-581153165
Examples also still work with this change.
PascalSchumacher edited a comment on issue #3: WIP: CAMEL-14471:
camel-spring-boot: Disable proxying of bean methods for auto-configuration
classes
URL: https://github.com/apache/camel-spring-boot/pull/3#issuecomment-581144291
> Is the integration tests going well?
Running a full
1 - 100 of 5598 matches
Mail list logo