Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/255
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Hi guys
We have to prepare the podling report. Who can start this ? I can help and
review. Please let me know.
Thanks
Regards
JB
On Oct 25, 2016, 02:01, at 02:01, johndam...@apache.org wrote:
>Dear podling,
>
>This email was sent by an automated system on behalf of the Apache
>Incubator PMC
Dear podling,
This email was sent by an automated system on behalf of the Apache
Incubator PMC. It is an initial reminder to give you plenty of time to
prepare your quarterly board report.
The board meeting is scheduled for Wed, 16 November 2016, 10:30 am PDT.
The report for your podling will for
+1.
I agree shipping the generated JAVA code has drawback, we should explore to
publish it on Maven central repository for release, so that with the correct
artifacts in place for the corresponding release in pom.xml, we are good.
Jihong
-Original Message-
From: Jacky Li [mailto:jack
GitHub user ravipesala opened a pull request:
https://github.com/apache/incubator-carbondata/pull/256
[CARBONDATA-213] Remove thrift complier dependency from default build.
By default `mvn install` does not include carbon-format, it downloads
dependency from repository.
User nee
hi, guys
for the reserve words, i think it maybe better to support, cause it harms
nothing.
but i am not sure. hope u can give suggestions.
Thanks
Jay
-- --
??: "Harmeet Singh (JIRA)";;
: 2016??10??20??(??) 6:36
??: "
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/255#discussion_r84699713
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
@@ -926,14 +926,14 @@ class CarbonSqlParser()
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
hi,
for 3, blocklets are not stored sequence in global, neither in block local.
actually, we can say that blocklets are sorted in partition, and one partition
has
many blocks. this word 'partition' is just exactly spark's partition, because
carbon makes further process in spark executor,
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/254#discussion_r84686198
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/CarbonCatalystOperators.scala
---
@@ -90,3 +90,11 @@ abstract class CarbonProfi
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/248#discussion_r84681646
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -210,7 +216,7 @@ object CarbonData
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/248#discussion_r84681761
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -277,44 +283,43 @@ object CarbonDa
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/248#discussion_r84681517
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -188,16 +194,16 @@ object CarbonDa
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/248#discussion_r84681004
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataLoadRDD.scala
---
@@ -196,30 +195,28 @@ class DataFileLoad
I agree with Ravindra, this is not the best approach. But since this issue
block integration with Apache CI, I think it makes sense to solve it quickly
and do the best approach later.
Without CI automation, it is really a pain to manually trigger the CI for every
PR.
So, +1
Regards,
Jacky
>
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/202
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
+1
It makes sense to me.
Regards
JB
On Oct 24, 2016, 13:03, at 13:03, Vimal Das Kammath
wrote:
>Yes, I agree with Ravindra and Vishal.
>Instead of the source code, we can have the jar published to
>repository,
>We can have a maven profile that depends on carbon-format as jar from
>reposito
Yes, I agree with Ravindra and Vishal.
Instead of the source code, we can have the jar published to repository,
We can have a maven profile that depends on carbon-format as jar from
repository (this can be the default, for new developers to build
successfully)
However, We also should have a profile
In case of any updation in thrift we need to update the java files. I think
keeping the java file is not a good idea.
-Regards
Kumar Vishal
On Oct 24, 2016 13:13, "caiqiang" wrote:
> Hi
>
> Currently, There are two typical Thrift issues:
>
> 1.Users want to directly build Apache CarbonData, do
Hi David,
I guess keeping the generated code in apache github may not be a good
solution, even I am not sure whether it is acceptable to keep generated
code in apache.
I prefer to decouple the thrift code compilation from main build and
provide separate profile to do thrift compilation and upload
+1 for directly using java code to build.
At the same time, we should have the CI infrastructure to ensure that the
.thrift files and the generated source code are always in sync.
Regards
Vimal
On Mon, Oct 24, 2016 at 2:09 PM, Liang Chen wrote:
> Hi
>
> I prefer to the new solution for fixing t
Hi
I prefer to the new solution for fixing thrift issues:Directly use java code
( thrift compiler compile carbondata format files to java code) to build,
then users don't need to do any thrift installation.
+1 for new solution.
Regards
Liang
QiangCai wrote
> Hi
>
> Currently, There are two ty
Hi
Currently, There are two typical Thrift issues:
1.Users want to directly build Apache CarbonData, don??t need to install Thrift
in advance. For example:
Julian Hyde-3??s feedback in IPMC mailing list: I was not able to build (not
your fault - I did not have thrift
installed and didn't have
24 matches
Mail list logo
