Re: Please vote and advise on building thrift files
+1 for solution 1 We should also have a mechanism to ensure that the jar in repo is in sync with the thrift files in git. Can we automate this in CI? -Vimal On Mon, Nov 21, 2016 at 8:02 AM, Venkata Gollamudi wrote: > +1 for solution 1. > > Solution 2 would be good if generated code is very less. But Carbondata > thrift generated code is around 10k, which is more. Also later has to > support C++ interface also. > > On Sun, Nov 20, 2016, 10:53 PM Fu Chen wrote: > > > +1 for Proposal 1 > > > 在 2016年11月18日，上午11:58，sujith chacko 写道： > > > > > > +1 for first approach. > > > > > > On Nov 17, 2016 9:58 AM, "金铸" wrote: > > > > > >> +1 for proposal 1 > > >> > > >> > > >> 在 2016/11/17 12:13, 邢冰 写道: > > >> > > >>> +1 for proposal 1 > > >>> > > >>> thx > > >>> > > >>> > > >>> > > >>> > > >>> 发自网易邮箱大师 > > >>> On 11/17/2016 12:09, Ravindra Pesala wrote: > > >>> +1 for proposal 1 > > >>> > > >>> On 17 November 2016 at 08:23, Xiaoqiao He > wrote: > > >>> > > >>> +1 for proposal 1. > > >>>> > > >>>> On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam < > allwefant...@gmail.com> > > >>>> wrote: > > >>>> > > >>>> +1 for proposal 1 . > > >>>>> > > >>>>> Auto generated code should not be added to project. Also most the > of > > >>>>> time > > >>>>> ,people who dive into carbondata may not touch format code. > > >>>>> > > >>>>> > > >>>>> > > >>>>> -- > > >>>>> View this message in context: http://apache-carbondata- > > >>>>> mailing-list-archive.1130556.n5.nabble.com/Please-vote-and- > > >>>>> advise-on-building-thrift-files-tp2952p2957.html > > >>>>> Sent from the Apache CarbonData Mailing List archive mailing list > > >>>>> archive > > >>>>> at Nabble.com. > > >>>>> > > >>>>> > > >>> > > >>> -- > > >>> Thanks & Regards, > > >>> Ravi > > >>> > > >> > > >> > > >> > > >> > > >> > > >> --- > > >> Confidentiality Notice: The information contained in this e-mail and > any > > >> accompanying attachment(s) > > >> is intended only for the use of the intended recipient and may be > > >> confidential and/or privileged of > > >> Neusoft Corporation, its subsidiaries and/or its affiliates. If any > > reader > > >> of this communication is > > >> not the intended recipient, unauthorized use, forwarding, printing, > > >> storing, disclosure or copying > > >> is strictly prohibited, and may be unlawful.If you have received this > > >> communication in error,please > > >> immediately notify the sender by return e-mail, and delete the > original > > >> message and all copies from > > >> your system. Thank you. > > >> > > >> --- > > >> > > > > >
Re: Please vote and advise on building thrift files
+1 for solution 1. Solution 2 would be good if generated code is very less. But Carbondata thrift generated code is around 10k, which is more. Also later has to support C++ interface also. On Sun, Nov 20, 2016, 10:53 PM Fu Chen wrote: > +1 for Proposal 1 > > 在 2016年11月18日，上午11:58，sujith chacko 写道： > > > > +1 for first approach. > > > > On Nov 17, 2016 9:58 AM, "金铸" wrote: > > > >> +1 for proposal 1 > >> > >> > >> 在 2016/11/17 12:13, 邢冰 写道: > >> > >>> +1 for proposal 1 > >>> > >>> thx > >>> > >>> > >>> > >>> > >>> 发自网易邮箱大师 > >>> On 11/17/2016 12:09, Ravindra Pesala wrote: > >>> +1 for proposal 1 > >>> > >>> On 17 November 2016 at 08:23, Xiaoqiao He wrote: > >>> > >>> +1 for proposal 1. > >>>> > >>>> On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam > >>>> wrote: > >>>> > >>>> +1 for proposal 1 . > >>>>> > >>>>> Auto generated code should not be added to project. Also most the of > >>>>> time > >>>>> ,people who dive into carbondata may not touch format code. > >>>>> > >>>>> > >>>>> > >>>>> -- > >>>>> View this message in context: http://apache-carbondata- > >>>>> mailing-list-archive.1130556.n5.nabble.com/Please-vote-and- > >>>>> advise-on-building-thrift-files-tp2952p2957.html > >>>>> Sent from the Apache CarbonData Mailing List archive mailing list > >>>>> archive > >>>>> at Nabble.com. > >>>>> > >>>>> > >>> > >>> -- > >>> Thanks & Regards, > >>> Ravi > >>> > >> > >> > >> > >> > >> > >> --- > >> Confidentiality Notice: The information contained in this e-mail and any > >> accompanying attachment(s) > >> is intended only for the use of the intended recipient and may be > >> confidential and/or privileged of > >> Neusoft Corporation, its subsidiaries and/or its affiliates. If any > reader > >> of this communication is > >> not the intended recipient, unauthorized use, forwarding, printing, > >> storing, disclosure or copying > >> is strictly prohibited, and may be unlawful.If you have received this > >> communication in error,please > >> immediately notify the sender by return e-mail, and delete the original > >> message and all copies from > >> your system. Thank you. > >> > >> --- > >> > >
Re: Please vote and advise on building thrift files
+1 for Proposal 1 > 在 2016年11月18日，上午11:58，sujith chacko 写道： > > +1 for first approach. > > On Nov 17, 2016 9:58 AM, "金铸" wrote: > >> +1 for proposal 1 >> >> >> 在 2016/11/17 12:13, 邢冰 写道: >> >>> +1 for proposal 1 >>> >>> thx >>> >>> >>> >>> >>> 发自网易邮箱大师 >>> On 11/17/2016 12:09, Ravindra Pesala wrote: >>> +1 for proposal 1 >>> >>> On 17 November 2016 at 08:23, Xiaoqiao He wrote: >>> >>> +1 for proposal 1. >>>> >>>> On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam >>>> wrote: >>>> >>>> +1 for proposal 1 . >>>>> >>>>> Auto generated code should not be added to project. Also most the of >>>>> time >>>>> ,people who dive into carbondata may not touch format code. >>>>> >>>>> >>>>> >>>>> -- >>>>> View this message in context: http://apache-carbondata- >>>>> mailing-list-archive.1130556.n5.nabble.com/Please-vote-and- >>>>> advise-on-building-thrift-files-tp2952p2957.html >>>>> Sent from the Apache CarbonData Mailing List archive mailing list >>>>> archive >>>>> at Nabble.com. >>>>> >>>>> >>> >>> -- >>> Thanks & Regards, >>> Ravi >>> >> >> >> >> >> >> --- >> Confidentiality Notice: The information contained in this e-mail and any >> accompanying attachment(s) >> is intended only for the use of the intended recipient and may be >> confidential and/or privileged of >> Neusoft Corporation, its subsidiaries and/or its affiliates. If any reader >> of this communication is >> not the intended recipient, unauthorized use, forwarding, printing, >> storing, disclosure or copying >> is strictly prohibited, and may be unlawful.If you have received this >> communication in error,please >> immediately notify the sender by return e-mail, and delete the original >> message and all copies from >> your system. Thank you. >> >> --- >>
Re: Please vote and advise on building thrift files
+1 for first approach. On Nov 17, 2016 9:58 AM, "金铸" wrote: > +1 for proposal 1 > > > 在 2016/11/17 12:13, 邢冰 写道: > >> +1 for proposal 1 >> >> thx >> >> >> >> >> 发自网易邮箱大师 >> On 11/17/2016 12:09, Ravindra Pesala wrote: >> +1 for proposal 1 >> >> On 17 November 2016 at 08:23, Xiaoqiao He wrote: >> >> +1 for proposal 1. >>> >>> On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam >>> wrote: >>> >>> +1 for proposal 1 . >>>> >>>> Auto generated code should not be added to project. Also most the of >>>> time >>>> ,people who dive into carbondata may not touch format code. >>>> >>>> >>>> >>>> -- >>>> View this message in context: http://apache-carbondata- >>>> mailing-list-archive.1130556.n5.nabble.com/Please-vote-and- >>>> advise-on-building-thrift-files-tp2952p2957.html >>>> Sent from the Apache CarbonData Mailing List archive mailing list >>>> archive >>>> at Nabble.com. >>>> >>>> >> >> -- >> Thanks & Regards, >> Ravi >> > > > > > > --- > Confidentiality Notice: The information contained in this e-mail and any > accompanying attachment(s) > is intended only for the use of the intended recipient and may be > confidential and/or privileged of > Neusoft Corporation, its subsidiaries and/or its affiliates. If any reader > of this communication is > not the intended recipient, unauthorized use, forwarding, printing, > storing, disclosure or copying > is strictly prohibited, and may be unlawful.If you have received this > communication in error,please > immediately notify the sender by return e-mail, and delete the original > message and all copies from > your system. Thank you. > > --- >
回复： Please vote and advise on building thrift files
+1 for first proposal too. -- 原始邮件 -- 发件人: "Jean-Baptiste Onofr ";; 发送时间: 2016年11月18日(星期五) 中午11:11 收件人: "dev"; 主题: Re: Please vote and advise on building thrift files +1 for first proposal too. Regards JB On Nov 18, 2016, 04:05, at 04:05, hseagle wrote: >+ vote for proposal 1 > > > >-- >View this message in context: >http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-advise-on-building-thrift-files-tp2952p2989.html >Sent from the Apache CarbonData Mailing List archive mailing list >archive at Nabble.com.
Re: Please vote and advise on building thrift files
+1 for first proposal too. Regards JB On Nov 18, 2016, 04:05, at 04:05, hseagle wrote: >+ vote for proposal 1 > > > >-- >View this message in context: >http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-advise-on-building-thrift-files-tp2952p2989.html >Sent from the Apache CarbonData Mailing List archive mailing list >archive at Nabble.com.
Re: Please vote and advise on building thrift files
+ vote for proposal 1 -- View this message in context: http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-advise-on-building-thrift-files-tp2952p2989.html Sent from the Apache CarbonData Mailing List archive mailing list archive at Nabble.com.
Re: Please vote and advise on building thrift files
+1 for Proposal 1 Best Regards, Aniket On Wed, Nov 16, 2016 at 10:34 AM, Liang Chen wrote: > Hi all > > Please vote the below proposals or advise other better proposal on building > thrift files. > > > > --- > > CarbonData is file format and introduce Apache thrift for supporting > multiple languages and any language can read the file format written by > thrift. > > > > Following are 2 proposals to build thrift file > > > > *Proposal 1:* provide dependency in maven pom file. > > For people(IPMC,PPMC, and others)who want to verify release need to install > thrift for building with this command "mvn clean -Pbuild-with-format > install". > > For general users: no need to install thrift and build with command "mvn > clean install", because the dependency provided in maven pom file(already > uploaded the compiled format jar to snapshot repository for dev, and to > release repository once released) > > > > pros: use jar dependency, easy to manage. > > cons: only verify release need to install thrift. > > > > *Proposal 2: *generate thrift java code and add to system for building > without thrift installation > > > > For people(IPMC,PPMC,and others) who want to verify release,no need to > install thrift and build with command "mvn clean install". > > > pros: no thrift installation for verify release > > cons: introduce around 10k java code to system, for every language(like > C++),need introduce more code. > > > Regards > Liang >
RE: Please vote and advise on building thrift files
+1 for proposal 1. Jihong -Original Message- From: Anurag Srivastava [mailto:anu...@knoldus.com] Sent: Thursday, November 17, 2016 2:32 AM To: dev@carbondata.incubator.apache.org Subject: Re: Please vote and advise on building thrift files +1 for proposal 1 On Thu, Nov 17, 2016 at 3:56 PM, Kumar Vishal wrote: > +1 for proposal 1 > > -Regards > Kumar Vishal > > On Nov 17, 2016 09:58, "金铸" wrote: > > > +1 for proposal 1 > > > > > > 在 2016/11/17 12:13, 邢冰 写道: > > > >> +1 for proposal 1 > >> > >> thx > >> > >> > >> > >> > >> 发自网易邮箱大师 > >> On 11/17/2016 12:09, Ravindra Pesala wrote: > >> +1 for proposal 1 > >> > >> On 17 November 2016 at 08:23, Xiaoqiao He wrote: > >> > >> +1 for proposal 1. > >>> > >>> On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam > >>> wrote: > >>> > >>> +1 for proposal 1 . > >>>> > >>>> Auto generated code should not be added to project. Also most the of > >>>> time > >>>> ,people who dive into carbondata may not touch format code. > >>>> > >>>> > >>>> > >>>> -- > >>>> View this message in context: http://apache-carbondata- > >>>> mailing-list-archive.1130556.n5.nabble.com/Please-vote-and- > >>>> advise-on-building-thrift-files-tp2952p2957.html > >>>> Sent from the Apache CarbonData Mailing List archive mailing list > >>>> archive > >>>> at Nabble.com. > >>>> > >>>> > >> > >> -- > >> Thanks & Regards, > >> Ravi > >> > > > > > > > > > > > > --- > > Confidentiality Notice: The information contained in this e-mail and any > > accompanying attachment(s) > > is intended only for the use of the intended recipient and may be > > confidential and/or privileged of > > Neusoft Corporation, its subsidiaries and/or its affiliates. If any > reader > > of this communication is > > not the intended recipient, unauthorized use, forwarding, printing, > > storing, disclosure or copying > > is strictly prohibited, and may be unlawful.If you have received this > > communication in error,please > > immediately notify the sender by return e-mail, and delete the original > > message and all copies from > > your system. Thank you. > > > > --- > > > -- *Thanks®ards* *Anurag Srivastava**Software Consultant* *Knoldus Software LLP* *India - US - Canada* * Twitter <http://www.twitter.com/anuragknoldus> | FB <http://www.facebook.com/anuragsrivastava.06> | LinkedIn <https://in.linkedin.com/pub/anurag-srivastava/5a/b6/441>*
Re: Please vote and advise on building thrift files
+1 for proposal 1 On Thu, Nov 17, 2016 at 3:56 PM, Kumar Vishal wrote: > +1 for proposal 1 > > -Regards > Kumar Vishal > > On Nov 17, 2016 09:58, "金铸" wrote: > > > +1 for proposal 1 > > > > > > 在 2016/11/17 12:13, 邢冰 写道: > > > >> +1 for proposal 1 > >> > >> thx > >> > >> > >> > >> > >> 发自网易邮箱大师 > >> On 11/17/2016 12:09, Ravindra Pesala wrote: > >> +1 for proposal 1 > >> > >> On 17 November 2016 at 08:23, Xiaoqiao He wrote: > >> > >> +1 for proposal 1. > >>> > >>> On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam > >>> wrote: > >>> > >>> +1 for proposal 1 . > >>>> > >>>> Auto generated code should not be added to project. Also most the of > >>>> time > >>>> ,people who dive into carbondata may not touch format code. > >>>> > >>>> > >>>> > >>>> -- > >>>> View this message in context: http://apache-carbondata- > >>>> mailing-list-archive.1130556.n5.nabble.com/Please-vote-and- > >>>> advise-on-building-thrift-files-tp2952p2957.html > >>>> Sent from the Apache CarbonData Mailing List archive mailing list > >>>> archive > >>>> at Nabble.com. > >>>> > >>>> > >> > >> -- > >> Thanks & Regards, > >> Ravi > >> > > > > > > > > > > > > --- > > Confidentiality Notice: The information contained in this e-mail and any > > accompanying attachment(s) > > is intended only for the use of the intended recipient and may be > > confidential and/or privileged of > > Neusoft Corporation, its subsidiaries and/or its affiliates. If any > reader > > of this communication is > > not the intended recipient, unauthorized use, forwarding, printing, > > storing, disclosure or copying > > is strictly prohibited, and may be unlawful.If you have received this > > communication in error,please > > immediately notify the sender by return e-mail, and delete the original > > message and all copies from > > your system. Thank you. > > > > --- > > > -- *Thanks®ards* *Anurag Srivastava**Software Consultant* *Knoldus Software LLP* *India - US - Canada* * Twitter <http://www.twitter.com/anuragknoldus> | FB <http://www.facebook.com/anuragsrivastava.06> | LinkedIn <https://in.linkedin.com/pub/anurag-srivastava/5a/b6/441>*
Re: Please vote and advise on building thrift files
+1 for proposal 1 -Regards Kumar Vishal On Nov 17, 2016 09:58, "金铸" wrote: > +1 for proposal 1 > > > 在 2016/11/17 12:13, 邢冰 写道: > >> +1 for proposal 1 >> >> thx >> >> >> >> >> 发自网易邮箱大师 >> On 11/17/2016 12:09, Ravindra Pesala wrote: >> +1 for proposal 1 >> >> On 17 November 2016 at 08:23, Xiaoqiao He wrote: >> >> +1 for proposal 1. >>> >>> On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam >>> wrote: >>> >>> +1 for proposal 1 . >>>> >>>> Auto generated code should not be added to project. Also most the of >>>> time >>>> ,people who dive into carbondata may not touch format code. >>>> >>>> >>>> >>>> -- >>>> View this message in context: http://apache-carbondata- >>>> mailing-list-archive.1130556.n5.nabble.com/Please-vote-and- >>>> advise-on-building-thrift-files-tp2952p2957.html >>>> Sent from the Apache CarbonData Mailing List archive mailing list >>>> archive >>>> at Nabble.com. >>>> >>>> >> >> -- >> Thanks & Regards, >> Ravi >> > > > > > > --- > Confidentiality Notice: The information contained in this e-mail and any > accompanying attachment(s) > is intended only for the use of the intended recipient and may be > confidential and/or privileged of > Neusoft Corporation, its subsidiaries and/or its affiliates. If any reader > of this communication is > not the intended recipient, unauthorized use, forwarding, printing, > storing, disclosure or copying > is strictly prohibited, and may be unlawful.If you have received this > communication in error,please > immediately notify the sender by return e-mail, and delete the original > message and all copies from > your system. Thank you. > > --- >
Re: Please vote and advise on building thrift files
+1 for proposal 1 在 2016/11/17 12:13, 邢冰 写道: +1 for proposal 1 thx 发自网易邮箱大师 On 11/17/2016 12:09, Ravindra Pesala wrote: +1 for proposal 1 On 17 November 2016 at 08:23, Xiaoqiao He wrote: +1 for proposal 1. On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam wrote: +1 for proposal 1 . Auto generated code should not be added to project. Also most the of time ,people who dive into carbondata may not touch format code. -- View this message in context: http://apache-carbondata- mailing-list-archive.1130556.n5.nabble.com/Please-vote-and- advise-on-building-thrift-files-tp2952p2957.html Sent from the Apache CarbonData Mailing List archive mailing list archive at Nabble.com. -- Thanks & Regards, Ravi --- Confidentiality Notice: The information contained in this e-mail and any accompanying attachment(s) is intended only for the use of the intended recipient and may be confidential and/or privileged of Neusoft Corporation, its subsidiaries and/or its affiliates. If any reader of this communication is not the intended recipient, unauthorized use, forwarding, printing, storing, disclosure or copying is strictly prohibited, and may be unlawful.If you have received this communication in error,please immediately notify the sender by return e-mail, and delete the original message and all copies from your system. Thank you. ---
Re: Re: Please vote and advise on building thrift files
+1 for proposal 1 thx 发自网易邮箱大师 On 11/17/2016 12:09, Ravindra Pesala wrote: +1 for proposal 1 On 17 November 2016 at 08:23, Xiaoqiao He wrote: > +1 for proposal 1. > > On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam > wrote: > > > +1 for proposal 1 . > > > > Auto generated code should not be added to project. Also most the of time > > ,people who dive into carbondata may not touch format code. > > > > > > > > -- > > View this message in context: http://apache-carbondata- > > mailing-list-archive.1130556.n5.nabble.com/Please-vote-and- > > advise-on-building-thrift-files-tp2952p2957.html > > Sent from the Apache CarbonData Mailing List archive mailing list archive > > at Nabble.com. > > > -- Thanks & Regards, Ravi
Re: Please vote and advise on building thrift files
+1 for proposal 1 On 17 November 2016 at 08:23, Xiaoqiao He wrote: > +1 for proposal 1. > > On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam > wrote: > > > +1 for proposal 1 . > > > > Auto generated code should not be added to project. Also most the of time > > ,people who dive into carbondata may not touch format code. > > > > > > > > -- > > View this message in context: http://apache-carbondata- > > mailing-list-archive.1130556.n5.nabble.com/Please-vote-and- > > advise-on-building-thrift-files-tp2952p2957.html > > Sent from the Apache CarbonData Mailing List archive mailing list archive > > at Nabble.com. > > > -- Thanks & Regards, Ravi
Re: Please vote and advise on building thrift files
+1 for proposal 1. On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam wrote: > +1 for proposal 1 . > > Auto generated code should not be added to project. Also most the of time > ,people who dive into carbondata may not touch format code. > > > > -- > View this message in context: http://apache-carbondata- > mailing-list-archive.1130556.n5.nabble.com/Please-vote-and- > advise-on-building-thrift-files-tp2952p2957.html > Sent from the Apache CarbonData Mailing List archive mailing list archive > at Nabble.com. >
Re: Please vote and advise on building thrift files
+1 for proposal 1 -- View this message in context: http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-advise-on-building-thrift-files-tp2952p2956.html Sent from the Apache CarbonData Mailing List archive mailing list archive at Nabble.com.
Re: Please vote and advise on building thrift files
+1 for proposal 1 . Auto generated code should not be added to project. Also most the of time ,people who dive into carbondata may not touch format code. -- View this message in context: http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-advise-on-building-thrift-files-tp2952p2957.html Sent from the Apache CarbonData Mailing List archive mailing list archive at Nabble.com.
Re: Please vote and advise on building thrift files
I vote for pooposal 1 -- View this message in context: http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-advise-on-building-thrift-files-tp2952p2955.html Sent from the Apache CarbonData Mailing List archive mailing list archive at Nabble.com.
?????? Please vote and advise on building thrift files
+1 for proposal 1 Regards Jay -- -- ??: "Raghunandan S";; : 2016??11??17??(??) 9:12 ??: "dev"; ????: Re: Please vote and advise on building thrift files I vote for pooposal 1 On Thu, 17 Nov 2016 at 12:04 AM, Liang Chen wrote: > Hi all > > Please vote the below proposals or advise other better proposal on building > thrift files. > > > > --- > > CarbonData is file format and introduce Apache thrift for supporting > multiple languages and any language can read the file format written by > thrift. > > > > Following are 2 proposals to build thrift file > > > > *Proposal 1:* provide dependency in maven pom file. > > For people(IPMC,PPMC, and others)who want to verify release need to install > thrift for building with this command "mvn clean -Pbuild-with-format > install". > > For general users: no need to install thrift and build with command "mvn > clean install", because the dependency provided in maven pom file(already > uploaded the compiled format jar to snapshot repository for dev, and to > release repository once released) > > > > pros: use jar dependency, easy to manage. > > cons: only verify release need to install thrift. > > > > *Proposal 2: *generate thrift java code and add to system for building > without thrift installation > > > > For people(IPMC,PPMC,and others) who want to verify release,no need to > install thrift and build with command "mvn clean install". > > > pros: no thrift installation for verify release > > cons: introduce around 10k java code to system, for every language(like > C++),need introduce more code. > > > Regards > Liang >
Re: Please vote and advise on building thrift files
I vote for pooposal 1 On Thu, 17 Nov 2016 at 12:04 AM, Liang Chen wrote: > Hi all > > Please vote the below proposals or advise other better proposal on building > thrift files. > > > > --- > > CarbonData is file format and introduce Apache thrift for supporting > multiple languages and any language can read the file format written by > thrift. > > > > Following are 2 proposals to build thrift file > > > > *Proposal 1:* provide dependency in maven pom file. > > For people(IPMC,PPMC, and others)who want to verify release need to install > thrift for building with this command "mvn clean -Pbuild-with-format > install". > > For general users: no need to install thrift and build with command "mvn > clean install", because the dependency provided in maven pom file(already > uploaded the compiled format jar to snapshot repository for dev, and to > release repository once released) > > > > pros: use jar dependency, easy to manage. > > cons: only verify release need to install thrift. > > > > *Proposal 2: *generate thrift java code and add to system for building > without thrift installation > > > > For people(IPMC,PPMC,and others) who want to verify release,no need to > install thrift and build with command "mvn clean install". > > > pros: no thrift installation for verify release > > cons: introduce around 10k java code to system, for every language(like > C++),need introduce more code. > > > Regards > Liang >
Please vote and advise on building thrift files
Hi all Please vote the below proposals or advise other better proposal on building thrift files. --- CarbonData is file format and introduce Apache thrift for supporting multiple languages and any language can read the file format written by thrift. Following are 2 proposals to build thrift file *Proposal 1:* provide dependency in maven pom file. For people(IPMC,PPMC, and others)who want to verify release need to install thrift for building with this command "mvn clean -Pbuild-with-format install". For general users: no need to install thrift and build with command "mvn clean install", because the dependency provided in maven pom file(already uploaded the compiled format jar to snapshot repository for dev, and to release repository once released) pros: use jar dependency, easy to manage. cons: only verify release need to install thrift. *Proposal 2: *generate thrift java code and add to system for building without thrift installation For people(IPMC,PPMC,and others) who want to verify release,no need to install thrift and build with command "mvn clean install". pros: no thrift installation for verify release cons: introduce around 10k java code to system, for every language(like C++),need introduce more code. Regards Liang
