Re: Stabilising Internode Messaging in 4.0

2019-04-04 Thread Jon Haddad
Given the number of issues that are addressed, I definitely think it's worth strongly considering merging this in. I think it might be a little unrealistic to cut the first alpha after the merge though. Being realistic, any 20K+ LOC change is going to introduce its own bugs, and we should be

Re: Stabilising Internode Messaging in 4.0

2019-04-04 Thread Pavel Yaskevich
Great to see such a significant progress made in the area! On Thu, Apr 4, 2019 at 1:13 PM Aleksey Yeschenko wrote: > I would like to propose CASSANDRA-15066 [1] - an important set of bug fixes > and stability improvements to internode messaging code that Benedict, I, > and others have been

Re: Stabilising Internode Messaging in 4.0

2019-04-04 Thread J. D. Jordan
Definitely sounds like it is worth taking a 2nd look here. Given that this is in relation to brand new code for 4.0, I agree that it makes sense to get it right the first time, rather than applying bandaids to 4.0 and rewriting things for 4.next. I think 4.0 should be a solid starting point for

Stabilising Internode Messaging in 4.0

2019-04-04 Thread Aleksey Yeschenko
I would like to propose CASSANDRA-15066 [1] - an important set of bug fixes and stability improvements to internode messaging code that Benedict, I, and others have been working on for the past couple of months. First, some context. This work started off as a review of CASSANDRA-14503