Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread guo Maxwell
+1 Jake Luciani 于2023年6月14日周三 09:21写道: > +1 > > On Tue, Jun 13, 2023 at 7:14 PM Nate McCall wrote: > >> +1 >> >> On Wed, Jun 14, 2023 at 2:15 AM Jeremy Hanna >> wrote: >> >>> Calling for a vote on CEP-8 [1]. >>> >>> To clarify the intent, as Benjamin said in the discussion thread [2], >>> the

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Jake Luciani
+1 On Tue, Jun 13, 2023 at 7:14 PM Nate McCall wrote: > +1 > > On Wed, Jun 14, 2023 at 2:15 AM Jeremy Hanna > wrote: > >> Calling for a vote on CEP-8 [1]. >> >> To clarify the intent, as Benjamin said in the discussion thread [2], the >> goal of this vote is simply to ensure that the community

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Nate McCall
+1 On Wed, Jun 14, 2023 at 2:15 AM Jeremy Hanna wrote: > Calling for a vote on CEP-8 [1]. > > To clarify the intent, as Benjamin said in the discussion thread [2], the > goal of this vote is simply to ensure that the community is in favor of > the donation. Nothing more. > The plan is to

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Derek Chen-Becker
+1 On Tue, Jun 13, 2023 at 8:15 AM Jeremy Hanna wrote: > Calling for a vote on CEP-8 [1]. > > To clarify the intent, as Benjamin said in the discussion thread [2], the > goal of this vote is simply to ensure that the community is in favor of > the donation. Nothing more. > The plan is to

Re: [DISCUSS] Remove deprecated keyspace_count_warn_threshold and table_count_warn_threshold

2023-06-13 Thread Josh McKenzie
> Warning that too many tables (including system) may have negative behavior I > think is fine This reminds me of the current situation with our tests where we just keep adding more and more without really considering the value of the current set and the costs of that body of work as it keeps

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-06-13 Thread Ekaterina Dimitrova
Thank you Maxim! I also agree with 1 and 2. Also, thank you for considering documentation. The datastax docs page mentioned here is not maintained by the project, the other one can get some love. I guess if we are adding description column, we can automate the way we populate that page. But I

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Michael Shuler
+1 On 6/13/23 09:14, Jeremy Hanna wrote: Calling for a vote on CEP-8 [1]. To clarify the intent, as Benjamin said in the discussion thread [2], the goal of this vote is simply to ensure that the community is in favor of the donation. Nothing more. The plan is to introduce the drivers, one by

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread DuyHai Doan
+1 nb On Tue, Jun 13, 2023 at 8:00 PM C. Scott Andreas wrote: > +1nb > > On Jun 13, 2023, at 10:25 AM, German Eichberger via dev < > dev@cassandra.apache.org> wrote: > >  > + 1 > > Great to see this moving forward! > -- > *From:* Abe Ratnofsky > *Sent:* Tuesday,

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-06-13 Thread Mick Semb Wever
> I want also to clarify and discuss with you some points related to the > SystemPropertiesTable virtual table. > > 1. Hide non-production environment properties in the SystemProperties > virtual table. > > As you may know, the result of the query on the virtual table > currently includes the

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread C. Scott Andreas
+1nbOn Jun 13, 2023, at 10:25 AM, German Eichberger via dev wrote: + 1 Great to see this moving forward! From: Abe Ratnofsky Sent: Tuesday, June 13, 2023 10:09 AM To: dev@cassandra.apache.org Subject: [EXTERNAL] Re: [VOTE] CEP-8 Datastax Drivers Donation   +1 (nb) On Jun 13,

Re: [DISCUSS] Remove deprecated keyspace_count_warn_threshold and table_count_warn_threshold

2023-06-13 Thread David Capwell
> I think that the combined decision of using a default value and counting > system tables was a mistake Default value I agree with you; features should be off by default! If we remove the default then we disable the feature by default (which im cool with) and for anyone who changed the

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread German Eichberger via dev
+ 1 Great to see this moving forward! From: Abe Ratnofsky Sent: Tuesday, June 13, 2023 10:09 AM To: dev@cassandra.apache.org Subject: [EXTERNAL] Re: [VOTE] CEP-8 Datastax Drivers Donation +1 (nb) On Jun 13, 2023, at 09:23, Andrés de la Peña wrote:  +1 On

[DISCUSS] Remove org.apache.cassandra.io.sstable.SSTableHeaderFix in trunk (5.0)?

2023-06-13 Thread David Capwell
org.apache.cassandra.io.sstable.SSTableHeaderFix was added due to bugs in 3.6 causing invalidate types or incompatible types (due to toString changes) in the SSTableHeader… this logic runs on start and rewrites all Stats files that had a mismatch from the local schema; with 5.0 requiring

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Abe Ratnofsky
+1 (nb)On Jun 13, 2023, at 09:23, Andrés de la Peña wrote:+1On Tue, 13 Jun 2023 at 16:40, Yifan Cai wrote: +1 From: David Capwell Sent: Tuesday, June 13, 2023 8:37:10 AM To: dev Subject: Re: [VOTE] CEP-8 Datastax

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Dinesh Joshi
+1 Dinesh > On Jun 13, 2023, at 7:15 AM, Jeremy Hanna wrote: > >  > Calling for a vote on CEP-8 [1]. > > To clarify the intent, as Benjamin said in the discussion thread [2], the > goal of this vote is simply to ensure that the community is in favor of the > donation. Nothing more. > The

Re: [DISCUSS] Remove deprecated keyspace_count_warn_threshold and table_count_warn_threshold

2023-06-13 Thread Andrés de la Peña
Indeed "keyspace_count_warn_threshold" and "table_count_warn_threshold" include system keyspaces and tables. Also, differently to the newer guardrails, they are enabled by default. I find that problematic because users need to know how many system keyspaces/tables there are to know if they need

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Caleb Rackliffe
+1 On Tue, Jun 13, 2023 at 11:25 AM Francisco Guerrero wrote: > +1 (nb) > > On 2023/06/13 16:22:55 Andrés de la Peña wrote: > > +1 > > > > On Tue, 13 Jun 2023 at 16:40, Yifan Cai wrote: > > > > > +1 > > > -- > > > *From:* David Capwell > > > *Sent:* Tuesday, June

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-06-13 Thread Maxim Muzafarov
Hello everyone, I have created the following JIRA issues to follow up on the discussion and to improve the user experience with virtual tables. I'll try to address them before the next release. CASSANDRA-18586: CQLSH formatting output is incorrect when querying the system properties virtual

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Francisco Guerrero
+1 (nb) On 2023/06/13 16:22:55 Andrés de la Peña wrote: > +1 > > On Tue, 13 Jun 2023 at 16:40, Yifan Cai wrote: > > > +1 > > -- > > *From:* David Capwell > > *Sent:* Tuesday, June 13, 2023 8:37:10 AM > > *To:* dev > > *Subject:* Re: [VOTE] CEP-8 Datastax Drivers

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Andrés de la Peña
+1 On Tue, 13 Jun 2023 at 16:40, Yifan Cai wrote: > +1 > -- > *From:* David Capwell > *Sent:* Tuesday, June 13, 2023 8:37:10 AM > *To:* dev > *Subject:* Re: [VOTE] CEP-8 Datastax Drivers Donation > > +1 > > On Jun 13, 2023, at 7:59 AM, Josh McKenzie wrote: > > +1

Re: [DISCUSS] Remove deprecated keyspace_count_warn_threshold and table_count_warn_threshold

2023-06-13 Thread David Capwell
> Have we been dropping support entirely for old params or using the @Replaces > annotation into perpetuity? My understanding is that the goal is to keep things around in perpetuity unless it actively causes us harm… and with @Replaces, there tends to be no harm to keep around… Looking at

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Yifan Cai
+1 From: David Capwell Sent: Tuesday, June 13, 2023 8:37:10 AM To: dev Subject: Re: [VOTE] CEP-8 Datastax Drivers Donation +1 On Jun 13, 2023, at 7:59 AM, Josh McKenzie wrote: +1 On Tue, Jun 13, 2023, at 10:55 AM, Jeremiah Jordan wrote: +1 nb On Jun 13,

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread David Capwell
+1 > On Jun 13, 2023, at 7:59 AM, Josh McKenzie wrote: > > +1 > > On Tue, Jun 13, 2023, at 10:55 AM, Jeremiah Jordan wrote: >> +1 nb >> >> On Jun 13, 2023 at 9:14:35 AM, Jeremy Hanna > > wrote: >>> >>> Calling for a vote on CEP-8 [1]. >>> >>> To clarify

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Josh McKenzie
+1 On Tue, Jun 13, 2023, at 10:55 AM, Jeremiah Jordan wrote: > +1 nb > > On Jun 13, 2023 at 9:14:35 AM, Jeremy Hanna > wrote: >> >> Calling for a vote on CEP-8 [1]. >> >> To clarify the intent, as Benjamin said in the discussion thread [2], the >> goal of this vote is simply to ensure that

Re: [DISCUSS] Remove deprecated keyspace_count_warn_threshold and table_count_warn_threshold

2023-06-13 Thread Josh McKenzie
> have subsequently been deprecated since 4.1-alpha in CASSANDRA-17195 when > they were replaced/migrated to guardrails as part of CEP-3 (Guardrails). Have we been dropping support entirely for old params or using the @Replaces annotation into perpetuity? I dislike the idea of operators having

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Jeremiah Jordan
+1 nb On Jun 13, 2023 at 9:14:35 AM, Jeremy Hanna wrote: > Calling for a vote on CEP-8 [1]. > > To clarify the intent, as Benjamin said in the discussion thread [2], the > goal of this vote is simply to ensure that the community is in favor of > the donation. Nothing more. > The plan is to

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Mick Semb Wever
Calling for a vote on CEP-8 [1]. > +1 to the CEP.

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Benjamin Lerer
+1 Le mar. 13 juin 2023 à 16:46, Ekaterina Dimitrova a écrit : > +1 > > On Tue, 13 Jun 2023 at 10:33, Jeff Jirsa wrote: > >> +1 >> >> >> On Tue, Jun 13, 2023 at 7:15 AM Jeremy Hanna >> wrote: >> >>> Calling for a vote on CEP-8 [1]. >>> >>> To clarify the intent, as Benjamin said in the

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Ekaterina Dimitrova
+1 On Tue, 13 Jun 2023 at 10:33, Jeff Jirsa wrote: > +1 > > > On Tue, Jun 13, 2023 at 7:15 AM Jeremy Hanna > wrote: > >> Calling for a vote on CEP-8 [1]. >> >> To clarify the intent, as Benjamin said in the discussion thread [2], the >> goal of this vote is simply to ensure that the community

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Jeff Jirsa
+1 On Tue, Jun 13, 2023 at 7:15 AM Jeremy Hanna wrote: > Calling for a vote on CEP-8 [1]. > > To clarify the intent, as Benjamin said in the discussion thread [2], the > goal of this vote is simply to ensure that the community is in favor of > the donation. Nothing more. > The plan is to

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Paulo Motta
+1 On Tue, Jun 13, 2023 at 10:16 AM Brandon Williams wrote: > +1 > > Kind Regards, > Brandon > > On Tue, Jun 13, 2023 at 9:15 AM Jeremy Hanna > wrote: > > > > Calling for a vote on CEP-8 [1]. > > > > To clarify the intent, as Benjamin said in the discussion thread [2], > the goal of this vote

Re: [VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Brandon Williams
+1 Kind Regards, Brandon On Tue, Jun 13, 2023 at 9:15 AM Jeremy Hanna wrote: > > Calling for a vote on CEP-8 [1]. > > To clarify the intent, as Benjamin said in the discussion thread [2], the > goal of this vote is simply to ensure that the community is in favor of the > donation. Nothing

[VOTE] CEP-8 Datastax Drivers Donation

2023-06-13 Thread Jeremy Hanna
Calling for a vote on CEP-8 [1]. To clarify the intent, as Benjamin said in the discussion thread [2], the goal of this vote is simply to ensure that the community is in favor of the donation. Nothing more. The plan is to introduce the drivers, one by one. Each driver donation will need to be

Re: [DISCUSS] Limiting query results by size (CASSANDRA-11745)

2023-06-13 Thread Benjamin Lerer
> > So my other question - for aggregation with the "group by" clause, we > return an aggregated row which is computed from a group of rows - with my > current implementation, it is approximated by counting the size of the > largest row in that group - I think it is the safest and simplest >