ent: Friday, October 13, 2023 15:36
To: dev
Cc: Miklosovic, Stefan
Subject: Re: [DISCUSS] putting versions into Deprecated annotations
NetApp Security WARNING: This is an external email. Do not click links or open
attachments unless you recognize the sender and know the content is safe.
I
>
> From: Miklosovic, Stefan via dev
> Sent: Friday, October 13, 2023 15:00
> To: dev@cassandra.apache.org
> Cc: Miklosovic, Stefan
> Subject: Re: [DISCUSS] putting versions into Deprecated annotations
>
> NetApp Security WARNING: Th
ubject: Re: [DISCUSS] putting versions into Deprecated annotations
NetApp Security WARNING: This is an external email. Do not click links or open
attachments unless you recognize the sender and know the content is safe.
OK. So here we are ... round 1 will be to map how bad it is, round 2 will be
t
into two parts.
From: Benjamin Lerer
Sent: Friday, October 13, 2023 14:45
To: dev@cassandra.apache.org
Subject: Re: [DISCUSS] putting versions into Deprecated annotations
NetApp Security WARNING: This is an external email. Do not click links or open
if we decide that, but we should provide some
>>> additional information like when it was deprecated and why it is necessary
>>> to keep it around otherwise the code-base will bloat and bloat ...
>>>
>>> (1) https://github.com/apache/cassandra/pull/2801/files
>>>
>>> __
andra/pull/2801/files
>>
>> ____________
>> From: Mick Semb Wever
>> Sent: Friday, October 13, 2023 13:51
>> To: dev@cassandra.apache.org
>> Subject: Re: [DISCUSS] putting versions into Deprecated annotations
>>
>> NetApp Securi
>
>
> From: Mick Semb Wever
> Sent: Friday, October 13, 2023 13:51
> To: dev@cassandra.apache.org
> Subject: Re: [DISCUSS] putting versions into Deprecated annotations
>
> NetApp Security WARNING: This is an external email. Do not click l
it
around otherwise the code-base will bloat and bloat ...
(1) https://github.com/apache/cassandra/pull/2801/files
From: Mick Semb Wever
Sent: Friday, October 13, 2023 13:51
To: dev@cassandra.apache.org
Subject: Re: [DISCUSS] putting versions into
______
>> From: Benjamin Lerer
>> Sent: Friday, October 13, 2023 13:07
>> To: dev@cassandra.apache.org
>> Subject: Re: [DISCUSS] putting versions into Deprecated annotations
>>
>> NetApp Security WARNING: This is an external email. Do not click lin
t if there was some
> solid guidance on this.
>
>
> From: Benjamin Lerer
> Sent: Friday, October 13, 2023 13:07
> To: dev@cassandra.apache.org
> Subject: Re: [DISCUSS] putting versions into Deprecated annotations
>
> NetApp Security WARNING: This is an exte
On Fri, 13 Oct 2023 at 13:07, Benjamin Lerer wrote:
> I was asking because outside of configuration parameters and JMX calls,
> the approach as far as I remember was to just change things without using
> an annotation.
>
Yes, it is my understanding that such deprecation is only needed on
if there was some solid
guidance on this.
From: Benjamin Lerer
Sent: Friday, October 13, 2023 13:07
To: dev@cassandra.apache.org
Subject: Re: [DISCUSS] putting versions into Deprecated annotations
NetApp Security WARNING: This is an external email. Do not click
l=https%3A%2F%2Fcheckstyle.sourceforge.io%2Fapidocs%2Fcom%2Fpuppycrawl%2Ftools%2Fcheckstyle%2Fchecks%2Fannotation%2FMissingDeprecatedCheck.html=05%7C01%7CStefan.Miklosovic%40netapp.com%7C59fa2b3786ff436c83ba08dbcbd5ece7%7C4b0911a0929b4715944bc03745165b3a%7C0%7C0%7C638327891917050879%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI
0%7C%7C%7C=8qKu8ob%2BvPdHfUQdkxr5C%2BgkR5iMcUaEqw9a%2FNN276k%3D=0>
> >
> > ____________
> > From: Francisco Guerrero mailto:fran...@apache.org>>
> > Sent: Tuesday, October 10, 2023 23:34
> > To: dev@cassandra.apache.org<mailto:d
/apidocs/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedCheck.html
> > >
> > >
> > > From: Francisco Guerrero
> > > Sent: Tuesday, October 10, 2023 23:34
> > > To: dev@cassandra.apache.org
> >
presence of both annotation and Javadoc comment is just enough.
> >
> > (1)
> > https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedCheck.html
> >
> > ________________
> > From: Fra
sday, October 10, 2023 23:34
> To: dev@cassandra.apache.org
> Subject: Re: [DISCUSS] putting versions into Deprecated annotations
>
> NetApp Security WARNING: This is an external email. Do not click links or
> open attachments unless you recognize the sender and know the content is safe.
>
tation/MissingDeprecatedCheck.html
>
>
> From: Francisco Guerrero
> Sent: Tuesday, October 10, 2023 23:34
> To: dev@cassandra.apache.org
> Subject: Re: [DISCUSS] putting versions into Deprecated annotations
>
> NetApp Security WARNING: This is an external email. Do not click li
ocs as mentioned. Let's
> > just stick with the standard stuff.
> >
> > I will try to implement this for 5.0 (versions since it was deprecated)
> > with my take on what should be removed (forRemoval = true) but that should
> > be definitely cross-checked on
gt; > with my take on what should be removed (forRemoval = true) but that should
> > be definitely cross-checked on review as Mick mentioned.
> >
> >
> > From: Mick Semb Wever
> > Sent: Monday, October 9, 2023 10:55
> >
take on what should be removed (forRemoval = true) but that should be
> definitely cross-checked on review as Mick mentioned.
>
>
> From: Mick Semb Wever
> Sent: Monday, October 9, 2023 10:55
> To: dev@cassandra.apache.org
> Subject: Re: [DIS
___
> From: Mick Semb Wever
> Sent: Monday, October 9, 2023 10:55
> To: dev@cassandra.apache.org
> Subject: Re: [DISCUSS] putting versions into Deprecated annotations
>
> NetApp Security WARNING: This is an external email. Do not click links or
> open attachment
be removed (forRemoval = true) but that should be
definitely cross-checked on review as Mick mentioned.
From: Mick Semb Wever
Sent: Monday, October 9, 2023 10:55
To: dev@cassandra.apache.org
Subject: Re: [DISCUSS] putting versions into Deprecated annotations
>
> Tangential question to this is if everything we deprecated is eligible for
> removal? In other words, are there any cases when forRemoval would be
> false? Could you elaborate on that and give such examples or do you all
> think that everything which is deprecated will be eventually removed?
>
for it.
From: Francisco Guerrero
Sent: Saturday, October 7, 2023 0:54
To: dev@cassandra.apache.org
Subject: Re: [DISCUSS] putting versions into Deprecated annotations
NetApp Security WARNING: This is an external email. Do not click links or open
attachments unless you
> Might be nice to support a 3rd param that's a String for the reason it's
> deprecated.
Javadocs offers this natively
/**
* @deprecated Use instance method {@link #newMethod(Param1, Param2...)}
instead.
*/
@Deprecated
So we could leverage javadocs for this purpose
On
+1 on reason string, especially some way to indicate what replaces a method if
it’s being moved into some other class/new method with more parameters/etc.
I’ve found lots of cases (in code bases in general, not C* in particular) where
something is marked as Deprecated but there’s no mention of
Might be nice to support a 3rd param that's a String for the reason it's
deprecated. i.e. "Replaced by X", "Unmaintained", "Obsolete", "See
CASSANDRA-N", link to a dev ML thread on pony mail, etc. That way if
someone comes across it in the codebase they have some context to follow up on
Hi list,
I have a ticket to discuss (1).
When we deprecate APIs / methods etc, what I want to suggest is that we might
start to explicitly add the version when that happened. For example, if you
deprecated something which goes to 5.0, would you be so nice to do this?
@Deprecated(since =
29 matches
Mail list logo
