Re: Use of OpOrder in memtable

Right. Although IIRC there is another OpOrder that coordinates the migration of readers from memtables to the sstables that replace them (and the reclamation of any off-heap memory associated with the memtable) On 13 February 2018 at 22:59, Tyagi, Preetika wrote: > Ah I see. That makes sense. >

Re: [VOTE] (Take 2) Release Apache Cassandra 3.11.2

Thank you, Kurt. I'll get to it within the next 12-24 hours (kids' homework time in the U.S. now ;) ) -Jason On Tue, Feb 13, 2018 at 5:10 PM, kurt greaves wrote: > CASSANDRA-14234 > patch > in for ReadCommandTest if anyone wants to take a

Re: row tombstones as a separate sstable citizen

I'm particularly interested in getting the tombstones to "promote" up the levels of LCS more quickly. Currently they get attached at the low level and don't propagate up to higher levels until enough activity at a lower level promotes the data. Meanwhile, LCS means compactions can occur in parallel

Re: [VOTE] (Take 2) Release Apache Cassandra 3.11.2

CASSANDRA-14234 patch in for ReadCommandTest if anyone wants to take a look. On 14 February 2018 at 00:45, kurt greaves wrote: > ​ReadCommandTest is still not passing. I would be a happy maintainer if >> someone could step up and analyze an

Re: [VOTE] (Take 2) Release Apache Cassandra 3.11.2

> > ​ReadCommandTest is still not passing. I would be a happy maintainer if > someone could step up and analyze and contribute a patch; I will review. Having a look. Appears to be just a case of using the same CF for multiple tests and metrics (tombstone histograms) aren't cleared in between.

Re: [VOTE] (Take 2) Release Apache Cassandra 3.11.2

CASSANDRA-14219 is committed, and ViewComplexTest is now green ( https://circleci.com/workflow-run/b1456e1c-c775-4fcb-82a1-ad3a00ced0d8). ReadCommandTest is still not passing. I would be a happy maintainer if someone could step up and analyze and contribute a patch; I will review. On Tue, Feb 13,

Re: [VOTE] Release Apache Cassandra 3.0.16

CASSANDRA-14219 is committed and tests look clean ( https://circleci.com/workflow-run/d0a2622a-e74f-4c46-b0ad-a84ca063736f). On Tue, Feb 13, 2018 at 1:47 PM, Brandon Williams wrote: > I change my vote to -1 binding as well. > > On Tue, Feb 13, 2018 at 3:43 PM, Jason Brown wrote: > > > -1, bindi

Re: row tombstones as a separate sstable citizen

Have you taken a look at the new stuff introduced by https://issues.apache.org/jira/browse/CASSANDRA-7019 ? I think it may go a ways to reducing the need for something complicated like this. Though it is an interesting idea as special handling for bulk deletes. If they were truly just sstables

Re: row tombstones as a separate sstable citizen

On Tue, Feb 13, 2018 at 2:38 PM, Carl Mueller wrote: > In process of doing my second major data purge from a cassandra system. > > Almost all of my purging is done via row tombstones. While performing this > the second time while trying to cajole compaction to occur (in 2.1.x, > LevelledCompactio

RE: Use of OpOrder in memtable

Ah I see. That makes sense. And it doesn't have to anything with the read requests going on in parallel with write requests, right? I mean we read the data from memtable depending on whatever has been written into memtable so far and return it to the client (of course including SSTable read and

row tombstones as a separate sstable citizen

In process of doing my second major data purge from a cassandra system. Almost all of my purging is done via row tombstones. While performing this the second time while trying to cajole compaction to occur (in 2.1.x, LevelledCompaction) to goddamn actually compact the data, I've been thinking as t

Re: Use of OpOrder in memtable

If you look closely, there can be multiple memtables extant at once. While all "new" writes are routed to the latest memtable, there may still be writes that have begun but not yet completed. The memtable cannot be flushed until any stragglers have completed, and some stragglers *may* still need

Use of OpOrder in memtable

Hi all, I'm trying to understand the behavior of memtable when writes/flush operations are going on in parallel. In my understanding, once a memtable is full it is queued for flushing and a new memtable is created for ongoing write operations. However, I was looking at the code and it looks lik

Re: Coordinator Write Metrics per CF

Sorry, I guess I'm tired. I thought this was discussing local write latency. I'm surprised we have that and not coordinator write latency. Please do ignore me, I'm not sure why I got involved! On 13 February 2018 at 21:48, Benedict Elliott Smith wrote: > For the record, I'm not certain there

Re: [VOTE] (Take 2) Release Apache Cassandra 3.11.2

I change my vote to -1 binding here, too. On Tue, Feb 13, 2018 at 3:45 PM, Jason Brown wrote: > -1, binding. Unit tests are broken: > https://circleci.com/gh/jasobrown/cassandra/452#tests/containers/60 > > > Dave ninja-committ

Re: Coordinator Write Metrics per CF

For the record, I'm not certain there *is* a great deal of value in this. The read latency metrics are expected to vary a great deal, since the entire IO subsystem is involved. Writes, however, go straight to a memtable. They only block on IO if we exceed our commit log flush bandwidth for an ex

Re: [VOTE] Release Apache Cassandra 3.0.16

I change my vote to -1 binding as well. On Tue, Feb 13, 2018 at 3:43 PM, Jason Brown wrote: > -1, binding. Unit tests are broken: > https://circleci.com/gh/jasobrown/cassandra/451#tests/containers/50 > > Dave ninja-committed 7df36056b12a13b60097b7a9a4f8155a1d02ff62 to update > some logging messa

Re: [VOTE] (Take 2) Release Apache Cassandra 3.11.2

-1, binding. Unit tests are broken: https://circleci.com/gh/jasobrown/cassandra/452#tests/containers/60 Dave ninja-committed 7df36056b12a13b60097b7a9a4f8155a1d02ff62 to update some logging messages, which broke ViewComplexTest.

Re: [VOTE] Release Apache Cassandra 3.0.16

-1, binding. Unit tests are broken: https://circleci.com/gh/jasobrown/cassandra/451#tests/containers/50 Dave ninja-committed 7df36056b12a13b60097b7a9a4f8155a1d02ff62 to update some logging messages, which broke ViewComplexTest. The errors like this: junit.framework.AssertionFailedError: Expected

Re: Coordinator Write Metrics per CF

Thanks Kurt and Chris for your valuable inputs. Created https://issues.apache.org/jira/browse/CASSANDRA-14232; I shall start working on this. Thanks, Sumanth On Mon, Feb 12, 2018 at 7:43 AM, Chris Lohfink wrote: > It would be good to have it. Its not that its not there because its > difficult o

Re: [VOTE] Release Apache Cassandra 3.0.16

+1 > On Feb 13, 2018, at 10:52 AM, Josh McKenzie wrote: > > +1 > > On Feb 13, 2018 9:20 AM, "Marcus Eriksson" wrote: > >> +1 >> >> On Tue, Feb 13, 2018 at 1:29 PM, Aleksey Yeshchenko >> wrote: >> >>> +1 >>> >>> — >>> AY >>> >>> On 12 February 2018 at 20:31:23, Michael Shuler (mich...@pba

Re: [VOTE] Release Apache Cassandra 2.1.20

+1 On Feb 13, 2018 12:19 PM, "Jason Brown" wrote: > +1 > > On Tue, Feb 13, 2018 at 7:20 AM, Marcus Eriksson > wrote: > > > +1 > > > > On Tue, Feb 13, 2018 at 1:30 PM, Aleksey Yeshchenko > > wrote: > > > > > +1 > > > > > > — > > > AY > > > > > > On 12 February 2018 at 20:30:58, Michael Shuler (

Re: [VOTE] Release Apache Cassandra 2.2.12

+1 On Feb 13, 2018 12:19 PM, "Jason Brown" wrote: > +1 > > On Tue, Feb 13, 2018 at 7:55 AM, Jon Haddad wrote: > > > +1 > > > > > > > On Feb 13, 2018, at 7:21 AM, Marcus Eriksson > wrote: > > > > > > +1 > > > > > > On Tue, Feb 13, 2018 at 4:18 PM, Gary Dusbabek > > wrote: > > > > > >> +1 > > >

Re: [VOTE] (Take 2) Release Apache Cassandra 3.11.2

+1 On Feb 13, 2018 9:36 AM, "Gary Dusbabek" wrote: > +1 > > On Mon, Feb 12, 2018 at 9:40 PM, Michael Shuler > wrote: > > > I propose the following artifacts for release as 3.11.2. > > > > sha1: 8a5e88f635fdb984505a99a553b5799cedccd06d > > Git: > > http://git-wip-us.apache.org/repos/asf?p=cassan

Re: [VOTE] Release Apache Cassandra 3.0.16

+1 On Feb 13, 2018 9:20 AM, "Marcus Eriksson" wrote: > +1 > > On Tue, Feb 13, 2018 at 1:29 PM, Aleksey Yeshchenko > wrote: > > > +1 > > > > — > > AY > > > > On 12 February 2018 at 20:31:23, Michael Shuler (mich...@pbandjelly.org) > > wrote: > > > > I propose the following artifacts for release

Re: [VOTE] Release Apache Cassandra 2.2.12

+1 On Tue, Feb 13, 2018 at 7:55 AM, Jon Haddad wrote: > +1 > > > > On Feb 13, 2018, at 7:21 AM, Marcus Eriksson wrote: > > > > +1 > > > > On Tue, Feb 13, 2018 at 4:18 PM, Gary Dusbabek > wrote: > > > >> +1 > >> > >> On Mon, Feb 12, 2018 at 2:30 PM, Michael Shuler > > >> wrote: > >> > >>> I pr

Re: [VOTE] Release Apache Cassandra 2.1.20

+1 On Tue, Feb 13, 2018 at 7:20 AM, Marcus Eriksson wrote: > +1 > > On Tue, Feb 13, 2018 at 1:30 PM, Aleksey Yeshchenko > wrote: > > > +1 > > > > — > > AY > > > > On 12 February 2018 at 20:30:58, Michael Shuler (mich...@pbandjelly.org) > > wrote: > > > > I propose the following artifacts for re

Re: CASSANDRA-14183 review request -> logback upgrade to fix CVE

Using the internals in ThreadAwareSecurityManager has caused countless problems, and needs to be fixed once and for all - There are 2 different patches up for review in https://issues.apache.org/jira/browse/CASSANDRA-13396 - would be nice if one could be selected, and hopefully whichever is chosen

Re: CASSANDRA-14183 review request -> logback upgrade to fix CVE

Ariel, >> Option 4, upgrade trunk, update NEWS.TXT in prior versions warning about the vulnerability +1 to this. I'll check the ticket, as well. On Tue, Feb 13, 2018 at 9:45 AM, Ariel Weisberg wrote: > Hi, > > Option 4, upgrade trunk, update NEWS.TXT in prior versions warning about > the vulne

Re: CASSANDRA-14183 review request -> logback upgrade to fix CVE

Hi, Option 4, upgrade trunk, update NEWS.TXT in prior versions warning about the vulnerability. Ariel On Tue, Feb 13, 2018, at 12:28 PM, Ariel Weisberg wrote: > Hi, > > So our options are: > > 1. Ignore it. > Most people aren't using this functionality. > Most people aren't and shouldn't be e

RE: CASSANDRA-14183 review request -> logback upgrade to fix CVE

Hi, I suppose upgrading Logback breaks Cassandra because some classes are used directly like in StorageService, ThreadAwareSecurityManager and StorageServiceMBean. This was a problem in my case as we're embedding Cassandra for our functional tests, I had to stub it as it was conflicting with lo

Re: CASSANDRA-14183 review request -> logback upgrade to fix CVE

Hi, So our options are: 1. Ignore it. Most people aren't using this functionality. Most people aren't and shouldn't be exposing the logging port to untrusted networks But everyone loses at defense in depth (or is it breadth) if they use this functionality and someone might expose the port 2. R

Re: CASSANDRA-14183 review request -> logback upgrade to fix CVE

Hi, I don't think the fix is in 1.1.11 looking at the diff between 1.1.11 and 1.2.0 https://github.com/qos-ch/logback/compare/v_1.1.11...v_1.2.0 I looked at 1.1.11 and 1.1.10 and didn't see it there either. When you say stuff broke do you mean stuff not in the dtests or utests? Ariel On Tue,

Re: CASSANDRA-14183 review request -> logback upgrade to fix CVE

Thanks, Michael and Jeremiah. That’s good input. Ok, let’s not hold up the vote. On Tue, Feb 13, 2018 at 08:58 Jeremiah D Jordan wrote: > s/does affect/does not affect/ > > > On Feb 13, 2018, at 11:57 AM, Jeremiah D Jordan < > jeremiah.jor...@gmail.com> wrote: > > > > I don’t think we need to s

Re: CASSANDRA-14183 review request -> logback upgrade to fix CVE

s/does affect/does not affect/ > On Feb 13, 2018, at 11:57 AM, Jeremiah D Jordan > wrote: > > I don’t think we need to stop the vote. This CVE has been around for a while > (3/13/2017), and does affect any install I have ever seen. It affects users > who manually enable some specific logbac

Re: CASSANDRA-14183 review request -> logback upgrade to fix CVE

I don’t think we need to stop the vote. This CVE has been around for a while (3/13/2017), and does affect any install I have ever seen. It affects users who manually enable some specific logback features using the SocketServer or ServerSocketReceiver component which are not used in our default

Re: CASSANDRA-14183 review request -> logback upgrade to fix CVE

I tried a logback 1.2.x jar update a number of months ago to fix the broken log rotation (try setting rotation to a large number - you'll find you only get I think it was 10 files, regardless of setting). Like we've found updating other jars in the past, this seemingly "simple" update broke a numb

Re: CASSANDRA-14183 review request -> logback upgrade to fix CVE

Ariel, If this is a legit CVE, then we would want to patch all the current versions we support - which is 2.1 and higher. Also, is this worth stopping the current open vote for this patch? (Not in a place to look at the patch and affects to impacted branches right now). Jason On Tue, Feb 13, 20

Re: CASSANDRA-14183 review request -> logback upgrade to fix CVE

Hi, Seems like users could conceivably be using the vulnerable component. Also seems like like we need potentially need to do this as far back as 2.1? Anyone else have an opinion before I commit this? What version to start from? Ariel On Tue, Feb 13, 2018, at 5:59 AM, Thiago Veronezi wrote: >

Re: [VOTE] Release Apache Cassandra 2.2.12

+1 > On Feb 13, 2018, at 7:21 AM, Marcus Eriksson wrote: > > +1 > > On Tue, Feb 13, 2018 at 4:18 PM, Gary Dusbabek wrote: > >> +1 >> >> On Mon, Feb 12, 2018 at 2:30 PM, Michael Shuler >> wrote: >> >>> I propose the following artifacts for release as 2.2.12. >>> >>> sha1: 1602e606348959ae

Re: [VOTE] (Take 2) Release Apache Cassandra 3.11.2

+1 On Mon, Feb 12, 2018 at 9:40 PM, Michael Shuler wrote: > I propose the following artifacts for release as 3.11.2. > > sha1: 8a5e88f635fdb984505a99a553b5799cedccd06d > Git: > http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a= > shortlog;h=refs/tags/3.11.2-tentative > Artifacts: > https:

Re: [VOTE] Release Apache Cassandra 2.2.12

+1 On Tue, Feb 13, 2018 at 4:18 PM, Gary Dusbabek wrote: > +1 > > On Mon, Feb 12, 2018 at 2:30 PM, Michael Shuler > wrote: > > > I propose the following artifacts for release as 2.2.12. > > > > sha1: 1602e606348959aead18531cb8027afb15f276e7 > > Git: > > http://git-wip-us.apache.org/repos/asf?p=

Re: [VOTE] Release Apache Cassandra 2.1.20

+1 On Tue, Feb 13, 2018 at 1:30 PM, Aleksey Yeshchenko wrote: > +1 > > — > AY > > On 12 February 2018 at 20:30:58, Michael Shuler (mich...@pbandjelly.org) > wrote: > > I propose the following artifacts for release as 2.1.20. > > sha1: b2949439ec62077128103540e42570238520f4ee > Git: > http://git-

Re: [VOTE] (Take 2) Release Apache Cassandra 3.11.2

+1 On Tue, Feb 13, 2018 at 1:32 PM, Aleksey Yeshchenko wrote: > +1 > > — > AY > > On 13 February 2018 at 03:41:09, Michael Shuler (mich...@pbandjelly.org) > wrote: > > I propose the following artifacts for release as 3.11.2. > > sha1: 8a5e88f635fdb984505a99a553b5799cedccd06d > Git: > http://git-

Re: [VOTE] Release Apache Cassandra 3.0.16

+1 On Tue, Feb 13, 2018 at 1:29 PM, Aleksey Yeshchenko wrote: > +1 > > — > AY > > On 12 February 2018 at 20:31:23, Michael Shuler (mich...@pbandjelly.org) > wrote: > > I propose the following artifacts for release as 3.0.16. > > sha1: 91e83c72de109521074b14a8eeae1309c3b1f215 > Git: > http://git-

Re: [VOTE] Release Apache Cassandra 2.2.12

+1 On Mon, Feb 12, 2018 at 2:30 PM, Michael Shuler wrote: > I propose the following artifacts for release as 2.2.12. > > sha1: 1602e606348959aead18531cb8027afb15f276e7 > Git: > http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a= > shortlog;h=refs/tags/2.2.12-tentative > Artifacts: > https:

Re: [VOTE] (Take 2) Release Apache Cassandra 3.11.2

+1 — AY On 13 February 2018 at 03:41:09, Michael Shuler (mich...@pbandjelly.org) wrote: I propose the following artifacts for release as 3.11.2. sha1: 8a5e88f635fdb984505a99a553b5799cedccd06d Git: http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=shortlog;h=refs/tags/3.11.2-tentati

Re: [VOTE] Release Apache Cassandra 2.1.20

+1 — AY On 12 February 2018 at 20:30:58, Michael Shuler (mich...@pbandjelly.org) wrote: I propose the following artifacts for release as 2.1.20. sha1: b2949439ec62077128103540e42570238520f4ee Git: http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=shortlog;h=refs/tags/2.1.20-tentati

Re: [VOTE] Release Apache Cassandra 3.0.16

+1 — AY On 12 February 2018 at 20:31:23, Michael Shuler (mich...@pbandjelly.org) wrote: I propose the following artifacts for release as 3.0.16. sha1: 91e83c72de109521074b14a8eeae1309c3b1f215 Git: http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=shortlog;h=refs/tags/3.0.16-tentati

Re: [VOTE] Release Apache Cassandra 2.2.12

+1 — AY On 12 February 2018 at 20:31:06, Michael Shuler (mich...@pbandjelly.org) wrote: I propose the following artifacts for release as 2.2.12. sha1: 1602e606348959aead18531cb8027afb15f276e7 Git: http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=shortlog;h=refs/tags/2.2.12-tentati

Re: CASSANDRA-14183 review request -> logback upgrade to fix CVE

Hi dev team, Sorry to keep bothering you. This is just a friendly reminder that I would like to contribute to this project starting with a fix for CASSANDRA-14183 . []s, Thiago. On Tue, Jan 30, 2018 at 8:05 AM, Thiago Veronezi wrote: >