pnoltes commented on a change in pull request #244:
URL: https://github.com/apache/celix/pull/244#discussion_r437689338
##
File path: libs/framework/include/celix_bundle_context.h
##
@@ -126,8 +126,38 @@ typedef struct celix_service_registration_options {
* for this.
pnoltes opened a new pull request #255:
URL: https://github.com/apache/celix/pull/255
Some small renaming
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
codecov-commenter commented on pull request #255:
URL: https://github.com/apache/celix/pull/255#issuecomment-642206358
# [Codecov](https://codecov.io/gh/apache/celix/pull/255?src=pr&el=h1) Report
> Merging [#255](https://codecov.io/gh/apache/celix/pull/255?src=pr&el=desc)
into
[master](
codecov-commenter edited a comment on pull request #255:
URL: https://github.com/apache/celix/pull/255#issuecomment-642206358
# [Codecov](https://codecov.io/gh/apache/celix/pull/255?src=pr&el=h1) Report
> Merging [#255](https://codecov.io/gh/apache/celix/pull/255?src=pr&el=desc)
into
[m
pnoltes merged pull request #250:
URL: https://github.com/apache/celix/pull/250
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pnoltes commented on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-642211354
@rbulter Is it possible to create two wire protocol bundles from the same
sources.
So a version 1 which encodes the same as released in 2.2.1 and a version 2
which adds the f
rbulter commented on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-642223828
>>@rbulter Is it possible to create two wire protocol bundles from the same
sources.
>>So a version 1 which encodes the same as released in 2.2.1 and a version 2
which adds the f
rbulter edited a comment on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-642223828
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
abroekhuis commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r437168634
##
File path: libs/framework/src/celix_log.c
##
@@ -26,6 +26,7 @@
#include "celix_log.h"
#include "celix_threads.h"
#include "celix_array_list.h"
+#incl
abroekhuis commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r438619890
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -1116,8 +1117,7 @@ char
*pubsub_tcpHandler_get_interface_url(pubsub_tcpHandle
abroekhuis commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r438620382
##
File path: bundles/remote_services/civetweb/src/civetweb.c
##
@@ -1,4 +1,4 @@
- /* Copyright (c) 2013-2015 the Civetweb developers
+/* Copyright (
abroekhuis commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r438620648
##
File path: bundles/http_admin/test/test/http_websocket_tests.cc
##
@@ -222,7 +222,8 @@ TEST(HTTP_ADMIN_INT_GROUP, websocket_echo_test) {
usleep(1
abroekhuis commented on a change in pull request #244:
URL: https://github.com/apache/celix/pull/244#discussion_r438622717
##
File path: libs/framework/include/celix_bundle_context.h
##
@@ -126,8 +126,38 @@ typedef struct celix_service_registration_options {
* for this.
codecov-commenter edited a comment on pull request #254:
URL: https://github.com/apache/celix/pull/254#issuecomment-640846079
# [Codecov](https://codecov.io/gh/apache/celix/pull/254?src=pr&el=h1) Report
> Merging [#254](https://codecov.io/gh/apache/celix/pull/254?src=pr&el=desc)
into
[m
codecov-commenter edited a comment on pull request #254:
URL: https://github.com/apache/celix/pull/254#issuecomment-640846079
# [Codecov](https://codecov.io/gh/apache/celix/pull/254?src=pr&el=h1) Report
> Merging [#254](https://codecov.io/gh/apache/celix/pull/254?src=pr&el=desc)
into
[m
pnoltes opened a new pull request #256:
URL: https://github.com/apache/celix/pull/256
The pubsub utils tests fail from time to time. The PR fixes that issue. I
have rerun several time to ensure to issues is not triggered anymore.
---
codecov-commenter commented on pull request #256:
URL: https://github.com/apache/celix/pull/256#issuecomment-642560318
# [Codecov](https://codecov.io/gh/apache/celix/pull/256?src=pr&el=h1) Report
> Merging [#256](https://codecov.io/gh/apache/celix/pull/256?src=pr&el=desc)
into
[master](
pnoltes merged pull request #255:
URL: https://github.com/apache/celix/pull/255
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pnoltes merged pull request #254:
URL: https://github.com/apache/celix/pull/254
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
abroekhuis commented on a change in pull request #256:
URL: https://github.com/apache/celix/pull/256#discussion_r438706986
##
File path: bundles/pubsub/pubsub_utils/src/pubsub_serialization_provider.c
##
@@ -258,6 +258,21 @@ static dyn_message_type*
pubsub_serializationProvide
pnoltes commented on a change in pull request #256:
URL: https://github.com/apache/celix/pull/256#discussion_r438873946
##
File path: bundles/pubsub/pubsub_utils/src/pubsub_serialization_provider.c
##
@@ -258,6 +258,21 @@ static dyn_message_type*
pubsub_serializationProvider_p
pnoltes merged pull request #256:
URL: https://github.com/apache/celix/pull/256
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
codecov-commenter edited a comment on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-640841097
# [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=h1) Report
> Merging [#253](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=desc)
into
[m
rbulter commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r438984082
##
File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_topic_sender.c
##
@@ -635,13 +631,24 @@ static int psa_zmq_topicPublicationSend(void* handle,
un
codecov-commenter edited a comment on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-640841097
# [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=h1) Report
> Merging [#253](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=desc)
into
[m
rbulter commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r438984082
##
File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_topic_sender.c
##
@@ -635,13 +631,24 @@ static int psa_zmq_topicPublicationSend(void* handle,
un
rbulter commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r438984082
##
File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_topic_sender.c
##
@@ -635,13 +631,24 @@ static int psa_zmq_topicPublicationSend(void* handle,
un
codecov-commenter edited a comment on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-640841097
# [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=h1) Report
> Merging [#253](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=desc)
into
[m
rbulter commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r438988041
##
File path:
bundles/pubsub/pubsub_protocol_wire_v1/src/pubsub_wire_protocol_impl.c
##
@@ -175,6 +176,27 @@ celix_status_t pubsubProtocol_encodeMetadata(voi
rbulter commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r438988614
##
File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_topic_receiver.c
##
@@ -650,6 +650,8 @@ static void* psa_zmq_recvThread(void * data) {
rbulter commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r438988878
##
File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_topic_receiver.c
##
@@ -650,6 +650,8 @@ static void* psa_zmq_recvThread(void * data) {
abroekhuis commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r439204971
##
File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_topic_sender.c
##
@@ -635,13 +631,24 @@ static int psa_zmq_topicPublicationSend(void* handle,
abroekhuis commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r439205114
##
File path: libs/framework/src/celix_log.c
##
@@ -26,6 +26,7 @@
#include "celix_log.h"
#include "celix_threads.h"
#include "celix_array_list.h"
+#incl
abroekhuis commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r439205651
##
File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_topic_sender.c
##
@@ -621,8 +626,9 @@ static int psa_zmq_topicPublicationSend(void* handle,
u
Oipo commented on a change in pull request #249:
URL: https://github.com/apache/celix/pull/249#discussion_r439271452
##
File path: bundles/http_admin/http_admin/src/activator.c
##
@@ -61,6 +61,15 @@ static int http_admin_start(http_admin_activator_t *act,
celix_bundle_context_
Oipo commented on a change in pull request #249:
URL: https://github.com/apache/celix/pull/249#discussion_r439271452
##
File path: bundles/http_admin/http_admin/src/activator.c
##
@@ -61,6 +61,15 @@ static int http_admin_start(http_admin_activator_t *act,
celix_bundle_context_
rbulter commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r439621576
##
File path: libs/framework/src/celix_log.c
##
@@ -26,6 +26,7 @@
#include "celix_log.h"
#include "celix_threads.h"
#include "celix_array_list.h"
+#include
rbulter commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r439621576
##
File path: libs/framework/src/celix_log.c
##
@@ -26,6 +26,7 @@
#include "celix_log.h"
#include "celix_threads.h"
#include "celix_array_list.h"
+#include
rbulter commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r439621996
##
File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_topic_sender.c
##
@@ -621,8 +626,9 @@ static int psa_zmq_topicPublicationSend(void* handle,
unsi
rbulter commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r439623009
##
File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_topic_sender.c
##
@@ -621,8 +626,9 @@ static int psa_zmq_topicPublicationSend(void* handle,
unsi
codecov-commenter edited a comment on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-640841097
# [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=h1) Report
> Merging [#253](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=desc)
into
[m
codecov-commenter edited a comment on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-640841097
# [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=h1) Report
> Merging [#253](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=desc)
into
[m
pnoltes commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r439967855
##
File path: libs/framework/src/celix_log.c
##
@@ -26,6 +26,7 @@
#include "celix_log.h"
#include "celix_threads.h"
#include "celix_array_list.h"
+#include
pnoltes commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r439969943
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_topic_receiver.c
##
@@ -209,9 +207,7 @@ pubsub_tcp_topic_receiver_t
*pubsub_tcpTopicReceiver_cre
pnoltes commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r439971625
##
File path: libs/framework/src/celix_log.c
##
@@ -26,6 +26,7 @@
#include "celix_log.h"
#include "celix_threads.h"
#include "celix_array_list.h"
+#include
pnoltes commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r440037844
##
File path: bundles/pubsub/pubsub_protocol_wire_v2/CMakeLists.txt
##
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mo
pnoltes commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r440038050
##
File path: bundles/pubsub/pubsub_protocol_wire_v2/CMakeLists.txt
##
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mo
Oipo commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r441480536
##
File path: bundles/remote_services/civetweb/src/civetweb.c
##
@@ -1,4 +1,4 @@
- /* Copyright (c) 2013-2015 the Civetweb developers
+/* Copyright (c) 201
Oipo commented on a change in pull request #249:
URL: https://github.com/apache/celix/pull/249#discussion_r441515670
##
File path: bundles/http_admin/http_admin/src/activator.c
##
@@ -61,6 +61,15 @@ static int http_admin_start(http_admin_activator_t *act,
celix_bundle_context_
pnoltes opened a new pull request #257:
URL: https://github.com/apache/celix/pull/257
Refactors all pubsub admins to support multiple subscriber services with the
same topic/scope combination in a single bundle.
@Oipo Could you also have a look?
pnoltes commented on issue #161:
URL: https://github.com/apache/celix/issues/161#issuecomment-64355
in #257 the web socket tests are working again under osx
This is an automated message from the Apache Git Service.
To res
Oipo commented on a change in pull request #257:
URL: https://github.com/apache/celix/pull/257#discussion_r442072432
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_topic_receiver.c
##
@@ -550,14 +554,19 @@ processMsgForSubscriberEntry(pubsub_tcp_topic_receiver_t
pnoltes commented on a change in pull request #257:
URL: https://github.com/apache/celix/pull/257#discussion_r442095368
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_topic_receiver.c
##
@@ -550,14 +554,19 @@ processMsgForSubscriberEntry(pubsub_tcp_topic_receiver_
pnoltes commented on pull request #257:
URL: https://github.com/apache/celix/pull/257#issuecomment-645901364
> The changes made so far look good to me, but I think all the senders have
the same issue and would need a similar refactoring.
no. a publisher service is registered as servi
pnoltes commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r442417729
##
File path: libs/framework/src/celix_log.c
##
@@ -26,6 +26,7 @@
#include "celix_log.h"
#include "celix_threads.h"
#include "celix_array_list.h"
+#include
pnoltes commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r442418039
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_topic_receiver.c
##
@@ -209,9 +207,7 @@ pubsub_tcp_topic_receiver_t
*pubsub_tcpTopicReceiver_cre
pnoltes commented on a change in pull request #257:
URL: https://github.com/apache/celix/pull/257#discussion_r442463106
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_topic_receiver.c
##
@@ -550,14 +554,19 @@ processMsgForSubscriberEntry(pubsub_tcp_topic_receiver_
Oipo commented on pull request #257:
URL: https://github.com/apache/celix/pull/257#issuecomment-646287483
LGTM.
What'd be really desirable is a shared_ptr, I think. But it's C
:sweat_smile:.
This is an automated mess
pnoltes closed issue #161:
URL: https://github.com/apache/celix/issues/161
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
pnoltes merged pull request #257:
URL: https://github.com/apache/celix/pull/257
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pnoltes commented on issue #161:
URL: https://github.com/apache/celix/issues/161#issuecomment-646440261
fixed in #257
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
codecov-commenter edited a comment on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-640841097
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
Oipo opened a new pull request #258:
URL: https://github.com/apache/celix/pull/258
Tried to introduce MSG_ZEROCOPY to the TCP admin, but that's too much
headache. Instead, this is what is left over from my foray into that world.
@rbulter @pnoltes please take a look.
---
Oipo commented on pull request #258:
URL: https://github.com/apache/celix/pull/258#issuecomment-646986165
Apple failures are because the test did not have enough time to send all 100
messages and stopped at around message number 95.
pnoltes opened a new pull request #259:
URL: https://github.com/apache/celix/pull/259
This PR contains an experimental implementation of a Celix C++ Framework.
See the README for more info:
misc/experimental/cxx_framework/README.md
https://github.com/pnoltes/celix/blob/feature
abroekhuis commented on pull request #259:
URL: https://github.com/apache/celix/pull/259#issuecomment-648026035
Why not merge to a branch? I'd like to have it at Celix, but for me a branch
is fine.
This is an automated messa
pnoltes merged pull request #253:
URL: https://github.com/apache/celix/pull/253
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pnoltes closed pull request #258:
URL: https://github.com/apache/celix/pull/258
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pnoltes commented on pull request #249:
URL: https://github.com/apache/celix/pull/249#issuecomment-648234056
the wire protocol v2 merge created a merge conflicts. @Oipo can you merge
with master?
This is an automated message
Oipo commented on pull request #258:
URL: https://github.com/apache/celix/pull/258#issuecomment-648256061
???
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
pnoltes commented on pull request #259:
URL: https://github.com/apache/celix/pull/259#issuecomment-648291031
> Why not merge to a branch? I'd like to have it at Celix, but for me a
branch is fine.
That is also possible. I am bit worried that eventually the branch will
diverge to omu
pnoltes commented on pull request #258:
URL: https://github.com/apache/celix/pull/258#issuecomment-648292297
Did I close this. I though I just merged the
feature/proposal_protocol_footer branch.
@Oipo can you reopen this on the master branch?
--
pnoltes edited a comment on pull request #258:
URL: https://github.com/apache/celix/pull/258#issuecomment-648292297
Did I close this? I though I just merged the
feature/proposal_protocol_footer branch.
@Oipo can you reopen this on the master branch?
---
Oipo opened a new pull request #260:
URL: https://github.com/apache/celix/pull/260
Because of squash after my PR, this PR shows more commits than there
actually are.
This is an automated message from the Apache Git Service.
codecov-commenter commented on pull request #260:
URL: https://github.com/apache/celix/pull/260#issuecomment-648325425
# [Codecov](https://codecov.io/gh/apache/celix/pull/260?src=pr&el=h1) Report
> Merging [#260](https://codecov.io/gh/apache/celix/pull/260?src=pr&el=desc)
into
[master](
Oipo opened a new pull request #261:
URL: https://github.com/apache/celix/pull/261
@abroekhuis @pnoltes this test currently cannot add the pubsub publisher
dependencies because it thinks it's in a system bundle. How do I get the test
to start the publisher properly? The test gives the foll
Oipo commented on pull request #245:
URL: https://github.com/apache/celix/pull/245#issuecomment-650041863
@pnoltes While this branch has seen several approvals, I have this gut
feeling that now is not an opportune time to merge this. There's been much
activity to get our next release up to
Oipo edited a comment on pull request #245:
URL: https://github.com/apache/celix/pull/245#issuecomment-650041863
@pnoltes While this branch has seen several approvals, I have this gut
feeling that now is not an opportune time to merge this. There's been much
activity to get our next releas
pnoltes commented on a change in pull request #261:
URL: https://github.com/apache/celix/pull/261#discussion_r446152795
##
File path: bundles/pubsub/pubsub_topology_manager/src/pubsub_topology_manager.c
##
@@ -69,7 +69,13 @@ celix_status_t
pubsub_topologyManager_create(celix_b
pnoltes commented on a change in pull request #261:
URL: https://github.com/apache/celix/pull/261#discussion_r446152795
##
File path: bundles/pubsub/pubsub_topology_manager/src/pubsub_topology_manager.c
##
@@ -69,7 +69,13 @@ celix_status_t
pubsub_topologyManager_create(celix_b
Oipo commented on a change in pull request #261:
URL: https://github.com/apache/celix/pull/261#discussion_r446171761
##
File path: bundles/pubsub/pubsub_topology_manager/src/pubsub_topology_manager.c
##
@@ -69,7 +69,13 @@ celix_status_t
pubsub_topologyManager_create(celix_bund
rbulter opened a new pull request #262:
URL: https://github.com/apache/celix/pull/262
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Oipo commented on pull request #249:
URL: https://github.com/apache/celix/pull/249#issuecomment-650996431
@pnoltes done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
Oipo commented on a change in pull request #262:
URL: https://github.com/apache/celix/pull/262#discussion_r446855467
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -865,12 +865,12 @@ int pubsub_tcpHandler_read(pubsub_tcpHandler_t *handle,
int fd)
Oipo commented on a change in pull request #262:
URL: https://github.com/apache/celix/pull/262#discussion_r446855467
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -865,12 +865,12 @@ int pubsub_tcpHandler_read(pubsub_tcpHandler_t *handle,
int fd)
Oipo commented on pull request #262:
URL: https://github.com/apache/celix/pull/262#issuecomment-651012504
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
pnoltes commented on pull request #249:
URL: https://github.com/apache/celix/pull/249#issuecomment-651043170
This PR is merged, but currently github seems to have to detect/handle that.
Closing PR
This is an automated mes
pnoltes closed pull request #249:
URL: https://github.com/apache/celix/pull/249
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
abroekhuis opened a new pull request #263:
URL: https://github.com/apache/celix/pull/263
@pnoltes please review, but do not yet merge.
Todo:
- Waiting for Apache infra to setup token
- Enable upload if other steps are ok (to prevent reaching the limit of
allowed coverity scans)
rlenferink commented on a change in pull request #263:
URL: https://github.com/apache/celix/pull/263#discussion_r446943351
##
File path: .github/workflows/coverity-scan.yml
##
@@ -0,0 +1,56 @@
+name: coverity-scan
+on:
+ schedule:
+- cron: '0 0 * * 0' # Weekly at 00:00 UTC
abroekhuis commented on a change in pull request #263:
URL: https://github.com/apache/celix/pull/263#discussion_r446951095
##
File path: .github/workflows/coverity-scan.yml
##
@@ -0,0 +1,56 @@
+name: coverity-scan
+on:
+ schedule:
+- cron: '0 0 * * 0' # Weekly at 00:00 UTC
pnoltes merged pull request #262:
URL: https://github.com/apache/celix/pull/262
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rlenferink commented on a change in pull request #263:
URL: https://github.com/apache/celix/pull/263#discussion_r446958706
##
File path: .github/workflows/coverity-scan.yml
##
@@ -0,0 +1,56 @@
+name: coverity-scan
+on:
+ schedule:
+- cron: '0 0 * * 0' # Weekly at 00:00 UTC
abroekhuis commented on a change in pull request #263:
URL: https://github.com/apache/celix/pull/263#discussion_r447244695
##
File path: .github/workflows/coverity-scan.yml
##
@@ -0,0 +1,56 @@
+name: coverity-scan
+on:
+ schedule:
+- cron: '0 0 * * 0' # Weekly at 00:00 UTC
pnoltes opened a new pull request #264:
URL: https://github.com/apache/celix/pull/264
Fixes an issue where pubsub receivers where connecting to the wrong senders.
This was because the publisher topic and scope where not check before
connection in the setupTopicReceiver call.
abroekhuis commented on a change in pull request #264:
URL: https://github.com/apache/celix/pull/264#discussion_r447471177
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_admin.c
##
@@ -610,15 +610,13 @@ celix_status_t pubsub_tcpAdmin_addDiscoveredEndpoint(void
*h
pnoltes commented on a change in pull request #264:
URL: https://github.com/apache/celix/pull/264#discussion_r447536602
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_admin.c
##
@@ -610,15 +610,13 @@ celix_status_t pubsub_tcpAdmin_addDiscoveredEndpoint(void
*hand
abroekhuis commented on a change in pull request #264:
URL: https://github.com/apache/celix/pull/264#discussion_r447674335
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_admin.c
##
@@ -610,15 +610,13 @@ celix_status_t pubsub_tcpAdmin_addDiscoveredEndpoint(void
*h
pnoltes merged pull request #264:
URL: https://github.com/apache/celix/pull/264
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pnoltes opened a new pull request #265:
URL: https://github.com/apache/celix/pull/265
Fixes an issue in the pubsub topology manager (pstm), which can deadlocks
when setting up topic senders.
This PR is a continuation of #261. As result #261 can be closed.
--
901 - 1000 of 2506 matches
Mail list logo
