[jira] [Commented] (CLIMATE-909) An example script to evaluate joint PDF of precipitation intensity and duration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLIMATE-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972109#comment-15972109
 ] 

ASF GitHub Bot commented on CLIMATE-909:


GitHub user huikyole opened a pull request:

https://github.com/apache/climate/pull/436

CLIMATE-909 - An example script to evaluate joint PDF of precipitation 
intensity and duration

- A new example, GPM_WRF24_JPDF_comparison, has been added.
- Joint PDF metric has been debugged.
- A new plotting module, draw_precipitation_JPDF, has been added.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/huikyole/climate CLIMATE-909

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/climate/pull/436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #436


commit 2c4b4becffccad1ee8dbc5eb6681124ef046bb92
Author: huikyole 
Date:   2017-04-18T04:39:08Z

CLIMATE-909 - An example script to evaluate joint PDF of precipitation 
intensity and duration

- A new example, GPM_WRF24_JPDF_comparison, has been added.
- Joint PDF metric has been debugged.
- A new plotting module, draw_precipitation_JPDF, has been added.




> An example script to evaluate joint PDF of precipitation intensity and 
> duration
> ---
>
> Key: CLIMATE-909
> URL: https://issues.apache.org/jira/browse/CLIMATE-909
> Project: Apache Open Climate Workbench
>  Issue Type: Improvement
>Reporter: Huikyo Lee
>Assignee: Huikyo Lee
> Fix For: 1.2.0
>
>
> The new example script will calculate the JPDF with sample observation and 
> model datasets and compare the two JPDF.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] climate pull request #436: CLIMATE-909 - An example script to evaluate joint...

[huikyole]

GitHub user huikyole opened a pull request:

https://github.com/apache/climate/pull/436

CLIMATE-909 - An example script to evaluate joint PDF of precipitation 
intensity and duration

- A new example, GPM_WRF24_JPDF_comparison, has been added.
- Joint PDF metric has been debugged.
- A new plotting module, draw_precipitation_JPDF, has been added.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/huikyole/climate CLIMATE-909

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/climate/pull/436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #436


commit 2c4b4becffccad1ee8dbc5eb6681124ef046bb92
Author: huikyole 
Date:   2017-04-18T04:39:08Z

CLIMATE-909 - An example script to evaluate joint PDF of precipitation 
intensity and duration

- A new example, GPM_WRF24_JPDF_comparison, has been added.
- Joint PDF metric has been debugged.
- A new plotting module, draw_precipitation_JPDF, has been added.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (CLIMATE-910) Throw an exception for inconsistent temporal reshaping / rebinning operatations

[Alex Goodman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLIMATE-910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Goodman resolved CLIMATE-910.
--
Resolution: Fixed

> Throw an exception for inconsistent temporal reshaping / rebinning 
> operatations
> ---
>
> Key: CLIMATE-910
> URL: https://issues.apache.org/jira/browse/CLIMATE-910
> Project: Apache Open Climate Workbench
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Alex Goodman
>Assignee: Alex Goodman
> Fix For: 1.2.0
>
>
> CLIMATE-897 fixed an issue where running ocw with python 3.x and numpy 1.11.x 
> resulted in errors if temporal rebinning / reshaping was done due to the 
> division operator ( / ) always returning floats in python 3.x, and floats 
> being illegal types for array shapes in numpy 1.11.x. These statements were 
> replaced with the floor operator ( // ) to suppress this behavior.
> However, CLIMATE-900 and CLIMATE-902 reverted some of these changes for the 
> sake of making sure an error is thrown if the new shapes are inconsistent. 
> For example, rebinning 13 months of data to yearly should throw an error 
> because 12 does not evenly divide into 13, which would be allowed to pass 
> silently when using floor division. However, this resulted in the same errors 
> that CLIMATE-897 was supposed to fix. We will revert to using floor division 
> again with an additional check for divisibility to ensure consistency in the 
> calculated shapes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] climate pull request #435: [CLIMATE 910] Throw an exception for inconsistent...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/435


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request #435: [CLIMATE 910] Throw an exception for inconsistent...

[agoodm]

GitHub user agoodm opened a pull request:

https://github.com/apache/climate/pull/435

[CLIMATE 910] Throw an exception for inconsistent temporal reshaping / 
rebinning operatations

This should fix the build errors for python 3. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/agoodm/climate CLIMATE-910

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/climate/pull/435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #435


commit 169f182b29191f9190ca4aa2a388005568556f18
Author: Alex Goodman 
Date:   2017-04-17T20:36:45Z

ntime % nmonth should always be 0 for reshape / rebin




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (CLIMATE-910) Throw an exception for inconsistent temporal reshaping / rebinning operatations

[Alex Goodman (JIRA)]

Alex Goodman created CLIMATE-910:


 Summary: Throw an exception for inconsistent temporal reshaping / 
rebinning operatations
 Key: CLIMATE-910
 URL: https://issues.apache.org/jira/browse/CLIMATE-910
 Project: Apache Open Climate Workbench
  Issue Type: Bug
Affects Versions: 1.1.0
Reporter: Alex Goodman
Assignee: Alex Goodman
 Fix For: 1.2.0


CLIMATE-897 fixed an issue where running ocw with python 3.x and numpy 1.11.x 
resulted in errors if temporal rebinning / reshaping was done due to the 
division operator ( / ) always returning floats in python 3.x, and floats being 
illegal types for array shapes in numpy 1.11.x. These statements were replaced 
with the floor operator ( // ) to suppress this behavior.

However, CLIMATE-900 and CLIMATE-902 reverted some of these changes for the 
sake of making sure an error is thrown if the new shapes are inconsistent. For 
example, rebinning 13 months of data to yearly should throw an error because 12 
does not evenly divide into 13, which would be allowed to pass silently when 
using floor division. However, this resulted in the same errors that 
CLIMATE-897 was supposed to fix. We will revert to using floor division again 
with an additional check for divisibility to ensure consistency in the 
calculated shapes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (CLIMATE-909) An example script to evaluate joint PDF of precipitation intensity and duration

[Huikyo Lee (JIRA)]

Huikyo Lee created CLIMATE-909:
--

 Summary: An example script to evaluate joint PDF of precipitation 
intensity and duration
 Key: CLIMATE-909
 URL: https://issues.apache.org/jira/browse/CLIMATE-909
 Project: Apache Open Climate Workbench
  Issue Type: Improvement
Reporter: Huikyo Lee
Assignee: Huikyo Lee
 Fix For: 1.2.0


The new example script will calculate the JPDF with sample observation and 
model datasets and compare the two JPDF.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (CLIMATE-896) Patch code updates for matplotlib 2.0 compatibility in 1.1.0 conda recipe

[Alex Goodman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLIMATE-896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Goodman closed CLIMATE-896.

Resolution: Won't Fix

Ultimately, getting the patch to work correctly is more trouble than it's worth 
since this just results in slightly different contour levels rather than not 
working outright.

> Patch code updates for matplotlib 2.0 compatibility in 1.1.0 conda recipe
> -
>
> Key: CLIMATE-896
> URL: https://issues.apache.org/jira/browse/CLIMATE-896
> Project: Apache Open Climate Workbench
>  Issue Type: Task
>  Components: build process
>Affects Versions: 1.1.0
>Reporter: Alex Goodman
>Assignee: Alex Goodman
> Fix For: 1.2.0
>
>
> See CLIMATE-895



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLIMATE-905) Box whisker plot to evaluate simulate trends

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLIMATE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971483#comment-15971483
 ] 

ASF GitHub Bot commented on CLIMATE-905:


Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/434


> Box whisker plot to evaluate simulate trends
> 
>
> Key: CLIMATE-905
> URL: https://issues.apache.org/jira/browse/CLIMATE-905
> Project: Apache Open Climate Workbench
>  Issue Type: New Feature
>  Components: visualization
>Affects Versions: 1.1.0
>Reporter: Huikyo Lee
>Assignee: Huikyo Lee
> Fix For: 1.2.0
>
>
> A new module to draw a box whisker plot and evaluate trends simulated by 
> multiple models will be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] climate pull request #434: CLIMATE-905 - Box whisker plot to evaluate simula...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/434


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (CLIMATE-905) Box whisker plot to evaluate simulate trends

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLIMATE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971374#comment-15971374
 ] 

ASF GitHub Bot commented on CLIMATE-905:


Github user huikyole commented on a diff in the pull request:

https://github.com/apache/climate/pull/434#discussion_r111779716
  
--- Diff: ocw/dataset_processor.py ---
@@ -391,8 +391,11 @@ def subset(target_dataset, subregion, 
subregion_name=None, extract=True, user_ma
 '''
 
 if not subregion.start:
-subregion.start = target_dataset.times[0]
-subregion.end = target_dataset.times[-1]
+time_start = target_dataset.times[0]
--- End diff --

Thanks, @agoodm . I defined time_start and time_end not to change the 
subregion object in case the object is used again for subsetting another OCW 
dataset. I will update the test.


> Box whisker plot to evaluate simulate trends
> 
>
> Key: CLIMATE-905
> URL: https://issues.apache.org/jira/browse/CLIMATE-905
> Project: Apache Open Climate Workbench
>  Issue Type: New Feature
>  Components: visualization
>Affects Versions: 1.1.0
>Reporter: Huikyo Lee
>Assignee: Huikyo Lee
> Fix For: 1.2.0
>
>
> A new module to draw a box whisker plot and evaluate trends simulated by 
> multiple models will be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] climate pull request #434: CLIMATE-905 - Box whisker plot to evaluate simula...

[huikyole]

Github user huikyole commented on a diff in the pull request:

https://github.com/apache/climate/pull/434#discussion_r111779716
  
--- Diff: ocw/dataset_processor.py ---
@@ -391,8 +391,11 @@ def subset(target_dataset, subregion, 
subregion_name=None, extract=True, user_ma
 '''
 
 if not subregion.start:
-subregion.start = target_dataset.times[0]
-subregion.end = target_dataset.times[-1]
+time_start = target_dataset.times[0]
--- End diff --

Thanks, @agoodm . I defined time_start and time_end not to change the 
subregion object in case the object is used again for subsetting another OCW 
dataset. I will update the test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (CLIMATE-905) Box whisker plot to evaluate simulate trends

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLIMATE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971369#comment-15971369
 ] 

ASF GitHub Bot commented on CLIMATE-905:


Github user agoodm commented on a diff in the pull request:

https://github.com/apache/climate/pull/434#discussion_r111778443
  
--- Diff: ocw/dataset_processor.py ---
@@ -391,8 +391,11 @@ def subset(target_dataset, subregion, 
subregion_name=None, extract=True, user_ma
 '''
 
 if not subregion.start:
-subregion.start = target_dataset.times[0]
-subregion.end = target_dataset.times[-1]
+time_start = target_dataset.times[0]
--- End diff --

The helper function `_are_bounds_contained_by_dataset)_` will now always 
throw an exception if the `start` and `end` attributes of the subregion 
instance are not defined. Was there any particular reason you made this change?


> Box whisker plot to evaluate simulate trends
> 
>
> Key: CLIMATE-905
> URL: https://issues.apache.org/jira/browse/CLIMATE-905
> Project: Apache Open Climate Workbench
>  Issue Type: New Feature
>  Components: visualization
>Affects Versions: 1.1.0
>Reporter: Huikyo Lee
>Assignee: Huikyo Lee
> Fix For: 1.2.0
>
>
> A new module to draw a box whisker plot and evaluate trends simulated by 
> multiple models will be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] climate pull request #434: CLIMATE-905 - Box whisker plot to evaluate simula...

[agoodm]

Github user agoodm commented on a diff in the pull request:

https://github.com/apache/climate/pull/434#discussion_r111778443
  
--- Diff: ocw/dataset_processor.py ---
@@ -391,8 +391,11 @@ def subset(target_dataset, subregion, 
subregion_name=None, extract=True, user_ma
 '''
 
 if not subregion.start:
-subregion.start = target_dataset.times[0]
-subregion.end = target_dataset.times[-1]
+time_start = target_dataset.times[0]
--- End diff --

The helper function `_are_bounds_contained_by_dataset)_` will now always 
throw an exception if the `start` and `end` attributes of the subregion 
instance are not defined. Was there any particular reason you made this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request #434: CLIMATE-905 - Box whisker plot to evaluate simula...

[huikyole]

GitHub user huikyole opened a pull request:

https://github.com/apache/climate/pull/434

CLIMATE-905 - Box whisker plot to evaluate simulated trends

- example/temperature/trends_over_CONUS.py has been updated
- data_source.local.load_multiple_files has been updated to load the CMIP5 
files without file concatenation.
- dataset_processor has been updated.
- plotter has a new module (draw_plot_to_compare_trends) to generate a plot 
to compare observed trends with simulated ones.
- test_local.py has been updated to reflect the changes in
- utils.calculate_temporal_trend_of_time_series has been debugged.
- utils.calculate_ensemble_temporal_trends has been updated.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/huikyole/climate CLIMATE-905

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/climate/pull/434.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #434


commit 6f6cde83ed23e5d121244896c97638070e280a74
Author: huikyole 
Date:   2017-04-17T06:01:39Z

CLIMATE-905 - Box whisker plot to evaluate simulated trends

- example/temperature/trends_over_CONUS.py has been updated
- data_source.local.load_multiple_files has been updated to load the CMIP5 
files without file concatenation.
- dataset_processor has been updated.
- plotter has a new module (draw_plot_to_compare_trends) to generate a plot 
to compare observed trends with simulated ones.
- test_local.py has been updated to reflect the changes in
- utils.calculate_temporal_trend_of_time_series has been debugged.
- utils.calculate_ensemble_temporal_trends has been updated.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (CLIMATE-905) Box whisker plot to evaluate simulate trends

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLIMATE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970712#comment-15970712
 ] 

ASF GitHub Bot commented on CLIMATE-905:


GitHub user huikyole opened a pull request:

https://github.com/apache/climate/pull/434

CLIMATE-905 - Box whisker plot to evaluate simulated trends

- example/temperature/trends_over_CONUS.py has been updated
- data_source.local.load_multiple_files has been updated to load the CMIP5 
files without file concatenation.
- dataset_processor has been updated.
- plotter has a new module (draw_plot_to_compare_trends) to generate a plot 
to compare observed trends with simulated ones.
- test_local.py has been updated to reflect the changes in
- utils.calculate_temporal_trend_of_time_series has been debugged.
- utils.calculate_ensemble_temporal_trends has been updated.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/huikyole/climate CLIMATE-905

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/climate/pull/434.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #434


commit 6f6cde83ed23e5d121244896c97638070e280a74
Author: huikyole 
Date:   2017-04-17T06:01:39Z

CLIMATE-905 - Box whisker plot to evaluate simulated trends

- example/temperature/trends_over_CONUS.py has been updated
- data_source.local.load_multiple_files has been updated to load the CMIP5 
files without file concatenation.
- dataset_processor has been updated.
- plotter has a new module (draw_plot_to_compare_trends) to generate a plot 
to compare observed trends with simulated ones.
- test_local.py has been updated to reflect the changes in
- utils.calculate_temporal_trend_of_time_series has been debugged.
- utils.calculate_ensemble_temporal_trends has been updated.




> Box whisker plot to evaluate simulate trends
> 
>
> Key: CLIMATE-905
> URL: https://issues.apache.org/jira/browse/CLIMATE-905
> Project: Apache Open Climate Workbench
>  Issue Type: New Feature
>  Components: visualization
>Affects Versions: 1.1.0
>Reporter: Huikyo Lee
>Assignee: Huikyo Lee
> Fix For: 1.2.0
>
>
> A new module to draw a box whisker plot and evaluate trends simulated by 
> multiple models will be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)