[jira] [Resolved] (CLIMATE-887) test_get_netcdf_variable_names setUp to run only once for the test case

[Lewis John McGibbney (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLIMATE-887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney resolved CLIMATE-887.
--
Resolution: Fixed

> test_get_netcdf_variable_names setUp to run only once for the test case
> ---
>
> Key: CLIMATE-887
> URL: https://issues.apache.org/jira/browse/CLIMATE-887
> Project: Apache Open Climate Workbench
>  Issue Type: Improvement
>  Components: tests
>Affects Versions: 1.1.0
>Reporter: Lewis John McGibbney
>Assignee: Justin Julian
> Fix For: 1.3.0
>
>
> Right now the particular test {code}test_get_netcdf_variable_names{code} 
> takes forever and a day due to the use of urlretrieve within the class setUp 
> function. This retrieves the same netCDF file from zipper.jpl.nasa.gov on 
> every test within the test_get_netcdf_variable_names function which is a 
> waste of time and resources. If anything, I would be +1 for having a small 
> netCDF file contained within the OCW test directory. This would speed up the 
> tests much more. 
> https://github.com/apache/climate/blob/master/ocw/tests/test_local.py#L236-L274



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (CLIMATE-887) test_get_netcdf_variable_names setUp to run only once for the test case

[Lewis John McGibbney (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLIMATE-887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney reassigned CLIMATE-887:


Assignee: Justin Julian

> test_get_netcdf_variable_names setUp to run only once for the test case
> ---
>
> Key: CLIMATE-887
> URL: https://issues.apache.org/jira/browse/CLIMATE-887
> Project: Apache Open Climate Workbench
>  Issue Type: Improvement
>  Components: tests
>Affects Versions: 1.1.0
>Reporter: Lewis John McGibbney
>Assignee: Justin Julian
> Fix For: 1.3.0
>
>
> Right now the particular test {code}test_get_netcdf_variable_names{code} 
> takes forever and a day due to the use of urlretrieve within the class setUp 
> function. This retrieves the same netCDF file from zipper.jpl.nasa.gov on 
> every test within the test_get_netcdf_variable_names function which is a 
> waste of time and resources. If anything, I would be +1 for having a small 
> netCDF file contained within the OCW test directory. This would speed up the 
> tests much more. 
> https://github.com/apache/climate/blob/master/ocw/tests/test_local.py#L236-L274



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLIMATE-887) test_get_netcdf_variable_names setUp to run only once for the test case

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLIMATE-887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120284#comment-16120284
 ] 

ASF GitHub Bot commented on CLIMATE-887:


Github user lewismc commented on the issue:

https://github.com/apache/climate/pull/449
  
Thank you @justinlulejian 


> test_get_netcdf_variable_names setUp to run only once for the test case
> ---
>
> Key: CLIMATE-887
> URL: https://issues.apache.org/jira/browse/CLIMATE-887
> Project: Apache Open Climate Workbench
>  Issue Type: Improvement
>  Components: tests
>Affects Versions: 1.1.0
>Reporter: Lewis John McGibbney
> Fix For: 1.3.0
>
>
> Right now the particular test {code}test_get_netcdf_variable_names{code} 
> takes forever and a day due to the use of urlretrieve within the class setUp 
> function. This retrieves the same netCDF file from zipper.jpl.nasa.gov on 
> every test within the test_get_netcdf_variable_names function which is a 
> waste of time and resources. If anything, I would be +1 for having a small 
> netCDF file contained within the OCW test directory. This would speed up the 
> tests much more. 
> https://github.com/apache/climate/blob/master/ocw/tests/test_local.py#L236-L274



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] climate issue #449: CLIMATE-887 - test_local.py speed and style guide improv...

[lewismc]

Github user lewismc commented on the issue:

https://github.com/apache/climate/pull/449
  
Thank you @justinlulejian 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request #449: CLIMATE-887 - test_local.py speed and style guide...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/449


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (CLIMATE-887) test_get_netcdf_variable_names setUp to run only once for the test case

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLIMATE-887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119571#comment-16119571
 ] 

ASF GitHub Bot commented on CLIMATE-887:


GitHub user justinlulejian opened a pull request:

https://github.com/apache/climate/pull/449

CLIMATE-887 - test_local.py speed and style guide improvements

- Change multiple tests (including test_get_netcdf_variable_names) to run 
setUp code once.
- Use small static local file TestGetNetcdfVariableNames.nc as test data 
for test_get_netcdf_variable_names.
- Clean up PEP8/257 warnings.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinlulejian/climate master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/climate/pull/449.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #449


commit 56989f5788bc6ef9e8b2a68bad62d7ed98b1e629
Author: Justin L 
Date:   2017-08-09T08:28:31Z

CLIMATE-887 - test_local.py speed and style guide improvements

- Change multiple tests (including test_get_netcdf_variable_names) to run 
setUp code once.
- Use small static local file TestGetNetcdfVariableNames.nc as test data 
for test_get_netcdf_variable_names.
- Clean up PEP8/257 warnings.




> test_get_netcdf_variable_names setUp to run only once for the test case
> ---
>
> Key: CLIMATE-887
> URL: https://issues.apache.org/jira/browse/CLIMATE-887
> Project: Apache Open Climate Workbench
>  Issue Type: Improvement
>  Components: tests
>Affects Versions: 1.1.0
>Reporter: Lewis John McGibbney
> Fix For: 1.3.0
>
>
> Right now the particular test {code}test_get_netcdf_variable_names{code} 
> takes forever and a day due to the use of urlretrieve within the class setUp 
> function. This retrieves the same netCDF file from zipper.jpl.nasa.gov on 
> every test within the test_get_netcdf_variable_names function which is a 
> waste of time and resources. If anything, I would be +1 for having a small 
> netCDF file contained within the OCW test directory. This would speed up the 
> tests much more. 
> https://github.com/apache/climate/blob/master/ocw/tests/test_local.py#L236-L274



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] climate pull request #449: CLIMATE-887 - test_local.py speed and style guide...

[justinlulejian]

GitHub user justinlulejian opened a pull request:

https://github.com/apache/climate/pull/449

CLIMATE-887 - test_local.py speed and style guide improvements

- Change multiple tests (including test_get_netcdf_variable_names) to run 
setUp code once.
- Use small static local file TestGetNetcdfVariableNames.nc as test data 
for test_get_netcdf_variable_names.
- Clean up PEP8/257 warnings.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinlulejian/climate master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/climate/pull/449.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #449


commit 56989f5788bc6ef9e8b2a68bad62d7ed98b1e629
Author: Justin L 
Date:   2017-08-09T08:28:31Z

CLIMATE-887 - test_local.py speed and style guide improvements

- Change multiple tests (including test_get_netcdf_variable_names) to run 
setUp code once.
- Use small static local file TestGetNetcdfVariableNames.nc as test data 
for test_get_netcdf_variable_names.
- Clean up PEP8/257 warnings.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---