Re: Review Request 12205: message(s) made more identifying for the error location

2013-07-02 Thread Daan Hoogland
ok, If any of those seem fine to me, should I hit ship it? I can not submit! On Tue, Jul 2, 2013 at 8:52 AM, Prasanna Santhanam t...@apache.org wrote: On Mon, Jul 01, 2013 at 06:30:57PM +0200, Daan Hoogland wrote: Is this request of yours still valid? happy to do a review or a half. Yes

Re: Review Request 12207: Cloudstack-3299 incorrect arguments sent to the script createIpalias in case of vmware, Cloudstack-3240 corrected a mistake in the script name.

2013-07-02 Thread bharat kumar
On July 2, 2013, 6:26 a.m., Abhinandan Prateek wrote: Has this been tested ? I did not test the fix, I don't have access to the vmware setup as of now. - bharat --- This is an automatically generated e-mail. To reply, visit:

Review Request 12230: Cloudstack-3168: test_network.py. Fixed two test cases.

2013-07-02 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12230/ --- Review request for cloudstack and Prasanna Santhanam. Repository:

Re: Review Request 12229: Fixing script issue

2013-07-02 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12229/#review22656 --- Ship it! 479f89c - Prasanna Santhanam On July 2, 2013, 9:38

Re: Test Result for test-smoke-matrix #559

2013-07-02 Thread Girish Shilamkar
Hello Prasanna, While adding rest of the affinity rules tests I had removed affinity rules test from smoke. But while going through various iterations on the review board this hunk to remove test from smoke was dropped. The same test is now included in component. I think we should remove

Re: Test Result for test-smoke-matrix #559

2013-07-02 Thread Prasanna Santhanam
On Tue, Jul 02, 2013 at 03:33:39PM +0530, Girish Shilamkar wrote: Hello Prasanna, While adding rest of the affinity rules tests I had removed affinity rules test from smoke. But while going through various iterations on the review board this hunk to remove test from smoke was dropped.

Re: [GSoC] Unit testing with Spock

2013-07-02 Thread Sebastien Goasguen
On 7/2/13 2:28 PM, Ian Duffy wrote: Hi, I was wondering if there would be any objections to using Spock for writing unit tests for a plugin instead of junit and mockito. Spock is JUnit under the hood but an excellent DSL. It supports behavior driven development style of testing with criteria

Re: CloudStack Collab 2013 - videos

2013-07-02 Thread Rohit Yadav
On Tue, Jul 2, 2013 at 5:10 PM, Prasanna Santhanam t...@apache.org wrote: When (approximately) will the videos be uploaded of the collab conference? Looking forward to some talks. +1 Me too -- Prasanna., Powered by BigRock.com

Re: In-Development Release Naming

2013-07-02 Thread John Burwell
Sebastien, Actually, you are completely correct. When we cut a release branch, we know the scope of change and can apply of the semantic versioning rules to service the correct version number (i.e. whether to increment x, y, or z). However, we have a 4 month period of development on feature

Re: [DISCUSS] [GSoC] Caching of password on Cloudstack side

2013-07-02 Thread Chip Childers
On Tue, Jul 02, 2013 at 12:58:06PM +0100, Ian Duffy wrote: tldr: should ldap passwords be cached within cloudstack? Hi Guys, I wanted to get your opinion on something. I seen a JIRA ticket for adding support for multiple LDAP because if the single LDAP server fails you lose access to your

RE: In-Development Release Naming

2013-07-02 Thread Sudha Ponnaganti
+1 to use code name during dev cycles and name the version for GA release for reasons outlined by John B. When querying metrics also would help to identify which defects are logged pre release and which came in post release i.e GA. -Original Message- From: John Burwell

Re: In-Development Release Naming

2013-07-02 Thread John Burwell
Sudha, In JIRA, is it possible to change an exist release name? If so, we use the code name until the release is cut, and change the JIRA release name to x.y.z (codename) which would make tracking consistent throughout the cycle. Otherwise, as part of the branch creation process, we could

Re: [GSoC] Unit testing with Spock

2013-07-02 Thread Chip Childers
On Tue, Jul 02, 2013 at 01:28:24PM +0100, Ian Duffy wrote: Hi, I was wondering if there would be any objections to using Spock for writing unit tests for a plugin instead of junit and mockito. Spock is JUnit under the hood but an excellent DSL. It supports behavior driven development

Re: DevCloud2 problem

2013-07-02 Thread CK
Added the following and it sprung to life: export MAVEN_OPTS=-Xms512m -Xmx1024m -XX:PermSize=256m -XX:MaxPermSize=512m Thanks On 2 July 2013 10:20, Sebastien Goasguen run...@gmail.com wrote: On 7/2/13 11:10 AM, CK wrote: To start off with I did allocate 2048 MB RAM and hit the problem, I

RE: In-Development Release Naming

2013-07-02 Thread Sudha Ponnaganti
Yes - it can be changed in JIRA unless some workflow is set up not to do that in ACS. However I think we can leave the defects logged before release with codename. I do not see a reason that they should be moved to version number post GA. -Original Message- From: John Burwell

Re: [DISCUSS] [GSoC] Caching of password on Cloudstack side

2013-07-02 Thread Ian Duffy
A user should probably be tied to a specific authenticator (IMO only), so that there isn't a backdoor option for getting them into the system. This is an issue I have come across too. With the way the authenticators are implemented it would be very easy for a user to keep their account despite

ACS development

2013-07-02 Thread CK
Hi I am new to ACS development and intend on using DevCloud2 as my self contained dev+test environment. I have the management server running in VirtualBox and have browsed the ACS website/wiki and not found answers to the following questions and hope you can help: 1) Where can I find the

Re: London CloudStack Meetup on July 4th

2013-07-02 Thread L Radhakrishna Rao
Cannot attend this, as i stay in india. On Tue, Jul 2, 2013 at 6:23 PM, Donal Lafferty donal.laffe...@citrix.comwrote: Definitely going to catch the digest version of CloudStack Collab. Note that the new location since last quarter's meeting. DL -Original Message- From: Mike

Re: ACS development

2013-07-02 Thread Rohit Yadav
Hey CK, On Tue, Jul 2, 2013 at 7:21 PM, CK cloudw...@gmail.com wrote: Hi I am new to ACS development and intend on using DevCloud2 as my self contained dev+test environment. I have the management server running in VirtualBox and have browsed the ACS website/wiki and not found answers to

Test Result for test-smoke-matrix #575

2013-07-02 Thread Prasanna Santhanam
Test Run: #575 Total:94 Fail :9 Skip :2 name passfailskip test_vm_life_cycle/ 9 1 0 test_global_settings/ 1 0 0 test_affinity_groups/

Re: Review Request 12224: Cloudstack-3313 Ipv6 - Not able to deploy a new VM in IPV6 network

2013-07-02 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12224/#review22663 --- Ship it! Ship It! - Abhinandan Prateek On July 2, 2013, 7:06

RE: In-Development Release Naming

2013-07-02 Thread Sudha Ponnaganti
I definitely understand the easy aspect to carry over defects to version number for committers and contributors. But we should triage them and move them to future or next release and get ready for GA. That is one of GA readiness tasks. Below is simple workflow to explain the reason what I am

Re: Review Request 12227: NPE wile deployVM in kvm due to capacityIops

2013-07-02 Thread Sateesh Chodapuneedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12227/#review22666 --- Rajesh, Can you re-upload patch again. Diff is showing following

RE: Review Request 12227: NPE wile deployVM in kvm due to capacityIops

2013-07-02 Thread Rajesh Battala
The issue is that, this patch is dependent on the review https://reviews.apache.org/r/12158/ . I had kept that dependency while creating the review request. First this patch should be committed https://reviews.apache.org/r/12158/ and then the current patch. Thanks Rajesh Battala From: Sateesh

RE: Review Request 12227: NPE wile deployVM in kvm due to capacityIops

2013-07-02 Thread Rajesh Battala
Hi Sateesh, For this patch https://reviews.apache.org/r/12158/ it is dependent on https://reviews.apache.org/r/11992/ . It is already committed by Edison in 4.2 only. Thanks Rajesh Battala -Original Message- From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] Sent: Tuesday, July

qemu-kvm not required by cloudstack-agent rpm package?

2013-07-02 Thread David Nalley
So I just installed a new 4.1.0 instance and found that qemu-kvm isn't installed when the agent is. Is this by design or did we accidentally omit this? Unless someone tells me otherwise, I will plan on fixing this prior to 4.1.1 However, in 4.2, we have the situation with LXC now entering the

ACS plugins

2013-07-02 Thread CK
Hi, Are UI plugins implemented/deployed differently to other types such as API, Storage or Networking plugins (reside under /cloudstack/plugins) I am looking at writing a UI plugin, browsing the wiki I have come across this page:

Re: ACS development

2013-07-02 Thread CK
Thanks Rohit. I found vmops.log under src, I assume that is the management server log? In DevCloud2, is the command to run the management server: mvn -pl :cloud-client-ui jetty:run but this does not run in the background, can I add to make it so, or is there another command I should be using to

Review Request 12232: CLOUDSTACK-3324: Fix/Improve upgrade system vm templates 41 to 42

2013-07-02 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12232/ --- Review request for cloudstack, Abhinandan Prateek and Kishan Kavala. Bugs:

Review Request 12233: CLOUDSTACK-3324: Fix/Improve upgrade system vm templates 41 to 42 (Stable master Patch)

2013-07-02 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12233/ --- Review request for cloudstack, Abhinandan Prateek and Kishan Kavala. Bugs:

RE: Secondary Storage/TinyLinux

2013-07-02 Thread Soheil Eizadi
I debugged this to another symptom of secondary storage VM network connectivity problem. (The Ready state of the template was No). Thanks, -Soheil From: Devdeep Singh [devdeep.si...@citrix.com] Sent: Monday, July 01, 2013 4:59 PM To:

RE: ACS plugins

2013-07-02 Thread Pranav Saxena
Please see my comments inline and shoot any queries you may have with UI plugins - Thanks, Pranav -Original Message- From: CK [mailto:cloudw...@gmail.com] Sent: Tuesday, July 02, 2013 9:36 PM To: dev@cloudstack.apache.org Subject: ACS plugins Hi, Are UI plugins implemented/deployed

Re: ACS plugins

2013-07-02 Thread CK
Hi Pranav, To keep things simple, I have exactly followed the wiki: https://cwiki.apache.org/confluence/display/CLOUDSTACK/UI+Plugin+Tutorial but it did not work :-( I have DevCloud2 running with ACS 4.1 pulled in via git. The /ui/plugins folder did not exist so I created it and followed the

RE: ACS plugins

2013-07-02 Thread Brian Federle
Hello, I have DevCloud2 running with ACS 4.1 pulled in via git. You'll want to make sure you are on either the master or 4.2 branch for UI plugins to work, since they didn't exist on 4.1 or earlier. -Brian -Original Message- From: CK [mailto:cloudw...@gmail.com] Sent: Tuesday, July

Re: Review Request 12158: CLOUDSTACK-3089-[ZWPS]-NPE-while-cancelling-the-Storage-Maintenance

2013-07-02 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12158/#review22673 --- Commit deaf10cad22a8fcf42663276df66365dea1ee3c7 in branch

Re: Review Request 12158: CLOUDSTACK-3089-[ZWPS]-NPE-while-cancelling-the-Storage-Maintenance

2013-07-02 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12158/#review22679 --- Commit d660bc7e8da57d94049d55e53ffe18df8016e4e5 in branch

RE: Async Job / Event Bus issue

2013-07-02 Thread Alex Huang
Ryan, There's explicit code to remove those two columns. IIRC, the reason is because asyncjob actually uses those two fields to sequence jobs on the same id and type. So when the job is done, then it removes those two fields so it doesn't block the next job. --Alex -Original

Re: Async Job / Event Bus issue

2013-07-02 Thread Ryan Dietrich
Ok. I see the reset attached object calls now. I'm curious why those columns are being wiped out. If you wanted to see outstanding calls for an ID or Type, wouldn't you just query where the jobStatus is still equal to zero? Wiping out those columns seems to destroy history, no? On Jul 2,

Re: Review Request 11984: Fix primary datastore NPE/incorrect db entry/exception propagation for KVM on cloudstack

2013-07-02 Thread Venkata Siva Vijayendra Bhamidipati
On June 20, 2013, 10:37 p.m., edison su wrote: engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreLifeCycle.java, line 44 https://reviews.apache.org/r/11984/diff/1/?file=308929#file308929line44 If stoagemanager wants to delete datastore, then just call

Re: ACS plugins

2013-07-02 Thread Mike Tutkowski
I wonder if this would work for you to reload (I've only used it when making changes to existing JavaScript files, though)? mvn -P developer -pl :cloud-client-ui -DskipTests=true On Tue, Jul 2, 2013 at 3:59 PM, CK cloudw...@gmail.com wrote: Thanks Brian, the UI plugins work on the master

Coding Convention Reminder

2013-07-02 Thread Alex Huang
I like to remind everyone to review our coding conventions. Our coding conventions have been going all over the place recently. Please take a look. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions I also like to propose that we extend the 120 column limit to 180

Re: Async Job / Event Bus issue

2013-07-02 Thread Marcus Sorensen
He has a point though, why go to the trouble of removing the data to tell that a job is no longer active, when there's a field that tells us if the job is active? Was there some other reason? On Tue, Jul 2, 2013 at 4:42 PM, Kelven Yang kelven.y...@citrix.com wrote: Fields in job record are tend

Re: Coding Convention Reminder

2013-07-02 Thread Min Chen
+1. It is better to check in your eclipse.eps into git repo, so anybody who checked out the CloudStack can access the preference file. -min On 7/2/13 5:17 PM, Prachi Damle prachi.da...@citrix.com wrote: + 1 Please upload the code template for reference. -Original Message- From: Edison

RE: Coding Convention Reminder

2013-07-02 Thread Rajesh Battala
+1. Please check-in the preferences file. -Original Message- From: Vijayendra Bhamidipati [mailto:vijayendra.bhamidip...@citrix.com] Sent: Wednesday, July 3, 2013 5:58 AM To: dev@cloudstack.apache.org Subject: RE: Coding Convention Reminder +1 to checking in the epf file to

Re: Review Request 12191: removed EnumerationImpl

2013-07-02 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12191/ --- (Updated July 3, 2013, 4:33 a.m.) Review request for cloudstack. Changes

Re: Review Request 12228: static resource compression

2013-07-02 Thread Prasanna Santhanam
On July 2, 2013, 10:15 a.m., Prasanna Santhanam wrote: Over VNC/RDP I've seen the login page take somewhere around 2minutes to load. This would definitely be useful. Prasanna Santhanam wrote: Here's the screen grab over RDP demonstrating the issue

RE: ACS plugins

2013-07-02 Thread Pranav Saxena
Yes , Mike's right . That command would help you copy your UI changes to the server and then you just need to refresh your browser for your changes to reflect on the CloudStack UI . The active destination where the code gets copied is - cloudstack/ client/target/cloud-client-Snapshot-4.2.0

Re: Review Request 12191: removed EnumerationImpl

2013-07-02 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12191/#review22701 --- Ship it! f15a6e4 - Prasanna Santhanam On July 3, 2013, 4:33